[Puppet-dev] Re: For Review: Feature #1833 patch

2009-01-25 Thread Jeffrey Hulten
All, Premature patch emailing... Must be a function of old age. This one passes the 'does it run' test. Thanks, Jeff diff --git a/install.rb b/install.rb old mode 100755 new mode 100644 index c99d7da..f19aa94 --- a/install.rb +++ b/install.rb @@ -92,9 +92,11 @@ def do_libs(libs, strip = 'lib/

[Puppet-dev] Re: For Review: Feature #1833 patch

2009-01-25 Thread Jeffrey Hulten
I may have spoken too soon. It would help if it ran properly... Let me know what you think of the approach and I will clean up the implementation. Jeff On Sun, Jan 25, 2009 at 9:54 PM, Jeffrey Hulten wrote: > All, > It is my first patch, so be kind. ;) Please let me know what you think. > Thi

[Puppet-dev] For Review: Feature #1833 patch

2009-01-25 Thread Jeffrey Hulten
All, It is my first patch, so be kind. ;) Please let me know what you think. This is in regards to http://projects.reductivelabs.com/issues/show/1833 Thanks, Jeff diff --git a/install.rb b/install.rb index c99d7da..b0803a5 100755 --- a/install.rb +++ b/install.rb @@ -92,9 +92,11 @@ def do_libs

[Puppet-dev] A new web interface for Puppet?

2009-01-25 Thread Ohad Levy
Hi All, in the last few months,a colleague of mine and I have been developing a rails application which handle various tasks around systems life cycle in a large scale enterprise / data centers. This application, is currently in production, and we plan to rollout about 2000 servers using this app

[Puppet-dev] Re: [PATCH 2/2] Change the way the tags and params are handled in rails

2009-01-25 Thread Luke Kanies
On Jan 25, 2009, at 3:54 PM, Brice Figureau wrote: > > The rationale behind this patch is that it takes a lots of time > to let rails unserialize the ParamValue and ResourceTag object > on each compilation, just to throw them away the second after. > The idea is to fetch directly (and batched hos

[Puppet-dev] Re: [PATCH 1/2] Add methods to return hash instead of objects to params and tags

2009-01-25 Thread Luke Kanies
On Jan 25, 2009, at 3:54 PM, Brice Figureau wrote: > > Signed-off-by: Brice Figureau > --- > lib/puppet/rails/param_value.rb | 50 + > +--- > lib/puppet/rails/resource_tag.rb | 18 + > 2 files changed, 58 insertions(+), 10 deletions(-) > > diff --g

[Puppet-dev] Re: [PATCH 2/2] Added uptime facts

2009-01-25 Thread Luke Kanies
+1 On Jan 25, 2009, at 8:10 PM, James Turnbull wrote: > > > Signed-off-by: James Turnbull > --- > CHANGELOG |2 ++ > lib/facter/uptime.rb | 19 +++ > lib/facter/util/uptime.rb | 32 > 3 files changed, 53 insertions(+), 0

[Puppet-dev] [PATCH 2/2] Added uptime facts

2009-01-25 Thread James Turnbull
Signed-off-by: James Turnbull --- CHANGELOG |2 ++ lib/facter/uptime.rb | 19 +++ lib/facter/util/uptime.rb | 32 3 files changed, 53 insertions(+), 0 deletions(-) create mode 100644 lib/facter/uptime.rb create mode

[Puppet-dev]

2009-01-25 Thread James Turnbull
Updated patch. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com To unsubscribe from this group, send email to puppet-dev+un

[Puppet-dev] Re: [PATCH 0/2] Improve Storeconfig performance

2009-01-25 Thread Peter Meier
Hi > So far, tests have shown a two times speed-up (ie from 9.8s to a 4.8s for the > rails part > of a compilation of a node with 1200 resources), and that was on sqlite3. > I think on MySQL/PostgreSQL we should get a more important speed-up, and even > more with > more covering index (I'll

[Puppet-dev] Re: Strange tag issue?

2009-01-25 Thread Brice Figureau
On 25/01/09 22:06, Luke Kanies wrote: > On Jan 25, 2009, at 12:28 PM, Brice Figureau wrote: > >> On 25/01/09 0:02, Brice Figureau wrote: >>> But, still I find some strange things related to tags. For some >>> resources, it insists in writing those tags again and again. >>> It's always for tag 'ma

[Puppet-dev] [PATCH 1/2] Add methods to return hash instead of objects to params and tags

2009-01-25 Thread Brice Figureau
Signed-off-by: Brice Figureau --- lib/puppet/rails/param_value.rb | 50 ++--- lib/puppet/rails/resource_tag.rb | 18 + 2 files changed, 58 insertions(+), 10 deletions(-) diff --git a/lib/puppet/rails/param_value.rb b/lib/puppet/rails/param_value.

[Puppet-dev] [PATCH 2/2] Change the way the tags and params are handled in rails

2009-01-25 Thread Brice Figureau
The rationale behind this patch is that it takes a lots of time to let rails unserialize the ParamValue and ResourceTag object on each compilation, just to throw them away the second after. The idea is to fetch directly (and batched host per host) the parameters and tags from the database and then

[Puppet-dev] [PATCH 0/2] Improve Storeconfig performance

2009-01-25 Thread Brice Figureau
Hi, Here is my first attempt to speed-up storeconfigs without touching too much code or the database schema (ie it is a drop-in replacement). I voluntary tried to speed-up the case of no modification, that is a compilation run where all the db resources match the just compiled resources, as I thi

[Puppet-dev] Re: Strange tag issue?

2009-01-25 Thread Luke Kanies
On Jan 25, 2009, at 12:28 PM, Brice Figureau wrote: > > On 25/01/09 0:02, Brice Figureau wrote: >> But, still I find some strange things related to tags. For some >> resources, it insists in writing those tags again and again. >> It's always for tag 'main' and 'class'. It was my understanding tha

[Puppet-dev] Re: Strange tag issue?

2009-01-25 Thread Brice Figureau
On 25/01/09 0:02, Brice Figureau wrote: > But, still I find some strange things related to tags. For some > resources, it insists in writing those tags again and again. > It's always for tag 'main' and 'class'. It was my understanding that > those tags are always applied to all resources, but st

[Puppet-dev] Re: [PATCH 1/1] Added uptime facts

2009-01-25 Thread James Turnbull
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrew Shafer wrote: > Why didn't you use get_uptime_simple? Did you add it then just never > change it here? > setcode do > Facter::Util::Uptime.get_uptime_simple > end That'd be it. I'll do another patch. > This is rereading /proc/uptime ev

[Puppet-dev] Re: [PATCH 1/1] Fixed #1868 - Added network/subnet facts

2009-01-25 Thread James Turnbull
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Paul Nasrat wrote: > There are some tests for util/ip.rb already, we probably should add > some for describing get_network_value. > >> diff --git a/lib/facter/network.rb b/lib/facter/network.rb >> new file mode 100644 >> index 000..1469902 >> ---

[Puppet-dev] Re: [PATCH 1/1] Fixed #1868 - Added network/subnet facts

2009-01-25 Thread Paul Nasrat
There are some tests for util/ip.rb already, we probably should add some for describing get_network_value. > diff --git a/lib/facter/network.rb b/lib/facter/network.rb > new file mode 100644 > index 000..1469902 > --- /dev/null > +++ b/lib/facter/network.rb > @@ -0,0 +1,11 @@ > +require 'fact

[Puppet-dev] [PATCH 1/1] Facter 1870 format all subnet masks as human readable

2009-01-25 Thread Paul Nasrat
Signed-off-by: Paul Nasrat --- lib/facter/util/ip.rb |9 +++-- spec/unit/util/ip.rb | 17 + 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/lib/facter/util/ip.rb b/lib/facter/util/ip.rb index 35dadb6..a7f0a85 100644 --- a/lib/facter/util/ip.rb +++ b/li

[Puppet-dev] Re: [PATCH 1/1] Fixed #1868 - Added network/subnet facts

2009-01-25 Thread Paul Nasrat
2009/1/25 James Turnbull : > > > Signed-off-by: James Turnbull > --- > CHANGELOG |2 ++ > lib/facter/network.rb | 11 +++ > lib/facter/util/ip.rb | 13 + > 3 files changed, 26 insertions(+), 0 deletions(-) > create mode 100644 lib/facter/network.rb I get

[Puppet-dev] Re: [PATCH 1/1] Added uptime facts

2009-01-25 Thread Andrew Shafer
On Sat, Jan 24, 2009 at 10:06 PM, James Turnbull wrote: > > > Signed-off-by: James Turnbull > --- > CHANGELOG |2 ++ > lib/facter/uptime.rb | 22 ++ > lib/facter/util/uptime.rb | 32 > 3 files changed, 56 insertion