[Puppet-dev] Disk Facts

2009-05-07 Thread R.I.Pienaar
Hello, There's been quite a few cases recently of people wanting disk facts so I thought I'd try my hand at writing some. I modeled it roughly on the IP facts, typical output looks like this: # xen virtual machine diskdrives => xvda diskmodel_xvda => Xen Virtual Disk disksize_xvda => 10485760 d

[Puppet-dev] Re: [PATCH 1/1] Facter ticket #2214 - Fix facts for OVS (rebase)

2009-05-07 Thread Paul Nasrat
> > I'm having a hard time believing these tests will work every time. > What if a higher-priority OS test doesn't use exists?, and uses > something else to pick the OS version? Possibly but at the moment we're seeing a lot of volatility amongst code paths that are shared in facter amongst simila

[Puppet-dev] Re: [PATCH 1/1] Cleanup of the Puppet Rakefile and removal of the requirement for the Reductive Build Library

2009-05-07 Thread James Turnbull
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Luke Kanies wrote: > Haven't looked at it really closely yet, but just to be clear This > still works to make tarballs and gems, right? :) > This is what the Rakefile now does: rake -T (in /home/james/src/puppet) rake changelog# Creat

[Puppet-dev] Re: [PATCH 1/1] Cleanup of the Puppet Rakefile and removal of the requirement for the Reductive Build Library

2009-05-07 Thread Luke Kanies
Haven't looked at it really closely yet, but just to be clear This still works to make tarballs and gems, right? :) On May 7, 2009, at 1:17 AM, James Turnbull wrote: > > > Signed-off-by: James Turnbull > --- > Rakefile| 197 > lib/puppet.rb

[Puppet-dev] Re: [PATCH 1/1] Facter ticket #2214 - Fix facts for OVS (rebase)

2009-05-07 Thread Luke Kanies
On May 7, 2009, at 12:11 AM, Paul Nasrat wrote: > > Added tests for operatingsystem fact covering the two simple cases > and a test > for this specific interaction of release files > > We should take some time to add tests when we're adding or changing > new > operatingsystem facts > > Signed

[Puppet-dev] Re: [Puppet Users] Re: ANNOUNCE: Facter 1.5.5rc1

2009-05-07 Thread Luke Kanies
On May 6, 2009, at 10:59 AM, Todd Zullinger wrote: > Stephen John Smoogen wrote: >> >> On Tue, Apr 21, 2009 at 11:34 AM, James Turnbull >> wrote: >>> R.I.Pienaar wrote: - The file 'COPYING' is not included anymore, the redhat spec file still mentions it though, either add the file or j

[Puppet-dev] [PATCH 1/1] Cleanup of the Puppet Rakefile and removal of the requirement for the Reductive Build Library

2009-05-07 Thread James Turnbull
Signed-off-by: James Turnbull --- Rakefile| 200 tasks/rake/redlabpackage.rb | 265 - tasks/rake/reductive.rb | 540 --- 3 files changed, 51 insertions(+), 954 deletions(-) delete mode 10064

[Puppet-dev] Re: [PATCH 1/1] Cleanup of the Puppet Rakefile and removal of the requirement for the Reductive Build Library

2009-05-07 Thread Paul Nasrat
2009/5/7 James Turnbull : > > > Signed-off-by: James Turnbull > --- >  Rakefile                    |  197 >  lib/puppet.rb               |    4 +- >  tasks/rake/redlabpackage.rb |  265 - >  tasks/rake/reductive.rb     |  540 >

[Puppet-dev] [PATCH 1/1] Cleanup of the Puppet Rakefile and removal of the requirement for the Reductive Build Library

2009-05-07 Thread James Turnbull
Signed-off-by: James Turnbull --- Rakefile| 197 lib/puppet.rb |4 +- tasks/rake/redlabpackage.rb | 265 - tasks/rake/reductive.rb | 540 --- 4 files changed, 53 insertions(

[Puppet-dev] [PATCH 1/1] Facter ticket #2214 - Fix facts for OVS (rebase)

2009-05-07 Thread Paul Nasrat
Added tests for operatingsystem fact covering the two simple cases and a test for this specific interaction of release files We should take some time to add tests when we're adding or changing new operatingsystem facts Signed-off-by: Paul Nasrat --- lib/facter/operatingsystem.rb |8 +--