[Puppet-dev] Re: [PATCH 1/1] Facter #2120 - Solaris support for Facter[virtual]

2009-05-15 Thread Paul Nasrat
2009/5/15 Luke Kanies : > > +1, although it'd be great to move away from so many nested > conditionals. Yes, we'll look at refactoring virtual.rb post release of 1.5.5 Paul --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google G

[Puppet-dev] Re: [PATCH] RackXMLRPC: buffer request contents in memory, as a real string.

2009-05-15 Thread Luke Kanies
+1 On May 15, 2009, at 7:37 AM, Christian Hofstaedtler wrote: > > Fixes #2268 "Rack::RewindableInput is not a valid input stream." > --- > lib/puppet/network/http/rack/xmlrpc.rb |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/puppet/network/http/rack/xmlrpc.rb b

[Puppet-dev] Re: [PATCH 1/1] Facter #2120 - Solaris support for Facter[virtual]

2009-05-15 Thread Luke Kanies
+1, although it'd be great to move away from so many nested conditionals. On May 15, 2009, at 2:31 AM, Paul Nasrat wrote: > > From: Jim Pirzyk > > Initial support for virtual vmware fact on Solaris > > Tested on VMWare Fusion and OpenSolaris > > Paul > > Signed-off-by: Paul Nasrat > --- > li

[Puppet-dev] [PATCH] RackXMLRPC: buffer request contents in memory, as a real string.

2009-05-15 Thread Christian Hofstaedtler
Fixes #2268 "Rack::RewindableInput is not a valid input stream." --- lib/puppet/network/http/rack/xmlrpc.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/puppet/network/http/rack/xmlrpc.rb b/lib/puppet/network/http/rack/xmlrpc.rb index ef686cd..4fc9e82 100644 ---

[Puppet-dev] [PATCH 1/1] Added split function

2009-05-15 Thread Thomas Bellman
James Turnbull wrote: > Thomas Bellman wrote: >> I suggest that we make split() take a regular expression instead of a >> fixed string to split on. That would make it more powerful. > Can you post the code to the list please. Here goes: From: Thomas Bellman Date: Thu, 14 May 2009 14:37:21 +0

[Puppet-dev] Re: [PATCH] Add facts for diskdrives, currently supports Linux SCSI, IDE and

2009-05-15 Thread R.I.Pienaar
Hello, I've reworked this whole thing to be less idiotic and perl like. Previously I had all the methods to build data and return it that then ends up in arrays that needed flattening and sorting, that all sucked. I now create a variable @diskdata and just populate that in a single method per

[Puppet-dev] [PATCH 1/1] Facter #2120 - Solaris support for Facter[virtual]

2009-05-15 Thread Paul Nasrat
From: Jim Pirzyk Initial support for virtual vmware fact on Solaris Tested on VMWare Fusion and OpenSolaris Paul Signed-off-by: Paul Nasrat --- lib/facter/virtual.rb | 28 +--- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git a/lib/facter/virtual.rb b