Re: [Puppet-dev] [PATCH/puppet 1/1] Fix for #3077 (unit tests broken in 0.25.1--0.25.4)

2010-01-18 Thread Luke Kanies
+1 On Jan 16, 2010, at 9:18 AM, Markus Roberts wrote: Most of these were caused by alias -- host_aliases; one was caused by the canonicalization of resource references and one by the removal of puppet_module. Signed-off-by: Markus Roberts mar...@reality.com ---

Re: [Puppet-dev] [PATCH/facter 1/1] Fix #2746 - add architecture support for GNU/kFreeBSD

2010-01-18 Thread Luke Kanies
What the heck is gnu/kfreebsd? Code seems ok, though. On Jan 17, 2010, at 8:09 AM, Paul Nasrat wrote: Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/architecture.rb |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/facter/architecture.rb

Re: [Puppet-dev] [PATCH/facter 1/1] Fix #2341 - stricter handling of dmidecode split

2010-01-18 Thread Luke Kanies
On Jan 17, 2010, at 9:03 AM, Paul Nasrat wrote: This adds a test to ensure we are not prematurely splitting on Handle Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/manufacturer.rb |2 +- spec/unit/util/manufacturer.rb | 22 ++ 2 files changed,

Re: [Puppet-dev] [PATCH/facter 1/1] Fix #2746 - add architecture support for GNU/kFreeBSD

2010-01-18 Thread Peter Meier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Luke Kanies wrote: What the heck is gnu/kfreebsd? http://www.debian.org/ports/freebsd/ cheers pete -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

Re: [Puppet-dev] [PATCH/facter 1/1] Fix #2341 - stricter handling of dmidecode split

2010-01-18 Thread Paul Nasrat
2010/1/18 Luke Kanies l...@reductivelabs.com: On Jan 17, 2010, at 9:03 AM, Paul Nasrat wrote: This adds a test to ensure we are not prematurely splitting on Handle Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/manufacturer.rb |    2 +- spec/unit/util/manufacturer.rb

Re: [Puppet-dev] [PATCH/facter 1/1] Fix #2746 - add architecture support for GNU/kFreeBSD

2010-01-18 Thread Luke Kanies
On Jan 18, 2010, at 1:14 PM, Peter Meier wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Luke Kanies wrote: What the heck is gnu/kfreebsd? http://www.debian.org/ports/freebsd/ Strange. I'd like to ask 'why?', but I expect I don't really want to know. -- As a general rule, don't