[Puppet-dev] [PATCH/facter 1/1] Resend - Discussion on ec2 facts - #2346

2010-02-28 Thread Paul Nasrat
The EC2 fact is completely broken at the moment: * Timeout::Error isn't caught by rescue (due to how it inherits) * The issue of wrong open semantics outlined here, this is causing hidden immediate failure * The fact is going to cause a 2 second wait to every facter run Whilst the following

[Puppet-dev] [PATCH/facter 1/1] fixes #2573, #2085, #1291 - fixes domain and fqdn facts resolution

2010-02-28 Thread Paul Nasrat
From: Ohad Levy ohad.l...@infineon.com This patch removes the relationship between the domain fact and LDAP/NIS domains. domain fact relates to DNS domain - this will avoid the confusion caused by the LDAP/NIS domain (which might be different to the DNS domain name). Additionally, if hostname is

[Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-02-28 Thread Paul Nasrat
This reverts commit 33fb7709404e706801683e6c47ab7a0a5a1884b1. This has broken master for some facts (eg OS X facts), it also breaks facter platform support on win32 as popen3 does not work there. I'd like to get master working, backlog of patches applied and revisit exec. Paul Signed-off-by:

[Puppet-dev] Re: [PATCH/facter 1/1] fixes #2573, #2085, #1291 - fixes domain and fqdn facts resolution

2010-02-28 Thread Paul Nasrat
On 28 February 2010 13:10, Paul Nasrat pnas...@googlemail.com wrote: From: Ohad Levy ohad.l...@infineon.com This patch removes the relationship between the domain fact and LDAP/NIS domains. domain fact relates to DNS domain - this will avoid the confusion caused by the LDAP/NIS domain

Re: [Puppet-dev] [PATCH/puppet 1/1] Fixed #3305 - Added client option to defaults.rb

2010-02-28 Thread Luke Kanies
On Feb 26, 2010, at 5:17 PM, James Turnbull wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/02/10 10:50 AM, Luke Kanies wrote: This seems to either conflict with the separate :client option in puppetd, or be entirely ignored. Either way I can't quite see what it's supposed to do.