[Puppet-dev] [PATCH/facter 1/1] Fix virtual unit test on non-linux by stubbing kernel

2010-04-26 Thread Paul Nasrat
Signed-off-by: Paul Nasrat pnas...@googlemail.com --- spec/unit/virtual.rb |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/spec/unit/virtual.rb b/spec/unit/virtual.rb index fe9988e..7dbd146 100644 --- a/spec/unit/virtual.rb +++ b/spec/unit/virtual.rb @@ -50,6 +50,7 @@

[Puppet-dev] Tracebacks when running rake spec need some love

2010-04-26 Thread Michael DeHaan
I'm trying to do hack on something ATM, and I'm finding out that without having good tracebacks in the rake spec output, it's very difficult to pin down test errors. I've tried both rake spec --trace and ruby spec/unit/type/file.rb (which does not accept --trace) And I'm getting no meaningful

Re: [Puppet-dev] Tracebacks when running rake spec need some love

2010-04-26 Thread Markus Roberts
Try spec -b spec/wherever/file.rb (-b stands for backtrace). But in general, yeah, we need to improve our exception handling. -- Markus -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To post to this group, send email to

Re: [Puppet-dev] Tracebacks when running rake spec need some love

2010-04-26 Thread James Turnbull
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 27/04/10 12:52 AM, Michael DeHaan wrote: Thanks! +1 to getting tracebacks happy for main test run though :) Just add --backtrace to spec.opts and that's done. Cheers James - -- Author of: * Pro Linux System Administration

Re: [Puppet-dev] Tracebacks when running rake spec need some love

2010-04-26 Thread Michael DeHaan
On Mon, Apr 26, 2010 at 11:00 AM, James Turnbull ja...@lovedthanlost.net wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 27/04/10 12:52 AM, Michael DeHaan wrote: Thanks! +1 to getting tracebacks happy for main test run though :) Just add --backtrace to spec.opts and that's done.

Re: [Puppet-dev] Tracebacks when running rake spec need some love

2010-04-26 Thread Luke Kanies
On Apr 26, 2010, at 8:09 AM, Michael DeHaan wrote: On Mon, Apr 26, 2010 at 11:00 AM, James Turnbull ja...@lovedthanlost.net wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 27/04/10 12:52 AM, Michael DeHaan wrote: Thanks! +1 to getting tracebacks happy for main test run though :)

Re: [Puppet-dev] Tracebacks when running rake spec need some love

2010-04-26 Thread Brice Figureau
On Mon, 2010-04-26 at 08:30 -0700, Luke Kanies wrote: On Apr 26, 2010, at 8:09 AM, Michael DeHaan wrote: On Mon, Apr 26, 2010 at 11:00 AM, James Turnbull ja...@lovedthanlost.net wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 27/04/10 12:52 AM, Michael DeHaan wrote:

Re: [Puppet-dev] [PATCH/facter 1/1] Fix virtual unit test on non-linux by stubbing kernel

2010-04-26 Thread Luke Kanies
+1 On Apr 25, 2010, at 11:26 PM, Paul Nasrat wrote: Signed-off-by: Paul Nasrat pnas...@googlemail.com --- spec/unit/virtual.rb |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/spec/unit/virtual.rb b/spec/unit/virtual.rb index fe9988e..7dbd146 100644 ---

[Puppet-dev] [PATCH/puppet] conf/redhat: Add notifempty to logrotate config

2010-04-26 Thread Todd Zullinger
We default to logging via syslog so there aren't any puppet logs on many boxes. Causing a weekly restart shouldn't be necessary. --- I filed this as http://projects.reductivelabs.com/issues/3684. I'm curious if anyone feels strongly that we want to retain the forced reload/restart caused by

Re: [Puppet-dev] [PATCH/puppet 1/1] Fix #3664 - qualified variable parsing in string interpolation

2010-04-26 Thread Markus Roberts
Brice -- Your patch fixes the overt behaviour (and the test is a good addition) but I'd favour a slightly different approach. Since the core issue is that CLASSNAME (like NAME) is never valid in the position of blah ${___} construct, I'd rather add the same Token#acceptable? test on

[Puppet-dev] [PATCH/puppet 1/1] Fixed #3672 - Error message on duplicate fileserver mounts incorrect

2010-04-26 Thread James Turnbull
Signed-off-by: James Turnbull ja...@lovedthanlost.net --- lib/puppet/network/handler/fileserver.rb |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/puppet/network/handler/fileserver.rb b/lib/puppet/network/handler/fileserver.rb index 7049fb0..bed232f 100755 ---

Re: [Puppet-dev] [PATCH/puppet 1/1] Fixed #3672 - Error message on duplicate fileserver mounts incorrect

2010-04-26 Thread Luke Kanies
+1 On Apr 26, 2010, at 8:53 PM, James Turnbull wrote: Signed-off-by: James Turnbull ja...@lovedthanlost.net --- lib/puppet/network/handler/fileserver.rb |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/puppet/network/handler/fileserver.rb b/lib/puppet/

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #3403 - Added fact to query vlans; added spec test

2010-04-26 Thread Luke Kanies
Looks good to me. +1, although I'd love to see others indicating they'd tested it. On Apr 23, 2010, at 10:38 PM, James Turnbull wrote: From: Jonas Genannt jo...@brachium-system.net Signed-off-by: James Turnbull ja...@lovedthanlost.net --- lib/facter/util/vlans.rb | 25