Signed-off-by: Marc Fournier marc.fourn...@camptocamp.com
---
lib/facter/util/manufacturer.rb |2 +-
spec/unit/util/manufacturer.rb |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/facter/util/manufacturer.rb b/lib/facter/util/manufacturer.rb
index
Hello,
I'm not sure to understand the use of these trailing dots I removed with the
2nd patch. As there isn't many tests for this function, maybe this breaks
something else and needs more work.
--
You received this message because you are subscribed to the Google Groups
Puppet Developers
On 7 May 2010 08:21, Marc Fournier marc.fourn...@camptocamp.com wrote:
Splitting dmi output on the string /^Handle/ didn't work, and
caused the function to match the wrong key if it was found more
than once.
The intended behaviour of the function is restored by splitting
the dmi output on
On 7 May 2010 08:21, Marc Fournier marc.fourn...@camptocamp.com wrote:
Hello,
I'm not sure to understand the use of these trailing dots I removed with
the
2nd patch. As there isn't many tests for this function, maybe this breaks
something else and needs more work.
If I have time over the
If the target is not specified it is automatically set to the user's
home directory. If the user does not exist when the generation of
the target path occurs then an ArgumentError exception is raised
but not caught. This patch catches the ArgumentError and raises
a Puppet::Error instead to more
I'm not sure to understand the use of these trailing dots I removed with
the
2nd patch. As there isn't many tests for this function, maybe this breaks
something else and needs more work.
I'm not sure either, but looking at it I'm dubious of the regex anyway;
specifically, the 0x\d+ segment,
+1 Good catch
Normally expand_path deals with non-existent directories fine, but in this
case it can't predict what the users home direct will be if (when) the user
is eventually created. I wonder if we should specify the missing user as a
resource, like so:
raise Puppet::Error, Target not
