[Puppet-dev] [PATCH/facter 1/1] Resend - Discussion on ec2 facts - #2346

2010-08-17 Thread Paul Nasrat
The EC2 fact is completely broken at the moment: * Timeout::Error isn't caught by rescue (due to how it inherits) * The issue of wrong open semantics outlined here, this is causing hidden immediate failure * The fact is going to cause a 2 second wait to every facter run Whilst the following

[Puppet-dev] Facter next - merge for 1.5.8RC1

2010-08-17 Thread Paul Nasrat
Reviewing next branch for RC as discussed, I'm happy with all the changes up to 6edf3199a212e6b33f9e09edbb3cb34710710326, we should create a branch with the RC version bump and think about generating the tarballs, documentation and release notes. Paul -- You received this message because you

Re: [Puppet-dev] Facter next - merge for 1.5.8RC1

2010-08-17 Thread Rein Henrichs
Excerpts from Paul Nasrat's message of Tue Aug 17 08:25:26 -0700 2010: Reviewing next branch for RC as discussed, I'm happy with all the changes up to 6edf3199a212e6b33f9e09edbb3cb34710710326, we should create a branch with the RC version bump and think about generating the tarballs,

Re: [Puppet-dev] Add fact execution timing to the facter binary

2010-08-17 Thread Rein Henrichs
Excerpts from Dean Wilson's message of Tue Aug 17 10:01:45 -0700 2010: I've attached the first pass of a patch that adds a -t option to facter to show how long each fact is taking to execute. I've added basic tests but pointers to anything else that needs testing (and some examples in the

Re: [Puppet-dev] [PATCH/facter 1/1] Resend - Discussion on ec2 facts - #2346

2010-08-17 Thread Rein Henrichs
Excerpts from Paul Nasrat's message of Tue Aug 17 06:40:42 -0700 2010: The EC2 fact is completely broken at the moment: * Timeout::Error isn't caught by rescue (due to how it inherits) * The issue of wrong open semantics outlined here, this is causing hidden immediate failure * The fact is

Re: [Puppet-dev] [PATCH/puppet 1/2] Moved perform_initial_import from Puppet::Resource::TypeCollection to Puppet::Node::Environment.

2010-08-17 Thread Jesse A Wolfe
+1 On Fri, Aug 13, 2010 at 4:13 PM, Paul Berry p...@puppetlabs.com wrote: This change is part of an ongoing effort to remove functionality from TypeCollection that is not related to keeping track of a collection of types. This reduces TypeCollection's linkage to the environment, which is a

[Puppet-dev] ANNOUNCE: Facter 1.5.8rc1

2010-08-17 Thread James Turnbull
For 40 days and 40 nights Facter wandered in the wilderness sustained only by the occasional patch and bottle of Kool-Aid. Tanned and happy Facter 1.5.8rc1 has now emerged from its desert retreat. 1.5.8 is a feature and maintenance release containing a number of fixes, updates and additional

Re: [Puppet-dev] [PATCH/facter 1/1] Resend - Discussion on ec2 facts - #2346

2010-08-17 Thread Nigel Kersten
On Tue, Aug 17, 2010 at 11:50 AM, Rein Henrichs r...@puppetlabs.com wrote: Excerpts from Paul Nasrat's message of Tue Aug 17 06:40:42 -0700 2010: The EC2 fact is completely broken at the moment: * Timeout::Error isn't caught by rescue (due to how it inherits) * The issue of wrong open

Re: [Puppet-dev] [PATCH/facter 1/1] Resend - Discussion on ec2 facts - #2346

2010-08-17 Thread Jeff McCune
On Tue, Aug 17, 2010 at 12:31 PM, Nigel Kersten nig...@google.com wrote: I've implemented local caching for my computational expensive and infrequently varying facts, and I've been thinking about whether it would make sense for Facter to implement something similar. Very cool. I'm thinking

Re: [Puppet-dev] [PATCH/facter 1/1] Resend - Discussion on ec2 facts - #2346

2010-08-17 Thread Nigel Kersten
On Tue, Aug 17, 2010 at 1:03 PM, Jeff McCune j...@puppetlabs.com wrote: On Tue, Aug 17, 2010 at 12:31 PM, Nigel Kersten nig...@google.com wrote: I've implemented local caching for my computational expensive and infrequently varying facts, and I've been thinking about whether it would make

[Puppet-dev] Re: [Puppet Users] ANNOUNCE: Facter 1.5.8rc1

2010-08-17 Thread Paul Nasrat
On 17 August 2010 20:20, James Turnbull ja...@puppetlabs.com wrote: For 40 days and 40 nights Facter wandered in the wilderness sustained only by the occasional patch and bottle of Kool-Aid. Tanned and happy Facter 1.5.8rc1 has now emerged from its desert retreat. Testing on various virtual

Re: [Puppet-dev] [PATCH/facter 1/1] Resend - Discussion on ec2 facts - #2346

2010-08-17 Thread Paul Nasrat
On 17 August 2010 21:27, Nigel Kersten nig...@google.com wrote: On Tue, Aug 17, 2010 at 1:03 PM, Jeff McCune j...@puppetlabs.com wrote: On Tue, Aug 17, 2010 at 12:31 PM, Nigel Kersten nig...@google.com wrote: I've implemented local caching for my computational expensive and infrequently

Re: [Puppet-dev] [PATCH/puppet 2/2] [#4496]+[#4521]+[#4522] Add structures to the AST to represent type definitions (classes, definitions, and nodes).

2010-08-17 Thread Luke Kanies
On Aug 17, 2010, at 1:39 PM, Jesse A Wolfe wrote: Doesn't this convert classes, definitions, et al from parse-time constructs into compile-time constructs? Not exactly. We've added a new phase. Parsing is now a side-effect-free function from .pp files to AST trees. After that, in the new

[Puppet-dev] [PATCH/puppet 1/1] [#4555] puppet queue tries to call code it hasn't required

2010-08-17 Thread Jesse Wolfe
puppet queue was trying to call .subscribe on Puppet::Resource::Catalog::Queue, but that object had not been loaded into the ruby interpreter. This bug was partially masked by ruby's confusing constant resolution, which was incorrectly returning the Puppet::Application::Queue class instead of

[Puppet-dev] [PATCH/facter 1/1] [#4558] Refactor facter binary using optparse

2010-08-17 Thread Rein Henrichs
Simplify the binary by moving all application specific code into a new Facter::Application module. This module is then refactored to use OptionParser and to simplify invocation logic, while maintaining existing behavior. Signed-off-by: Rein Henrichs r...@puppetlabs.com --- bin/facter