On 13/07/11 08:46, Luke Kanies wrote:
This primarily takes Volcane's code[1], adds tests, and
splits it into multiple files.
It has support for facts in non-ruby files, using either plain test,
json, or yaml. You can also have a script that returns facts on
execution.
Very nice, this will
On Jul 14, 2011, at 1:29 AM, Dominic Cleal dcl...@redhat.com wrote:
On 13/07/11 08:46, Luke Kanies wrote:
This primarily takes Volcane's code[1], adds tests, and
splits it into multiple files.
It has support for facts in non-ruby files, using either plain test,
json, or yaml. You can also
It was decided earlier this week that the 2.6 series will have it's
last release at 2.6.10 (we're currently at 2.6.9). However, we are
not doing a 2.6.10 RC/release this month. That will wait until
August.
If you have patches waiting on some final tweaks or any other work
that you feel like
We may need to do some type of FHS audit while packaging up the new
features. I'm happy to lead that.
Mike
--
You received this message because you are subscribed to the Google Groups
Puppet Developers group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe
As mentioned here https://projects.puppetlabs.com/issues/7986#note-8
the pkg provider cannot handle the output of pkg list -H when an
installed package is not from the preferred publisher.
This patchset uses a slightly different regex to parse the output.
It is worth mentioning that I only
Switch from Puppet.warning to the warning classmethod. This is mostly
for testing purposes and changes messages produced by puppet slightly.
Instead of
warning: Failed to match 'pkg list' line foo
The user will now get
warning: Puppet::Type::Package::ProviderPkg: Failed to match 'pkg
The methods :instances, :query and :latest did not handle pkg list -H
lines correctly when the publisher of a package is not the preferred
publisher.
Modify the parsing method to handle lines with publisher correctly
Signed-off-by: Stefan Schulte stefan.schu...@taunusstein.net
---
Local-branch:
The testing of hash[:error] is apparently dead code because it is never set
to anything different than ok. Remove the hashkey :missing because it is
never used later.
Signed-off-by: Stefan Schulte stefan.schu...@taunusstein.net
---
Local-branch: ticket/2.7.x/7986
From: Max Martin m...@puppetlabs.com
Settings#writesub was not checking the type of the mode value passed in
from the defaults, causing it to pass a string for mode to File.open,
leading to failures. This commit resolves that issue.
Paired-with: Matt Robinson m...@puppetlabs.com
Signed-off-by:
We now allow for builds out of master that utilizes git-describe for
versioning. The generation of the tarball or package will create a
VERSION file with the proper contents.
The package/tarball will also use erb to substitute versions, dates and
other metadata into the Red Hat spec or Debian
Converted plain regex checks to use Test::Unit::Accertions.
Adding more verbose output in the case of failure to speeed
debugging.
Signed-off-by: Dominic Maraglia domi...@puppetlabs.com
---
acceptance/tests/jeff_append_to_array.rb |9 ---
Commit #7d35a479 changed the default value of the service type's hasstatus
attribute, which was never documented. This commit documents the changed
behavior, which will end up in the type references for version 2.7.2 and
greater. (I intend to manually change the cached references for versions
Going over this with Mike, we're squashing the following in to clean up
the logic a bit.
diff --git a/config/initializers/app_version_init.rb
b/config/initializers/app_version_init.rb
index 88bc573..df49f0e 100644
--- a/config/initializers/app_version_init.rb
+++
This change updates the list action to output more than a simple list of
DNS names. This wasn't ideal for terminated instances because they no
longer have DNS names associated with them.
The output now has the following information in a Hash of Hashes data
structure:
id: { id, dns_name,
This change adds a console rendering hook that makes the default console
output a bit more pretty. This is based on feedback from James and help
from Daniel.
Signed-off-by: Jeff McCune j...@puppetlabs.com
---
This addition is based on feedback from James Turnbull that we should support
prettier
Mock the upload method of SCP and the run method
of SSH by default to make testing easier.
This allows us to assume the methods are mocked
by default so that we can just consentrate on what
we are testing.
This is probably a patch that needs to be
submitted to Fog.
Reviewed-by: Jeff McCune
Initial test for run_install_script.
tests that the expected commands are called with
and without sudo.
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
spec/unit/puppet/cloudpack_spec.rb | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff
As part of ths refactor, the code for creating
a tmp_dir has changed.
- ssh is now connections[:ssh]
- the tmp dir should be determined in the install
method, because the path is required by multiple
other methods.
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
To make testing easier.
Moved option assignments out of method for options
that are used by other functions.
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
lib/puppet/cloudpack.rb | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git
To make testing easier.
clarified the variables required for running the
installation script.
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
lib/puppet/cloudpack.rb |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/puppet/cloudpack.rb
Add before section to build out a tempfile and
mock connections object that can be used
in the tests.
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
spec/unit/puppet/cloudpack_spec.rb | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git
Moved code related to files that are scp'ed to its
own method to make testing easier.
Moved validation of related options to this method
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
lib/puppet/cloudpack.rb | 17 ++---
1 files changed, 10 insertions(+),
Install changed to upload for clarity.
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
spec/unit/puppet/cloudpack_spec.rb |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/spec/unit/puppet/cloudpack_spec.rb
b/spec/unit/puppet/cloudpack_spec.rb
Previously it was not so clear that
Signed-off-by: Dan Bode d...@puppetlabs.com
Reviewed-by: Jeff McCune
---
spec/unit/puppet/cloudpack_spec.rb |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/spec/unit/puppet/cloudpack_spec.rb
b/spec/unit/puppet/cloudpack_spec.rb
This is part of a refactor to simplify testing.
Splitting the ssh connection code into its own
method.
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
lib/puppet/cloudpack.rb | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git
Required in order to identify the ssh
exceptions.
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
lib/puppet/cloudpack.rb |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/puppet/cloudpack.rb b/lib/puppet/cloudpack.rb
index 3fce683..0ad3f1e
Adding initial tests of ssh connection code.
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
spec/unit/puppet/cloudpack_spec.rb | 19 +++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/spec/unit/puppet/cloudpack_spec.rb
Was incorrectly referring to keyfile as a symbol
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
lib/puppet/cloudpack.rb |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/puppet/cloudpack.rb b/lib/puppet/cloudpack.rb
index 1d94f68..3fce683
Stubbed sleep to make it retry and fail faster
raised an AuthenticationFailed (to emulate a more
likely failure)
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
spec/unit/puppet/cloudpack_spec.rb |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff
Template compilation expects this variable to be
set.
Reviewed-by: Jeff McCune
Signed-off-by: Dan Bode d...@puppetlabs.com
---
lib/puppet/cloudpack.rb |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/puppet/cloudpack.rb b/lib/puppet/cloudpack.rb
index
This a feature release candidate of Puppet Dashboard.
This release is available for download at:
http://downloads.puppetlabs.com/dashboard/
We have included Debian and RPM packages as well as a tarball.
See the Verifying Puppet Download section at:
31 matches
Mail list logo
