Re: [Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

2010-12-03 Thread Dominic Cleal
On 01/12/10 13:10, Paul Nasrat wrote: On 1 December 2010 10:49, Dominic Cleal dcl...@redhat.com wrote: On 01/12/10 10:32, Dominic Cleal wrote: Memory and swap values are now given in standard units via additional facts (e.g. memorysize_mb) as well as the most appropriate unit as before.

Re: [Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

2010-12-03 Thread Paul Nasrat
On 3 December 2010 10:54, Dominic Cleal dcl...@redhat.com wrote: On 01/12/10 13:10, Paul Nasrat wrote: On 1 December 2010 10:49, Dominic Cleal dcl...@redhat.com wrote: On 01/12/10 10:32, Dominic Cleal wrote: Memory and swap values are now given in standard units via additional facts (e.g.

[Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

2010-12-01 Thread Dominic Cleal
Memory and swap values are now given in standard units via additional facts (e.g. memorysize_mb) as well as the most appropriate unit as before. Standard units provided are B and MB. Signed-off-by: Dominic Cleal dcl...@redhat.com --- Local-branch: tickets/master/2066 lib/facter/memory.rb |

Re: [Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

2010-12-01 Thread Dominic Cleal
On 01/12/10 10:32, Dominic Cleal wrote: Memory and swap values are now given in standard units via additional facts (e.g. memorysize_mb) as well as the most appropriate unit as before. Please note that this conflicts with the patch I submitted yesterday for #1423 (Solaris memory facts), but I

Re: [Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

2010-12-01 Thread Paul Nasrat
On 1 December 2010 10:49, Dominic Cleal dcl...@redhat.com wrote: On 01/12/10 10:32, Dominic Cleal wrote: Memory and swap values are now given in standard units via additional facts (e.g. memorysize_mb) as well as the most appropriate unit as before. Please note that this conflicts with the