Re: [Puppet-dev] [PATCH/facter 1/1] Feature #4575: win32 support for manufacturer, productname, serialnumber

2010-10-19 Thread Paul Nasrat
+1 Using WMI queries where we can makes sense On 19 October 2010 00:28, Rein Henrichs r...@puppetlabs.com wrote: From: William Van Hevelingen wva...@gmail.com Signed-off-by: William Van Hevelingen wva...@gmail.com Signed-off-by: Rein Henrichs r...@puppetlabs.com ---  

[Puppet-dev] [PATCH/facter 1/1] Feature #4575: win32 support for manufacturer, productname, serialnumber

2010-10-18 Thread Rein Henrichs
From: William Van Hevelingen wva...@gmail.com Signed-off-by: William Van Hevelingen wva...@gmail.com Signed-off-by: Rein Henrichs r...@puppetlabs.com --- lib/facter/manufacturer.rb |8 lib/facter/util/manufacturer.rb | 17 + 2 files changed, 25 insertions(+),

Re: [Puppet-dev] [PATCH/facter 1/1] Feature #4575: win32 support for manufacturer, productname, serialnumber

2010-10-18 Thread Rein Henrichs
Sending this to the list for review on William's behalf. -- Rein Henrichs http://puppetlabs.com I hope you will find the courage to keep on living despite the existence of this feature. - Richard Stallman -- You received this message because you are subscribed to the Google Groups Puppet

Re: [Puppet-dev] [PATCH/facter 1/1] Feature #4575: win32 support for manufacturer, productname, serialnumber

2010-10-18 Thread William Van Hevelingen
+1 :) Thanks Rein -- William Van Hevelingen wva...@gmail.com -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To post to this group, send email to puppet-...@googlegroups.com. To unsubscribe from this group, send email to

Re: [Puppet-dev] [PATCH/facter 1/1] Feature #4575: win32 support for manufacturer, productname, serialnumber

2010-10-18 Thread Rein Henrichs
Excerpts from William Van Hevelingen's message of Mon Oct 18 18:21:45 -0700 2010: +1 :) Thanks Rein You can't +1 your own patch :p -- Rein Henrichs http://puppetlabs.com I hope you will find the courage to keep on living despite the existence of this feature. - Richard Stallman -- You