Re: [Puppet-dev] [PATCH/facter 1/1] Remove whitespace in DMI facts (#3008, #3011)

2010-01-11 Thread Paul Nasrat
2010/1/11 Ohad Levy ohadl...@gmail.com: +1 is there a reason why not to strip all facts? I'm a little cautious about doing that in general in case someone has a dependancy on a fact with a space in or valid but odd setups (directories with trailing space). Although all the examples I can

Re: [Puppet-dev] [PATCH/facter 1/1] Remove whitespace in DMI facts (#3008, #3011)

2010-01-11 Thread Thomas Bellman
Paul Nasrat wrote: 2010/1/11 Ohad Levy ohadl...@gmail.com: is there a reason why not to strip all facts? I'm a little cautious about doing that in general in case someone has a dependancy on a fact with a space in or valid but odd setups (directories with trailing space). Although all the

Re: [Puppet-dev] [PATCH/facter 1/1] Remove whitespace in DMI facts (#3008, #3011)

2010-01-11 Thread Paul Nasrat
2010/1/11 Thomas Bellman bell...@nsc.liu.se: Paul Nasrat wrote: 2010/1/11 Ohad Levy ohadl...@gmail.com: is there a reason why not to strip all facts? I'm a little cautious about doing that in general in case someone has a dependancy on a fact with a space in or valid but odd setups

[Puppet-dev] [PATCH/facter 1/1] Remove whitespace in DMI facts (#3008, #3011)

2010-01-10 Thread Paul Nasrat
In addition to the stripping of the output of these facts this patchset: Refactor - Extracted function to enable easier testing. Tests - data driven tests for the dmidecode/smbios fact. Paul Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/manufacturer.rb| 17

Re: [Puppet-dev] [PATCH/facter 1/1] Remove whitespace in DMI facts (#3008, #3011)

2010-01-10 Thread Ohad Levy
+1 is there a reason why not to strip all facts? Ohad On Mon, Jan 11, 2010 at 1:25 AM, Paul Nasrat pnas...@googlemail.com wrote: In addition to the stripping of the output of these facts this patchset: Refactor - Extracted function to enable easier testing. Tests - data driven tests for