Re: [Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-03-09 Thread Markus Roberts
This reverts commit 33fb7709404e706801683e6c47ab7a0a5a1884b1. This has broken master for some facts (eg OS X facts), it also breaks facter platform support on win32 as popen3 does not work there. Is there a ticket for the problem? For the broken tests but not the win32 platform

Re: [Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-03-09 Thread Paul Nasrat
On 9 March 2010 18:13, Markus Roberts mar...@reductivelabs.com wrote: Doh, yes, thanks.  I was reading that on the train with screen glare and missed some of the -' signs. I've commited this now, and have started working through the 1.5.8 bug list. Paul -- You received this message because

Re: [Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-03-09 Thread Michael DeHaan
Paul Nasrat wrote: On 9 March 2010 18:13, Markus Roberts mar...@reductivelabs.com wrote: Doh, yes, thanks. I was reading that on the train with screen glare and missed some of the -' signs. I've commited this now, and have started working through the 1.5.8 bug list. Paul

Re: [Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-03-09 Thread Paul Nasrat
On 9 March 2010 19:33, Michael DeHaan mich...@reductivelabs.com wrote: Excellent.  I also hope to help some with the code refactoring and support for new datastructure types. I agree bugs should come first, so those too :) If you're doing this, we should do a testing branch and target for

Re: [Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-03-09 Thread Michael DeHaan
Paul Nasrat wrote: On 9 March 2010 19:33, Michael DeHaan mich...@reductivelabs.com wrote: Excellent. I also hope to help some with the code refactoring and support for new datastructure types. I agree bugs should come first, so those too :) If you're doing this, we should do a

Re: [Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-03-08 Thread Michael DeHaan
On Tue, Mar 2, 2010 at 3:14 PM, Paul Nasrat pnas...@googlemail.com wrote: On 2 March 2010 18:52, Markus Roberts mar...@reductivelabs.com wrote: On Sun, Feb 28, 2010 at 5:52 AM, Paul Nasrat pnas...@googlemail.com wrote: This reverts commit 33fb7709404e706801683e6c47ab7a0a5a1884b1. This has

Re: [Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-03-02 Thread Markus Roberts
On Sun, Feb 28, 2010 at 5:52 AM, Paul Nasrat pnas...@googlemail.com wrote: This reverts commit 33fb7709404e706801683e6c47ab7a0a5a1884b1. This has broken master for some facts (eg OS X facts), it also breaks facter platform support on win32 as popen3 does not work there. Is there a ticket

[Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-02-28 Thread Paul Nasrat
This reverts commit 33fb7709404e706801683e6c47ab7a0a5a1884b1. This has broken master for some facts (eg OS X facts), it also breaks facter platform support on win32 as popen3 does not work there. I'd like to get master working, backlog of patches applied and revisit exec. Paul Signed-off-by: