Re: [Puppet-dev] [PATCH/facter 1/3] Discussion on ec2 facts - #2346

2011-03-10 Thread Paul Nasrat
On 9 March 2011 16:55, James Turnbull ja...@puppetlabs.com wrote: Paul Nasrat wrote: On 8 March 2011 17:23, James Turnbull ja...@puppetlabs.com wrote: Paul Nasrat wrote: +1 been pending for too long Was that a +1 on patches 2 and 3 in that series also?  I largely rewrote the whole fact.

Re: [Puppet-dev] [PATCH/facter 1/3] Discussion on ec2 facts - #2346

2011-03-10 Thread James Turnbull
Paul Nasrat wrote: On 9 March 2011 16:55, James Turnbull ja...@puppetlabs.com wrote: Paul Nasrat wrote: On 8 March 2011 17:23, James Turnbull ja...@puppetlabs.com wrote: Paul Nasrat wrote: +1 been pending for too long Was that a +1 on patches 2 and 3 in that series also? I largely rewrote

Re: [Puppet-dev] [PATCH/facter 1/3] Discussion on ec2 facts - #2346

2011-03-09 Thread Paul Nasrat
On 8 March 2011 17:23, James Turnbull ja...@puppetlabs.com wrote: Paul Nasrat wrote: +1 been pending for too long Was that a +1 on patches 2 and 3 in that series also?  I largely rewrote the whole fact. Just on this, I need to review the arp fact in more depth. I think the basic idea for the

Re: [Puppet-dev] [PATCH/facter 1/3] Discussion on ec2 facts - #2346

2011-03-09 Thread James Turnbull
Paul Nasrat wrote: On 8 March 2011 17:23, James Turnbull ja...@puppetlabs.com wrote: Paul Nasrat wrote: +1 been pending for too long Was that a +1 on patches 2 and 3 in that series also? I largely rewrote the whole fact. Just on this, I need to review the arp fact in more depth. I think

[Puppet-dev] [PATCH/facter 1/3] Discussion on ec2 facts - #2346

2011-03-08 Thread James Turnbull
From: Paul Nasrat pnas...@googlemail.com The EC2 fact is completely broken at the moment: * Timeout::Error isn't caught by rescue (due to how it inherits) * The issue of wrong open semantics outlined here, this is causing hidden immediate failure * The fact is going to cause a 2 second wait to

Re: [Puppet-dev] [PATCH/facter 1/3] Discussion on ec2 facts - #2346

2011-03-08 Thread Paul Nasrat
+1 been pending for too long On 8 March 2011 10:28, James Turnbull ja...@lovedthanlost.net wrote: From: Paul Nasrat pnas...@googlemail.com The EC2 fact is completely broken at the moment: * Timeout::Error isn't caught by rescue (due to how it inherits) * The issue of wrong open semantics

Re: [Puppet-dev] [PATCH/facter 1/3] Discussion on ec2 facts - #2346

2011-03-08 Thread James Turnbull
Paul Nasrat wrote: +1 been pending for too long Was that a +1 on patches 2 and 3 in that series also? I largely rewrote the whole fact. James -- James Turnbull Puppet Labs 1-503-734-8571 -- You received this message because you are subscribed to the Google Groups Puppet Developers group.