+1, nicely done.
On Nov 18, 2009, at 11:30 PM, Jesse Wolfe wrote:
Replace deprecated method call. This code was not tested before, so
I've
tried to capture what I think the method was trying to do.
This version includes Luke's suggested change to better preserve the
original behavior.
You've provided somewhat different behaviour - the old type[] method
only looked in the managed list of resources, but the 'instances'
method does a discovery of all resources, managed and unmanaged.
Instead of 'atype.instances', I'd use 'catalog.resource(:mailalias,
foo)'.
Does that make
Ah, that does make sense. I'll swap that in and submit another patch
shortly.
On Wed, Nov 18, 2009 at 4:14 PM, Luke Kanies l...@madstop.com wrote:
You've provided somewhat different behaviour - the old type[] method
only looked in the managed list of resources, but the 'instances'
method does
Replace deprecated method call. This code was not tested before, so I've
tried to capture what I think the method was trying to do.
This version includes Luke's suggested change to better preserve the
original behavior.
Signed-off-by: Jesse Wolfe jes5...@gmail.com
---
Replace deprecated method call. This code was not tested before, so I've
tried to capture what I think the method was trying to do.
Signed-off-by: Jesse Wolfe jes5...@gmail.com
---
lib/puppet/type/maillist.rb | 12 +---
spec/unit/type/maillist.rb | 33
