Re: [Puppet-dev] [PATCH/puppet 1/1] Fix for #3094 (libdir should take : delimited path)

2010-01-25 Thread Paul Nasrat
2010/1/22 Markus Roberts mar...@reality.com: Since libdir is also the default for the plugin handler, it needs to be : savvy as well. This really should be File::PATH_SEPARATOR and not ':' Paul -- You received this message because you are subscribed to the Google Groups Puppet Developers

[Puppet-dev] [PATCH/puppet 1/1] Fix for #3094 (libdir should take : delimited path)

2010-01-25 Thread Markus Roberts
Actually, File::PATH_SEPARATOR, which is generally, but not always, :). Since libdir is also the default for the plugin handler, users will need to specify it explicitly if a multipart libdir is given (and it will need to be one of the segments given in the libdir for the plugins to be found).

Re: [Puppet-dev] [PATCH/puppet 1/1] Fix for #3094 (libdir should take : delimited path)

2010-01-25 Thread Luke Kanies
+1 On Jan 25, 2010, at 8:33 AM, Markus Roberts wrote: Actually, File::PATH_SEPARATOR, which is generally, but not always, :). Since libdir is also the default for the plugin handler, users will need to specify it explicitly if a multipart libdir is given (and it will need to be one of

[Puppet-dev] [PATCH/puppet 1/1] Fix for #3094 (libdir should take : delimited path)

2010-01-22 Thread Markus Roberts
Since libdir is also the default for the plugin handler, it needs to be : savvy as well. Signed-off-by: Markus Roberts mar...@reality.com --- lib/puppet/configurer/plugin_handler.rb |6 -- lib/puppet/util/autoload.rb |4 ++-- spec/unit/configurer/plugin_handler.rb | 14

Re: [Puppet-dev] [PATCH/puppet 1/1] Fix for #3094 (libdir should take : delimited path)

2010-01-22 Thread Markus Roberts
   # Retrieve facts from the central server. -    def download_plugins +    def download_plugins(dummy_argument=:work_arround_for_ruby_GC_bug)        return nil unless download_plugins? -        Puppet::Configurer::Downloader.new(plugin, Puppet[:plugindest], Puppet[:pluginsource],