Re: [Puppet-dev] [PATCH/puppet 1/1] Maint: made upstart tests more robust.

2010-11-30 Thread Paul Berry
I'm not sure whether Windows shell supports the true command, so you're right, this test may fail under Windows. As to your question about unit testing of Windows in general, this is currently a gap in our testing infrastructure. We don't have a windows box in our CI pipeline, and we know that

Re: [Puppet-dev] [PATCH/puppet 1/1] Maint: made upstart tests more robust.

2010-11-24 Thread Paul Nasrat
Does a true command ship by default on Win32? If not this will break the tests there. Unittests should be runnable - please confirm you have a windows box in your CI pipeline by default and the tests all pass on that platform with this change. Paul On Tuesday, November 23, 2010, Paul Berry

[Puppet-dev] [PATCH/puppet 1/1] Maint: made upstart tests more robust.

2010-11-23 Thread Paul Berry
The tests for the upstart provider were attempting to stub Process::Status.exitstatus. However, this doesn't work (presumably because Process::Status is implemented in C). As a result, the upstart spec tests were failing if the most recent exit code was nonzero. Changed the tests so that