Re: [Puppet-dev] Plugin sync support for external facts

2013-10-04 Thread John Julien
This has been a great discussion, thanks everyone for participating. I think we're at a point where we've come to an agreement so here's the summary I'd like to post to the redmine ticket. Capturing a discussion from the mailing list on this topic. There were 3 questions discussed about

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread John Julien
On Sep 26, 2013, at 4:40 PM, Adrien Thebo wrote: > I'm coming in late here so please forgive me if someone has mentioned this, > but why don't we confine facts based on file extension or execute bit? > Windows doesn't respect the execute bit but uses file extensions, so if we > have 'exe' we

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread Adrien Thebo
I'm coming in late here so please forgive me if someone has mentioned this, but why don't we confine facts based on file extension or execute bit? Windows doesn't respect the execute bit but uses file extensions, so if we have 'exe' we run it, else not. On POSIX systems we just check if the file is

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread John Julien
On Thursday, September 26, 2013 2:18:06 PM UTC-5, Luke Kanies wrote: > > On Sep 26, 2013, at 2:44 PM, Ryan Coleman > > wrote: > > > On Thu, Sep 26, 2013 at 6:45 AM, Andy Parker > > > wrote: > >> Agreed, the last thing that is needed is to present a solution that we >> say is to make things "e

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread Spencer Krum
I feel like I should chime in on facter --puppet vs puppet facts. I run Puppet in a nonroot environment, and I don't use the default location for puppet.conf. As a result whenever I run puppet I also pass --config=path. Facter, even with -p, doesn't look for a --puppet-config=path option which mean

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread Luke Kanies
On Sep 26, 2013, at 2:44 PM, Ryan Coleman wrote: On Thu, Sep 26, 2013 at 6:45 AM, Andy Parker wrote: > Agreed, the last thing that is needed is to present a solution that we say > is to make things "easier" and then have people start the simple case by > having to learn an abstract language ex

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread Luke Kanies
On Sep 26, 2013, at 2:44 PM, Ryan Coleman wrote: On Thu, Sep 26, 2013 at 6:45 AM, Andy Parker wrote: > Agreed, the last thing that is needed is to present a solution that we say > is to make things "easier" and then have people start the simple case by > having to learn an abstract language ex

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread Ryan Coleman
On Thu, Sep 26, 2013 at 6:45 AM, Andy Parker wrote: > Agreed, the last thing that is needed is to present a solution that we say > is to make things "easier" and then have people start the simple case by > having to learn an abstract language expressed in data structures :) > > How about a hybrid

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread Andy Parker
On Thu, Sep 26, 2013 at 11:26 AM, John Julien wrote: > I think we've attacked the "how to confine external facts" pretty good. > I'm getting ready to write up a summary and post it to the redmine ticket. > I've got one more thing I want to hash out before doing so. > > This post also brought up

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread John Julien
I think we've attacked the "how to confine external facts" pretty good. I'm getting ready to write up a summary and post it to the redmine ticket. I've got one more thing I want to hash out before doing so. This post also brought up the question of if we should deprecate "facter --puppet" and

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread John Julien
On Sep 26, 2013, at 8:45 AM, Andy Parker wrote: > On Wed, Sep 25, 2013 at 7:59 PM, John Julien wrote: > A third option is that an external fact has an optional metadata file > (myfacts.sh and myfacts.meta). That file can describe things like: > > * What facts do you expect to get out of the

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread Andy Parker
On Thu, Sep 26, 2013 at 7:23 AM, Kylo Ginsberg wrote: > On Thu, Sep 26, 2013 at 6:45 AM, Andy Parker wrote: > >> On Wed, Sep 25, 2013 at 7:59 PM, John Julien wrote: >> >>> This is an interesting proposal. A bit complicated, but as a result very flexible. If you recall, my main selling poi

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread Kylo Ginsberg
On Thu, Sep 26, 2013 at 6:45 AM, Andy Parker wrote: > On Wed, Sep 25, 2013 at 7:59 PM, John Julien wrote: > >> This is an interesting proposal. A bit complicated, but as a result very >>> flexible. If you recall, my main selling point for this enhancement was to >>> include those who are not as

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-26 Thread Andy Parker
On Wed, Sep 25, 2013 at 7:59 PM, John Julien wrote: > A third option is that an external fact has an optional metadata file >> (myfacts.sh and myfacts.meta). That file can describe things like: >> >> * What facts do you expect to get out of the script >> * What confines the script has >> *

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-25 Thread John Julien
> > A third option is that an external fact has an optional metadata file > (myfacts.sh and myfacts.meta). That file can describe things like: > > * What facts do you expect to get out of the script > * What confines the script has > * Maybe a description of it? > > I encountered this same

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-24 Thread Andy Parker
On Tue, Sep 24, 2013 at 6:24 AM, Kylo Ginsberg wrote: > On Mon, Sep 23, 2013 at 11:56 AM, John Julien wrote: > >> Andy, thanks for getting the brainstorm going. I've attempted to address >> each item below. >> > > Yeah, great brainstorm session. A few more comments below. > > >> On Monday, Septe

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-24 Thread Kylo Ginsberg
On Mon, Sep 23, 2013 at 11:56 AM, John Julien wrote: > Andy, thanks for getting the brainstorm going. I've attempted to address > each item below. > Yeah, great brainstorm session. A few more comments below. > On Monday, September 23, 2013 11:38:25 AM UTC-5, Andy Parker wrote: > >> I think th

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-23 Thread John Julien
Andy, thanks for getting the brainstorm going. I've attempted to address each item below. On Monday, September 23, 2013 11:38:25 AM UTC-5, Andy Parker wrote: > > On Sat, Sep 21, 2013 at 1:00 PM, John Julien > > > wrote: > >> I'd like to start some discussion around how to implement >> https:

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-23 Thread Andy Parker
On Sat, Sep 21, 2013 at 1:00 PM, John Julien wrote: > I'd like to start some discussion around how to implement > https://projects.puppetlabs.com/issues/9546 (Plugin sync support for > external facts) > > Since external facts can be any type of executable and additionally > straight json and yaml

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-23 Thread Andy Parker
On Mon, Sep 23, 2013 at 9:37 AM, Eric Sorenson wrote: > On Sep 23, 2013, at 2:29 AM, Andy Parker wrote: > > > I guess my first question is, what scenarios do we need to support that > aren't handled right now (or handled in a very clumsy way)? > > Facter/puppet when run as non-root users need t

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-23 Thread Eric Sorenson
On Sep 23, 2013, at 2:29 AM, Andy Parker wrote: > I guess my first question is, what scenarios do we need to support that > aren't handled right now (or handled in a very clumsy way)? Facter/puppet when run as non-root users need to run external facts if they are defined, but currently they o

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-23 Thread Andy Parker
On Mon, Sep 23, 2013 at 7:56 AM, John Julien wrote: > On Monday, September 23, 2013 4:29:35 AM UTC-5, Andy Parker wrote: > >> On Sat, Sep 21, 2013 at 1:00 PM, John Julien wrote: >> >>> I'd like to start some discussion around how to implement >>> https://projects.puppetlabs.**com/issues/9546

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-23 Thread John Julien
On Monday, September 23, 2013 4:29:35 AM UTC-5, Andy Parker wrote: > > On Sat, Sep 21, 2013 at 1:00 PM, John Julien > > > wrote: > >> I'd like to start some discussion around how to implement >> https://projects.puppetlabs.com/issues/9546 (Plugin sync support for >> external facts) >> >> > Th

Re: [Puppet-dev] Plugin sync support for external facts

2013-09-23 Thread Andy Parker
On Sat, Sep 21, 2013 at 1:00 PM, John Julien wrote: > I'd like to start some discussion around how to implement > https://projects.puppetlabs.com/issues/9546 (Plugin sync support for > external facts) > > That issue unfortunately only states that it should do it, but nothing about why we should d

[Puppet-dev] Plugin sync support for external facts

2013-09-21 Thread John Julien
I'd like to start some discussion around how to implement https://projects.puppetlabs.com/issues/9546 (Plugin sync support for external facts) Since external facts can be any type of executable and additionally straight json and yaml, i'm not sure putting then under lib/ is the best place to m