[Puppet-dev] fixes for #3740

2010-05-07 Thread Marc Fournier
Hello, I'm not sure to understand the use of these trailing dots I removed with the 2nd patch. As there isn't many tests for this function, maybe this breaks something else and needs more work. -- You received this message because you are subscribed to the Google Groups Puppet Developers

Re: [Puppet-dev] fixes for #3740

2010-05-07 Thread Paul Nasrat
On 7 May 2010 08:21, Marc Fournier marc.fourn...@camptocamp.com wrote: Hello, I'm not sure to understand the use of these trailing dots I removed with the 2nd patch. As there isn't many tests for this function, maybe this breaks something else and needs more work. If I have time over the

Re: [Puppet-dev] fixes for #3740

2010-05-07 Thread Markus Roberts
I'm not sure to understand the use of these trailing dots I removed with the 2nd patch. As there isn't many tests for this function, maybe this breaks something else and needs more work. I'm not sure either, but looking at it I'm dubious of the regex anyway; specifically, the 0x\d+ segment,