Re: [Puppet-dev] issue 7629 against master

2011-05-24 Thread Dan Bode
On Mon, May 23, 2011 at 10:45 PM, Luke Kanies l...@puppetlabs.com wrote: On May 23, 2011, at 11:45 AM, Dan Bode wrote: This is an experimental set of patches that I wrote for composite namevars to work with parsedfile and to support purging. This is not ready to be merged, I would just

Re: [Puppet-dev] issue 7629 against master

2011-05-24 Thread Dan Bode
HI Stefan, I modified and merged your ports code with the latest version of my patch (which has changed a little from yesterday) comments below: It could be that I fixed you use cases with some of my changes this morning. I have still identified that this is causing other things in puppet

Re: [Puppet-dev] issue 7629 against master

2011-05-24 Thread Stefan Schulte
On Tue, May 24, 2011 at 12:12:20AM +0200, Stefan Schulte wrote: On Mon, May 23, 2011 at 02:39:40PM -0700, Dan Bode wrote: :name is special (and hardcoded) in several parts of the Puppet code. Could you try using some other name that :name and see if it resolves those issues? Doesnt

[Puppet-dev] issue 7629 against master

2011-05-23 Thread Dan Bode
This is an experimental set of patches that I wrote for composite namevars to work with parsedfile and to support purging. This is not ready to be merged, I would just like to get some input on the following: - does this work (for people who have pending composite namevar work) - will this

Re: [Puppet-dev] issue 7629 against master

2011-05-23 Thread Stefan Schulte
On Mon, May 23, 2011 at 11:45:45AM -0700, Dan Bode wrote: This is an experimental set of patches that I wrote for composite namevars to work with parsedfile and to support purging. This is not ready to be merged, I would just like to get some input on the following: - does this work

Re: [Puppet-dev] issue 7629 against master

2011-05-23 Thread Dan Bode
:name is special (and hardcoded) in several parts of the Puppet code. Could you try using some other name that :name and see if it resolves those issues? On Mon, May 23, 2011 at 2:25 PM, Stefan Schulte stefan.schu...@taunusstein.net wrote: On Mon, May 23, 2011 at 11:45:45AM -0700, Dan Bode

Re: [Puppet-dev] issue 7629 against master

2011-05-23 Thread Stefan Schulte
On Mon, May 23, 2011 at 02:39:40PM -0700, Dan Bode wrote: :name is special (and hardcoded) in several parts of the Puppet code. Could you try using some other name that :name and see if it resolves those issues? Doesnt resolve the issue. The test did pass before I applied your patch. Here

Re: [Puppet-dev] issue 7629 against master

2011-05-23 Thread Dan Bode
can you point me to a branch I can pull from? On Mon, May 23, 2011 at 3:12 PM, Stefan Schulte stefan.schu...@taunusstein.net wrote: On Mon, May 23, 2011 at 02:39:40PM -0700, Dan Bode wrote: :name is special (and hardcoded) in several parts of the Puppet code. Could you try using some

Re: [Puppet-dev] issue 7629 against master

2011-05-23 Thread Luke Kanies
On May 23, 2011, at 11:45 AM, Dan Bode wrote: This is an experimental set of patches that I wrote for composite namevars to work with parsedfile and to support purging. This is not ready to be merged, I would just like to get some input on the following: - does this work (for people who