[Puppet-dev] Re: Rspec tests on puppet master branch failing
On 2015-13-03 2:43, Trevor Vaughan wrote: This file appears to be the issue according to the binary search (neat tool BTW) The culprit is /home/thanos/Work/puppet/spec/integration/agent/logging_spec.rb. However, when I run that file by hand, it works just fine. The issues do specifically seem to be related to the Package tests from what I can tell. For completeness: Fedora 20 Ruby 2.0.0-p353 The next step would be to do an rspec run of the alleged culprit followed by the test that was originally failing. That then becomes proof of guilt. - henrik Thanks, Trevor On Thu, Mar 12, 2015 at 3:14 PM, Kylo Ginsberg k...@puppetlabs.com mailto:k...@puppetlabs.com wrote: On Thu, Mar 12, 2015 at 9:01 AM, Trevor Vaughan tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com wrote: No, if I run parallel::spec, I actually get different errors, so I stopped trying to use it. I just ran with a clean ruby 2.0.0-p353 with the same results. As Henrik mentioned, it could be a spec order problem. If you run: bundle exec rake ci:spec then you should get a shiny spec_order.txt. Then you can run: util/binary_search_specs.rb full path to failing spec And it will (usually) tell you the test that makes the failing spec fail. (The 'usually' caveat is because there can be spec failures that require specific ordering between 2 spec files, and this tool only handles the case for 2 spec files. The 2 case is super duper fun.) Clearly, this needs to be in our docs, PR coming. Kylo Not quite sure what's going on. I'll poke around some more later since you can't seem to reproduce. Trevor On Thu, Mar 12, 2015 at 11:57 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com mailto:henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 16:40, Trevor Vaughan wrote: Hi Henrik, I purged all of my gems removed my Gemfile.lock file and then ran bundle install followed by bundle update with the same result. Does it work if you run the failing tests in isolation? (If so it could be an ordering problem). I just ran this on master: * bundle update * bundle exec rake parallel:spec[4] = 18768 examples, 0 failures, 44 pending - henrik Thanks, Trevor On Thu, Mar 12, 2015 at 11:11 AM, Henrik Lindberg henrik.lindberg@cloudsmith.__com mailto:henrik.lindb...@cloudsmith.com mailto:henrik.lindberg@__cloudsmith.com mailto:henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 14:10, Trevor Vaughan wrote: Hi all, Some of the package spec tests are failing for me under Ruby 1.9.3. The offending commit appears to be: commit 8eb9557420bd10cfb268c55a62698136338c9b79 Merge: 0abb9a9 11bba86 Author: Henrik Lindberg henrik.lindberg@cloudsmith.com mailto:henrik.lindberg@__cloudsmith.com mailto:henrik.lindb...@cloudsmith.com mailto:henrik.lindberg@ mailto:henrik.lindberg@__clou__dsmith.com http://cloudsmith.com mailto:henrik.lindberg@__cloudsmith.com mailto:henrik.lindb...@cloudsmith.com Date: Thu Mar 5 22:50:14 2015 +0100 Merge branch 'stable' Conflicts: lib/puppet/parser/scope.rb lib/puppet/type/package.rb spec/unit/type/package_spec.rb Changed be_true matcher to be_truthy because of rspec version change Ruby Version: ruby-1.9.3-p551 Gemfile: Stock in Puppet core Branch: master (stable is fine) You probably do not have rspec 3 which is now required on master. Try a 'bundle update' - henrik Thanks, Trevor -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 tel:%28410%29%20541-6699 tel:%28410%29%20541-6699 tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com__
Re: [Puppet-dev] Re: Rspec tests on puppet master branch failing
On Thu, Mar 12, 2015 at 6:43 PM, Trevor Vaughan tvaug...@onyxpoint.com wrote: This file appears to be the issue according to the binary search (neat tool BTW) The culprit is /home/thanos/Work/puppet/spec/integration/agent/logging_spec.rb. However, when I run that file by hand, it works just fine. The issues do specifically seem to be related to the Package tests from what I can tell. For completeness: Fedora 20 Ruby 2.0.0-p353 Can you gist the actual invocation and failure? (In the case where there are just two specs files together that cause a failure.) I tried: be rspec spec/integration/agent/logging_spec.rb spec/unit/type/package_spec.rb And it was happy. (Full disclosure: this was on osx not f20.) Kylo Thanks, Trevor On Thu, Mar 12, 2015 at 3:14 PM, Kylo Ginsberg k...@puppetlabs.com wrote: On Thu, Mar 12, 2015 at 9:01 AM, Trevor Vaughan tvaug...@onyxpoint.com wrote: No, if I run parallel::spec, I actually get different errors, so I stopped trying to use it. I just ran with a clean ruby 2.0.0-p353 with the same results. As Henrik mentioned, it could be a spec order problem. If you run: bundle exec rake ci:spec then you should get a shiny spec_order.txt. Then you can run: util/binary_search_specs.rb full path to failing spec And it will (usually) tell you the test that makes the failing spec fail. (The 'usually' caveat is because there can be spec failures that require specific ordering between 2 spec files, and this tool only handles the case for 2 spec files. The 2 case is super duper fun.) Clearly, this needs to be in our docs, PR coming. Kylo Not quite sure what's going on. I'll poke around some more later since you can't seem to reproduce. Trevor On Thu, Mar 12, 2015 at 11:57 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 16:40, Trevor Vaughan wrote: Hi Henrik, I purged all of my gems removed my Gemfile.lock file and then ran bundle install followed by bundle update with the same result. Does it work if you run the failing tests in isolation? (If so it could be an ordering problem). I just ran this on master: * bundle update * bundle exec rake parallel:spec[4] = 18768 examples, 0 failures, 44 pending - henrik Thanks, Trevor On Thu, Mar 12, 2015 at 11:11 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com mailto:henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 14:10, Trevor Vaughan wrote: Hi all, Some of the package spec tests are failing for me under Ruby 1.9.3. The offending commit appears to be: commit 8eb9557420bd10cfb268c55a626981__36338c9b79 Merge: 0abb9a9 11bba86 Author: Henrik Lindberg henrik.lindberg@cloudsmith.__com mailto:henrik.lindb...@cloudsmith.com mailto:henrik.lindberg@__cloudsmith.com mailto:henrik.lindb...@cloudsmith.com Date: Thu Mar 5 22:50:14 2015 +0100 Merge branch 'stable' Conflicts: lib/puppet/parser/scope.rb lib/puppet/type/package.rb spec/unit/type/package_spec.rb Changed be_true matcher to be_truthy because of rspec version change Ruby Version: ruby-1.9.3-p551 Gemfile: Stock in Puppet core Branch: master (stable is fine) You probably do not have rspec 3 which is now required on master. Try a 'bundle update' - henrik Thanks, Trevor -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 tel:%28410%29%20541-6699 tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com __ -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscribe@__googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com mailto:puppet-dev+__unsubscr...@googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/__msgid/puppet-dev/CANs%__ 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT___mLucay%3D9oXe-kQU9PQ%40mail. __gmail.com https://groups.google.com/d/msgid/puppet-dev/CANs% 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail.gmail.com https://groups.google.com/d/__msgid/puppet-dev/CANs%__ 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT___mLucay%3D9oXe-kQU9PQ%40mail. __gmail.com?utm_medium=email__utm_source=footer https://groups.google.com/d/msgid/puppet-dev/CANs% 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail.
[Puppet-dev] Re: Rspec tests on puppet master branch failing
On 2015-12-03 16:40, Trevor Vaughan wrote: Hi Henrik, I purged all of my gems removed my Gemfile.lock file and then ran bundle install followed by bundle update with the same result. Does it work if you run the failing tests in isolation? (If so it could be an ordering problem). I just ran this on master: * bundle update * bundle exec rake parallel:spec[4] = 18768 examples, 0 failures, 44 pending - henrik Thanks, Trevor On Thu, Mar 12, 2015 at 11:11 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com mailto:henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 14:10, Trevor Vaughan wrote: Hi all, Some of the package spec tests are failing for me under Ruby 1.9.3. The offending commit appears to be: commit 8eb9557420bd10cfb268c55a626981__36338c9b79 Merge: 0abb9a9 11bba86 Author: Henrik Lindberg henrik.lindberg@cloudsmith.__com mailto:henrik.lindb...@cloudsmith.com mailto:henrik.lindberg@__cloudsmith.com mailto:henrik.lindb...@cloudsmith.com Date: Thu Mar 5 22:50:14 2015 +0100 Merge branch 'stable' Conflicts: lib/puppet/parser/scope.rb lib/puppet/type/package.rb spec/unit/type/package_spec.rb Changed be_true matcher to be_truthy because of rspec version change Ruby Version: ruby-1.9.3-p551 Gemfile: Stock in Puppet core Branch: master (stable is fine) You probably do not have rspec 3 which is now required on master. Try a 'bundle update' - henrik Thanks, Trevor -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 tel:%28410%29%20541-6699 tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com__ -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscribe@__googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com mailto:puppet-dev+__unsubscr...@googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/__msgid/puppet-dev/CANs%__2BFoXR9dtAJ5x4qk4vwrK14CRGxyT___mLucay%3D9oXe-kQU9PQ%40mail.__gmail.com https://groups.google.com/d/msgid/puppet-dev/CANs%2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail.gmail.com https://groups.google.com/d/__msgid/puppet-dev/CANs%__2BFoXR9dtAJ5x4qk4vwrK14CRGxyT___mLucay%3D9oXe-kQU9PQ%40mail.__gmail.com?utm_medium=email__utm_source=footer https://groups.google.com/d/msgid/puppet-dev/CANs%2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail.gmail.com?utm_medium=emailutm_source=footer. For more options, visit https://groups.google.com/d/__optout https://groups.google.com/d/optout. -- Visit my Blog Puppet on the Edge http://puppet-on-the-edge.__blogspot.se/ http://puppet-on-the-edge.blogspot.se/ -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscribe@__googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/__msgid/puppet-dev/mdsab4%24uit%__241%40ger.gmane.org https://groups.google.com/d/msgid/puppet-dev/mdsab4%24uit%241%40ger.gmane.org. For more options, visit https://groups.google.com/d/__optout https://groups.google.com/d/optout. -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com mailto:puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CANs%2BFoVKj5nYqz2Ogbn-LZi%3DMbpTOPftKr%2Bz6gCpmD9Ss-rkLA%40mail.gmail.com https://groups.google.com/d/msgid/puppet-dev/CANs%2BFoVKj5nYqz2Ogbn-LZi%3DMbpTOPftKr%2Bz6gCpmD9Ss-rkLA%40mail.gmail.com?utm_medium=emailutm_source=footer. For more options, visit https://groups.google.com/d/optout. -- Visit my Blog Puppet on the Edge http://puppet-on-the-edge.blogspot.se/ -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe
Re: [Puppet-dev] Re: Rspec tests on puppet master branch failing
Just for additional info. When I run 'bundle update' I get the following output from the latest HEAD in master: Installing rake 10.1.1 Installing CFPropertyList 2.2.8 Installing ast 2.0.0 Installing parser 2.2.0.3 Installing astrolabe 1.3.0 Installing builder 3.2.2 Installing coderay 1.1.0 Installing diff-lcs 1.2.5 Installing facter 2.4.1 Installing json_pure 1.8.2 Installing hiera 1.3.4 Installing json 1.8.2 Installing json-schema 2.1.1 Installing metaclass 0.0.4 Installing method_source 0.8.2 Installing mocha 0.10.5 Installing msgpack 0.5.11 Installing multi_json 1.7.7 Installing net-ssh 2.9.2 Installing powerpack 0.0.9 Installing slop 3.6.0 Installing pry 0.10.1 Using puppet 4.0.0 (was 3.7.3) from source at /home/user/puppet Installing puppet-lint 1.1.0 Installing puppet-syntax 2.0.0 Installing rspec-support 3.2.2 Installing rspec-core 3.2.2 Installing rspec-expectations 3.2.0 Installing rspec-mocks 3.2.1 Installing rspec 3.2.0 Installing rspec-puppet 1.0.1 Installing puppetlabs_spec_helper 0.9.1 Installing racc 1.4.9 Installing rack 1.6.0 Installing rainbow 2.0.0 Installing rdoc 4.2.0 Installing redcarpet 2.3.0 Installing rspec-collection_matchers 1.1.2 Installing rspec-its 1.2.0 Installing rspec-legacy_formatters 1.0.0 Installing ruby-progressbar 1.7.1 Installing rubocop 0.26.1 Installing ruby-prof 0.15.6 Installing thread_safe 0.3.5 Installing tzinfo 1.2.2 Installing yard 0.8.7.6 Installing yarjuf 2.0.0 Using bundler 1.6.2 Your bundle is updated! On Thu, Mar 12, 2015 at 12:01 PM, Trevor Vaughan tvaug...@onyxpoint.com wrote: No, if I run parallel::spec, I actually get different errors, so I stopped trying to use it. I just ran with a clean ruby 2.0.0-p353 with the same results. Not quite sure what's going on. I'll poke around some more later since you can't seem to reproduce. Trevor On Thu, Mar 12, 2015 at 11:57 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 16:40, Trevor Vaughan wrote: Hi Henrik, I purged all of my gems removed my Gemfile.lock file and then ran bundle install followed by bundle update with the same result. Does it work if you run the failing tests in isolation? (If so it could be an ordering problem). I just ran this on master: * bundle update * bundle exec rake parallel:spec[4] = 18768 examples, 0 failures, 44 pending - henrik Thanks, Trevor On Thu, Mar 12, 2015 at 11:11 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com mailto:henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 14:10, Trevor Vaughan wrote: Hi all, Some of the package spec tests are failing for me under Ruby 1.9.3. The offending commit appears to be: commit 8eb9557420bd10cfb268c55a626981__36338c9b79 Merge: 0abb9a9 11bba86 Author: Henrik Lindberg henrik.lindberg@cloudsmith.__com mailto:henrik.lindb...@cloudsmith.com mailto:henrik.lindberg@__cloudsmith.com mailto:henrik.lindb...@cloudsmith.com Date: Thu Mar 5 22:50:14 2015 +0100 Merge branch 'stable' Conflicts: lib/puppet/parser/scope.rb lib/puppet/type/package.rb spec/unit/type/package_spec.rb Changed be_true matcher to be_truthy because of rspec version change Ruby Version: ruby-1.9.3-p551 Gemfile: Stock in Puppet core Branch: master (stable is fine) You probably do not have rspec 3 which is now required on master. Try a 'bundle update' - henrik Thanks, Trevor -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 tel:%28410%29%20541-6699 tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com __ -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscribe@__googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com mailto:puppet-dev+__unsubscr...@googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/__msgid/puppet-dev/CANs%__ 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT___mLucay%3D9oXe-kQU9PQ%40mail.__gmail.com https://groups.google.com/d/msgid/puppet-dev/CANs% 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail.gmail.com https://groups.google.com/d/__msgid/puppet-dev/CANs%__ 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT___mLucay%3D9oXe-kQU9PQ%40mail. __gmail.com?utm_medium=email__utm_source=footer https://groups.google.com/d/msgid/puppet-dev/CANs%
Re: [Puppet-dev] Re: Rspec tests on puppet master branch failing
Hi Henrik, I purged all of my gems removed my Gemfile.lock file and then ran bundle install followed by bundle update with the same result. Thanks, Trevor On Thu, Mar 12, 2015 at 11:11 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 14:10, Trevor Vaughan wrote: Hi all, Some of the package spec tests are failing for me under Ruby 1.9.3. The offending commit appears to be: commit 8eb9557420bd10cfb268c55a62698136338c9b79 Merge: 0abb9a9 11bba86 Author: Henrik Lindberg henrik.lindb...@cloudsmith.com mailto:henrik.lindb...@cloudsmith.com Date: Thu Mar 5 22:50:14 2015 +0100 Merge branch 'stable' Conflicts: lib/puppet/parser/scope.rb lib/puppet/type/package.rb spec/unit/type/package_spec.rb Changed be_true matcher to be_truthy because of rspec version change Ruby Version: ruby-1.9.3-p551 Gemfile: Stock in Puppet core Branch: master (stable is fine) You probably do not have rspec 3 which is now required on master. Try a 'bundle update' - henrik Thanks, Trevor -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com mailto:puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CANs% 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail.gmail.com https://groups.google.com/d/msgid/puppet-dev/CANs% 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail. gmail.com?utm_medium=emailutm_source=footer. For more options, visit https://groups.google.com/d/optout. -- Visit my Blog Puppet on the Edge http://puppet-on-the-edge.blogspot.se/ -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/ msgid/puppet-dev/mdsab4%24uit%241%40ger.gmane.org. For more options, visit https://groups.google.com/d/optout. -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 tvaug...@onyxpoint.com -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CANs%2BFoVKj5nYqz2Ogbn-LZi%3DMbpTOPftKr%2Bz6gCpmD9Ss-rkLA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: [Puppet-dev] Re: Rspec tests on puppet master branch failing
No, if I run parallel::spec, I actually get different errors, so I stopped trying to use it. I just ran with a clean ruby 2.0.0-p353 with the same results. Not quite sure what's going on. I'll poke around some more later since you can't seem to reproduce. Trevor On Thu, Mar 12, 2015 at 11:57 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 16:40, Trevor Vaughan wrote: Hi Henrik, I purged all of my gems removed my Gemfile.lock file and then ran bundle install followed by bundle update with the same result. Does it work if you run the failing tests in isolation? (If so it could be an ordering problem). I just ran this on master: * bundle update * bundle exec rake parallel:spec[4] = 18768 examples, 0 failures, 44 pending - henrik Thanks, Trevor On Thu, Mar 12, 2015 at 11:11 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com mailto:henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 14:10, Trevor Vaughan wrote: Hi all, Some of the package spec tests are failing for me under Ruby 1.9.3. The offending commit appears to be: commit 8eb9557420bd10cfb268c55a626981__36338c9b79 Merge: 0abb9a9 11bba86 Author: Henrik Lindberg henrik.lindberg@cloudsmith.__com mailto:henrik.lindb...@cloudsmith.com mailto:henrik.lindberg@__cloudsmith.com mailto:henrik.lindb...@cloudsmith.com Date: Thu Mar 5 22:50:14 2015 +0100 Merge branch 'stable' Conflicts: lib/puppet/parser/scope.rb lib/puppet/type/package.rb spec/unit/type/package_spec.rb Changed be_true matcher to be_truthy because of rspec version change Ruby Version: ruby-1.9.3-p551 Gemfile: Stock in Puppet core Branch: master (stable is fine) You probably do not have rspec 3 which is now required on master. Try a 'bundle update' - henrik Thanks, Trevor -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 tel:%28410%29%20541-6699 tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com__ -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscribe@__googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com mailto:puppet-dev+__unsubscr...@googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/__msgid/puppet-dev/CANs%__ 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT___mLucay%3D9oXe-kQU9PQ%40mail.__gmail.com https://groups.google.com/d/msgid/puppet-dev/CANs% 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail.gmail.com https://groups.google.com/d/__msgid/puppet-dev/CANs%__ 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT___mLucay%3D9oXe-kQU9PQ%40mail. __gmail.com?utm_medium=email__utm_source=footer https://groups.google.com/d/msgid/puppet-dev/CANs% 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail. gmail.com?utm_medium=emailutm_source=footer. For more options, visit https://groups.google.com/d/__optout https://groups.google.com/d/optout. -- Visit my Blog Puppet on the Edge http://puppet-on-the-edge.__blogspot.se/ http://puppet-on-the-edge.blogspot.se/ -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscribe@__googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/__msgid/puppet-dev/mdsab4%24uit% __241%40ger.gmane.org https://groups.google.com/d/msgid/puppet-dev/mdsab4%24uit% 241%40ger.gmane.org. For more options, visit https://groups.google.com/d/__optout https://groups.google.com/d/optout. -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com mailto:puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CANs%2BFoVKj5nYqz2Ogbn-LZi%
Re: [Puppet-dev] Re: Rspec tests on puppet master branch failing
On Thu, Mar 12, 2015 at 9:01 AM, Trevor Vaughan tvaug...@onyxpoint.com wrote: No, if I run parallel::spec, I actually get different errors, so I stopped trying to use it. I just ran with a clean ruby 2.0.0-p353 with the same results. As Henrik mentioned, it could be a spec order problem. If you run: bundle exec rake ci:spec then you should get a shiny spec_order.txt. Then you can run: util/binary_search_specs.rb full path to failing spec And it will (usually) tell you the test that makes the failing spec fail. (The 'usually' caveat is because there can be spec failures that require specific ordering between 2 spec files, and this tool only handles the case for 2 spec files. The 2 case is super duper fun.) Clearly, this needs to be in our docs, PR coming. Kylo Not quite sure what's going on. I'll poke around some more later since you can't seem to reproduce. Trevor On Thu, Mar 12, 2015 at 11:57 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 16:40, Trevor Vaughan wrote: Hi Henrik, I purged all of my gems removed my Gemfile.lock file and then ran bundle install followed by bundle update with the same result. Does it work if you run the failing tests in isolation? (If so it could be an ordering problem). I just ran this on master: * bundle update * bundle exec rake parallel:spec[4] = 18768 examples, 0 failures, 44 pending - henrik Thanks, Trevor On Thu, Mar 12, 2015 at 11:11 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com mailto:henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 14:10, Trevor Vaughan wrote: Hi all, Some of the package spec tests are failing for me under Ruby 1.9.3. The offending commit appears to be: commit 8eb9557420bd10cfb268c55a626981__36338c9b79 Merge: 0abb9a9 11bba86 Author: Henrik Lindberg henrik.lindberg@cloudsmith.__com mailto:henrik.lindb...@cloudsmith.com mailto:henrik.lindberg@__cloudsmith.com mailto:henrik.lindb...@cloudsmith.com Date: Thu Mar 5 22:50:14 2015 +0100 Merge branch 'stable' Conflicts: lib/puppet/parser/scope.rb lib/puppet/type/package.rb spec/unit/type/package_spec.rb Changed be_true matcher to be_truthy because of rspec version change Ruby Version: ruby-1.9.3-p551 Gemfile: Stock in Puppet core Branch: master (stable is fine) You probably do not have rspec 3 which is now required on master. Try a 'bundle update' - henrik Thanks, Trevor -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 tel:%28410%29%20541-6699 tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com __ -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscribe@__googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com mailto:puppet-dev+__unsubscr...@googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/__msgid/puppet-dev/CANs%__ 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT___mLucay%3D9oXe-kQU9PQ%40mail.__gmail.com https://groups.google.com/d/msgid/puppet-dev/CANs% 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail.gmail.com https://groups.google.com/d/__msgid/puppet-dev/CANs%__ 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT___mLucay%3D9oXe-kQU9PQ%40mail. __gmail.com?utm_medium=email__utm_source=footer https://groups.google.com/d/msgid/puppet-dev/CANs% 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail. gmail.com?utm_medium=emailutm_source=footer. For more options, visit https://groups.google.com/d/__optout https://groups.google.com/d/optout. -- Visit my Blog Puppet on the Edge http://puppet-on-the-edge.__blogspot.se/ http://puppet-on-the-edge.blogspot.se/ -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscribe@__googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/__msgid/puppet-dev/mdsab4%24uit% __241%40ger.gmane.org https://groups.google.com/d/msgid/puppet-dev/mdsab4%24uit% 241%40ger.gmane.org. For more options, visit https://groups.google.com/d/__optout
Re: [Puppet-dev] Re: Rspec tests on puppet master branch failing
This file appears to be the issue according to the binary search (neat tool BTW) The culprit is /home/thanos/Work/puppet/spec/integration/agent/logging_spec.rb. However, when I run that file by hand, it works just fine. The issues do specifically seem to be related to the Package tests from what I can tell. For completeness: Fedora 20 Ruby 2.0.0-p353 Thanks, Trevor On Thu, Mar 12, 2015 at 3:14 PM, Kylo Ginsberg k...@puppetlabs.com wrote: On Thu, Mar 12, 2015 at 9:01 AM, Trevor Vaughan tvaug...@onyxpoint.com wrote: No, if I run parallel::spec, I actually get different errors, so I stopped trying to use it. I just ran with a clean ruby 2.0.0-p353 with the same results. As Henrik mentioned, it could be a spec order problem. If you run: bundle exec rake ci:spec then you should get a shiny spec_order.txt. Then you can run: util/binary_search_specs.rb full path to failing spec And it will (usually) tell you the test that makes the failing spec fail. (The 'usually' caveat is because there can be spec failures that require specific ordering between 2 spec files, and this tool only handles the case for 2 spec files. The 2 case is super duper fun.) Clearly, this needs to be in our docs, PR coming. Kylo Not quite sure what's going on. I'll poke around some more later since you can't seem to reproduce. Trevor On Thu, Mar 12, 2015 at 11:57 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 16:40, Trevor Vaughan wrote: Hi Henrik, I purged all of my gems removed my Gemfile.lock file and then ran bundle install followed by bundle update with the same result. Does it work if you run the failing tests in isolation? (If so it could be an ordering problem). I just ran this on master: * bundle update * bundle exec rake parallel:spec[4] = 18768 examples, 0 failures, 44 pending - henrik Thanks, Trevor On Thu, Mar 12, 2015 at 11:11 AM, Henrik Lindberg henrik.lindb...@cloudsmith.com mailto:henrik.lindb...@cloudsmith.com wrote: On 2015-12-03 14:10, Trevor Vaughan wrote: Hi all, Some of the package spec tests are failing for me under Ruby 1.9.3. The offending commit appears to be: commit 8eb9557420bd10cfb268c55a626981__36338c9b79 Merge: 0abb9a9 11bba86 Author: Henrik Lindberg henrik.lindberg@cloudsmith.__com mailto:henrik.lindb...@cloudsmith.com mailto:henrik.lindberg@__cloudsmith.com mailto:henrik.lindb...@cloudsmith.com Date: Thu Mar 5 22:50:14 2015 +0100 Merge branch 'stable' Conflicts: lib/puppet/parser/scope.rb lib/puppet/type/package.rb spec/unit/type/package_spec.rb Changed be_true matcher to be_truthy because of rspec version change Ruby Version: ruby-1.9.3-p551 Gemfile: Stock in Puppet core Branch: master (stable is fine) You probably do not have rspec 3 which is now required on master. Try a 'bundle update' - henrik Thanks, Trevor -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 tel:%28410%29%20541-6699 tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com mailto:tvaug...@onyxpoint.com __ -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscribe@__googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com mailto:puppet-dev+__unsubscr...@googlegroups.com mailto:puppet-dev%2bunsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/__msgid/puppet-dev/CANs%__ 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT___mLucay%3D9oXe-kQU9PQ%40mail.__gmail.com https://groups.google.com/d/msgid/puppet-dev/CANs% 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail.gmail.com https://groups.google.com/d/__msgid/puppet-dev/CANs%__ 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT___mLucay%3D9oXe-kQU9PQ%40mail. __gmail.com?utm_medium=email__utm_source=footer https://groups.google.com/d/msgid/puppet-dev/CANs% 2BFoXR9dtAJ5x4qk4vwrK14CRGxyT_mLucay%3D9oXe-kQU9PQ%40mail. gmail.com?utm_medium=emailutm_source=footer. For more options, visit https://groups.google.com/d/__optout https://groups.google.com/d/optout. -- Visit my Blog Puppet on the Edge http://puppet-on-the-edge.__blogspot.se/ http://puppet-on-the-edge.blogspot.se/ -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To
