Re: [pve-devel] [PATCH v4 qemu-server 2/2] remote-migration: add target-cpu && target-reboot params

2023-10-10 Thread DERUMIER, Alexandre
> > I think that a true offline migration (without starting any > source/target vm) can be done with qemu-storage-daemon running nbd > server on target &&  qemu-img on source. > > This could be also used for online migration with unused/detached > disks. > >>Yes, we could, but would require add

[pve-devel] applied: [PATCH manager v5] ui: ceph: improve discoverability of warning details

2023-10-10 Thread Thomas Lamprecht
Am 02/10/2023 um 11:00 schrieb Aaron Lauterer: > by > * replacing the info button with expandable rows that contain the > details of the warning > * adding two action buttons to copy the summary and details > * making the text selectable > > The row expander works like the one in the mail gatewa

[pve-devel] [PATCH qemu-server] Fix: cpu hotplug feature can't be changed online

2023-10-10 Thread Alexandre Derumier
The cpus are passed as devices with specific id only when cpu hotplug is enable at start. We can't enable/disable it online or vcpu hotplug api will thrown errors not finding core id. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared

2023-10-10 Thread Thomas Lamprecht
Am 10/10/2023 um 15:19 schrieb Aaron Lauterer: >>> >>> >>> diff --git a/www/manager6/storage/DirEdit.js  >>> b/www/manager6/storage/DirEdit.js >>> index 7e9ec44d..8469a7c3 100644 >>> --- a/www/manager6/storage/DirEdit.js >>> +++ b/www/manager6/storage/DirEdit.js >>> @@ -30,6 +30,10 @@ Ext.define('P

Re: [pve-devel] [PATCH v3 qemu-server] Fix ACPI-suspended VMs resuming after migration

2023-10-10 Thread Fiona Ebner
Am 10.10.23 um 13:45 schrieb Thomas Lamprecht: > Am 09/10/2023 um 15:25 schrieb Filip Schauer: >> Add checks for "suspended" and "prelaunch" runstates when checking >> whether a VM is paused. >> >> This fixes the following issues: >> * ACPI-suspended VMs automatically resuming after migration >> *

[pve-devel] [PATCH pve-manager 2/2] Homogenize UI naming

2023-10-10 Thread Stefan Lendl
use title case or upper case appreviations everywhere Signed-off-by: Stefan Lendl --- www/manager6/sdn/OptionsPanel.js | 2 +- www/manager6/sdn/SubnetEdit.js| 2 +- www/manager6/sdn/SubnetView.js| 2 +- www/manager6/sdn/dns/PowerdnsEdit.js | 6 +++--- www/manager6/sdn/i

[pve-devel] [PATCH pve-manager 1/2] Refer to SDN subnets as 'Subnet' not as ID

2023-10-10 Thread Stefan Lendl
The Subnet's CIDR in the Edit view is called 'Subnet'. Also refer to it as Subnet in the list view. Signed-off-by: Stefan Lendl --- www/manager6/sdn/SubnetView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/sdn/SubnetView.js b/www/manager6/sdn/SubnetView.js i

[pve-devel] [PATCH manager v3] ui: DirEdit: LVMEdit: add hint when to enable shared

2023-10-10 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer Reviewed-by: Fiona Ebner --- changes since v2: fixed missing trailing comma www/manager6/storage/DirEdit.js | 4 www/manager6/storage/LVMEdit.js | 4 2 files changed, 8 insertions(+) diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/Dir

Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared

2023-10-10 Thread Aaron Lauterer
On 10/10/23 15:06, Fiona Ebner wrote: Am 21.08.23 um 12:06 schrieb Aaron Lauterer: Signed-off-by: Aaron Lauterer --- www/manager6/storage/DirEdit.js | 4 www/manager6/storage/LVMEdit.js | 4 2 files changed, 8 insertions(+) diff --git a/www/manager6/storage/DirEdit.js b/www/ma

Re: [pve-devel] [PATCH installer 1/1] fix #4869: Show state in management interface ComboBox

2023-10-10 Thread Thomas Lamprecht
Am 10/10/2023 um 14:56 schrieb Christoph Heiss: > On Tue, Oct 10, 2023 at 01:55:43PM +0200, Thomas Lamprecht wrote: >> UP -> 🟢 https://unicode-explorer.com/c/1F7E2 > A green circle would be problematic/non-optimal for people deuteranopia > (red-green color blindness). So maybe some other characte

Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared

2023-10-10 Thread Fiona Ebner
Am 21.08.23 um 12:06 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > www/manager6/storage/DirEdit.js | 4 > www/manager6/storage/LVMEdit.js | 4 > 2 files changed, 8 insertions(+) > > diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js > index

Re: [pve-devel] [PATCH installer 1/1] fix #4869: Show state in management interface ComboBox

2023-10-10 Thread Christoph Heiss
On Tue, Oct 10, 2023 at 01:55:43PM +0200, Thomas Lamprecht wrote: > > Am 10/10/2023 um 13:33 schrieb Christoph Heiss: > > On Fri, Aug 04, 2023 at 12:26:46PM +0200, Filip Schauer wrote: > >> @@ -347,7 +347,7 @@ sub create_ipconf_view { > >> > >> my $get_device_desc = sub { > >>my $iface =

Re: [pve-devel] [PATCH storage 1/1] iscsi: allow to configure multiple portals

2023-10-10 Thread Fiona Ebner
Hi, thank you for the contribution! Please prepend the commit title with "fix #254: ". Am 16.08.23 um 13:56 schrieb ykonoto...@gnome.org: > From: Yuri Konotopov > > Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=254 To accept contributions, we need your Signed-off-by trailer here and you n

Re: [pve-devel] [PATCH manager] ui: acl add: show warning if root@pam is selected

2023-10-10 Thread Lukas Wagner
On 10/10/23 14:10, Fiona Ebner wrote: Am 26.07.23 um 15:41 schrieb Lukas Wagner: Currently, users are able to add ACL entries for the root@pam user. Since this user always has full permissions, no entry in the ACL tree will be saved, and consequently no new entry shows up in the UI after pressin

Re: [pve-devel] [PATCH manager] ui: acl add: show warning if root@pam is selected

2023-10-10 Thread Fiona Ebner
Am 26.07.23 um 15:41 schrieb Lukas Wagner: > Currently, users are able to add ACL entries for the root@pam user. > Since this user always has full permissions, no entry in the ACL > tree will be saved, and consequently no new entry shows up in the UI > after pressing 'Add' in the dialog. This can b

Re: [pve-devel] [PATCH installer 1/1] fix #4869: Show state in management interface ComboBox

2023-10-10 Thread Thomas Lamprecht
Am 10/10/2023 um 13:33 schrieb Christoph Heiss: > On Fri, Aug 04, 2023 at 12:26:46PM +0200, Filip Schauer wrote: >> @@ -347,7 +347,7 @@ sub create_ipconf_view { >> >> my $get_device_desc = sub { >> my $iface = shift; >> -return "$iface->{name} - $iface->{mac} ($iface->{driver})"; >> +

Re: [pve-devel] [PATCH v3 qemu-server] Fix ACPI-suspended VMs resuming after migration

2023-10-10 Thread Thomas Lamprecht
Am 09/10/2023 um 15:25 schrieb Filip Schauer: > Add checks for "suspended" and "prelaunch" runstates when checking > whether a VM is paused. > > This fixes the following issues: > * ACPI-suspended VMs automatically resuming after migration > * Shutdown and reboot commands timing out instead of fai

Re: [pve-devel] [PATCH installer 1/1] fix #4869: Show state in management interface ComboBox

2023-10-10 Thread Christoph Heiss
Needs to be done for the TUI installer as well. Easiest way here is to add `state` to each interface in Proxmox::Sys::RunEnv::query_netdevs(), then deserialize that in `setup::Interface`. Looking at it, adding the MAC address there too would be great, if you are already at it. On Fri, Aug 04, 2

[pve-devel] applied: [PATCH v3 proxmox-i18n] update German translation

2023-10-10 Thread Thomas Lamprecht
Am 10/10/2023 um 09:42 schrieb Hannes Duerr: > update German translation I drop that part on applying, as having the subject and commit message the same thing is not really adding anything. > > Signed-off-by: Hannes Duerr > --- > > Hab die Änderungen aufgenommen > > de.po | 121 +

[pve-devel] [PATCH proxmox-widget-toolkit v2 2/3] fix #4546: utils: Highlight accounts in user management that exprie soon

2023-10-10 Thread Philipp Hufnagl
When a user account is about to expire in the next 7 days, the date column will be highlighted with warning color. Signed-off-by: Philipp Hufnagl --- src/Utils.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Utils.js b/src/Utils.js index f269607..f5769a0 100644 --

[pve-devel] [PATCH access-control v2 1/1] fix #4546: api: Return user expiration date on access/ticket API call

2023-10-10 Thread Philipp Hufnagl
Adds an additional, optional parameter to the access/tickets api call which tells when the currently used user account will expire. If it will not expire, the parameter will not be added. Signed-off-by: Philipp Hufnagl --- src/PVE/API2/AccessControl.pm | 8 src/PVE/AccessControl.pm

[pve-devel] [PATCH proxmox-widget-toolkit v2 1/1] fix #4546: ui: notify user if there usser account expires soon

2023-10-10 Thread Philipp Hufnagl
When the user account that is currently logged in will expire soon, the user icon will turn into a yellow exclamation mark. In the user menu there will be a new element informing the user briefly about it. If the element is clicked, a popup will appear informing the user in detail about it Signed-

[pve-devel] [PATCH proxmox-widget-toolkit v2 1/3] fix #4546: css: create a new css class for warning texts

2023-10-10 Thread Philipp Hufnagl
Creates a new css class 'text-color-warning' for the dark theme, which will be used to propperly show a warning icon later. For this purpose the 'pwt-gauge-warn' color is extracted in a variable and reused. Also the variable 'pwd-gauge-crit' has been extracted for consistency. Signed-off-by: Phili

[pve-devel] [PATCH proxmox-widget-toolkit/manager/access-control v2 0/5] fix #4546: Show warning hint/badge if user account is expiring in next few days

2023-10-10 Thread Philipp Hufnagl
Currently, when an user account expires, it catches the users by surprise. It would be helpful to notify the the user as well as the administrator. This patch highlights such accounts in the user account pannel and also shows for regular user an exclamation mark in the user info pannel. It also ad

[pve-devel] [PATCH proxmox-widget-toolkit v2 3/3] fix #4546: utils: Expand authentication data with account expiry date

2023-10-10 Thread Philipp Hufnagl
When the authentication data of a session are set, the account expiry date will be set also (provided there is one). Signed-off-by: Philipp Hufnagl --- src/Utils.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Utils.js b/src/Utils.js index f5769a0..654c907 100644 --- a/src/Utils.js

Re: [pve-devel] [PATCH proxmox-widget-toolkit v1 1/2] fix #4546: css: Inform user administrator about user accounts expiring soon

2023-10-10 Thread Philipp Hufnagl
> for the light theme you could simply use the `.warning` class instead > then you can simply overwrite that with a more specific selector in the > dark theme again, like we already do in a couple of places. Thank you. I tried using .warning. Unfortunately the result was yellow on white backgro

Re: [pve-devel] [PATCH manager v1 1/1] fix #4546: ui: notify user if their user account expires soon

2023-10-10 Thread Philipp Hufnagl
On 10/6/23 15:16, Lukas Wagner wrote: > Comments inline. > > On 9/22/23 16:36, Philipp Hufnagl wrote: >> When the user account that is currently logged in will expire soon, the >> user icon will turn into a yellow exclamation mark. In the user menu >> there will be a new element informing the us

Re: [pve-devel] [PATCH v4 qemu-server 2/2] remote-migration: add target-cpu && target-reboot params

2023-10-10 Thread Fiona Ebner
Am 09.10.23 um 15:47 schrieb DERUMIER, Alexandre: >>> One could argue that a true 'restart' migration would migrate the >>> volumes also offline, but right now, I don't see a big downside to do >>> it >>> via NBD like in this patch. Still, something we should think about. >>> If >>> it turns out to

Re: [pve-devel] [PATCH v3 proxmox-i18n] update German translation

2023-10-10 Thread Lukas Wagner
Hi again, On 10/10/23 09:42, Hannes Duerr wrote: update German translation Signed-off-by: Hannes Duerr --- Hab die Änderungen aufgenommen not a blocker for this patch (so no need to send another version, as this won't be visible in the commit message), but usually you'd write something like

[pve-devel] applied: [PATCH v3 qemu-server] Fix ACPI-suspended VMs resuming after migration

2023-10-10 Thread Fiona Ebner
Am 09.10.23 um 15:25 schrieb Filip Schauer: > Add checks for "suspended" and "prelaunch" runstates when checking > whether a VM is paused. > > This fixes the following issues: > * ACPI-suspended VMs automatically resuming after migration > * Shutdown and reboot commands timing out instead of faili

[pve-devel] [PATCH qemu-server] qmeventd: also treat 'prelaunch' and 'suspended' states as active

2023-10-10 Thread Fiona Ebner
Otherwise, a VM in those states would be terminated after a backup in handle_qmp_return() with QMP 'quit', which is pretty bad in case of the 'suspended' state. Does not change the fact that a VM started in prelaunch mode for backup is terminated later (that is handled by the Perl code). Signed-o

[pve-devel] [PATCH v3 proxmox-i18n] update German translation

2023-10-10 Thread Hannes Duerr
update German translation Signed-off-by: Hannes Duerr --- Hab die Änderungen aufgenommen de.po | 121 +++--- 1 file changed, 40 insertions(+), 81 deletions(-) diff --git a/de.po b/de.po index fea74f1..e5202af 100644 --- a/de.po +++ b/de.po @