[pve-devel] [PATCH pve-esxi-import-tools/storage v2] improve error handling/logging

2024-05-10 Thread Dominik Csapak
two smaller patches that improve which error gets shown to the user and logged to syslog in case of an early error when trying to fuse mount changes from v1: * improved commit message * remove superfluous space in error * split 'open_file' into its own line * reworded context messages * removed (d

[pve-devel] [PATCH pve-esxi-import-tools v2 1/1] improve error handling before mounting

2024-05-10 Thread Dominik Csapak
when we fail early in the mount process, we did not log any error to the syslog, but only the top most one to stderr. sadly we were not able to see them anywhere, so improve the log by * log the complete error chain with log::error (so we also can see the causes) * add more context hints This c

[pve-devel] [PATCH storage v2 1/1] esxi: improve error handling for fuse mount tool

2024-05-10 Thread Dominik Csapak
if the fuse tool encounters an error early, it prints it like: Error: some error message on stderr. Redirect STDERR of the child process (which mounts the ESXi instance) to the pipe of the parent (API) process, so that it can pass a hopefully more meaningful message to the user than just an err

Re: [pve-devel] [PATCH storage 1/1] esxi: improve error handling for fuse mount tool

2024-05-10 Thread Dominik Csapak
On 5/8/24 16:43, Thomas Lamprecht wrote: On 08/05/2024 14:41, Dominik Csapak wrote: if the fuse tool encounters an error early, it prints it like: Error: some error message on stderr. We can capture that here by redirecting STDERR to $wr and die'ing with using just a variable name like $w

Re: [pve-devel] [PATCH pve-esxi-import-tools 1/1] improve error handling before mounting

2024-05-10 Thread Dominik Csapak
On 5/8/24 16:26, Thomas Lamprecht wrote: On 08/05/2024 14:41, Dominik Csapak wrote: when we fail early in the mount process, we did not log any error to the syslog, but only the top most one to stderr. sadly we were not able to see them anywhere, so improve the log by * log the complete error c

[pve-devel] [PATCH docs] asciidoc: add clickable anchor link to all headings

2024-05-10 Thread Christoph Heiss
Works the same as in our PBS documentation and is generally common for documentations. Very useful for linking specific sections of the documentation in other places. Previously, this always had to be done by getting the correct anchor from the HTML directly via e.g. browser devtools. Signed-off-

[pve-devel] [PATCH qemu-server v10 1/4] add C program to get hardware capabilities from CPUID

2024-05-10 Thread Markus Frank
Implement a systemd service that runs a C program that extracts AMD SEV hardware information such as reduced-phys-bios and cbitpos from CPUID at boot time, looks if SEV, SEV-ES & SEV-SNP are enabled, and outputs these details as JSON to /run/qemu-server/hw-params.json. This programm can also be us

[pve-devel] [PATCH qemu-server v10 2/4] config: add AMD SEV support

2024-05-10 Thread Markus Frank
This patch is for enabling AMD SEV (Secure Encrypted Virtualization) support in QEMU. VM-Config-Examples: amd_sev: type=std,no-debug=1,no-key-sharing=1 amd_sev: es,no-debug=1,kernel-hashes=1 kernel-hashes, reduced-phys-bios & cbitpos correspond to the variables with the same name in QEMU. kernel

[pve-devel] [PATCH docs v10 3/4] add AMD SEV documentation

2024-05-10 Thread Markus Frank
add documentation for the "[PATCH qemu-server] config: QEMU AMD SEV enable" patch. Signed-off-by: Markus Frank --- changes v10: * none qm.adoc | 103 1 file changed, 103 insertions(+) diff --git a/qm.adoc b/qm.adoc index 42c26db..2001bd4

[pve-devel] [PATCH qemu-server/docs/manager v10 0/4] AMD SEV

2024-05-10 Thread Markus Frank
Patch series to enable AMD Secure Encrypted Virtualization (SEV) changes v10: * removed include of sys/types.h in C Program * also die if the BIOS is not set, since the default is SeaBIOS * added pve-manager patch apply/compile order: 1. qemu-server: add C program to get hardware capabilities fro

[pve-devel] [PATCH manager v10 4/4] ui: add AMD SEV configuration to Options

2024-05-10 Thread Markus Frank
By adding a new input panel with an AMD SEV technology selection combo box and checkboxes for the optional parameters in an advanced section, the user can configure the amd_sev option via the WebUI's Options tab. Signed-off-by: Markus Frank --- changes v10: * this patch is new to v10 www/manage