.. such that receivers can differentiate between these two cases more
clearly.
Sometimes, the `progress` sub does not get passed a text (on purpose!),
just updating the progress ratio. This would cause log messages to be
written out which could indicate missing text and look rather weird.
Signed-off-by: Christoph Heiss
---
Proxmox/Install.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index c0f8955..af857ca 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -1331,7 +1331,7 @@ _EOD
my $err = $@;
-
Signed-off-by: Christoph Heiss
---
.../src/bin/proxmox-auto-installer.rs | 8 ++--
proxmox-auto-installer/src/utils.rs | 23 -
proxmox-installer-common/src/setup.rs | 23 +
.../src/views/install_progress.rs | 48 +--
4 files
Same as the TUI does, as introduced in [0].
[0] 22de6e5 ("tui: install_progress: write low-level non-JSON messages to
separate file")
Signed-off-by: Christoph Heiss
---
.../src/bin/proxmox-auto-installer.rs | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
In case the progress message did not contain any text and the percentage
did not change, don't print another (useless) line.
Signed-off-by: Christoph Heiss
---
proxmox-auto-installer/src/bin/proxmox-auto-installer.rs | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
Previously, if something failed in the child, the overall test would
still be successful and exit with `0`.
Signed-off-by: Christoph Heiss
---
test/ui2-stdio.pl | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/test/ui2-stdio.pl b/test/ui2-stdio.pl
index
This series tries to improve upon some small things around the
installation progress reporting, esp. in the auto-installer, as well as
some small fixes & code-deduplication.
Christoph Heiss (6):
test: ui2-stdio: fix multi-process testing
auto, tui: move low-level installer message struct to
because otherwise the SSH calls to other nodes in the cluster will fail
on newer clusters that only have the ssh host keys located in the
pmxcfs.
With ssh_info_to_command we get all the needed SSH options that set the
alias and point to the right known_hosts file.
Signed-off-by: Aaron Lauterer
I'll give it a try and will send a v2 :)
On 2024-05-16 12:17, Fabian Grünbichler wrote:
On May 15, 2024 12:32 pm, Aaron Lauterer wrote:
because otherwise the SSH calls to other nodes in the cluster will fail
on newer clusters that only have the ssh known host keys located in the
pmxcfs.
By
Signed-off-by: Christoph Heiss
---
Proxmox/Makefile | 1 +
Proxmox/Sys/ZFS.pm| 43 ++
test/Makefile | 6 +
test/zfs-get-pool-list.pl | 49 +++
4 files changed, 99 insertions(+)
create mode
Signed-off-by: Christoph Heiss
---
Proxmox/Install.pm | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index c0f8955..c86a574 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -169,6 +169,13 @@ sub btrfs_create {
Pretty straight forward overall, implements a check for an exising
`rpool` on the system and ask the user whether they would like to rename
it, much in the same way as it works for VGs already.
Without this, the installer would silently create a second (and thus
conflicting) `rpool` and cause a
.. in the same manner as the detection for LVM works.
zpools can only be renamed by importing them with a new name, so
unfortunaly the import-export dance is needed.
Signed-off-by: Christoph Heiss
---
Proxmox/Install.pm | 33 +
1 file changed, 33 insertions(+)
On May 15, 2024 12:32 pm, Aaron Lauterer wrote:
> because otherwise the SSH calls to other nodes in the cluster will fail
> on newer clusters that only have the ssh known host keys located in the
> pmxcfs.
>
> By utilizing SSHInfo::ssh_info_to_ssh_opts we can add the needed options
> to the SSH
On May 15, 2024 12:32 pm, Aaron Lauterer wrote:
> The first instance had the line break mid array. It now is a bit over
> the limit, but follows the style guide closely: putting each argument to
> the function in a newline.
>
> Signed-off-by: Aaron Lauterer
> ---
> src/PVE/CLI/pvecm.pm | 18
15 matches
Mail list logo
