[pve-devel] applied-series: [PATCH zfsonlinux v2 0/2] Update to ZFS 2.2.4

2024-05-21 Thread Thomas Lamprecht
Am 07/05/2024 um 17:02 schrieb Stoiko Ivanov: > v1->v2: > Patch 2/2 (adaptation of arc_summary/arcstat patch) modified: > * right after sending the v1 I saw a report where pinning kernel 6.2 (thus > ZFS 2.1) leads to a similar traceback - which I seem to have overlooked > when packaging 2.2.0 .

[pve-devel] applied: [PATCH docs] network: override device names: suggest running update-initramfs

2024-05-21 Thread Thomas Lamprecht
Am 21/05/2024 um 14:55 schrieb Friedrich Weber: > The initramfs-tools hook /usr/share/initramfs-tools/hooks/udev copies > link files from /etc/systemd/network to the initramfs, where they take > effect in early userspace. If the link files in the initramfs diverge > from the link files in the rootf

[pve-devel] applied: [PATCH v2 manager] api: add proxmox-firewall to versions pkg list

2024-05-21 Thread Thomas Lamprecht
Am 24/04/2024 um 13:35 schrieb Mira Limbeck: > Signed-off-by: Mira Limbeck > --- > v2: > - add `api: ` prefix to commit msg > > PVE/API2/APT.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists

[pve-devel] applied-series: [PATCH proxmox-firewall 1/2] firewall: improve handling of ARP traffic for guests

2024-05-21 Thread Thomas Lamprecht
Am 15/05/2024 um 15:37 schrieb Stefan Hanreich: > In order to be able to send outgoing ARP packets when the default > policy is set to drop or reject, we need to explicitly allow ARP > traffic in the outgoing chain of guests. We need to do this in the > guest chain itself in order to be able to fil

Re: [pve-devel] [PATCH zfsonlinux v2 1/2] update zfs submodule to 2.2.4 and refresh patches

2024-05-21 Thread Max Carrara
On Tue May 7, 2024 at 5:02 PM CEST, Stoiko Ivanov wrote: > mostly - drop all patches we had queued up to get kernel 6.8 > supported. > > Signed-off-by: Stoiko Ivanov > --- See my reply to the cover letter. Tested-by: Max Carrara > ...md-unit-for-importing-specific-pools.patch | 4 +- > ...-

[pve-devel] applied: [PATCH proxmox-firewall v2 1/1] firewall: properly reject ipv6 traffic

2024-05-21 Thread Thomas Lamprecht
Am 13/05/2024 um 14:14 schrieb Stefan Hanreich: > ICMPv6 has different message types for rejecting traffic. With ICMP we > used host-prohibited as rejection type, which doesn't exist in ICMPv6. > Add an additional rule for IPv6, so it uses admin-prohibited. > > Additionally, add a terminal drop st

Re: [pve-devel] [PATCH zfsonlinux v2 2/2] update arc_summary arcstat patch with new introduced values

2024-05-21 Thread Max Carrara
On Tue May 7, 2024 at 5:02 PM CEST, Stoiko Ivanov wrote: > ZFS 2.2.4 added new kstats for speculative prefetch in: > 026fe796465e3da7b27d06ef5338634ee6dd30d8 > > Adapt our patch introduced with ZFS 2.1 (for the then added MFU/MRU > stats), to also deal with the now introduced values not being prese

[pve-devel] [PATCH pve-ha-manager v3 5/8] env: notify: use named templates instead of passing template strings

2024-05-21 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- debian/pve-ha-manager.install | 3 +++ src/Makefile | 1 + src/PVE/HA/Env/PVE2.pm| 4 ++-- src/PVE/HA/NodeStatus.pm | 20 +-- src/PVE/HA/Sim/Env.pm

[pve-devel] [PATCH proxmox-perl-rs v3 2/8] notify: don't pass config structs by reference

2024-05-21 Thread Lukas Wagner
proxmox_notify's api functions have been changed so that they take ownership of config structs. Signed-off-by: Lukas Wagner --- common/src/notify.rs | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/common/src/notify.rs b/common/src/notify.rs index d9

[pve-devel] [PATCH many v3 0/8] notifications: move template strings to template files

2024-05-21 Thread Lukas Wagner
These changes adapts the PVE notification stack to the changes introduced in proxmox-notify 0.4. The notification system uses handlebar templates to render the subject and the body of notifications. Previously, the template strings were defined inline at the call site. This patch series extracts t

[pve-devel] [PATCH proxmox-perl-rs v3 3/8] notify: adapt to Option> to Vec changes in proxmox_notify

2024-05-21 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- common/src/notify.rs | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/common/src/notify.rs b/common/src/notify.rs index 00a6056..e1b006b 100644 --- a/common/src/notify.rs +++ b/common/src/notify.rs @@ -153,8 +153,8 @@ mod export

Re: [pve-devel] [PATCH zfsonlinux v2 0/2] Update to ZFS 2.2.4

2024-05-21 Thread Max Carrara
On Tue May 7, 2024 at 5:02 PM CEST, Stoiko Ivanov wrote: > v1->v2: > Patch 2/2 (adaptation of arc_summary/arcstat patch) modified: > * right after sending the v1 I saw a report where pinning kernel 6.2 (thus > ZFS 2.1) leads to a similar traceback - which I seem to have overlooked > when packag

[pve-devel] [PATCH manager v3 8/8] notifications: use named templates instead of in-code templates

2024-05-21 Thread Lukas Wagner
This commit adapts notification sending for - package update - replication - backups to use named templates (installed in /usr/share/pve-manager/templates) instead of passing template strings defined in code to the notification stack. Signed-off-by: Lukas Wagner --- Makefile

[pve-devel] [PATCH manager v3 7/8] tests: remove vzdump_notification test

2024-05-21 Thread Lukas Wagner
With the upcoming changes in how we send notifications, this one really becomes pretty annoying to keep working. The location where templates are looked up are defined in the proxmox_notify crate, so there is no easy way to mock this for testing. The test itself seemed not super valuable, mainly te

[pve-devel] [PATCH manager v3 6/8] gitignore: ignore any test artifacts

2024-05-21 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index e8d1eb27..481ae1e0 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,5 @@ dest/ /www/mobile/pvemanager-mobile.js /www/touch/touch-[0-9]*/ /pve-manager-[0-9]*/ +/test

[pve-devel] [PATCH cluster v3 4/8] notify: use named template instead of passing template strings

2024-05-21 Thread Lukas Wagner
The notification system will now load template files from a defined location. The template to use is now passed to proxmox_notify, instead of separate template strings for subject/body. Signed-off-by: Lukas Wagner --- src/PVE/Notify.pm | 29 - 1 file changed, 12 inser

[pve-devel] [PATCH proxmox-perl-rs v3 1/8] notify: use file based notification templates

2024-05-21 Thread Lukas Wagner
Instead of passing literal template strings to the notification system, we now only pass an identifier. This identifier will be used load the template files from a product-specific directory. Signed-off-by: Lukas Wagner --- common/src/notify.rs | 8 +++- 1 file changed, 3 insertions(+), 5 de

[pve-devel] [PATCH docs] network: override device names: suggest running update-initramfs

2024-05-21 Thread Friedrich Weber
The initramfs-tools hook /usr/share/initramfs-tools/hooks/udev copies link files from /etc/systemd/network to the initramfs, where they take effect in early userspace. If the link files in the initramfs diverge from the link files in the rootfs, this can lead to confusing behavior, as reported in e

Re: [pve-devel] [PATCH qemu-server v10 1/4] add C program to get hardware capabilities from CPUID

2024-05-21 Thread Thomas Lamprecht
Am 17/05/2024 um 13:21 schrieb Dominik Csapak: > one small nit inline: > > On 5/10/24 13:47, Markus Frank wrote: >> diff --git a/query-machine-capabilities/Makefile >> b/query-machine-capabilities/Makefile >> new file mode 100644 >> index 000..c5f6348 >> --- /dev/null >> +++ b/query-machine-c

Re: [pve-devel] [PATCH cluster 0/2] fix #5461: qdevice cluster mgmt

2024-05-21 Thread Aaron Lauterer
v2 is available https://lists.proxmox.com/pipermail/pve-devel/2024-May/063878.html On 2024-05-15 12:32, Aaron Lauterer wrote: on clusters where the ssh known hosts info is only stored in the pmxcfs, it broke the mgmt of the qdevice. By adding the necessary ssh options on each intra cluster ss