[pve-devel] applied: [PATCH-SERIES qemu-server v5 00/16] more robust handling of fleecing images

2025-04-10 Thread Thomas Lamprecht
On Mon, 27 Jan 2025 12:29:07 +0100, Fiona Ebner wrote: > Changes in v5: > * everything new in v5 except the last 3 patches > * new approach, use special config section instead of config key > * add tests and some fixes for configuration handling > * make special section handling more generic > * al

[pve-devel] [PATCH manager] ui: util: simplify volume_is_qemu_backup again

2025-04-10 Thread Fiona Ebner
Commit f8087e0f ("ui: fix regression with checking if volume is QEMU backup") opted for making the function support multiple types of callers making the function more complex than it needs to be. Simply adapt the rest of the call sites that the commit introducing the regression missed, i.e. commit

[pve-devel] [PATCH manager] ui: qemu: hardware view: fix hwrng cap check for unprivileged users

2025-04-10 Thread Friedrich Weber
Currently, as an unprivileged user with role PVEVMUser the GUI breaks with an error after navigating to a VM's hardware tab. The reason is that the frontend checks the GUI capabilites via `caps.mapping.hwrng`, but `caps.mapping` does not actually have a property called `hwrng`. The reason this doe

[pve-devel] applied: [PATCH proxmox-i18n] update Spanish translations

2025-04-10 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 10:00:09 +0200, Maximiliano Sandoval wrote: > Applied, thanks! [1/1] update Spanish translations commit: d0c38483146bd3ce35e0fc8ae171db816fa3567a ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.

[pve-devel] applied: [PATCH proxmox-i18n] update Spanish translations

2025-04-10 Thread Thomas Lamprecht
On Thu, 10 Apr 2025 11:51:05 +0200, Maximiliano Sandoval wrote: > Applied, thanks! [1/1] update Spanish translations commit: 5001cc32cfd3e869b578db60076c38e98be6519f ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.

[pve-devel] applied: SPAM: [PATCH pve-network v3 1/4] vnet: do not skip if no range is defined, ask for allocation inside prefix instead

2025-04-10 Thread Thomas Lamprecht
On Fri, 13 Dec 2024 20:45:37 +0100, lou lecrivain via pve-devel wrote: > Applied, thanks! [1/1] SPAM: [PATCH pve-network v3 1/4] vnet: do not skip if no range is defined, ask for allocation inside prefix instead commit: 7603197666df54d15ece0deb9d55e427b8aca850 _

[pve-devel] [PATCH qemu-server, manager v5 0/4] fix #1926 autodetect xtermjs or novnc for VM console

2025-04-10 Thread Aaron Lauterer
This version 5 of the series uses a different approach as discussed [0] in the last interation. We add a new property in the VM status/current API result that includes the display configurtion of the VM. This way we can check in the frontend what to do with it. I chose a nested return value, as t

[pve-devel] [PATCH] btrfs: use proxmox-boot-tool to sync ESPs for RAID installs

2025-04-10 Thread Dominik Csapak
instead of just having the first one mounted. This is done by handling it the same as ZFS regarding the ESP. This fixes an issue where installing with BTRFS showed a 'Boot Option Restoration' prompt after boot. Signed-off-by: Dominik Csapak --- Proxmox/Install.pm | 4 ++-- 1 file changed, 2 in

[pve-devel] [PATCH installer] gui: fall back to first found NIC if no default could be determined

2025-04-10 Thread Christoph Heiss
If no DHCP server is configured on the network and/or no DHCP lease and thus network configuration is retrieved, the installer will also be unable to determine the default interface, aka. the one with the default gateway set. Fix it by pre-selecting the first found interface. If we *do* have a def

Re: [pve-devel] [PATCH manager v6 3/4] ui: qemu hd edit: allow importing a disk from the import storage

2025-04-10 Thread Thomas Lamprecht
Am 07.04.25 um 12:13 schrieb Dominik Csapak: > adds a checkbox 'import image' above the storage selector which: > * hides the original storage selector > * shows a 'source storage' selector > * shows a 'import file' selector > * shows a 'target storage' selector > > Since the wizard and the hd edi

[pve-devel] [PATCH proxmox-i18n] update Japanese translations

2025-04-10 Thread ribbon via pve-devel
--- Begin Message --- --- ja.po.old 2025-04-08 17:49:19.253871143 +0900 +++ ja.po 2025-04-08 18:48:58.615114632 +0900 @@ -34,9 +34,8 @@ msgstr "(ブートデバイスが未選択)" #: pve-manager/www/manager6/dc/AuthEditOpenId.js:98 -#, fuzzy msgid "(none)" -msgstr "none" +msgstr "(none)" #: proxmox-back

Re: [pve-devel] [PATCH manager v5 3/4] fix #1926 ui: vm console: autodetect novnc or xtermjs

2025-04-10 Thread Dominik Csapak
tiny nits inline, with or without that, consider this Reviewed-by: Dominik Csapak On 4/7/25 18:27, Aaron Lauterer wrote: Some users configure their VMs to use serial as their display. The big benefit is that in combination with the xtermjs remote console, copy & paste works a lot better than

[pve-devel] applied: SPAM: [PATCH pve-network v3 3/4] fix: register details in pve ipam db for add_next_freeip

2025-04-10 Thread Thomas Lamprecht
On Fri, 13 Dec 2024 20:45:39 +0100, lou lecrivain via pve-devel wrote: > Applied, thanks! [1/1] SPAM: [PATCH pve-network v3 3/4] fix: register details in pve ipam db for add_next_freeip commit: 5a050f4d4c6bc315df27d9950af1796486c95712 ___ pve

Re: [pve-devel] [PATCH pve-http-server v2 1/1] fix unexpected EOF for client when closing TLS session

2025-04-10 Thread Fiona Ebner
Am 05.03.25 um 22:45 schrieb Rob Rozestraten via pve-devel: > When pve-http-server initiates the closure of a TLS session, it does not > send a TLS close notify, resulting in an unexpected EOF error on systems > with recent crypto policies. This can break functionality with other > applications, su

[pve-devel] [PATCH access-control] openid: fix groups-claim regex

2025-04-10 Thread Mira Limbeck
The previous regex matched exactly that combination of characters, rather than any combination of the specified ones. Fixes: e80f840 ("openid: make groups-claim RE more restrictive") Signed-off-by: Mira Limbeck --- src/PVE/Auth/OpenId.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [pve-devel] [PATCH pve-network v2 1/8] ipam: netbox: factor out common api methods and unify error handling

2025-04-10 Thread Thomas Lamprecht
Am 07.04.25 um 17:38 schrieb Thomas Lamprecht: > Am 07.04.25 um 17:32 schrieb Hannes Duerr: >> Tested this series against netbox version 4.2.2 and didn't run into any >> issues. >> Created and deleted a simple zone with two vnets and respective subnet. >> The prefixes were created and deleted corr

Re: [pve-devel] [PATCH pve-network v2 1/8] ipam: netbox: factor out common api methods and unify error handling

2025-04-10 Thread Hannes Duerr
Tested this series against netbox version 4.2.2 and didn't run into any issues. Created and deleted a simple zone with two vnets and respective subnet. The prefixes were created and deleted correctly Assigned and removed VMs to the vnets and the ip addresses were created and removed correctly.

[pve-devel] [PATCH qemu-server v5 2/4] api: status/current: add display property

2025-04-10 Thread Aaron Lauterer
This new property returns the configured or default display for a VM. Instead of a flat property, we use a nested 'type' object that contains the actual information. This way we can add other properties that belong to a VM's display in the future without much hassle, to have them all in one place.

[pve-devel] [PATCH qemu-server] d/control: bump (build-)dependency for libpve-guest-common-perl

2025-04-10 Thread Fiona Ebner
Version 5.2.0 of libpve-guest-common-perl is required for the PVE/Mapping/Dir.pm module, but there was a transitive dependency for libpve-cluster-perl missing for tracking the corresponding file on the cluster file system and build would still fail with: > unknown file 'mapping/directory.cfg' at /u

[pve-devel] [PATCH installer] common: options: use more sensible fallback values for network options

2025-04-10 Thread Christoph Heiss
When no DHCP server is configured on the network and/or no DHCP lease is received, the auto-installer falls back to Ipv4Addr::UNSPECIFIED - which resolves to `0.0.0.0/0` - for the interface address, gateway and DNS server. This is then written to /etc/network/interfaces and could cause further issu

Re: [pve-devel] [PATCH docs/qemu-server/manager v17 0/10] Virtio-fs

2025-04-10 Thread Thomas Lamprecht
On Mon, 07 Apr 2025 15:49:40 +0200, Markus Frank wrote: > Virtio-fs is a shared file system that enables sharing a directory > between host and guest VMs. It takes advantage of the locality of > virtual machines and the hypervisor to get a higher throughput than > the 9p remote file system protocol

[pve-devel] [PATCH manager v7 0/3] allow importing vm disk images on the UI

2025-04-10 Thread Dominik Csapak
this is a continuation of my previous series [0] It enables importing disks on the UI in the HardwareView of a vm, in the create wizard, and in the storage content view. I split the patches so that the wizard and storage content view one are separate, so they can be reviewed independently. chang

[pve-devel] [PATCH qemu-server, manager v7 0/4] fix #1926 autodetect xtermjs or novnc for VM console

2025-04-10 Thread Aaron Lauterer
Sorry for the noise, after the feedback from Fiona on v6 and some off-list discussion, we decided to improve the backend part by moving the "default" logic out of `get_vga_properties` and move it into a separate public `get_default_vga_type` function. This way we can leave all the other functions p

Re: [pve-devel] [PATCH qemu-server v6 2/4] api: status/current: add display property

2025-04-10 Thread Fiona Ebner
Am 08.04.25 um 12:37 schrieb Aaron Lauterer: > This new property returns the configured or default display for a VM. > > Instead of a flat property, we use a nested 'type' object that contains > the actual information. This way we can add other properties that belong > to a VM's display in the fut

[pve-devel] applied: [PATCH pve-docs] notifications: add section about how to use custom templates

2025-04-10 Thread Thomas Lamprecht
On Wed, 09 Apr 2025 09:47:13 +0200, Lukas Wagner wrote: > This section is meant to give a basic overview on how to use > custom templates for notifications. It will be expanded in the > future, providing a more detailed view on how templates are resolved, > existing fallback mechanisms, available t

[pve-devel] applied: [PATCH v2] fix #6223: fit terminal after 'OK' message

2025-04-10 Thread Thomas Lamprecht
On Mon, 07 Apr 2025 10:25:09 +0200, Dominik Csapak wrote: > instead of simply waiting 250ms after we send the credentials, wait > until after the server responded with 'OK' to fit the terminal size. > > Execute after the next frame, by using requestAnimationFrame twice. (One > for the current fram

[pve-devel] applied: SPAM: [PATCH pve-network v3 2/4] dhcp: always generate dhcp-range for dnsmasq

2025-04-10 Thread Thomas Lamprecht
On Fri, 13 Dec 2024 20:45:38 +0100, lou lecrivain via pve-devel wrote: > (configure_range is now noop) > > Applied, thanks! [1/1] SPAM: [PATCH pve-network v3 2/4] dhcp: always generate dhcp-range for dnsmasq commit: 8794d57125531e2d290c9af841234b52b44e6b98 _

[pve-devel] applied: [PATCH installer] gui: fall back to first found NIC if no default could be determined

2025-04-10 Thread Thomas Lamprecht
On Mon, 07 Apr 2025 15:55:07 +0200, Christoph Heiss wrote: > If no DHCP server is configured on the network and/or no DHCP lease and > thus network configuration is retrieved, the installer will also be > unable to determine the default interface, aka. the one with the default > gateway set. > > F

[pve-devel] applied: [PATCH pve-kernel] cherry-pick fixes for AMD Epyc genua systems

2025-04-10 Thread Thomas Lamprecht
On Thu, 10 Apr 2025 15:08:34 +0200, Stoiko Ivanov wrote: > both patches are queued for 6.14.2: > https://lore.kernel.org/all/20250409115934.968141...@linuxfoundation.org/ > issue was reported in our community forum: > https://forum.proxmox.com/threads/.164497/post-762617 > > as we have access to a

[pve-devel] [PATCH manager 10/12] accept .tar.lzo ct templates in the storage upload dialog

2025-04-10 Thread Filip Schauer
.tar.lzo container templates are already explicitly supported in PVE::LXC::Create::restore_tar_archive Signed-off-by: Filip Schauer --- www/manager6/window/UploadToStorage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager

Re: [pve-devel] [PATCH manager] ui: qemu: hardware view: fix hwrng cap check for unprivileged users

2025-04-10 Thread Friedrich Weber
On 08/04/2025 18:38, Friedrich Weber wrote: > Currently, as an unprivileged user with role PVEVMUser the GUI breaks > with an error after navigating to a VM's hardware tab. The reason is > that the frontend checks the GUI capabilites via `caps.mapping.hwrng`, > but `caps.mapping` does not actually

[pve-devel] [PATCH guest-common 1/2] d/control: bump dependency for libpve-cluster-perl

2025-04-10 Thread Fiona Ebner
For example, otherwise build of qemu-server will fail with: > unknown file 'mapping/directory.cfg' at /usr/share/perl5/PVE/Cluster.pm if libpve-cluster-perl is not recent enough and there most likely are runtime issues too. Signed-off-by: Fiona Ebner --- debian/control | 2 +- 1 file changed, 1

[pve-devel] [PATCH manager v5 3/4] fix #1926 ui: vm console: autodetect novnc or xtermjs

2025-04-10 Thread Aaron Lauterer
Some users configure their VMs to use serial as their display. The big benefit is that in combination with the xtermjs remote console, copy & paste works a lot better than via novnc. While the console button in the top right allows to manually choose the console type, the Console in the main subme

[pve-devel] applied: [PATCH qemu-server v5 1/4] vmstatus_return_properties: add missing serial property

2025-04-10 Thread Thomas Lamprecht
Am 07.04.25 um 18:27 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > first introduces with v5 > > PVE/QemuServer.pm | 5 + > 1 file changed, 5 insertions(+) > > applied this one, added a reference to what commit this fixes though, thanks! _

Re: [pve-devel] [PATCH manager v17 10/10] ui: add options to add virtio-fs to qemu config

2025-04-10 Thread Thomas Lamprecht
Am 07.04.25 um 15:49 schrieb Markus Frank: > + { > + xtype: 'displayfield', > + userCls: 'pmx-hint', > + value: gettext('Directory Mappings can be managed under > Datacenter -> Directory Mappings'), > + }, Hints can be OK, but in the end they ar

Re: [pve-devel] [PATCH manager] ui: qemu: hardware view: fix hwrng cap check for unprivileged users

2025-04-10 Thread Stefan Hanreich
Created a user with only PVEVMUser privileges and navigated to the hardware tab of a VM. Could reproduce the issue with the exact same error message in the JS console. Applied the patch and reloaded, navigating to the HW tab now worked, so consider this: Tested-by: Stefan Hanreich On 4/8/25 18:

[pve-devel] [PATCH qemu-server] fix: also add resource mappings that do not exist to missing mappings

2025-04-10 Thread Markus Frank
Currently you get a "Can't use an undefined value..." error because all get_node_mapping functions return undefined if there is no resource mapping entry for the id. Fixes: a52eb3c4e ("check local resources: extend for mapped resources") Signed-off-by: Markus Frank --- This patch supersedes "fix:

[pve-devel] [PATCH follow-up manager] ui: backup: move change detection help tooltip behind field

2025-04-10 Thread Dominik Csapak
instead of having it in a separate line. This could be confusing on first glance, e.g. if it belongs to the line above or below. To make it more clear, put it in line with the field itself. Because this uses a FieldContainer now, we can use that to hide and show both at the same time, reducing th

Re: [pve-devel] [PATCH manager v7 0/3] allow importing vm disk images on the UI

2025-04-10 Thread Dominik Csapak via pve-devel
--- Begin Message --- On 4/10/25 14:04, Lukas Wagner wrote: On 2025-04-08 14:13, Dominik Csapak wrote: this is a continuation of my previous series [0] It enables importing disks on the UI in the HardwareView of a vm, in the create wizard, and in the storage content view. I split the patche

[pve-devel] [PATCH pve-kernel] cherry-pick fixes for AMD Epyc genua systems

2025-04-10 Thread Stoiko Ivanov
both patches are queued for 6.14.2: https://lore.kernel.org/all/20250409115934.968141...@linuxfoundation.org/ issue was reported in our community forum: https://forum.proxmox.com/threads/.164497/post-762617 as we have access to a server where we could reproduce the issue (crash+loop, before the sy

[pve-devel] [PATCH qemu-server v2] fix: print error message that the resource mapping entry does not exist

2025-04-10 Thread Markus Frank
Currently you get a "Can't use an undefined value..." error because all get_node_mapping functions return undefined if there is no resource mapping entry for the id. Fixes: a52eb3c4e ("check local resources: extend for mapped resources") Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner ---

Re: [pve-devel] [pbs-devel] [PATCH v2] kernel: enable codepage 437 for vfat support

2025-04-10 Thread Thomas Lamprecht
On Tue, 26 Nov 2024 14:26:02 +0100, Stoiko Ivanov wrote: > ran into an issue when clicking on the ESP of a VM while trying > single-file restore. Enabling the single option fixed the issue, and > got the partition successfully mounted. > > Applied, thanks! [1/1] kernel: enable codepage 437 for

Re: [pve-devel] [PATCH qemu-server] fix: also add resource mappings that do not exist to missing mappings

2025-04-10 Thread Fiona Ebner
Am 10.04.25 um 14:14 schrieb Markus Frank: > On  2025-04-10 13:18, Fiona Ebner wrote: >> Am 10.04.25 um 12:59 schrieb Markus Frank: >>> Currently you get a "Can't use an undefined value..." error because all >>> get_node_mapping functions return undefined if there is no resource >>> mapping entry f

Re: [pve-devel] [PATCH qemu-server] fix: also add resource mappings that do not exist to missing mappings

2025-04-10 Thread Fiona Ebner
Am 10.04.25 um 12:59 schrieb Markus Frank: > Currently you get a "Can't use an undefined value..." error because all > get_node_mapping functions return undefined if there is no resource > mapping entry for the id. > > Fixes: a52eb3c4e ("check local resources: extend for mapped resources") > Signe

Re: [pve-devel] [PVE-User] Proxmox VE 8.4 released!

2025-04-10 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>How do we upgrade from 8 to 8.4 using apt or any command-line commands? apt dist-upgrade (or simply use the gui update button ;) --- End Message --- ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.co

Re: [pve-devel] [PATCH manager v7 3/3] ui: import storage content: allow importing of vm disk images

2025-04-10 Thread Gilberto Ferreira via pve-devel
--- Begin Message --- Oh! I almost forgot. About the vhd(x) image format, often we can use the disk2vhd Windows tool to generate a disk clone from a running Windows system. The import storage accepting the vhd(x) format will help in this case. I think the same about vdi formats. But, anyway, I will

Re: [pve-devel] [PATCH qemu-server] fix: also add resource mappings that do not exist to missing mappings

2025-04-10 Thread Markus Frank via pve-devel
--- Begin Message --- On 2025-04-10 13:18, Fiona Ebner wrote: Am 10.04.25 um 12:59 schrieb Markus Frank: Currently you get a "Can't use an undefined value..." error because all get_node_mapping functions return undefined if there is no resource mapping entry for the id. Fixes: a52eb3c4e ("ch

Re: [pve-devel] [PATCH manager v7 3/3] ui: import storage content: allow importing of vm disk images

2025-04-10 Thread Gilberto Ferreira via pve-devel
--- Begin Message --- Thank you, for the clarification. Regards --- Gilberto Nunes Ferreira +55 (47) 99676-7530 - Whatsapp / Telegram Em qui., 10 de abr. de 2025 às 09:05, Dominik Csapak via pve-devel < pve-devel@lists.proxmox.com> escreveu: > > > > -- Forwarded message --

Re: [pve-devel] [PATCH manager v7 3/3] ui: import storage content: allow importing of vm disk images

2025-04-10 Thread Dominik Csapak via pve-devel
--- Begin Message --- On 4/10/25 13:39, Gilberto Ferreira via pve-devel wrote: Hi folks. Hi I tried this feature in the new Proxmox VE 8.4, I just can upload vmdk, qcow2 and raw file. Tried vhd and vdi and no luck. And I can't use the uploaded file to import the image and create a new VM. Is

Re: [pve-devel] [PATCH manager v7 0/3] allow importing vm disk images on the UI

2025-04-10 Thread Lukas Wagner via pve-devel
--- Begin Message --- On 2025-04-08 14:13, Dominik Csapak wrote: > this is a continuation of my previous series [0] > > It enables importing disks on the UI in the HardwareView of a vm, > in the create wizard, and in the storage content view. > > I split the patches so that the wizard and stor

Re: [pve-devel] [RFC PATCH backup-restore-image] enable the codepage 437 for FAT filesystems

2025-04-10 Thread Thomas Lamprecht
Am 10.04.25 um 13:41 schrieb Dominik Csapak: > On 4/10/25 13:24, Fabian Grünbichler wrote: >> https://lore.proxmox.com/all/20241126132602.576027-1-s.iva...@proxmox.com/ ;) >> >> also see some discussions on v1 there: >> https://lore.proxmox.com/all/20241126120357.389046-1-s.iva...@proxmox.com/ >>

Re: [pve-devel] [RFC PATCH backup-restore-image] enable the codepage 437 for FAT filesystems

2025-04-10 Thread Fabian Grünbichler
> Dominik Csapak hat am 10.04.2025 13:41 CEST > geschrieben: > > > On 4/10/25 13:24, Fabian Grünbichler wrote: > > https://lore.proxmox.com/all/20241126132602.576027-1-s.iva...@proxmox.com/ > > ;) > > > > also see some discussions on v1 there: > > https://lore.proxmox.com/all/2024112612035

Re: [pve-devel] [RFC PATCH backup-restore-image] enable the codepage 437 for FAT filesystems

2025-04-10 Thread Dominik Csapak
On 4/10/25 13:24, Fabian Grünbichler wrote: https://lore.proxmox.com/all/20241126132602.576027-1-s.iva...@proxmox.com/ ;) also see some discussions on v1 there: https://lore.proxmox.com/all/20241126120357.389046-1-s.iva...@proxmox.com/ ah ok, seems i missed that ... IMHO the change still m

Re: [pve-devel] [PATCH manager v7 3/3] ui: import storage content: allow importing of vm disk images

2025-04-10 Thread Gilberto Ferreira via pve-devel
--- Begin Message --- Hi folks. I tried this feature in the new Proxmox VE 8.4, I just can upload vmdk, qcow2 and raw file. Tried vhd and vdi and no luck. And I can't use the uploaded file to import the image and create a new VM. Is that supposed to be this way, at least for now? Is there any furth

Re: [pve-devel] [PATCH qemu-server] fix: print error message that the resource mapping entry does not exist

2025-04-10 Thread Fiona Ebner
Am 09.04.25 um 16:48 schrieb Markus Frank: > Currently you get a "Can't use an undefined value..." error because all > get_node_mapping functions return undefined if there is no resource > mapping entry for the id. > > Fixes: a52eb3c4e ("check local resources: extend for mapped resources") > Signe

Re: [pve-devel] [RFC PATCH backup-restore-image] enable the codepage 437 for FAT filesystems

2025-04-10 Thread Fabian Grünbichler
https://lore.proxmox.com/all/20241126132602.576027-1-s.iva...@proxmox.com/ ;) also see some discussions on v1 there: https://lore.proxmox.com/all/20241126120357.389046-1-s.iva...@proxmox.com/ > Dominik Csapak hat am 10.04.2025 12:50 CEST > geschrieben: > > > This enables mounting fat32 form

[pve-devel] [RFC PATCH backup-restore-image] enable the codepage 437 for FAT filesystems

2025-04-10 Thread Dominik Csapak
This enables mounting fat32 formatted volumes, since codepage 437 is the default when mounting such volumes. (E.g. this also allows mounting EFI partitions) Signed-off-by: Dominik Csapak --- stumbled upon this while doing file restore tests Not sure if we just want to enable this one codepage or

[pve-devel] [PATCH proxmox-i18n] update Spanish translations

2025-04-10 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- Some minor adjustments I found. Nothing urgent. es.po | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/es.po b/es.po index 2506f23..5e8c75e 100644 --- a/es.po +++ b/es.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: pro

[pve-devel] [PATCH manager v2] ui: backup: hide change mode detection for vms and non-pbs storage

2025-04-10 Thread Dominik Csapak
Since it does not do anything for non-pbs storages and vms, this is only distracting in these cases, so hide the selector + tooltip help icon. Refactor the help icon into a variable, so we can more easily disable/hide it. Signed-off-by: Dominik Csapak --- replacement for: https://lore.proxmox.co

Re: [pve-devel] [PATCH manager] ui: util: simplify volume_is_qemu_backup again

2025-04-10 Thread Thomas Lamprecht
Am 10.04.25 um 10:29 schrieb Fiona Ebner: > Agreed and I get your point. It just felt more natural to go with the > object approach since all call sites have that very object and would > need to do the very same deconstruction if going with function(volume, > format, subtype). Independent of the ch

Re: [pve-devel] [PATCH manager] ui: util: simplify volume_is_qemu_backup again

2025-04-10 Thread Fiona Ebner
Am 10.04.25 um 10:12 schrieb Thomas Lamprecht: > Am 10.04.25 um 09:16 schrieb Fiona Ebner: >> Commit f8087e0f ("ui: fix regression with checking if volume is QEMU >> backup") opted for making the function support multiple types of >> callers making the function more complex than it needs to be. Sim

Re: [pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms

2025-04-10 Thread Thomas Lamprecht
Am 10.04.25 um 10:11 schrieb Dominik Csapak: > On 4/10/25 10:10, Fiona Ebner wrote: >> Am 10.04.25 um 10:08 schrieb Dominik Csapak: >>> the help tooltip says it's unavailable for vms, and choosing a mode >>> here does not make a difference, so disable it for vms >> >> Maybe we should even hide it c

Re: [pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms

2025-04-10 Thread Dominik Csapak
On 4/10/25 10:10, Fiona Ebner wrote: Am 10.04.25 um 10:08 schrieb Dominik Csapak: the help tooltip says it's unavailable for vms, and choosing a mode here does not make a difference, so disable it for vms Maybe we should even hide it completely? It's just distracting/additional mental load for

Re: [pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms

2025-04-10 Thread Fiona Ebner
Am 10.04.25 um 10:08 schrieb Dominik Csapak: > the help tooltip says it's unavailable for vms, and choosing a mode > here does not make a difference, so disable it for vms Maybe we should even hide it completely? It's just distracting/additional mental load for no reason if it can't ever be used f

[pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms

2025-04-10 Thread Dominik Csapak
the help tooltip says it's unavailable for vms, and choosing a mode here does not make a difference, so disable it for vms Signed-off-by: Dominik Csapak --- www/manager6/window/Backup.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Bac

Re: [pve-devel] [PATCH qemu-server] fix: print error message that the resource mapping entry does not exist

2025-04-10 Thread Fiona Ebner
Am 09.04.25 um 16:48 schrieb Markus Frank: > Currently you get a "Can't use an undefined value..." error because all > get_node_mapping functions return undefined if there is no resource > mapping entry for the id. > > Fixes: a52eb3c4e ("check local resources: extend for mapped resources") > Signe