Re: [pve-devel] [PATCH container/proxmox{, -perl-rs}/storage 0/9] support OCI images as container templates

2025-06-06 Thread Christoph Heiss
Tested this series a bit using the `docker.io/library/nginx:mainline-{alpine,bookworm}` images, pulled & exported using `podman`. Came across the same Problem as Michael, that for `podman save` the `--format=oci-archive` is required. According to podman-save(1), the default format is "docker-archi

Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support

2025-06-06 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >> >>ah, indeed. I think I'll use the ide.conf test to verify (this is the >>only test with cdrom medias attached, and it's using cifs-store, >>where >>io_uring is disabled). >> >>should be io_uring or threads if storage don't support io_uring. >> >>I'll fix it, and improve te

[pve-devel] [PATCH qemu-server] tests: add cache && aio tests for differents storage type

2025-06-06 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- test/cfg2cmd/ide.conf | 2 +- test/cfg2cmd/ide.conf.cmd | 2 +- test/cfg2cmd/simple-btrfs.conf | 3 ++ test/cfg2cmd/simple-btrfs.conf.cmd | 6 test/cfg2cmd/simple-cif

[pve-devel] [PATCH debcargo-config proxmox/trixie] oci-spec: initial packaging at 0.8.1-1

2025-06-06 Thread Christoph Heiss
Needed for Filips OCI image support series [0]. [0] https://lore.proxmox.com/pve-devel/20250520124257.165949-1-f.scha...@proxmox.com/ Signed-off-by: Christoph Heiss --- Applies to the `proxmox/trixie` branch. Packaging for bookworm would involve bumping/backporting quite a few dependencies of

Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support

2025-06-06 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel: > +sub generate_blockdev_drive_aio { > +    my ($drive, $scfg) = @_; > + > +    my $cache_direct = drive_uses_cache_direct($drive, $scfg); > +    $drive->{aio} = 'threads' if drive_is_cdrom($drive); >>We didn't fo

Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support

2025-06-06 Thread joao.sousa via pve-devel
--- Begin Message --- Hi, I'd like to help out with this feature. I've gone through the developer documentation and have a basic understanding of the topic, but to be honest, I'm feeling a bit lost on how to get started. Could you please point me in the right direction or suggest some initial step

Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support

2025-06-06 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > > No manual editing needed, just use "qm set" twice with the same > volume > ;) Sure, those are most likely quite exotic use cases. If we want to, > we > could go ahead an prohibit this for PVE 9. There always is the -args > escape hatch for people that really need it. Woul

Re: [pve-devel] [PATCH storage] zfs plugin: alloc/clone: cleanup image when creating LU mapping fails

2025-06-06 Thread Christoph Heiss
Tested this by setting up a iSCSI target using targetcli(d) on a separate PVE 8.4 system as a base (due to ZFS goodies) and then adding a ZFS-over-iSCSI storage using the LIO provider to a test cluster. Due to #5071 [0], this configuration is currently broken and allocation will fail. I then trie

[pve-devel] [PATCH cluster] fix #6445: correctly set size when stat-ing symlinks

2025-06-06 Thread Fabian Grünbichler
the size of a symlink should be the length of its target, some tools like bsdtar seem to actually rely on this information for allocating buffers.. Signed-off-by: Fabian Grünbichler --- Notes: should apply to master and stable-bookworm, and can IMHO go into both.. src/pmxcfs/cfs-plug-link.

Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support

2025-06-06 Thread Fiona Ebner
Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel: > +sub generate_blockdev_drive_aio { > +my ($drive, $scfg) = @_; > + > +my $cache_direct = drive_uses_cache_direct($drive, $scfg); > +$drive->{aio} = 'threads' if drive_is_cdrom($drive); We didn't force aio=threads for CD-R

[pve-devel] [PATCH pve-storage] tests: add lvmplugin test

2025-06-06 Thread Alexandre Derumier via pve-devel
--- Begin Message --- use same template than zfspoolplugin tests Signed-off-by: Alexandre Derumier --- src/test/Makefile | 5 +- src/test/run_test_lvmplugin.pl | 582 + 2 files changed, 586 insertions(+), 1 deletion(-) create mode 100755 src/test/r

Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support

2025-06-06 Thread Fabian Grünbichler
> Fiona Ebner hat am 06.06.2025 09:50 CEST geschrieben: > > > Am 05.06.25 um 16:39 schrieb DERUMIER, Alexandre: > > Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel: > >> +sub encode_nodename { > >> +    my ($type, $volid, $snap) = @_; > >> + > >> +    my $nodename = "$volid"; > >

[pve-devel] Plans for Realtime Kernel and Realtime Configuration Support in Proxmox?

2025-06-06 Thread Florent Carli via pve-devel
--- Begin Message --- Hello, After trying the user forum first, I'm turning to you here. I did a quick Google search to make sure the question hadn't already been answered (apparently not). Now I'm reaching out to the real experts :) I’m currently exploring Proxmox for some use cases that require

Re: [pve-devel] [PATCH proxmox{_login_manager, _dart_api_client} v3 0/2] fix #6409: login manager doesn't pre-selects default authentication realm

2025-06-06 Thread Michael Köppl
Gave this another spin in my Android emulator. User's realm selection is now respected if there is one, otherwise the site's selected default is used. Did not notice anything off. With my comments from v2 addressed and everything working as expected, consider this: Reviewed-by: Michael Köppl Test

Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support

2025-06-06 Thread Fiona Ebner
Am 05.06.25 um 16:39 schrieb DERUMIER, Alexandre: > Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel: >> +sub encode_nodename { >> +    my ($type, $volid, $snap) = @_; >> + >> +    my $nodename = "$volid"; >> +    $nodename .= "-$snap" if $snap; > > This will lead to clashes in some c