hi,
a few high level comments:
first:
is the iscsi.cfg really necessary? couldn't we just lookup on demand like we do
now?
*if* we want to cache that list, we should only do this on a per node level,
since
there is no guarantee that this is the same for all nodes.
(e.g. use /var/run//scs
current nettle-sys 2.1 does not support our current packaged bindgen
version (0.66), an update from debian unstable (and backport) fixes that
this packaged is used by sequoia-openpgp (which is used by
proxmox-offline-mirror)
Dominik Csapak (2):
update nettle-sys
backport nettle-sys
src
sync with Debian unstable
Signed-off-by: Dominik Csapak
---
src/nettle-sys/debian/changelog | 19 +
src/nettle-sys/debian/copyright | 4 ++--
src/nettle-sys/debian/copyright.debcargo.hint | 12 +--
.../0001-Avoid-msvc-dependencies.patch
Signed-off-by: Dominik Csapak
---
src/nettle-sys/debian/changelog | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/nettle-sys/debian/changelog b/src/nettle-sys/debian/changelog
index ca97618c9..d4a2de38a 100644
--- a/src/nettle-sys/debian/changelog
+++ b/src/nettle-sys/debian
On 9/26/23 00:34, Alexandre Aguirre via pve-devel wrote:
Hello goodnight !
My name is Alexandre, I'm Brazilian and I've been a proxmox user since
2015, I'm an active collaborator in BR communities as well as groups on
Telegram and WhatsApp, I'd like to know how I can collaborate with the
soluti
On 9/25/23 12:30, Fiona Ebner wrote:
Am 25.09.23 um 10:57 schrieb Dominik Csapak:
On 9/25/23 10:46, Fiona Ebner wrote:
Am 20.09.23 um 13:23 schrieb Dominik Csapak:
On 9/12/23 11:16, Fiona Ebner wrote:
@@ -7483,14 +7483,11 @@ sub restore_vma_archive {
$devinfo->{$devname} = { s
in vm selection: ${item}`);
+ }
}
return found;
}).filter(r => r);
LGTM
Reviewed-by: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On 7/7/23 10:02, Fiona Ebner wrote:
which is passed by the backup job window when using selection mode
'all', would be converted to [""] and wrongly add an entry with VMID
0 because the item "" could not be found in the store.
Reported in the community forum:
https://forum.proxmox.com/threads/13
On 9/25/23 10:46, Fiona Ebner wrote:
Am 20.09.23 um 13:23 schrieb Dominik Csapak:
comment inline:
Feel free to cut out irrelevant parts in the reply ;)
On 9/12/23 11:16, Fiona Ebner wrote:
@@ -7483,14 +7483,11 @@ sub restore_vma_archive {
$devinfo->{$devname} = { size =>
e.g.)
the last hunk in the second patch seems leftover, but it only removes an empty
line,
so it should do any harm.
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https
Rest of the series looks fine to me (and tested ok), but here i have some
comments/nits inline:
On 9/8/23 13:06, Markus Frank wrote:
Signed-off-by: Markus Frank
---
www/manager6/qemu/DisplayEdit.js | 8 +
www/manager6/qemu/Options.js | 52
2 files
sadly removing these parameters would be a breaking change
i'd rather mark it deprecatedand non-functional in the description
and remove the functionality
then on the next major release, we can announce the breaking change and
remove the parameter
On 9/7/23 11:49, Maximiliano Sandoval wrote:
T
On 9/20/23 13:50, Dominik Csapak wrote:
On 9/20/23 13:46, Fabian Grünbichler wrote:
On September 20, 2023 1:07 pm, Dominik Csapak wrote:
LGTM and works as advertised.
it breaks downloading container templates that are compressed with one
of the "known" compression algorithms (
On 9/20/23 13:46, Fabian Grünbichler wrote:
On September 20, 2023 1:07 pm, Dominik Csapak wrote:
LGTM and works as advertised.
it breaks downloading container templates that are compressed with one
of the "known" compression algorithms (such as gz).
probably the detect-compression
sry just saw that this was already applied (some version of it)
and the discussion had included about oldtimeout always being 0 here, but
my point still stands for the applied code in case $oldtimeout is not 0
___
pve-devel mailing list
pve-devel@list
comment inline:
On 9/12/23 11:16, Fiona Ebner wrote:
10 minutes is not long enough when disks are large and/or network
storages are used when preallocation is not disabled. The default is
metadata preallocation for qcow2, so there are still reports of the
issue [0][1]. If allocation really does
LGTM and works as advertised.
Needs pve-storage >= 8.0.3 (for compression parameter)
consider both patches:
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/
personally i would be cautious to include such deep links to vendor sites in our
documentation, because they can be outdated fast and it becomes a catch-up
game
No strong feelings though if the others are fine with it.
Besides that, consider this
Reviewed-by: Dominik Csapak
On 8/30/23 14:43, Philipp Hufnagl wrote:
On 8/14/23 12:42, Dominik Csapak wrote:
On 8/14/23 12:36, Wolfgang Bumiller wrote:
applied, thanks
@Dominik: does extjs have an 'enableFn' for rows in a grid?
IMO we should either disable the ones with pools when the transfer
checkbox is n
On 8/30/23 11:07, Thomas Lamprecht wrote:
meta: your repo tag is wrong, this is for widget-toolkit, not manager.
off topic, while checking that I saw that we still have a (FWICT unused)
copy of the old pveACMEPluginEditor module checked in in pve-manager, we
should probably clean that up (no nee
a few comments inline
On 8/14/23 16:42, Philipp Hufnagl wrote:
extends the download iso prompt with a "compression algorithm" drop down
under advanced. User can configure there if a decompression algorithm
should be used from the storage backend. The compression algorithm will
be automatically g
looks mostly good, one high level comment, and a few nits inline:
do we really need the 'detect-compression' parameter?
when wouldn't we want that? also the gui always enables that for isos anyway?
if there is a good reason, that would be nice to have in a commit message
if we can always use th
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
semantically the patch looks good to me, but please check our style guide:
https://pve.proxmox.com/wiki/Javascript_Style_Guide
i know that the surrounding code isn't correctly formatted that way, but
for new code please don't use single line if statements
On 8/16/23 10:25, Filip Schauer wrote:
#x27; section
and run into the `is_array` error)
(Reported in the forum: https://forum.proxmox.com/threads/132091)
Suggested-by: Fiona Ebner
Signed-off-by: Dominik Csapak
---
changes from v1:
* only convert to array on the second occurance of a key
(more future proof and does not need a change in
b backup jobs (since there we parse an 'unknown' section
and run into the `is_array` error)
Signed-off-by: Dominik Csapak
---
src/PVE/SectionConfig.pm| 20
test/section_config_test.pl | 2 +-
2 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/src/
On 8/14/23 12:36, Wolfgang Bumiller wrote:
applied, thanks
@Dominik: does extjs have an 'enableFn' for rows in a grid?
IMO we should either disable the ones with pools when the transfer
checkbox is not checked, or hide them (but when hiding them after
already checking them... it's weird)
Or disa
did not look through the api/backend part, but the gui part is now ok from my
side,
so consider the manger ui patches (15-22) and the wt patches (25-29)
Reviewed-by: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https
in the tag view, we have a custom 'full' style in a place where we
can have another tagstyle class above. to compensate for that, we have
to add another condition to those styles, namely that there is not the
'proxmox-tags-full' in between.
Signed-off-by: Dominik Csapak
---
this adds a 'tagview' to the web ui, organizing guests by their tags
(for details see the pve-manager patch)
pve-docs:
Dominik Csapak (1):
gui: add anchor for tags chapter
pve-gui.adoc | 1 +
1 file changed, 1 insertion(+)
proxmox-widget-toolkit:
Dominik Csapak (1):
css
the resource store)
Signed-off-by: Dominik Csapak
---
this depends on the docs (onlineHelp ref) and widget toolkit (css)
patches
there is probably some optimization potential in how we handle the
overrides, but i tried to keep it as generic as possible so that
we can extend it easily if
Signed-off-by: Dominik Csapak
---
pve-gui.adoc | 1 +
1 file changed, 1 insertion(+)
diff --git a/pve-gui.adoc b/pve-gui.adoc
index e0fc873..0dd6646 100644
--- a/pve-gui.adoc
+++ b/pve-gui.adoc
@@ -379,6 +379,7 @@ and the corresponding interfaces for each menu item on the
right
looks mostly fine, some comments inline
On 6/26/23 14:41, Noel Ullreich wrote:
A little update to the PCI(e) docs with the plan of reworking the PCI
wiki as well.
Along some minor grammar fixes added:
* how to check if kernelmodules are being loaded
* how to check which drivers to blacklis
On 7/20/23 09:46, Lukas Wagner wrote:
On 7/19/23 14:53, Dominik Csapak wrote:
On 7/17/23 17:00, Lukas Wagner wrote:
Signed-off-by: Lukas Wagner
---
Notes:
I'm not sure if I like this solution, but adding notification targets to
the resources API endpoint would not have make
more or less the same comments as for 61/66
autoShow,
single line if,
column use,
etc.
On 7/17/23 17:00, Lukas Wagner wrote:
Signed-off-by: Lukas Wagner
---
src/Makefile | 3 +-
src/data/model/NotificationConfig.js | 9 ++
src/panel/NotificationConfigView.js |
comments inline
On 7/17/23 17:00, Lukas Wagner wrote:
Signed-off-by: Lukas Wagner
---
src/Makefile| 1 +
src/Schema.js | 5 +
src/panel/NotificationGroupEditPanel.js | 177
src/window/EndpointEditBase.js
some comments/nits inline:
On 7/17/23 17:00, Lukas Wagner wrote:
Signed-off-by: Lukas Wagner
---
src/Makefile | 4 +
src/Schema.js| 8 ++
src/data/model/NotificationConfig.js | 8 ++
src/panel/NotificationConfigView.js | 192 ++
On 7/17/23 17:00, Lukas Wagner wrote:
Signed-off-by: Lukas Wagner
---
Notes:
I'm not sure if I like this solution, but adding notification targets to
the resources API endpoint would not have make sense.
Maybe we could create a new API endpoint that returns all possible ACL
some comments inline:
On 7/17/23 17:00, Lukas Wagner wrote:
Signed-off-by: Lukas Wagner
---
www/manager6/Makefile | 1 +
www/manager6/dc/Config.js | 12 ++
www/manager6/dc/NotificationEvents.js | 238 ++
3 files changed, 251 insertions
looks fine, one comment inline
On 7/17/23 17:00, Lukas Wagner wrote:
This commit adds a possibility to choose between different options
for notifications for backup jobs:
- Notify via email, in the same manner as before
- Notify via an endpoint/group
If 'notify via mail' is selected,
the combogrid sets the default itself correctly
Signed-off-by: Dominik Csapak
---
depends on the widget-toolkit patch
www/manager6/form/NodeSelector.js | 5 +
www/manager6/ha/GroupSelector.js | 1 -
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/www/manager6/form
if it does not
it's either invalid (and thus "dirty") or it has a selected value anyway
this should make the manual setting of
value: [],
unnecessary in the child classes. We can even remove it direcly in the
NetworkSelector.
Signed-off-by: Dominik Csapak
---
src/form/ComboGr
the combogrid does that itself already
Signed-off-by: Dominik Csapak
---
can be applied independently, but fixes dirty tracking when the
widget-toolkit patch is also present
www/manager6/grid/FirewallRules.js | 2 --
www/manager6/panel/IPSet.js| 1 -
2 files changed, 3 deletions
it is in the backend, so make it required in the gui too
Signed-off-by: Dominik Csapak
---
can be applied independently
www/manager6/panel/IPSet.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/panel/IPSet.js b/www/manager6/panel/IPSet.js
index c449cdaa..d42d062d 100644
mox-widget-toolkit:
Dominik Csapak (1):
combogrid: initialze value with [] by default
src/form/ComboGrid.js | 2 +-
src/form/NetworkSelector.js | 4
2 files changed, 1 insertion(+), 5 deletions(-)
pve-manager:
Dominik Csapak (3):
ui: ipset: make ip/cidr required
ui: don't
On 7/18/23 15:14, Lukas Wagner wrote:
On 7/18/23 14:34, Dominik Csapak wrote:
gave the series a quick spin, review of the gui patches comes later ;)
a few high level comments from a user perspective:
* the node fencing/replication edit windows always shows the warning that it
shouldn'
gave the series a quick spin, review of the gui patches comes later ;)
a few high level comments from a user perspective:
* the node fencing/replication edit windows always shows the warning that it
shouldn't be
disabled, that should imo only be there if i select 'never' ?
(conversely, the
by converting the textfield into a textarea and validate the value
line wise (if there is more than one line)
also create a 'MultiFileButton' (mostly copied from extjs) that allows
to select multiple files at once
Signed-off-by: Dominik Csapak
---
changes from v2:
* added comments t
On 7/13/23 12:09, Christoph Heiss wrote:
On Mon, Jul 03, 2023 at 04:51:16PM +0200, Dominik Csapak wrote:
by converting the textfield into a textarea and validate the value
line wise (if there is more than one line)
also create a 'MultiFileButton' (mostly copied from extjs) that
like we do for qemu guest, by multiplying cpu usage by 100
Signed-off-by: Dominik Csapak
---
lib/bloc/pve_lxc_overview_bloc.dart | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/lib/bloc/pve_lxc_overview_bloc.dart
b/lib/bloc/pve_lxc_overview_bloc.dart
index
abort the login when the form returns null. This happens if the user
presses 'X' in the tfa form.
Signed-off-by: Dominik Csapak
---
lib/proxmox_login_form.dart | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/lib/proxmox_login_form.
if the user was logged in in the past, but that ticket expired, we still
gave the expired ticket to the login form which tried to login with
that, producing a login error the first time the user pressed login.
we already get the correct ticket in a variable, so use that.
Signed-off-by: Dominik
by converting the textfield into a textarea and validate the value
line wise (if there is more than one line)
also create a 'MultiFileButton' (mostly copied from extjs) that allows
to select multiple files at once
Signed-off-by: Dominik Csapak
---
changes from v2:
* reduces lin
by converting the textfield into a textarea and validate the value
line wise (if there is more than one line)
Signed-off-by: Dominik Csapak
---
www/manager6/lxc/CreateWizard.js | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/www/manager6/lxc
NU/LINUX and some newer BSD systems'
With this fix, one can safely install 'libanyevent-aio-perl' and
'libperl-languageserver-perl' (the only user of it AFAICS) on a PVE or
PMG system.
Signed-off-by: Dominik Csapak
---
maybe we should leave the use statement in and only c
but fallback to 'eslint' otherwise
Suggested-by: Thomas Lamprecht
Signed-off-by: Dominik Csapak
---
defines.mk| 2 ++
www/manager6/Makefile | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/defines.mk b/defines.mk
index 3a5792ad..811f3483 10
but fallback to 'eslint' otherwise
Suggested-by: Thomas Lamprecht
Signed-off-by: Dominik Csapak
---
src/Makefile | 6 +++---
src/defines.mk | 1 +
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/Makefile b/src/Makefile
index 7cff5dd..2fca191 100644
--- a/src/Make
so that we don't conflict with 'eslint' package in debian, which ships
the same binary
Signed-off-by: Dominik Csapak
---
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/links b/debian/links
index 99342ed..0a1546f 100644
--- a/debian/lin
but fallback to 'eslint' otherwise
Suggested-by: Thomas Lamprecht
Signed-off-by: Dominik Csapak
---
defines.mk | 1 +
www/Makefile | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/defines.mk b/defines.mk
index cd5b52a2..c113d4e1 100644
--- a/define
s.mk in pmg-gui for ESLINT variable
pve-eslint:
Dominik Csapak (1):
change binary name from 'eslint' to 'pve-eslint'
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
pve-manager:
Dominik Csapak (1):
try using 'pve-eslint' if it exists
defi
but fallback to 'eslint' otherwise
introduce the defines.mk for this
Suggested-by: Thomas Lamprecht
Signed-off-by: Dominik Csapak
---
defines.mk | 1 +
js/Makefile| 6 --
js/mobile/Makefile | 3 ++-
3 files changed, 7 insertions(+), 3 deletions(-)
create m
sorry i forgot to add,
basically all patches (feel free to fixup on commit):
Suggested-by: Thomas Lamprecht
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
but fallback to 'eslint' otherwise
introduce the defines.mk for this
Signed-off-by: Dominik Csapak
---
defines.mk | 5 +
js/Makefile| 6 --
js/mobile/Makefile | 3 ++-
3 files changed, 11 insertions(+), 3 deletions(-)
create mode 100644 defines.mk
di
but fallback to 'eslint' otherwise
Signed-off-by: Dominik Csapak
---
src/Makefile | 6 +++---
src/defines.mk | 6 ++
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/Makefile b/src/Makefile
index 7cff5dd..2fca191 100644
--- a/src/Makefile
+++ b/src/Makefile
se $(wildcard) make builtin to check if pve-eslint exists, use eslint as
fallback
* introduce defines.mk in pmg-gui for ESLINT variable
pve-eslint:
Dominik Csapak (1):
change binary name from 'eslint' to 'pve-eslint'
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 d
but fallback to 'eslint' otherwise
Signed-off-by: Dominik Csapak
---
defines.mk| 7 +++
www/manager6/Makefile | 4 ++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/defines.mk b/defines.mk
index 3a5792ad..b75671f4 100644
--- a/defines.mk
+++ b/
but fallback to 'eslint' otherwise
Signed-off-by: Dominik Csapak
---
defines.mk | 6 ++
www/Makefile | 4 ++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/defines.mk b/defines.mk
index cd5b52a2..68e7741c 100644
--- a/defines.mk
+++ b/defines.mk
@@ -11,5 +11,1
so that we don't conflict with 'eslint' package in debian, which ships
the same binary
Signed-off-by: Dominik Csapak
---
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/links b/debian/links
index 99342ed..0a1546f 100644
--- a/debian/lin
t anyway, and the source does not
change, we probably could move that out of that function altogether)
Signed-off-by: Dominik Csapak
---
www/manager6/window/Migrate.js | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/www/manager6/window/Migrate.js b/www/manager6/window
since we changed the binary name
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 2d884f4a..d19167c2 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
o 8.x/3.x it does not run into issues?
pve-eslint:
Dominik Csapak (1):
change binary name from 'eslint' to 'pve-eslint'
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
pve-manager:
Dominik Csapak (1):
use 'pve-eslint' instead of 'eslin
since we changed the binary name
Signed-off-by: Dominik Csapak
---
js/Makefile| 4 ++--
js/mobile/Makefile | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/js/Makefile b/js/Makefile
index fad2bd6..d0f02ff 100644
--- a/js/Makefile
+++ b/js/Makefile
@@ -106,7 +106,7
so that we don't conflict with 'eslint' package in debian, which ships
the same binary
Signed-off-by: Dominik Csapak
---
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/links b/debian/links
index 99342ed..0a1546f 100644
--- a/debian/lin
since we changed the binary name
Signed-off-by: Dominik Csapak
---
www/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/Makefile b/www/Makefile
index 476c80b6..bc1fd6f2 100644
--- a/www/Makefile
+++ b/www/Makefile
@@ -133,11 +133,11 @@ js/proxmox-backup
since we changed the binary name
Signed-off-by: Dominik Csapak
---
src/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/Makefile b/src/Makefile
index 7cff5dd..d312308 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -110,14 +110,14 @@ all: $(SUBDIRS
except the password dialog, since the user must provide input
to do that, we have to set the focus index on all relevant views
Signed-off-by: Dominik Csapak
---
not sure if this is the correct approach, also the extra parameter feels
slightly wrong, but didn't found a nicer way to do this
regex copied from perl gui installer
Signed-off-by: Dominik Csapak
---
this needs librust-regex-dev as build-dependency
proxmox-tui-installer/Cargo.toml | 1 +
proxmox-tui-installer/src/main.rs | 8
2 files changed, 9 insertions(+)
diff --git a/proxmox-tui-installer/Cargo.toml b
like the gui installer
Signed-off-by: Dominik Csapak
---
proxmox-tui-installer/src/main.rs| 2 +-
proxmox-tui-installer/src/options.rs | 14 +++---
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/proxmox-tui-installer/src/main.rs
b/proxmox-tui-installer/src/main.rs
i have added it to the pci api call, but forgot to add it for usb
otherwise adding a mapped usb device only works on the node where the
gui is connected to
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster/Mapping/USB.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/PVE/API2/Cluster
by disallowing nodes to be selected where a mapping already exists
Signed-off-by: Dominik Csapak
---
changes from v1:
* dont' disable autoselect, the first allowed node will be selected
* for usb mappings too
www/manager6/window/PCIMapEdit.js | 9 -
www/manager6/window/USBMapEdit.j
by changing into 'mapping matches host data' which indicates that the
configured values matches the host information
also for the pci and usb map selectors
Signed-off-by: Dominik Csapak
---
www/manager6/form/PCIMapSelector.js | 2 +-
www/manager6/form/USBMapSelector.js | 2 +-
ww
, but only
mappings are editable
we have to split the nodeselector into two fields, since the disabling
cbind does not pass through to the editconfig (and thus makes the form
invalid if we try that)
Signed-off-by: Dominik Csapak
---
changes from rfc:
* for usb mappings too, so they are consiste
they got lost in my last rebase/refactor.
the onLoadCallBack is used to check by the window if there are iommu
groups at all, and the checkIsolated function checks if the selected
ones are in a separate group (in regards to the other devices)
Signed-off-by: Dominik Csapak
---
factored out the
so they can be translated
Signed-off-by: Dominik Csapak
---
new in v2
www/manager6/window/PCIMapEdit.js | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/www/manager6/window/PCIMapEdit.js
b/www/manager6/window/PCIMapEdit.js
index f243362b..2b268719 100644
--- a/www
thanks for the review!
i agree with all of the points of the answers in your other mails
some comments here:
On 6/20/23 15:25, Fiona Ebner wrote:
Am 19.06.23 um 16:13 schrieb Dominik Csapak:
by removing the confusing buttons in the toolbar and adding them as
actions in an actioncolumn. There
On 6/20/23 12:18, Aaron Lauterer wrote:
On 6/20/23 11:57, Dominik Csapak wrote:
On 6/20/23 11:35, Aaron Lauterer wrote:
I like the approach as it cleans up the overloaded tbar that has items that are only valid in
certain contexts.
Two small nits from a UX POV:
- double clicking any PCI
robably it is a bit harder to gather the info from the other nodes?
we already query the pci list of each node, so we could extract that from there
but this only works if the user has Sys.Audit which may not be the case.
then the column would be empty
On 6/19/23 16:13, Dominik Csapak wrote:
b
pings, but only
mappings are editable
we have to split the nodeselector into two fields, since the disabling
cbind does not pass through to the editconfig (and thus makes the form
invalid if we try that)
Signed-off-by: Dominik Csapak
---
this is not intended to be applied as is, rather i&#
they got lost in my last rebase/refactor.
the onLoadCallBack is used to check by the window if there are iommu
groups at all, and the checkIsolated function checks if the selected
ones are in a separate group (in regards to the other devices)
Signed-off-by: Dominik Csapak
---
www/manager6/form
by changing into 'mapping matches host data' which indicates that the
configured values matches the host information
also for the pci and usb map selectors
Signed-off-by: Dominik Csapak
---
www/manager6/form/PCIMapSelector.js | 2 +-
www/manager6/form/USBMapSelector.js | 2 +-
ww
by disallowing nodes to be selected where a mapping already exists
and not preselecting a node
Signed-off-by: Dominik Csapak
---
www/manager6/window/PCIMapEdit.js | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/PCIMapEdit.js
b/www/manager6
and mdev change.
giving an empty array did not have the desired effect of resetting the
selection, but giving no parameter at all does.
this now also clears the selection when the mdev filter/config changed
(was just forgotten)
Signed-off-by: Dominik Csapak
---
www/manager6/form
when there is more than one function for a device, indent the individual
functions. This sets them visually apart from the 'pass all through as
one' entry
We have to use a html entity here, as extjs trims the normal whitespace.
Signed-off-by: Dominik Csapak
---
www/man
by
* moving the node to the left column and changing the label
* moving the mdev filter to the right column
* show only the create button for new node mappings (otherwise we'd have
a reset button here that cannot do anything useful)
Signed-off-by: Dominik Csapak
---
www/manager6/w
the 'errors' property changed to 'checks' so we have to adapt here too
Signed-off-by: Dominik Csapak
---
www/manager6/form/PCIMapSelector.js | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/www/manager6/form/PCIMapSelector.js
aka a 'splitter'. that way the user can determine how much of each panel
he wants to see himself
Signed-off-by: Dominik Csapak
---
www/manager6/dc/Config.js | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc
reworks the panel to use a controller, so that we can easily
add the selector for mapped pci devices
shows now a selection between 'raw' and 'mapped' devices, where
'raw' ones work like before, and 'mapped' ones take the values
form the hardware m
this will be the base class for trees for the individual mapping types,
e.g. pci and usb mapping.
there are a few things to configure, but the overall code sharing is
still significant, and should work out fine for future mapping types
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile
very similar to the PCIMapEdit window, but we only ever allow one
mapping per host
Signed-off-by: Dominik Csapak
---
depends on the pve-docs patch otherwise the onlineHelp ref is not there
www/manager6/Makefile | 3 +-
www/manager6/window/USBMapEdit.js | 217
Signed-off-by: Dominik Csapak
---
depends on the pve-docs patch otherwise the onlineHelp ref is not there
changes from v6:
* removed accidentally commited hunk
* show warning again for multiple devices
www/manager6/Makefile | 1 +
www/manager6/window/PCIMapEdit.js | 215
501 - 600 of 1457 matches
Mail list logo
