we want to move the 'exclude-path' to an array format (from 'string-alist')
prepare the code that it can be either a string or a list
Signed-off-by: Dominik Csapak
---
PVE/VZDump.pm | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/PVE/VZDump.pm b/PVE
since there is no other way to get an array parameter when using
x-www-form-urlencoded content type
the previous format with \0 separated strings (known as '-alist' format)
should not be used anymore (in favor of the now supported arrays)
Signed-off-by: Dominik Csapak
---
this technically
thanks for your feedback @fabian, @wolfgang!
so the consensus seems to be to simply expose the array in the api schema and
always have the client send the whole array over, like in pbs updater
(not a problem for my series, since in the gui we have the whole info anyway,
also if one want a custom
entries then
also adds a test case for such array fields
Signed-off-by: Dominik Csapak
---
another idea i had with the schemas was to extract the seperate options
of the property string into the api, but that was weird for the
following reasons:
* it's asymmetric if we don't automatically use
to summarize what thomas and i discussed off-list:
1. i'll try to integrate arrays into the section config in pve(pbs has
rudimentary support,
but no "automatic" api integration)
including a sensible api create/update/delete schema:
- plan is to have the inner properties exposed but
On 5/4/23 10:42, Thomas Lamprecht wrote:
Am 04/05/2023 um 10:31 schrieb Dominik Csapak:
On 5/4/23 10:13, Thomas Lamprecht wrote:
Am 03/05/2023 um 13:26 schrieb Dominik Csapak:
just a short comment since this series overlaps a bit with my
cluster resource mapping series (i plan on sending a v4
On 5/4/23 10:13, Thomas Lamprecht wrote:
Am 03/05/2023 um 13:26 schrieb Dominik Csapak:
just a short comment since this series overlaps a bit with my
cluster resource mapping series (i plan on sending a v4 soon).
i'd prefer to have the configuration endpoints for mapping bundled
just a short comment since this series overlaps a bit with my
cluster resource mapping series (i plan on sending a v4 soon).
i'd prefer to have the configuration endpoints for mapping bundled in a
subdirectory
so instead of /nodes//dirs/ i'd put it in /nodes//mapping/dirs/
(or /nodes//map/dirs
any comment to the rest of the series (access-control 2/2 and manager)?
it still applies
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
hi,
a few comments inline, hopefully we're soon at the finish line ;)
On 4/21/23 12:00, Markus Frank wrote:
added option to use the qemu vdagent implementation to enable the noVNC
clipboard. When enabled with SPICE the spice-vdagent gets replaced with the qemu
implementation.
This patch does
makes it easier to add columns, and uses less indentation
Signed-off-by: Dominik Csapak
---
new in v2
www/manager6/storage/BackupView.js | 40 +++---
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/www/manager6/storage/BackupView.js
b/www/manager6
instead, add the vmid as extra column, so that the user can still sort
by vmid if they wish to
Signed-off-by: Dominik Csapak
---
changes from v1:
* fallback to vmid 0 if there was none from the api, that way entries
without a vmid will be sorted before the rest, otherwise they would
On 4/19/23 17:43, Aaron Lauterer wrote:
If a user is accessing the Ceph install wizard via Datacenter -> Ceph
and gets to the configuration part, the variable 'nodename' will be
'localhost'. This means, that the first MON and MGR would be using
'localhost' as their ID.
Therefore fall back to
instead, add the vmid as extra column, so that the user can still sort
by vmid if they wish to
Signed-off-by: Dominik Csapak
---
www/manager6/storage/BackupView.js | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/www/manager6/storage/BackupView.js
b/www/manager6
this enables the user to sort the grid by multiple columns
simultaneously, e.g. by vmid and then by date
Signed-off-by: Dominik Csapak
---
sending as rfc because i'm not so sure about this.
on one hand, this allows to recreate the original sorting if users want
that, but the selection is a bit
so that e.g. a custom sort/column order is saved
Signed-off-by: Dominik Csapak
---
www/manager6/storage/BackupView.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/www/manager6/storage/BackupView.js
b/www/manager6/storage/BackupView.js
index 9ad1a4915..bb045f5b6 100644
--- a/www
comments inline:
On 3/14/23 12:09, Markus Frank wrote:
added option to use the qemu vdagent implementation to enable the noVNC
clipboard. When enabled with SPICE the spice-vdagent gets replaced with the qemu
implementation.
This patch does not solve #1406, but does allow copy and paste with
a
used when trying to open it.
Without this patch, we leak the picker that was created with this
call every time a combogrid is created.
Signed-off-by: Dominik Csapak
---
src/form/ComboGrid.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/form/ComboGrid.js b/src/form
.
Since the first thing we do here is to deselect all, this wiped
the vm selection sometimes.
To fix it, check if we're actually in the correct mode before doing
anything.
Signed-off-by: Dominik Csapak
---
www/manager6/dc/Backup.js | 6 ++
1 file changed, 6 insertions(+)
diff --git a/www
dling in AnyEvent event
loop")
Signed-off-by: Dominik Csapak
---
src/PVE/RESTEnvironment.pm | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm
index c258b1e..89def38 100644
--- a/src/PVE/RESTEnvironment.pm
+++
works, LGTM
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
number sign at the beginning (was missing completely)
space only needs escaping at the start and end
Signed-off-by: Dominik Csapak
---
pveum.adoc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/pveum.adoc b/pveum.adoc
index 147f317..6a0ad17 100644
--- a/pveum.adoc
+++ b
uot;)
0: https://www.ietf.org/rfc/rfc2253.txt
Signed-off-by: Dominik Csapak
---
src/PVE/Auth/LDAP.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Auth/LDAP.pm b/src/PVE/Auth/LDAP.pm
index 4d771e7..57782ad 100755
--- a/src/PVE/Auth/LDAP.pm
+++ b/src/PVE/Auth/L
to better cover existing configurations and the spec
pve-access-control:
Dominik Csapak (1):
fix #4609: allow valid DN in ldap/ad realm config
src/PVE/Auth/LDAP.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
pve-docs:
Dominik Csapak (1):
user management: ldap: specify space
otherwise the container stays masked and we cannot interact with it
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index b25445374..94e75d5c4 100644
--- a/www/manager6/Utils.js
+++ b
by removing the references and change the one place where we used
one of the references.
Signed-off-by: Dominik Csapak
---
while i tested all places where we have a disk selector
(wizard, clone, efidisk, add hd) i am not super sure i found all uses
i grepped after the references, and only found
Signed-off-by: Dominik Csapak
---
www/manager6/storage/LvmThinEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/storage/LvmThinEdit.js
b/www/manager6/storage/LvmThinEdit.js
index c3b55d87d..63f1fd78f 100644
--- a/www/manager6/storage/LvmThinEdit.js
+++ b
create an empty one when we need it
Signed-off-by: Dominik Csapak
---
www/manager6/storage/LvmThinEdit.js | 2 --
1 file changed, 2 deletions(-)
diff --git a/www/manager6/storage/LvmThinEdit.js
b/www/manager6/storage/LvmThinEdit.js
index bed5facb3..c3b55d87d 100644
--- a/www/manager6/storage
Signed-off-by: Dominik Csapak
---
pveum.adoc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pveum.adoc b/pveum.adoc
index fa6579b..fa32b11 100644
--- a/pveum.adoc
+++ b/pveum.adoc
@@ -394,8 +394,8 @@ The main options for syncing are:
Reserved characters
since my reservations about being too strict were unfounded
(since these configs wouldn't have worked in the first place)
i'll send a follow up for adding a link to the rfc shortly
consider this:
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
series LGTM
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
aside from the one nit (which can be fixed up)
Reviewed-By: Dominik Csapak
Tested-By: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
one super small nit inline, rest LGTM
On 3/20/23 11:50, Aaron Lauterer wrote:
Consolidating the different config paths lets us add more as needed
without polluting our API with too many 'configxxx' endpoints.
The config and configdb paths are renamed under the ceph/cfg path:
* config -> raw
if the user has the tree sorted by name, we have to move the items
on a name change, otherwise they'll stay on the old position
Signed-off-by: Dominik Csapak
---
www/manager6/tree/ResourceTree.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/manager6/tree
we use a different api call where we currently don't have the tags or
lock, so don't add the columns there
Signed-off-by: Dominik Csapak
---
we could also add these in the api call, or use the resource grid as
source for the grid (not needing an api call at all), but for now
this seems
On 3/15/23 12:17, Christoph Heiss wrote:
Thanks for the review!
On Wed, Mar 15, 2023 at 10:54:38AM +0100, Dominik Csapak wrote:
hi,
so high level comment:
i'd write most of what you wrote in the cover letter here in the commit message,
makes it much more convenient to find it only via git
sorry forgot one high level thing
while having it split up is nice in the gui, the user has no real
way of knowing what it actually represents.
i'd suggest adding a tooltip to the bar and/or modifying
the text in a way such that it's clear that this is the arc usage
On 1/25/23 12:29, Matthias
in general i'm not really happy with the manual insertion of a div here,
wouldn't it also be possible to extend the progressbar
and change the rendertemplate?
that way we could have a way nicer interface than
"get the dom element if it exists, and manually set the css classes"
further comments
hi not sure we would want to do it this way, since
this will only work for the node where the new pve-cluster
is installed, the other nodes will not be able to update their
local database with the info from the new nodes
AFAIR, the way we dealt with rrd updates in the past is
that we introduced
hi,
so high level comment:
i'd write most of what you wrote in the cover letter here in the commit message,
makes it much more convenient to find it only via git ;)
also i'm missing a bit the rationale for how the regex was chosen, besides
that it works in some conditions
further comment
a few comments inline
On 3/14/23 13:48, Noel Ullreich wrote:
A little update to the PCI(e) docs with the plan of reworking the PCI
wiki as well.
Some questions and reasoning to the patch:
* I would only mention the ACS patch in the PCI examples wiki, since it is a
last-ditch effort to get
()' instead of directly accessing the store to be
consistent with the extjs api use
Signed-off-by: Dominik Csapak
---
www/manager6/form/VMSelector.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
index
that by temporarily setting 'allowBlank' to true
until the store is loaded, and then it revalidates the field.
Signed-off-by: Dominik Csapak
---
note: this patch requires the previous widget-toolkit one to work
www/manager6/ceph/Pool.js | 14 +++---
1 file changed, 11 insertions(+), 3 deletions
was valid before.
Signed-off-by: Dominik Csapak
---
we need this for the next patch for manager to work correctly,
but i guess this can happen on other panels too, just harder to trigger
src/window/Edit.js | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff
it was missing there. Without this, it will not show up during
cli autocompletion and in the html debug view (/api2/html/).
Signed-off-by: Dominik Csapak
---
PVE/API2/Nodes.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 47c2d7414..f1b3bca41
some (minor) comments inline
On 1/13/23 16:09, Aaron Lauterer wrote:
instead of relying purely on listeners that then manually change other
components, we can use binds, formulas and a basic controller.
This makes it quite a bit easier to let multiple components react to
changes.
A cbind is
some comments inline:
On 1/13/23 16:09, Aaron Lauterer wrote:
Instead of hard coded defaults for the size and min_size parameter,
check if we have defaults configured in the ceph.conf or config db and
use those.
There are clusters where different defaults are needed. For example if
the cluster
high level:
as you mentioned the path 'configkey' is not really optimal
i recently mentioned off-list that we could clean this up on
the next breaking major release with a breaking api change:
have a 'config' dir and a
'file'
'db'
and 'key'( or 'value') api endpoint inside
that represents the
nice, works really good now with the different interactions
(button/container/changing store/etc)
some comments inline (mostly minor stuff though)
On 3/3/23 16:59, Aaron Lauterer wrote:
This is another step to make it easier for admins to discover more
information for a warning or problem that
On 3/7/23 19:49, Thomas Lamprecht wrote:
Am 06/03/2023 um 15:03 schrieb Friedrich Weber:
Some UI components use `Ext.data.Store.setProxy` to change their
associated API endpoint URL in reaction to user input. One example is
`BackupView`, which calls `setProxy` when the user switches from
any comment here? IMO the series is in good shape, maybe
it could take a bit more testing (from someone besides me)
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
simplifies some things, e.g. en/disabling the grid and pool selector
while refactoring, cleanup up some smaller things like nested if/else
paths, unnecessary splitting of the deprecated 'dow' parameter, etc.
Signed-off-by: Dominik Csapak
---
www/manager6/dc/Backup.js | 690
by replacing the manual vm grid implementation and reusing the
VMSelector we already have. Since this is a full-fledged form field, we
can drop the complicated selection tracking / reselecting that we did
by saving into a hidden field.
Signed-off-by: Dominik Csapak
---
www/manager6/dc/Backup.js
two bugfixes (the VMSelector changes are necessary for those)
and a refactor of the edit window (i put that patch at the end, because even
with simplifications, it's still ~30 lines more, and i was not sure if that's
worth it)
Dominik Csapak (7):
ui: VMSelector: columns customizable
ui
when we do {set,get}Value during a store load, the store might be empty
or incomplete, so defer the selection after the load and cache the value
for getValue invocations until the store is loaded
Signed-off-by: Dominik Csapak
---
www/manager6/form/VMSelector.js | 30
since we manually handle the invalid class, we have to manually trigger
that on setDisabled
Signed-off-by: Dominik Csapak
---
www/manager6/form/VMSelector.js | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form
we will reuse this component but don't want to show all columns
Signed-off-by: Dominik Csapak
---
www/manager6/form/VMSelector.js | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
index 78cd90134
by adding records manually when using 'setValue' on a vmselector.
It'll show up normally but have an 'unknown' nodename, and no type/status/etc.
Signed-off-by: Dominik Csapak
---
www/manager6/form/VMSelector.js | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git
so that we can modify the filters without having to consider filtering
for the type. Note that 'vm' for the 'type' parameter also returns
containers.
Signed-off-by: Dominik Csapak
---
www/manager6/form/VMSelector.js | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/www
one additional comment inline:
On 3/3/23 12:16, Matthieu Malvache wrote:
This commit adds support for a custom timeout value in the 'vncproxy'
method of the Proxmox PVE REST API. The timeout can be specified using
the 'timeout' parameter and defaults to 10 seconds if not set.
Signed-off-by:
one nit inline:
On 2/22/23 10:36, Aaron Lauterer wrote:
The button for more details is barely noticable as something one can
click on. By making it more obvious that it is a button, users will
hopefully notice it easier.
Signed-off-by: Aaron Lauterer
---
While moving code around I also
one bug did occur when trying it out:
if i had my mouse over a warning, and then the warnings vanished all,
the tooltip was still there and i could trigger it with hovering over
the grid
so we want to clean the tooltips up on every load anyway,
or at least when the number of items is smaller
comments inline:
On 10/28/22 14:33, Markus Frank wrote:
Signed-off-by: Markus Frank
---
qm.adoc | 11 +++
1 file changed, 11 insertions(+)
diff --git a/qm.adoc b/qm.adoc
index 4d0c7c4..3a575bc 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -693,6 +693,17 @@ Selecting `serialX` as display
first:
sorry for the late review ;)
high level comments:
i know why you're adding it to the vga format, but maybe that's not the way
to go? we couple the console method with the display quite a lot, but
maybe we don't want to further increase that coupling?
(imho it would be much nicer to be
high level comments:
i'd only show the hint when the checkbox is checked
or 'novnc' is selected in the combobox
also here it shows that the options does not really fit to the display at all,
at least i would not search the setting for the console clipboard under the
virtual display hardware...
comment inline
On 10/28/22 14:33, Markus Frank wrote:
By that noVNC is able to check if clipboard is active.
Signed-off-by: Markus Frank
---
PVE/API2/Qemu.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 99b426e..25f3a1d 100644
---
instead of using the mdev uuid. The nvidia driver does not actually care
that it's the same as the mdev, and in qemu the uuid parameter
overwrites the smbios1 uuid internally, so we should have been reusing
that in the first place.
Signed-off-by: Dominik Csapak
---
when i was writing the uuid
On 2/24/23 13:10, Matthias Heiserer wrote:
Signed-off-by: Matthias Heiserer
---
Sorry for the long delay and the overall confusion!
This is the v2 of
https://lists.proxmox.com/pipermail/pve-devel/2023-February/055798.html
The second arrow function spans multiple lines, that's because it
. that should give the driver enough time
to clean up and we will not find the path anymore and skip the cleanup.
This way, it works with both the newer and older versions of the driver
(some of the older drivers are LTS releases, so they're still
supported).
Signed-off-by: Dominik Csapak
---
PVE
Otherwise the created vlan bridge has the default MTU, which is
unexpected when the original bridge has some other MTU configured.
We already do this for the firewall bridges, so we should do so too for
the vlan bridges.
Signed-off-by: Dominik Csapak
---
technically this is a breaking change i
by updating them on every change, but if the window is closed
without pressing ok, revert to the original settings
moves the fireUIConfigChanged call inside the window, since we
have to call it from inside too
Signed-off-by: Dominik Csapak
---
one weird 'feature': if one changes a value
we'll need it elsewhere too, and it was rather hidden in the
updateTagSettings call.
Signed-off-by: Dominik Csapak
---
www/manager6/UIOptions.js | 13 -
www/manager6/dc/OptionView.js | 1 +
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/www/manager6/UIOptions.js
Considers the newly added options from browser local storage. We have to
save the last sorting mechanism there, so we can detect if it changes
and trigger the movement/text changes (otherwise the tree nodes won't
be updated/moved)
Signed-off-by: Dominik Csapak
---
www/manager6/UIOptions.js
it's not used anymore, does not belong into pve-manager (rather in
proxmox-widget-toolkit), does not have a proper alias.
it's simple enough to recreate should we ever need it again
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile| 1 -
www/manager6/form/Boolean.js | 10
a new singleton like Utils/Parser, intended for holding stuff for
ui options, such as the tag settings/overrides
no behavioural change intended
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/UIOptions.js | 92
such as the sorting/grouping of guests. saves them in the browser local
storage under 'pve-tree-sorting'
adds a button for it next to the the view selector
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/Workspace.js | 27
it is basically the 'Server View' but with less content, and has often
times lead to confusion when uses accidentally selected it.
Signed-off-by: Dominik Csapak
---
www/manager6/form/ViewSelector.js | 7 ---
1 file changed, 7 deletions(-)
diff --git a/www/manager6/form/ViewSelector.js
b
* don't use booleanfield anymore (because of above change)
* rename sp into localStorage
* use fieldDefaults
* refactor stuff into PVE.UIOptions (a new singleton)
* remove storage view
* remove booleanfield()
Dominik Csapak (6):
ui: remove 'Storage View'
ui: remove unused booleanfield
ui
) atomic file '/var/log/pve/tasks/active' failed: No such file or
directory
We use the fact that only 'pub' and 'priv' RESTEnvironment types are an
api server with anyevent. For other types we call it like before.
Signed-off-by: Dominik Csapak
---
Not super happy about the coupling between
On 2/15/23 16:22, Matthias Heiserer wrote:
On 15.02.2023 16:03, Dominik Csapak wrote:
On 2/15/23 15:46, Stefan Sterz wrote:
with the additional parenthesis eslint throws an error due to the
"no-extra-parens" rule that avoids unnecessary parenthesis. remove
them to get rid of the erro
On 2/15/23 15:46, Stefan Sterz wrote:
with the additional parenthesis eslint throws an error due to the
"no-extra-parens" rule that avoids unnecessary parenthesis. remove
them to get rid of the error.
Signed-off-by: Stefan Sterz
---
i am personally not too happy with this eslint requirement
applied, with a short follow up that moves the icon inside the interpolated
string
(it's shorter and still readable)
should we maybe look into adding specific icons for pre-generated types?
or is that a niche feature for our users anyway?
___
such as the sorting/grouping of guests. saves them in the browser local
storage under 'pve-tree-sorting'
adds a button for it next to the the view selector
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/Workspace.js | 26
it's not used anymore, does not belong into pve-manager (rather in
proxmox-widget-toolkit), does not have a proper alias.
it's simple enough to recreate should we ever need it again
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile| 1 -
www/manager6/form/Boolean.js | 10
we'll need it elsewhere too, and it was rather hidden in the
updateTagSettings call.
Signed-off-by: Dominik Csapak
---
www/manager6/UIOptions.js | 13 -
www/manager6/dc/OptionView.js | 1 +
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/www/manager6/UIOptions.js
it is basically the 'Server View' but with less content, and has often
times lead to confusion when uses accidentally selected it.
Signed-off-by: Dominik Csapak
---
www/manager6/form/ViewSelector.js | 7 ---
1 file changed, 7 deletions(-)
diff --git a/www/manager6/form/ViewSelector.js
b
a new singleton like Utils/Parser, intended for holding stuff for
ui options, such as the tag settings/overrides
no behavioural change intended
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/UIOptions.js | 92
Considers the newly added options from browser local storage. We have to
save the last sorting mechanism there, so we can detect if it changes
and trigger the movement/text changes (otherwise the tree nodes won't
be updated/moved)
Signed-off-by: Dominik Csapak
---
www/manager6/UIOptions.js
* refactor stuff into PVE.UIOptions (a new singleton)
* remove storage view
* remove booleanfield
Dominik Csapak (6):
ui: remove 'Storage View'
ui: remove unused booleanfield
ui: refactor ui option related methods into UIOptions
ui: refactor refreshing the the resource store/tree
ui: add
that this is for sorting
only, I could immagine that we expose other knobs for the tree behavior or
visuals in the future (e.g., add more font-weight to names, or
yeah sure, does 'TreeSettingsEdit' (or 'TreeOptionsEdit') make sense?
Am 01/02/2023 um 16:49 schrieb Dominik Csapak:
in cluster options
-by: Dominik Csapak
---
www/manager6/Utils.js | 12 +++
www/manager6/tree/ResourceTree.js | 54 ---
2 files changed, 54 insertions(+), 12 deletions(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 0c57e0844..14f03e6d1 100644
--- a/www/manager6
namely the 'sort-field' (either vmid or name), 'group-templates' (if the
guest templates should be grouped seperately) and 'group-guest-types'
(if the guest types should be grouped or not)
Signed-off-by: Dominik Csapak
---
data/PVE/DataCenterConfig.pm | 37
in cluster options (for datacenter.cfg) and besides the view selector
(for the browser local storage)
the edit window is the same for bot but either makes an api call or
saves the resulting values into the browser local storage.
Signed-off-by: Dominik Csapak
---
not sure about just showing
we'll need it elsewhere too, and it was rather hidden in the
updateTagSettings call.
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js | 3 +++
www/manager6/dc/OptionView.js | 1 +
2 files changed, 4 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index
/selecting the default is really
optimal by just showing 'Default'. (more in the comment of the specific
patch 2/3 in pve-manager)
pve-cluster:
Dominik Csapak (1):
datacenter config: add options for sorting the gui tree
data/PVE/DataCenterConfig.pm | 37
1
On 1/26/23 11:47, Lukas Wagner wrote:
From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner
---
src/Utils.js
these two patches fix two issues regarding the combobox and the
ComboBoxSetStoreNode. The widget-toolkit patch is necessary to avoid
glitches after the second patch, but independently fixes also the
behaviour described in that commit message.
proxmox-widget-toolkit:
Dominik Csapak (1
focus the combobox again, so that the nexct
focusLeave can trigger again.
Signed-off-by: Dominik Csapak
---
www/manager6/form/ComboBoxSetStoreNode.js | 30 +++
1 file changed, 30 insertions(+)
diff --git a/www/manager6/form/ComboBoxSetStoreNode.js
b/www/manager6/form
the
necessary book-keeping.
Signed-off-by: Dominik Csapak
---
src/form/ComboGrid.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js
index ba3ce40..29c3d26 100644
--- a/src/form/ComboGrid.js
+++ b/src/form/ComboGrid.js
@@ -290,7
since we already have many elements here, and in our minimal resolution
of 1280x720 we don't see all elements any more.
reported in the forum:
https://forum.proxmox.com/threads/web-forms-extend-beyond-web-page-window-in-some-cases.120714
Signed-off-by: Dominik Csapak
---
www/manager6/dc
701 - 800 of 2027 matches
Mail list logo
