Relevant when modifying or removing an existing network device.
Signed-off-by: Fiona Ebner
---
PVE/API2/Qemu.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 59307133..fd718f93 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
Hi,
Am 11.07.23 um 12:52 schrieb Martijn:
> Maybe add an option when you can select a node when creating a new vm that
> it will automatically used the node that is least used based on CPU and RAM
> utilization.
there is no auto-balancing on guest creation, but you can configure
auto-balancing
Most commits are not relevant for Proxmox VE, but there are a few
(semi-)relevant ones, related to TCG, vhost (used by default for net
devices), vfio, virtio-gpu and ARM.
Signed-off-by: Fiona Ebner
---
...memory-prevent-dma-reentracy-issues.patch} | 0
...hen-getting-cursor-without
Signed-off-by: Fiona Ebner
---
...in-drained-section-after-vm_shutdown.patch | 140 ++
debian/patches/series | 1 +
2 files changed, 141 insertions(+)
create mode 100644
debian/patches/extra/0009-qemu_cleanup-begin-drained-section-after
24), must be a power of 2 between 256 and 256
Since neither vhost-user, nor vhost-vdpa netdev types are exposed by
Proxmox VE, just changing the limit to the correct 256 should be fine.
No obvious issue during live-migration found.
Fixes: 620d6b32 ("virtio-net: increase defaults rx|tx-queue-size
usly made the code expect to find the
VMID.
To improve detection, as a first step, match the trailing slash too.
Reported in the community forum:
https://forum.proxmox.com/threads/129320/post-571654
Signed-off-by: Fiona Ebner
---
Changes in v2:
* Improve commit message, seems like the
While such entries shuoldn't exist in practice without manually
messing around, it's not hard to imagine, and there's still a good
chance the actual VMID can still be found.
It's still unexpected to encounter such entries so keep the log line.
Signed-off-by: Fiona Ebner
---
New in v2
by also expecting the ".scope" part and trying the next entry if it is
not present instead of immediately failing.
It's still unexpected to encounter such entries, so keep the log line.
Signed-off-by: Fiona Ebner
---
Changes in v2:
* Keep setting vmid to zero in the error case!
If strtol() returns an errno, make sure not to print the error message
twice after the refactoring.
Signed-off-by: Fiona Ebner
---
New in v2.
qmeventd/qmeventd.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/qmeventd/qmeventd.c b/qmeventd/qmeventd.c
index 76a894cb
Am 10.07.23 um 09:58 schrieb Fiona Ebner:
> On a hybrid cgroup system, the /proc//cgroup file usually looks
> like:
>
>> 13:pids:/qemu.slice/110.scope
>> 12:perf_event:/
>> 11:devices:/qemu.slice
>> 10:misc:/
>> 9:hugetlb:/
>> 8:freezer:/
>&
art, which previously made the code expect to
find the VMID.
To improve detection, as a first step, match the trailing slash too.
Reported in the community forum:
https://forum.proxmox.com/threads/129320/post-571654
Signed-off-by: Fiona Ebner
---
qmeventd/qmeventd.c | 4 ++--
1 file changed, 2
by also expecting the ".scope" part and trying the next entry if it is
not present instead of immediately failing.
Signed-off-by: Fiona Ebner
---
qmeventd/qmeventd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qmeventd/qmeventd.c b/qmeventd/qmeven
Am 15.06.23 um 16:14 schrieb Alexander Zeidler:
> Signed-off-by: Alexander Zeidler
> ---
> Changes from v1:
> Improve description
> Move description to 'performance' section
> Remove arrow alignment
>
>
> src/PVE/VZDump/Common.pm | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff
Am 15.06.23 um 16:14 schrieb Alexander Zeidler:
> configuring pbs-entries-max can avoid failing backups due to a high
> amount of files in folders where a folder exclusion is not possible
>
> Signed-off-by: Alexander Zeidler
> ---
> Changes from v1:
> Reword loginfo message and include new set
Am 15.06.23 um 16:14 schrieb Alexander Zeidler:
> configuring pbs-entries-max can avoid failing backups due to a high
> amount of files in folders where a folder exclusion is not possible
>
> Signed-off-by: Alexander Zeidler
> ---
> Changes from v1:
> Add 'pbs-entries-max' according to the new
Am 15.06.23 um 16:14 schrieb Alexander Zeidler:
> Alter style to make the parameter check more concise
>
> Signed-off-by: Alexander Zeidler
Reviewed-by: Fiona Ebner
> ---
> Changes from v1:
> Shorten permission check
>
>
> PVE/API2/Backup.pm | 2 +-
> 1 f
Am 16.06.23 um 11:54 schrieb Noel Ullreich:
> Up until now, ram, balloonsize and swap were set in MiB, meaning if you
> wanted to
> create or change a VMs/CTs memory, you would first have to do the math to
> convert from GiB to MiB.
> This patch adds a dropdown-menu of units, MiB, GiB, and TiB,
Doing a simple numericity check and warn in the console so developers
can notice if there is something off.
Signed-off-by: Fiona Ebner
---
New in v2.
www/manager6/form/VMSelector.js | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/www/manager6/form/VMSelector.js b/www
7a5ca76a ("fix #4239: ui: show selected but non-existing vmids in backup
edit")
Signed-off-by: Fiona Ebner
---
Applying either of the patches to stable-7 is enough to fix the issue.
No changes in v2.
www/manager6/form/VMSelector.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Am 06.07.23 um 18:16 schrieb Thomas Lamprecht:
> Am 06/07/2023 um 15:51 schrieb Fiona Ebner:
>> which is passed by the backup job window when using selection mode
>> 'all', would be converted to [""] and wrongly add an entry with VMID
>> 0 because the item &qu
7a5ca76a ("fix #4239: ui: show selected but non-existing vmids in backup
edit")
Signed-off-by: Fiona Ebner
---
www/manager6/form/VMSelector.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
index 4c0bb
there). So make sure to silence it, if the silent param
is set.
Signed-off-by: Fiona Ebner
---
No changes in v3.
New in v2.
Can't use a normal if here, because of the 'local'.
src/PVE/CLI/pvecm.pm | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/PVE/CLI/pvecm.pm b/src/PVE/CL
In preparation to wait for quorum in the updatecerts command. The
generation of files that do not depend on quorum should still be done
beforehand.
Signed-off-by: Fiona Ebner
---
No changes in v3.
New in v2.
src/PVE/CLI/pvecm.pm | 1 +
src/PVE/Cluster/Setup.pm | 10 ++
2 files
of the ExecStartPre hook.
[0]: https://forum.proxmox.com/threads/129644/
Suggested-by: Thomas Lamprecht
Signed-off-by: Fiona Ebner
---
Changes in v3:
* Fix commit title.
Changes in v2:
* Different approach: always wait for quorum until timeout.
src/PVE/CLI/pvecm.pm | 8
1 file
Signed-off-by: Fiona Ebner
---
No changes in v3.
No changes in v2.
src/PVE/Cluster.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index ff777ba..c310a67 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -93,7 +93,7
Am 30.06.23 um 13:49 schrieb Fiona Ebner:
> Useful for the updatecerts call triggered via the ExecStartPre hook
> for pveproxy.service.
>
> When starting a node that's part of a cluster, there is a time window
> between the start of pve-cluster.service and when quorum is
In preparation to wait for quorum in the updatecerts command. The
generation of files that do not depend on quorum should still be done
beforehand.
Signed-off-by: Fiona Ebner
---
New in v2.
src/PVE/CLI/pvecm.pm | 1 +
src/PVE/Cluster/Setup.pm | 10 ++
2 files changed, 7
of the ExecStartPre hook.
[0]: https://forum.proxmox.com/threads/129644/
Suggested-by: Thomas Lamprecht
Signed-off-by: Fiona Ebner
---
Changes in v2:
* Different approach: always wait for quorum until timeout.
src/PVE/CLI/pvecm.pm | 8
1 file changed, 8 insertions(+)
diff --git a/src/PVE
there). So make sure to silence it, if the silent param
is set.
Signed-off-by: Fiona Ebner
---
New in v2.
Can't use a normal if here, because of the 'local'.
src/PVE/CLI/pvecm.pm | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/PVE/CLI/pvecm.pm b/src/PVE/CLI/pvecm.pm
ind
Signed-off-by: Fiona Ebner
---
No changes in v2.
src/PVE/Cluster.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index ff777ba..c310a67 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -93,7 +93,7 @@ sub
Am 29.06.23 um 16:26 schrieb Thomas Lamprecht:
> Am 29/06/2023 um 15:59 schrieb Fiona Ebner:
>> Useful for the updatecerts call triggered via the ExecStartPre hook
>> for pveproxy.service.
>>
>> When starting a node that's part of a cluster, there is a time window
] and reproduced right away in
a virtual test cluster).
To increase the chances for successful execution of the hook during
startup, wait for up to 5 seconds for quorum.
[0]: https://forum.proxmox.com/threads/129644/
Signed-off-by: Fiona Ebner
---
Dependency bump for libpve-cluster-api-perl needed
during/after the upgrade from Proxmox VE 7
to 8 (reported in the community forum [0] and reproduced right away in
a virtual test cluster).
This parameter will allow to increase the chances for successful
execution of the hook.
[0]: https://forum.proxmox.com/threads/129644/
Signed-off-by: Fiona Ebner
Signed-off-by: Fiona Ebner
---
src/PVE/Cluster.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index ff777ba..c310a67 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -93,7 +93,7 @@ sub prepare_observed_file_basedirs
The call was moved by 84c3ab0 ("pve-cluster.service: move pvecm call
to pveproxy.service") to pveproxy.service's ExecStartPre.
Signed-off-by: Fiona Ebner
---
src/PVE/CLI/pvecm.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/CLI/pvecm.pm b/src/PVE/CL
.
Signed-off-by: Fiona Ebner
---
src/PVE/Storage/CIFSPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage/CIFSPlugin.pm b/src/PVE/Storage/CIFSPlugin.pm
index 4cab2e1..2184471 100644
--- a/src/PVE/Storage/CIFSPlugin.pm
+++ b/src/PVE/Storage/CIFSPlugin.pm
@@
by not having -W eat the next argument when $scfg->{domain} is defined
but empty.
As reported in the community forum [0], this could lead to issues
adding a storage in the UI.
[0]: https://forum.proxmox.com/threads/44983/post-566842
Signed-off-by: Fiona Ebner
---
Didn't have time to l
Am 20.06.23 um 17:46 schrieb Maximiliano Sandoval:
> When running `pct status VMID` the variable
Issue is only present with --verbose.
> $last_proc_vmid_stat->{$vmid} is not set and pct reports no cpu usage.
>
> We address this by computing the used cpu time over the total uptime of
> the
and removing the replication job. Fix
it by not passing the invalid storage ID in the first place.
Signed-off-by: Fiona Ebner
---
src/PVE/Replication.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm
index 469ca19..bd627e5 100644
--- a/src/PVE
/post-566375
Signed-off-by: Fiona Ebner
---
Proxmox/Install.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index 7970f83..c2c014d 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -469,9 +469,10 @@ sub create_lvm_volumes
ree would
fail.
Turns out two extents would be missing because of lvcreate implicitly
rounding up, one of them for the root LV (the one for metadata was
already handled in the previous commit).
[0]: https://forum.proxmox.com/threads/129320/post-566375
Signed-off-by: Fiona Ebner
---
I think i
Just like 3b776617 ("pve6to7: enable noout before upgrade") last time,
it should be enabled in the stable branch to ensure users see the
warning before upgrade.
Signed-off-by: Fiona Ebner
---
Intended only for the stable-7 branch.
PVE/CLI/pve7to8.pm | 2 +-
1 file changed, 1 inser
Signed-off-by: Fiona Ebner
---
Applies to the master branch. It's enough the have the reminder here,
stable would even need a different patch because of changed context.
PVE/CLI/pve7to8.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
index
' - 'storage': missing property -
'notes-template' requires this property\nmissing property - 'protected'
requires this property
Signed-off-by: Fiona Ebner
---
Intended for both master and stable-7.
PVE/CLI/pve7to8.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/CLI/pve7to8.pm b
It just talks about the default behavior since PVE 7. It's rather
confusing to mention this, because the behavior doesn't change anymore
in PVE 8.
Signed-off-by: Fiona Ebner
---
Intended for both master and stable-7.
PVE/CLI/pve7to8.pm | 13 -
1 file changed, 13 deletions(-)
diff
Am 19.06.23 um 11:29 schrieb Aaron Lauterer:
> This patch series changes the behavior during guest migrations:
>
> Don't scan all storages for potential images belonging to the guest.
> Only migrate images referenced in the config.
> This made it necessary to handle pending changes explicitly
The default in Proxmox VE 7 was true and it was decided to keep that
and avoid a breaking change.
Signed-off-by: Fiona Ebner
---
www/manager6/qemu/CloudInit.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/qemu/CloudInit.js b/www/manager6/qemu/CloudInit.js
for catching the issue!
qemu-server:
Fiona Ebner (2):
schema: cloudinit: document default for ciupgrade
cloudinit: restore previous default for package upgrades
PVE/QemuServer.pm | 3 ++-
PVE/QemuServer/Cloudinit.pm | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
ma
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 0fa43a74..91aab21c 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -785,7 +785,8 @@ my $confdesc_cloudinit
t an issue for most users. It also leads to a
different cloud-init instance ID, because of the different setting,
which in turn leads to ssh host key regeneration within the VM.
Reported-by: Friedrich Weber
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 2 +-
PVE/QemuServer/Cloudinit.pm
which combines the stop+wait logic previously present at the single
call site of wait_for_unit_removed() in QemuServer.pm. It also does a
reset-failed call first, to ensure a unit in a failed state is also
cleaned up properly.
Signed-off-by: Fiona Ebner
---
src/PVE/Systemd.pm | 16
which also runs a reset-failed command for the unit first, to ensure
it is also cleaned up properly if in a failed state (e.g. after being
OOM-killed). Previuosly, users in that situation would only see the
less than ideal error message 'timeout waiting on systemd'.
Signed-off-by: Fiona Ebner
Am 19.06.23 um 16:13 schrieb Dominik Csapak:
> by removing the confusing buttons in the toolbar and adding them as
> actions in an actioncolumn. There a only relevant actions are visible
> and get a more expressive tooltip
I agree with Aaron that the actioncolumn is too far right at the moment.
Am 19.06.23 um 16:13 schrieb Dominik Csapak:
> by disallowing nodes to be selected where a mapping already exists
> and not preselecting a node
>
Two UX nits, not sure how hard they would be to address:
- if all nodes already have a mapping, disable the button (or after the
RFC, hide the action
Am 19.06.23 um 16:13 schrieb Dominik Csapak:
> diff --git a/www/manager6/window/PCIMapEdit.js
> b/www/manager6/window/PCIMapEdit.js
> index 516678e0..cd2dbfbe 100644
> --- a/www/manager6/window/PCIMapEdit.js
> +++ b/www/manager6/window/PCIMapEdit.js
> @@ -70,6 +70,44 @@
Signed-off-by: Fiona Ebner
---
No changes in v2.
src/test/test-shutdown-policy-override/README | 3 +
.../test-shutdown-policy-override/cmdlist | 4 ++
.../datacenter.cfg| 10
.../hardware_status | 5 ++
.../test-shutdown-policy
new param).
Changes in v2:
* Also check for Sys.Modify permisson when shutdown policy
parameter is used.
* Add UI patch.
* Drop already applied cluster patch.
ha-manager:
Fiona Ebner (7):
lrm service: add runtime directory
lrm service: move PID file to service's runtime directo
Signed-off-by: Fiona Ebner
---
New in v2, was sent separately before (no changes to that).
Used a new window, because it's small and couldn't find a good
fit with the existing ones. Maybe SafeDestroy, but not in name and
would require a few modifications too.
Not sure about using gettext
to model the recent change in the pve2 environment.
Signed-off-by: Fiona Ebner
---
No changes in v2.
src/PVE/HA/Sim/Env.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/HA/Sim/Env.pm b/src/PVE/HA/Sim/Env.pm
index c6ea73c..1b8399a 100644
--- a/src/PVE/HA/Sim/Env.pm
+++ b/src/PVE
a
policy arrive at the same time.
Suggested-by: Thomas Lamprecht
Signed-off-by: Fiona Ebner
---
(Build-)dependency bump for libpve-cluster-perl needed.
Changes in v2:
* Also check for Sys.Modify privilege when parameter is specified.
PVE/API2/Nodes.pm | 18 +-
1 file
The /nodes//status API endpoint in pve-manager allows to specify
the shutdown policy now. This change is required for it to have any
effect of course.
Being able to choose the shutdown policy on a per-node/per-shutdown
is more flexible and user-friendly.
Signed-off-by: Fiona Ebner
for future-proofing.
Signed-off-by: Fiona Ebner
---
Not sure if this is worth it.
(Build-)dependency bump for libpve-cluster-perl needed
No changes in v2.
src/PVE/HA/Env/PVE2.pm | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Env/PVE2.pm b/src
Signed-off-by: Fiona Ebner
---
No changes in v2.
src/PVE/HA/Env/PVE2.pm | 8
1 file changed, 8 insertions(+)
diff --git a/src/PVE/HA/Env/PVE2.pm b/src/PVE/HA/Env/PVE2.pm
index f6ebfeb..6a75bd4 100644
--- a/src/PVE/HA/Env/PVE2.pm
+++ b/src/PVE/HA/Env/PVE2.pm
@@ -458,9 +458,17 @@ sub
in preparation to allow overriding the shutdown policy with a file
there.
Signed-off-by: Fiona Ebner
---
No changes in v2.
debian/pve-ha-lrm.service | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/pve-ha-lrm.service b/debian/pve-ha-lrm.service
index fb1b5db..9f3f73d 100644
it's arguably cleaner to put it there, now that there is one.
Signed-off-by: Fiona Ebner
---
No changes in v2.
debian/pve-ha-lrm.service | 2 +-
src/PVE/Service/pve_ha_lrm.pm | 5 -
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/debian/pve-ha-lrm.service b/debian/pve
Am 19.06.23 um 10:38 schrieb Alexandre Derumier:
> add doc for differents cpu models including
> new x86-64-vX models
>
> changelog v2: x86-64-v2 is compatible with >= opteron_g3
>
> Signed-off-by: Alexandre Derumier
applied, thanks! Made some follow-ups for typo/style/consistency fixes
and
Am 19.06.23 um 12:03 schrieb Fiona Ebner:
> Am 19.06.23 um 10:38 schrieb Alexandre Derumier:
>> add doc for differents cpu models including
>> new x86-64-vX models
>>
>> changelog v2: x86-64-v2 is compatible with >= opteron_g3
>>
I'm applying this with follo
Am 19.06.23 um 14:25 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier
> ---
> PVE/QemuServer/CPUConfig.pm | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm
> index fb0861b..cfccbd4 100644
> ---
Signed-off-by: Fiona Ebner
---
Depends on https://lists.proxmox.com/pipermail/pve-devel/2023-June/057635.html
Used a new window, because it's small and couldn't find a good
fit with the existing ones. Maybe SafeDestroy, but not in name and
would require a few modifications too.
Not sure about
Am 19.06.23 um 11:29 schrieb Aaron Lauterer:
>
> @@ -4876,11 +4876,13 @@ sub foreach_volid {
> $volhash->{$volid}->{shared} = 1 if $drive->{shared};
>
> $volhash->{$volid}->{referenced_in_config} //= 0;
> - $volhash->{$volid}->{referenced_in_config} = 1 if !defined($snapname);
ion by themselves
and can be fixed upon/after applying.
For the patches that don't have it yet:
Reviewed-by: Fiona Ebner
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Am 19.06.23 um 11:29 schrieb Aaron Lauterer:
> @@ -277,6 +280,12 @@ sub phase1 {
> # finally all current volumes
> PVE::LXC::Config->foreach_volume_full($conf, { include_unused => 1 },
> $test_mp);
>
> +for my $path (keys %$path_to_volid) {
> + my @volids = keys
Am 19.06.23 um 11:29 schrieb Aaron Lauterer:
> @@ -427,6 +429,12 @@ sub scan_local_volumes {
> }
> });
>
> + for my $path (keys %$path_to_volid) {
> + my @volids = keys $path_to_volid->{$path}->%*;
> + die "detected not supported aliased volumes: '" .
Am 19.06.23 um 11:19 schrieb DERUMIER, Alexandre:
> Le lundi 19 juin 2023 à 10:46 +0200, Fiona Ebner a écrit :
>
>> I also noticed that
>> Denverton{-v2,-v3}
>> Snowridge{-v2,-v3,-v4}
>
> Both are atom cpu. I don't known if we want to support them ? (they
>
Am 19.06.23 um 10:38 schrieb Alexandre Derumier:
> add doc for differents cpu models including
> new x86-64-vX models
>
> changelog v2: x86-64-v2 is compatible with >= opteron_g3
>
> Signed-off-by: Alexandre Derumier
> ---
> qm.adoc | 145
Am 09.06.23 um 12:27 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier
> ---
> PVE/QemuServer/CPUConfig.pm | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm
> index fb0861b..77fc682 100644
> ---
quot;;
> }
but that can also just s/referenced_in_config/is_attached/
Consider patches 7/12 until 12/12:
Reviewed-by: Fiona Ebner
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Am 16.06.23 um 11:57 schrieb Aaron Lauterer:> changes since v3:
hopefully caught all style nits now ;)
I'm sorry to tell you:
> +if (defined $conf->{pending} && $conf->{pending}->%*) {
missing parentheses around defined() :P
___
pve-devel
Could've been done for the test repository already, but now that there
is a split between no-subscription and enterprise it becomes even more
relevant.
Reported-by: Thomas Lamprecht
Signed-off-by: Fiona Ebner
---
Changes in v2:
* rebase on current master.
src/node/APTRepositories.js | 48
Am 16.06.23 um 11:57 schrieb Aaron Lauterer:
> We use this in a few places. By factoring it into its own function, we
> can avoid running slightly different checks in various places.
>
> Signed-off-by: Aaron Lauterer
> ---
applied this one, thanks!
Not too important right now, but could be
Am 16.06.23 um 11:57 schrieb Aaron Lauterer:
> after snapshots and the pending section to make sure, that volids that
> are referenced here, will be marked correctly, e.g. 'is_unused'.
>
The flag is set as follows:
> $volhash->{$volid}->{is_unused} //= 0;
>
Am 16.06.23 um 11:56 schrieb Aaron Lauterer:
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 6cbaf87..33acef6 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -2424,7 +2424,7 @@ sub destroy_vm {
>
> if ($purge_unreferenced) { # also remove unreferenced disk
>
Am 16.06.23 um 11:56 schrieb Aaron Lauterer:
> When scanning all configured storages for disk images belonging to the
> VM, the migration could easily fail if a storage is not available, but
> enabled. That storage might not even be used by the VM at all.
>
> By not scanning all storages and only
t and LRM honor the new param).
cluster:
Fiona Ebner (1):
datacenter config: turn shutdown policy into a standard option
src/PVE/DataCenterConfig.pm | 50 +++--
1 file changed, 26 insertions(+), 24 deletions(-)
ha-manager:
Fiona Ebner (7):
lrm service: ad
for future-proofing.
Signed-off-by: Fiona Ebner
---
Not sure if this is worth it.
(Build-)dependency bump for libpve-cluster-perl needed
src/PVE/HA/Env/PVE2.pm | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Env/PVE2.pm b/src/PVE/HA/Env/PVE2.pm
in preparation to allow overriding the shutdown policy with a file
there.
Signed-off-by: Fiona Ebner
---
debian/pve-ha-lrm.service | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/pve-ha-lrm.service b/debian/pve-ha-lrm.service
index fb1b5db..9f3f73d 100644
--- a/debian/pve-ha
it's arguably cleaner to put it there, now that there is one.
Signed-off-by: Fiona Ebner
---
debian/pve-ha-lrm.service | 2 +-
src/PVE/Service/pve_ha_lrm.pm | 5 -
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/debian/pve-ha-lrm.service b/debian/pve-ha-lrm.service
index
Signed-off-by: Fiona Ebner
---
src/test/test-shutdown-policy-override/README | 3 +
.../test-shutdown-policy-override/cmdlist | 4 ++
.../datacenter.cfg| 10
.../hardware_status | 5 ++
.../test-shutdown-policy-override/log.expect
to model the recent change in the pve2 environment.
Signed-off-by: Fiona Ebner
---
src/PVE/HA/Sim/Env.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/HA/Sim/Env.pm b/src/PVE/HA/Sim/Env.pm
index c6ea73c..1b8399a 100644
--- a/src/PVE/HA/Sim/Env.pm
+++ b/src/PVE/HA/Sim/Env.pm
The /nodes//status API endpoint in pve-manager allows to specify
the shutdown policy now. This change is required for it to have any
effect of course.
Being able to choose the shutdown policy on a per-node/per-shutdown
is more flexible and user-friendly.
Signed-off-by: Fiona Ebner
---
src/PVE
Increases flexibility/user-friendliness.
Suggested-by: Thomas Lamprecht
Signed-off-by: Fiona Ebner
---
(Build-)dependency bump for libpve-cluster-perl needed.
Dependency bump for ha-manager needed (to have the runtime dir exist
and LRM honor the new param).
PVE/API2/Nodes.pm | 11
to be re-used by the node/status API endpoint.
Signed-off-by: Fiona Ebner
---
src/PVE/DataCenterConfig.pm | 50 +++--
1 file changed, 26 insertions(+), 24 deletions(-)
diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
index 5f12450..3d24e78
Signed-off-by: Fiona Ebner
---
src/PVE/HA/Env/PVE2.pm | 8
1 file changed, 8 insertions(+)
diff --git a/src/PVE/HA/Env/PVE2.pm b/src/PVE/HA/Env/PVE2.pm
index f6ebfeb..6a75bd4 100644
--- a/src/PVE/HA/Env/PVE2.pm
+++ b/src/PVE/HA/Env/PVE2.pm
@@ -458,9 +458,17 @@ sub
Am 16.06.23 um 10:23 schrieb Thomas Lamprecht:
> Am 16/06/2023 um 09:35 schrieb Fiona Ebner:
>> The associated pve_verify_vmid() method already restricts the value
>> to this range, but this wouldn't be visible in the API viewer for
>> example [0].
>>
>> The ver
/threads/128845/post-564526
Signed-off-by: Fiona Ebner
---
src/PVE/JSONSchema.pm | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 60b02cb..7589bba 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE/JSONSchema.pm
@@ -59,8
There's still some context changes not covered by earlier series. No
functional change intended.
Signed-off-by: Fiona Ebner
---
...VE-add-savevm-async-for-background-state-snapshots.patch | 4 ++--
.../pve/0020-PVE-Add-dummy-id-command-line-parameter.patch | 4 ++--
...E-Compat-4.0-used
-by: Fiona Ebner
---
...rive-mirror-add-support-for-sync-bitmap-mode-never.patch | 4 ++--
...03-mirror-add-check-for-bitmap-mode-without-bitmap.patch | 2 +-
.../bitmap-mirror/0006-mirror-move-some-checks-to-qmp.patch | 6 +++---
.../0030-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch | 2
-by: Fiona Ebner
---
src/PVE/SafeSyslog.pm | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/PVE/SafeSyslog.pm b/src/PVE/SafeSyslog.pm
index 7d3e7a7..af105a1 100644
--- a/src/PVE/SafeSyslog.pm
+++ b/src/PVE/SafeSyslog.pm
@@ -18,7 +18,11 @@ my $log_tag = "un
Am 13.06.23 um 15:42 schrieb Alexander Zeidler:
> Signed-off-by: Alexander Zeidler
> ---
> src/PVE/VZDump/Common.pm | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
> index a6fe483..28ab0d3 100644
> --- a/src/PVE/VZDump/Common.pm
Am 14.06.23 um 13:44 schrieb Aaron Lauterer:
> On 6/14/23 13:38, Thomas Lamprecht wrote:
>> Am 14/06/2023 um 13:28 schrieb Aaron Lauterer:
>>> This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15.
>>>
>>> The bug should be fixed by now [0]. The reproducer doesn't cause any
>>> issues in my
701 - 800 of 1315 matches
Mail list logo
