' is set to 'channel')
- Add new option 'notification-policy'
Replacement for the now deprecated 'mailnotification' option. Mostly
just a rename for consistency, but also adds the 'never' option.
- Mark 'mailnotification' as deprecated in favor of 'notification-policy'
Signed-off-by: Lukas Wagner
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/filter.rs | 366 +
proxmox-notify/src/api/gotify.rs | 7 +
proxmox-notify/src/api/mod.rs | 1 +
proxmox-notify/src/api/sendmail.rs | 5 +
4 files changed, 379 insertions(+)
create mode 100644
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 87
1 file changed, 87 insertions(+)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index 84bc184..9adeff5 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -13,6 +13,9
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster.pm | 7 ++
PVE/API2/Cluster/Makefile | 1 +
PVE/API2/Cluster/Notifications.pm | 134 ++
3 files changed, 142 insertions(+)
create mode 100644 PVE/API2/Cluster/Notifications.pm
diff --git
Signed-off-by: Lukas Wagner
---
www/manager6/dc/BackupJobDetail.js | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/www/manager6/dc/BackupJobDetail.js
b/www/manager6/dc/BackupJobDetail.js
index c4683a47..f4a0d981 100644
--- a/www/manager6/dc
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/gotify.rs | 284 +++
proxmox-notify/src/api/mod.rs| 6 +
2 files changed, 290 insertions(+)
create mode 100644 proxmox-notify/src/api/gotify.rs
diff --git a/proxmox-notify/src/api/gotify.rs b/proxmox
Signed-off-by: Lukas Wagner
---
pve-rs/Cargo.toml| 1 +
pve-rs/Makefile | 1 +
pve-rs/src/lib.rs| 1 +
pve-rs/src/notify.rs | 65
4 files changed, 68 insertions(+)
create mode 100644 pve-rs/src/notify.rs
diff --git a/pve-rs
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/mod.rs | 7 +
proxmox-notify/src/api/sendmail.rs | 254 +
2 files changed, 261 insertions(+)
create mode 100644 proxmox-notify/src/api/sendmail.rs
diff --git a/proxmox-notify/src/api/mod.rs b/proxmox
roxmox-notify/src/renderer/mod.rs
create mode 100644 proxmox-notify/src/renderer/plaintext.rs
create mode 100644 proxmox-notify/src/renderer/table.rs
create mode 100644 proxmox-notify/src/schema.rs
proxmox-perl-rs:
Lukas Wagner (7):
log: set default log level to 'info', add product specific loggin
They need to have the same name as the target.
Took the opportunity to move the .PHONY right next to the target recipe,
so that mistakes like these are hopefully easier caught.
Signed-off-by: Lukas Wagner
---
test/Makefile | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff
Signed-off-by: Lukas Wagner
---
Cargo.toml | 1 +
proxmox-notify/Cargo.toml | 9 +
proxmox-notify/src/config.rs| 51 +
proxmox-notify/src/endpoints/mod.rs | 0
proxmox-notify/src/lib.rs | 299
proxmox
Add an endpoint for Gotify [1], showing the how easy it is to add new
endpoint implementations.
[1] https://gotify.net/
Signed-off-by: Lukas Wagner
---
proxmox-notify/Cargo.toml | 6 +-
proxmox-notify/src/config.rs | 22 +
proxmox-notify/src/endpoints/gotify.rs
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 79
1 file changed, 79 insertions(+)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index 177e01d..84bc184 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -6,6 +6,10
to be added/removed from *all*
affected backup job configurations.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/channel.rs | 53 ++
proxmox-notify/src/config.rs | 9 +++
proxmox-notify/src/lib.rs | 133 ++
3 files changed, 179 insertions
Logging behaviour can be overridden by the {PMG,PVE}_LOG environment
variable.
This commit also disables styled output and timestamps in log messages,
since we usually log to the journal anyway. The log output is configured
to match with other log messages in task logs.
Signed-off-by: Lukas
urthermore, there
are checks in place so that recursive sub-filter definitions are
detected.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/gotify.rs | 3 +
proxmox-notify/src/api/sendmail.rs | 4 +
proxmox-notify/src/config.rs | 9 +
proxmox-notify/src
.
- Rename `sendmail` sub to `send_notification`
- Breaking out some of the code into helper subs, hopefully
reducing the spaghetti factor a bit
Signed-off-by: Lukas Wagner
---
PVE/API2/VZDump.pm | 2 +-
PVE/VZDump.pm | 323 -
test
automatically migrates from
'mailnotification' has been added.
Signed-off-by: Lukas Wagner
---
www/manager6/Makefile | 4 +-
www/manager6/dc/Backup.js | 77 +--
.../form/NotificationChannelSelector.js | 47 +++
www/manager6/form
The module previously lived in `pbs-api-types`, however turned out to
be useful in other places as well (POM, proxmox-notify), so it is moved
here as its own micro-crate.
Signed-off-by: Lukas Wagner
---
Notes:
Already posted to pbs-devel, but included here as well since we
depend
... instead of using sendmail directly
Signed-off-by: Lukas Wagner
---
src/PVE/HA/Env.pm| 6 ++---
src/PVE/HA/Env/PVE2.pm | 27 ++---
src/PVE/HA/NodeStatus.pm | 52
src/PVE/HA/Sim/Env.pm| 10 ++--
4 files changed, 66
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 257 ++
1 file changed, 257 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index 53e447ad..823e8107 100644
--- a/PVE/API2/Cluster/Notifications.pm
Signed-off-by: Lukas Wagner
---
www/manager6/window/Backup.js | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 4b21c746..8c8cd7d8 100644
--- a/www/manager6/window/Backup.js
... instead of using sendmail directly
As of now, there is no way to configure a notification channel
for APT notifications. Thus, the implementation simply creates
an temporary channel with a sendmail endpoint sending mail
to root.
Signed-off-by: Lukas Wagner
---
PVE/API2/APT.pm | 73
The PVE::Notify module is a very thin wrapper around the
Proxmox::RS::Notify module, feeding the configuration from the
new 'notifications.cfg' and 'priv/notifications.cfg' files into
it.
Also, PVE::Notify contains some useful helpers.
Signed-off-by: Lukas Wagner
---
PVE/Makefile | 1 +
PVE
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/channel.rs | 253 ++
proxmox-notify/src/api/mod.rs | 1 +
2 files changed, 254 insertions(+)
create mode 100644 proxmox-notify/src/api/channel.rs
diff --git a/proxmox-notify/src/api/channel.rs
b/proxmox
The `#[cfg(test)]` directive ensures that the tests are not compiled
for non-test builds.
Signed-off-by: Lukas Wagner
---
Notes:
Already posted to pbs-devel, but included here as well since we
depend on it and it has not yet been applied.
Changes from the version posted there: Fixed
Signed-off-by: Lukas Wagner
---
Notes:
Changes v1 -> v2:
- Renamed crate from 'proxmox-notification' to 'proxmox-notify'
Cargo.toml| 1 +
proxmox-notify/Cargo.toml | 10 ++
proxmox-notify/src/lib.rs | 0
3 files changed, 11 insertions(+)
create m
Signed-off-by: Lukas Wagner
---
proxmox-notify/examples/render.rs | 63 +++
1 file changed, 63 insertions(+)
create mode 100644 proxmox-notify/examples/render.rs
diff --git a/proxmox-notify/examples/render.rs
b/proxmox-notify/examples/render.rs
new file mode 100644
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 83
1 file changed, 83 insertions(+)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index c6483dc..177e01d 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -6,6 +6,9
This plugin uses the 'sendmail' command to send an email
to one or more recipients.
Signed-off-by: Lukas Wagner
---
proxmox-notify/Cargo.toml| 9 ++-
proxmox-notify/src/config.rs | 12
proxmox-notify/src/endpoints/mod.rs | 2 +
proxmox-notify/src
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 34 --
1 file changed, 32 insertions(+), 2 deletions(-)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index db573ef..a101416 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -2,10
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/common.rs | 46
proxmox-notify/src/api/mod.rs| 2 ++
2 files changed, 48 insertions(+)
create mode 100644 proxmox-notify/src/api/common.rs
diff --git a/proxmox-notify/src/api/common.rs b/proxmox-notify
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/mod.rs | 94 +++
proxmox-notify/src/lib.rs | 1 +
2 files changed, 95 insertions(+)
create mode 100644 proxmox-notify/src/api/mod.rs
diff --git a/proxmox-notify/src/api/mod.rs b/proxmox-notify/src/api
Signed-off-by: Lukas Wagner
---
proxmox-notify/debian/changelog | 5 +
proxmox-notify/debian/control | 31 +
proxmox-notify/debian/copyright | 16 +++
proxmox-notify/debian/debcargo.toml | 7 +++
4 files changed, 59 insertions
Hi!
On 5/9/23 09:56, Aaron Lauterer wrote:
To hopefully reduce confusion what the 'shared' checkbox does.
Signed-off-by: Aaron Lauterer
---
I saw it one time too many where users were a bit confused as to what
this checkbox is for. Since we have a hard time to find a better label,
maybe we
Gave this a quick test and reviewed the changes - looks good to me.
Tested-by: Lukas Wagner
Reviewed-by: Lukas Wagner
On 3/23/23 12:02, Christoph Heiss wrote:
Adds a default-on checkbox to the QEMU Guest Agent feature selector
controlling the 'fs-freeze-on-backup' option. If unchecked
On 4/18/23 11:31, Leo Nunner wrote:
Proxmox.Utils.API2Request({
- url: me.url,
+ url: '/nodes/' + nodename + '/lxc/' + vmid + '/interfaces',
Nit, I think a template string here would be nicer ;)
url: `/nodes/${nodename}/lxc/${vmid}/interfaces`
--
- Lukas
On 4/18/23 11:31, Leo Nunner wrote:
+foreach my $interface ($config->@*) {
+ my $obj = { name => $interface->{ifname} };
+ foreach my $ip ($interface->{addr_info}->@*) {
+ $obj->{$ip->{family}} = $ip->{local} . "/" . $ip->{prefixlen};
+ }
+ $obj->{hwaddr} =
First of all, thanks for the feedback!
On 4/14/23 08:19, Thomas Lamprecht wrote:
Hmmm, this is something that I did not think to closely about when drafting
the (very rough) design for the notification overhaul, but it has some merit
to be able to configure this per job – but naturally it also
Signed-off-by: Lukas Wagner
---
configs/pve-blacklist.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/pve-blacklist.conf b/configs/pve-blacklist.conf
index 9687961d..27d1be48 100644
--- a/configs/pve-blacklist.conf
+++ b/configs/pve-blacklist.conf
@@ -1,4 +1,4
Whoop, not sure what happened here with the commit message - already fixed
locally, will be included in v2 ;)
On 3/27/23 17:18, Lukas Wagner wrote:
Logging behaviour can be overridden by the {PMG,PVE}_LOG environment
variable.
This commit also disables styled output and timestamps in log
Signed-off-by: Lukas Wagner
---
Notes:
notifications.rs should be moved to common/src at some point.
Currently it resides in pve-rs/src, since rust-analyzer breaks for me
for all code in common/src.
Cargo.toml | 2 +
common/pkg/Makefile| 1 +
pve-rs
.
Potential side effect: If there is another sendmail endpoint configured
in notifications.cfg which also sends to root@pam, root may receive
two emails.
Signed-off-by: Lukas Wagner
---
PVE/API2/APT.pm | 55 ++---
1 file changed, 34 insertions(+), 21
urthermore, there
are checks in place so that recursive sub-filter definitions are
detected.
Signed-off-by: Lukas Wagner
---
proxmox-notification/src/config.rs| 9 +
.../src/endpoints/sendmail.rs | 7 +
proxmox-notification/src/filter.rs
Signed-off-by: Lukas Wagner
---
PVE/API2/VZDump.pm | 2 +-
PVE/VZDump.pm | 10 --
test/mail_test.pl | 6 +++---
3 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/PVE/API2/VZDump.pm b/PVE/API2/VZDump.pm
index 8e873c05..83772e73 100644
--- a/PVE/API2/VZDump.pm
+++ b
The PVE::Notification is a very thin wrapper around the
Proxmox::RS::Notification module, feeding the configuration from the
new 'notifications.cfg' file into it as a raw string.
Signed-off-by: Lukas Wagner
---
PVE/Makefile| 1 +
PVE/Notification.pm | 60
Signed-off-by: Lukas Wagner
---
src/PVE/HA/Env.pm| 4 ++--
src/PVE/HA/Env/PVE2.pm | 2 +-
src/PVE/HA/NodeStatus.pm | 2 +-
src/PVE/HA/Sim/Env.pm| 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/PVE/HA/Env.pm b/src/PVE/HA/Env.pm
index 16603ec..98aeb09 100644
They need to have the same name as the target.
Took the opportunity to move the .PHONY right next to the target recipe,
so that mistakes like these are hopefully easier caught.
Signed-off-by: Lukas Wagner
---
test/Makefile | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff
Add an endpoint for Gotify [1], showing the how easy it is to add new
endpoint implementations.
[1] https://gotify.net/
Signed-off-by: Lukas Wagner
---
proxmox-notification/src/config.rs | 9 +++
proxmox-notification/src/endpoints/gotify.rs | 80
proxmox
Signed-off-by: Lukas Wagner
---
data/PVE/Cluster.pm | 1 +
data/src/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
index efca58f..1a1f9e8 100644
--- a/data/PVE/Cluster.pm
+++ b/data/PVE/Cluster.pm
@@ -55,6 +55,7 @@ my $observed
Signed-off-by: Lukas Wagner
---
proxmox-notification/debian/changelog | 5 ++
proxmox-notification/debian/control | 59 +++
proxmox-notification/debian/copyright | 16 ++
proxmox-notification/debian/debcargo.toml | 7 +++
4 files changed, 87 insertions
Logging behaviour can be overridden by the {PMG,PVE}_LOG environment
variable.
This commit also disables styled output and timestamps in log messages,
since we usually log to the journal anyway. The log output is configured
to match with other log messages in task logs.
Signed-off-by: Lukas
generation has been removed.
Signed-off-by: Lukas Wagner
---
PVE/VZDump.pm | 116 +-
test/mail_test.pl | 22 +
2 files changed, 44 insertions(+), 94 deletions(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index a04837e7..c0971220 100644
--- a/PVE
nts, e.g. webhook, a generic SMTP, etc.
- Integrate the new module into the other products
[1] https://gotify.net/
[2] https://bugzilla.proxmox.com/show_bug.cgi?id=4526
proxmox:
Lukas Wagner (6):
add proxmox-notification crate
notification: implement sendmail endpoint
notification: add no
... instead of using sendmail directly
Signed-off-by: Lukas Wagner
---
src/PVE/HA/Env/PVE2.pm | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Env/PVE2.pm b/src/PVE/HA/Env/PVE2.pm
index f6ebfeb..a3b30b5 100644
--- a/src/PVE/HA/Env/PVE2.pm
+++ b/src
Signed-off-by: Lukas Wagner
---
PVE/API2/Replication.pm | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm
index d70b4607..e3566a71 100644
--- a/PVE/API2/Replication.pm
+++ b/PVE/API2/Replication.pm
@@ -15,6 +15,7
for notification endpoints
and filters will live in a new configuration file, `notifications.cfg`.
However, since the crate should be product-agnostic, we process the
configuration as a raw string. Loading/storing of the configuration
file will happen in product-specific code.
Signed-off-by: Lukas
Signed-off-by: Lukas Wagner
---
test/Makefile | 8
test/{mail_test.pl => vzdump_notification_test.pl} | 0
2 files changed, 4 insertions(+), 4 deletions(-)
rename test/{mail_test.pl => vzdump_notification_test.pl} (100%)
diff --git a/test/Ma
notification module, without any events going
unnoticed.
Signed-off-by: Lukas Wagner
---
proxmox-notification/src/lib.rs | 1 +
proxmox-notification/src/methods.rs | 55 +
2 files changed, 56 insertions(+)
create mode 100644 proxmox-notification/src/methods.rs
Signed-off-by: Lukas Wagner
---
Cargo.toml | 1 +
proxmox-notification/Cargo.toml | 10 ++
proxmox-notification/src/lib.rs | 0
3 files changed, 11 insertions(+)
create mode 100644 proxmox-notification/Cargo.toml
create mode 100644 proxmox-notification/src/lib.rs
On 2/23/23 16:25, Lukas Wagner wrote:
Sometimes it can be quite useful to know when exactly a system report
was generated. Adds the following output quite prominently in the
general system info section:
# date -R
Thu, 23 Feb 2023 16:21:12 +0100
Signed-off-by: Lukas Wagner
---
PVE
Signed-off-by: Lukas Wagner
---
First time using 'in-rely-to' in `git format-patch`. Let's hope this
works as expected :^)
de.po | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/de.po b/de.po
index b2460a5..58861d8 100644
--- a/de.po
+++ b/de.po
@@ -362,7 +362,7 @@ msgid
Mostly related to 'Leerzeichen in Komposita' [1]
[1] https://de.wikipedia.org/wiki/Leerzeichen_in_Komposita
Signed-off-by: Lukas Wagner
---
de.po | 76 +--
1 file changed, 38 insertions(+), 38 deletions(-)
diff --git a/de.po b/de.po
Signed-off-by: Lukas Wagner
---
de.po | 40 +---
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/de.po b/de.po
index 35c19bd..b2460a5 100644
--- a/de.po
+++ b/de.po
@@ -362,7 +362,7 @@ msgid ""
"Additional monitors are recomm
On 3/14/23 13:48, Noel Ullreich wrote:
+Since passthrough is preformed on real hardware, the hardware needs to fulfill
Small typo, I guess this should be 'performed'?
--
- Lukas
___
pve-devel mailing list
pve-devel@lists.proxmox.com
On 2/23/23 16:54, Stefan Sterz wrote:
While I agree that this can be useful sometimes, just as a heads-up,
iptables-save provides that info already:
# Generated by iptables-save v1.8.7 on Thu Feb 23 16:43:26 2023
However, we may not want to rely on that.
Thanks for the feedback!
I am aware
Sometimes it can be quite useful to know when exactly a system report
was generated. Adds the following output quite prominently in the
general system info section:
# date -R
Thu, 23 Feb 2023 16:21:12 +0100
Signed-off-by: Lukas Wagner
---
PVE/Report.pm | 1 +
1 file changed, 1 insertion
This commit sets up logging by hooking into module loading/bootstraping
process to call a new `init` function exported by the `Proxmox::Lib::{PVE,PMG}`
module, which initializes `env_logger` with its default settings.
This allows us to use `log::*` macros from Rust code.
Signed-off-by: Lukas
is that no changes of client-side Perl code is required.
Signed-off-by: Lukas Wagner
---
Not sure if this is the best/cleanest approach for this,
seems to work just fine though.
Proxmox/Lib/template.pm | 7 +++
common/src/logging.rs | 8
common/src/mod.rs | 1 +
pmg-rs/Cargo.toml
mment",
"filter,sync-attributes"
}
This commit fixes this by splitting `delete` in case it is a string.
Reported-by: Friedrich Weber
Signed-off-by: Lukas Wagner
---
Same fix as in my LDAP widget-toolkit patch series:
https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005952.h
Keycloak seems to have dropped the `auth` part at some point in the past.
Signed-off-by: Lukas Wagner
---
pveum.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pveum.adoc b/pveum.adoc
index 65d874a..6981d02 100644
--- a/pveum.adoc
+++ b/pveum.adoc
@@ -461,7 +461,7
'additionally' in this context is a bit misleading, as it suggests
that e.g. 'VM.Allocate' AND 'Permissions.Modify' are needed, conflicting
with the previous paragraph.
Signed-off-by: Lukas Wagner
---
The ambiguity popped up in a recent support ticket.
pveum.adoc | 6 +++---
1 file changed, 3
On 1/27/23 12:04, Lukas Wagner wrote:
I'll check once I find the time for it.
For the record:
https://github.com/algesten/ureq/pull/587
--
- Lukas
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin
Thank you for your input!
On 1/27/23 12:09, Dominik Csapak wrote:
i know i'm a bit late to the party, but couldn't we simply show nothing when a
repo is not enabled?
it's greyed-out anyway (though i'm not opposed to using the 'minus' icon here
either)
I have considered this option as well.
Thanks for reviewing my patch!
On 1/27/23 11:25, Fabian Grünbichler wrote:
I wonder how much work it would be to change that upstream? IIRC we also
contributed HTTPS_PROXY support to ureq, and this is not the only place where we
use it and want proper proxy support..
I'll check once I find
>From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner
---
src/Utils.js| 2 ++
src/node/APTRepositories
>From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Backup.js| 6 ++
www/manager6/g
* Use camel case for render function
* Use arrow functions
* Remove spurious newline
proxmox-widget-toolkit:
Lukas Wagner (1):
repo view: replace non-clickable checkbox with icons
src/Utils.js| 2 ++
src/node/APTRepositories.js | 6 ++
2 files changed, 4 insertions(+), 4 del
On 1/24/23 16:28, Thomas Lamprecht wrote:
you break setting dataIndex by writing it all lowercase ?!
+ align: 'center',
+ renderer: function(enabled, cell, record) {
+ return
Proxmox.Utils.render_enabled_icon(record.data.enabled);
clear.
Also increased the label width a bit, so that a full MAC
address can be properly displayed.
Signed-off-by: Lukas Wagner
---
www/manager6/node/NodeOptionsView.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/manager6/node/NodeOptionsView.js
b/www/manager6/node
>From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner
---
src/Utils.js| 6 ++
src/n
configuration also uses a checkbox, however there it is
possible to enable/disable elements by clicking on the checkbox.
As mentioned by Thomas in v1, this could be replaced by a more explicit
icon-based toggle button in the future series.
proxmox-widget-toolkit:
Lukas Wagner (1):
repo view: replace non
>From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Backup.js| 11 ++-
www/manag
On 1/23/23 11:57, Thomas Lamprecht wrote:
Ok, tbh. I have some faint memory that I saw some comment about this in the
distant past; IIRC it was mostly due to the the "writeable" firewall and the
"read-only" other usages using both the exact same display.
My bad, there actually was a report
On 1/20/23 15:09, Thomas Lamprecht wrote:
While looking sleek, the problem with this is that from a user's
perspective, a checkbox generally implies that it is operable by
clicking on it (which we allow in other places, to make the matter even
more confusing).
If it's editable it gets a
>From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Backup.js| 7 ++-
www/manager6/g
>From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner
---
src/node/APTRepositories.js | 7 +++
1 file changed
configuration also uses a checkbox, however there it is
possible to enable/disable elements by clicking on the checkbox - so
this can stay as IMHO.
pve-manager:
Lukas Wagner (1):
ui: backup: replication: replace non-clickable checkbox with Yes/No
text
www/manager6/dc/Backup.js| 7
In JS, a `for (const a in <...>)` loop iterates over indices, not
over values. To iterate over values, `for (const a of <..>)` has
to be used. Furthermore, filtering by ID did not work properly, since
the property is called `vmid`, not `id`.
Signed-off-by: Lukas Wagner
---
www
to be configured to allow that - Squid by
default allows CONNECT only for HTTPS on port 443.
Signed-off-by: Lukas Wagner
---
src/mirror.rs | 3 ++-
src/subscription.rs | 13 +++--
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/src/mirror.rs b/src/mirror.rs
index
Signed-off-by: Lukas Wagner
---
docs/command-syntax.rst | 3 +++
docs/offline-mirror.rst | 24
2 files changed, 27 insertions(+)
diff --git a/docs/command-syntax.rst b/docs/command-syntax.rst
index bd91d46..272e6bd 100644
--- a/docs/command-syntax.rst
+++ b/docs
Tested-by: Lukas Wagner
On 11/10/22 14:24, Stefan Hrdlicka wrote:
V1 -> V2:
# pve-storage
* formating change
* fixing typos & wording
* added check if dRAID options draidspares & draiddata are used for something
else then setting up a dRAID
# pve-manager
* add a viewModel and us
"the following two are ident" --> "the following two are identical"
Signed-off-by: Lukas Wagner
---
pve-firewall.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pve-firewall.adoc b/pve-firewall.adoc
index f59c302..b759b91 100644
--- a/pve-
Signed-off-by: Lukas Wagner
---
asciidoc/dblatex-custom.sty| 2 +-
pve-admin-guide-docinfo.xml.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/asciidoc/dblatex-custom.sty b/asciidoc/dblatex-custom.sty
index ba4a508..6b2578c 100644
--- a/asciidoc/dblatex-custom.sty
801 - 894 of 894 matches
Mail list logo
