[pve-devel] applied: [PATCH stable-7 manager 2/2] pve7to8: avoid confusing warning about required setting 'storage' for vzdump

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 17:02 schrieb Fiona Ebner: > It's required in the schema for notes-template and protected, but when > parsing vzdump.conf, it shouldn't matter whether the storage parameter > is set or not. > > The warning is ugly and users might interpret it as something that > needs to be acted

[pve-devel] applied: [PATCH stable-7 manager 1/2] pve7to8: remove outdated warning about retention

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 17:02 schrieb Fiona Ebner: > It just talks about the default behavior since PVE 7. It's rather > confusing to mention this, because the behavior doesn't change anymore > in PVE 8. > > Signed-off-by: Fiona Ebner > --- > > Intended for both master and stable-7. > > PVE/CLI/pve7t

[pve-devel] applied: [PATCH pve-installer] tui: improve ipv6 handling

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 16:16 schrieb Stefan Hanreich: > * fix detection of ipv6 addresses > * change input for CIDR to allow integers up until 128 > > Signed-off-by: Stefan Hanreich > --- > proxmox-tui-installer/src/utils.rs | 2 +- > proxmox-tui-installer/src/views/mod.rs | 6 +++--- > 2 files ch

[pve-devel] applied: [PATCH 0/3] adapt to systemd-boot hooks in bookworm

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 16:32 schrieb Stoiko Ivanov: > This patchset addresses the change of shipping systemd-boot as separate > binary packge introduced with Debian Bookworm. > > The patches are mostly cosmetic in nature - since they silence warnings, > which look scary, but don't hurt functionality. >

Re: [pve-devel] [PATCH installer] tui: multiply the disk size back into bytes

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 16:00 schrieb Stefan Sterz: > previously the installer correctly divided the value when using them > for the `FloatEditView`, but forgot to multiply the value again when > retrieving it after editing. this commit fixes that > > Signed-off-by: Stefan Sterz > --- > tested this only

Re: [pve-devel] [PATCH 2/2] tui: verify email with basic regex

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 14:30 schrieb Dominik Csapak: > regex copied from perl gui installer > > Signed-off-by: Dominik Csapak > --- > this needs librust-regex-dev as build-dependency > proxmox-tui-installer/Cargo.toml | 1 + > proxmox-tui-installer/src/main.rs | 8 > 2 files changed, 9 inser

[pve-devel] applied: [PATCH manager] api: resource usb mapping: add missing proxyto_callback

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 12:05 schrieb Dominik Csapak: > i have added it to the pci api call, but forgot to add it for usb > otherwise adding a mapped usb device only works on the node where the > gui is connected to > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Cluster/Mapping/USB.pm | 5 + >

[pve-devel] applied: [PATCH installer] gui: make abort button unsensitive on last panel

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 11:57 schrieb Maximiliano Sandoval: > It makes no sense from a UX point of view to abort an install that's > already finished. > > Signed-off-by: Maximiliano Sandoval > --- > proxinstall | 5 + > 1 file changed, 5 insertions(+) > > applied, thanks! (albeit it's a bit scar

Re: [pve-devel] [PATCH pve-installer] tui: read correct input for DNS server address

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 12:46 schrieb Stefan Hanreich: > Currently the TUI installer reads the value for the DNS server from > the field for the gateway. > Many thanks for the patch-as-report approach, but Christoph already provided this one after I noticed it off-list, and I pushed that (looks exactly

[pve-devel] applied-series: [PATCH-SERIES qemu-server/manager] restore PVE 7 default for cloudinit package upgrades

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 12:04 schrieb Fiona Ebner: > Commit efa3355d ("fix #3428: cloudinit: add parameter for upgrade on > boot") changed the default, but this is a breaking change. The bug > report was only about making the option configurable. > > The commit doesn't give an explicit reason for why, an

Re: [pve-devel] [PATCH installer] tui: Add a cancel button to Advanced bootdisk options

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 11:16 schrieb Maximiliano Sandoval: > This matches the GUI installer which counts with a close (x) button. > > Signed-off-by: Maximiliano Sandoval > --- > proxmox-tui-installer/src/views/bootdisk.rs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/proxmox-tui-installer/

Re: [pve-devel] [PATCH installer] gui: make abort button focusable

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 12:02 schrieb Maximiliano Sandoval: > GtkWiget:can-focus=false means that the user cannot use tab or key > navigation to interact with this button. > that's not true, as Do the Alt + A combination works just fine here. And not having it in the default focusing "group" is definiti

[pve-devel] applied: [PATCH v2 installer 1/1] fix #4643: show a confirmation dialog when clicking abort

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 10:55 schrieb Maximiliano Sandoval: > Note that unlike the rest of the file, we connect to the response signal > instead of using Gtk3::Dialog->run, the reason is that run blocks the > main loop used by GTK and this undesirable to the point where > Gtk3::Dialog->run was removed for

[pve-devel] applied: [PATCH manager v2 1/5] ui: resource map tree: make 'ok' status clearer

2023-06-21 Thread Thomas Lamprecht
Am 21/06/2023 um 09:41 schrieb Dominik Csapak: > by changing into 'mapping matches host data' which indicates that the > configured values matches the host information > > also for the pci and usb map selectors > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/PCIMapSelector.js | 2 +

[pve-devel] applied: [PATCH manager 1/2] api: ceph: remove deprecrated Pools path

2023-06-21 Thread Thomas Lamprecht
Am 15/06/2023 um 09:39 schrieb Aaron Lauterer: > The replacement is Pool (singular). > > Signed-off-by: Aaron Lauterer > --- > PVE/API2/Ceph.pm | 7 - > PVE/API2/Ceph/Makefile | 1 - > PVE/API2/Ceph/Pools.pm | 766 - > 3 files changed, 774 deleti

[pve-devel] applied: [PATCH qemu-server 1/2] restore: refactor archive parsing

2023-06-20 Thread Thomas Lamprecht
Am 20/06/2023 um 09:41 schrieb Fabian Grünbichler: > to avoid duplicate work, always set 'volid' to the backup volume's volid, if > it > was successfully parsed as such. > > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Qemu.pm | 16 > 1 file changed, 8 insertions(+), 8 de

Re: [pve-devel] [PATCH installer] remove nonexistent file from makefile

2023-06-20 Thread Thomas Lamprecht
Am 20/06/2023 um 10:42 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > Proxmox/Makefile | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Proxmox/Makefile b/Proxmox/Makefile > index d49da80..6360064 100644 > --- a/Proxmox/Makefile > +++ b/Proxmox/Makefile > @@ -

[pve-devel] applied-series: [PATCH manager 1/5] ui: fix pci map selector status column

2023-06-19 Thread Thomas Lamprecht
Am 19/06/2023 um 11:13 schrieb Dominik Csapak: > the 'errors' property changed to 'checks' so we have to adapt here too > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/PCIMapSelector.js | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > applied series, thank

[pve-devel] applied: [PATCH installer 0/2] Close app gracefully

2023-06-19 Thread Thomas Lamprecht
Am 16/06/2023 um 12:57 schrieb Maximiliano Sandoval: > We make sure that the Glib main loop is closed before exiting the application. > > Ideally all of this, among other things, is handled automatically when using > Gtk3::ApplicationWindow and Glib::IO::Application->run(), but that needs > https:

[pve-devel] applied: [PATCH installer 0/4] Drop deprecated GTK 3 methods

2023-06-19 Thread Thomas Lamprecht
Am 15/06/2023 um 14:14 schrieb Maximiliano Sandoval: > Small series of patches to drop the use of properties and methods that were > deprecated in GTK 3. > > Maximiliano Sandoval (4): > stop using Gtk3::Misc->set_alignment > stop using Gtk3::HBox and Gtk3::VBox > stop using Gtk3::HSeparator

[pve-devel] applied: [PATCH qemu-server/manager/docs v7] cluster mapping

2023-06-19 Thread Thomas Lamprecht
Am 16/06/2023 um 15:05 schrieb Dominik Csapak: > pve-manager: > > Dominik Csapak (14): > api: add resource map api endpoints for PCI and USB > ui: parser: add helper for lists of property strings > ui: form/USBSelector: make it more flexible with nodename > ui: form: add PCIMapSelector >

[pve-devel] applied: [PATCH docs v7 1/1] qemu: add documentation about cluster device mapping

2023-06-19 Thread Thomas Lamprecht
Am 16/06/2023 um 15:05 schrieb Dominik Csapak: > explain why someone would want it, how to configure and which privileges > are necessary > > Signed-off-by: Dominik Csapak > --- > changes from v6: > * added small note about only one usb device per node per map > > qm-pci-passthrough.adoc | 8 +

Re: [pve-devel] [PATCH-SERIES v6 qemu-server/manager] add and set x86-64-v2-AES as default model for new vms

2023-06-19 Thread Thomas Lamprecht
Am 08/06/2023 um 11:51 schrieb Alexandre Derumier: > Here the new builtin models: > > > x86-64-v1 : not implemented, as it's basicaly qemu64|kvm64 -vme,-cx16 for > compat Opteron_G1 from 2004 > so will use it as qemu64|kvm64 is higher are not working on > opteron_g1 anyway > > x86-

[pve-devel] partially-applied: [PATCH qemu-server/manager/docs v7] cluster mapping

2023-06-18 Thread Thomas Lamprecht
Am 16/06/2023 um 15:05 schrieb Dominik Csapak: > qemu-server: > > Dominik Csapak (7): > usb: refactor usb code and move some into USB module > enable cluster mapped USB devices for guests > enable cluster mapped PCI devices for guests > check_local_resources: extend for mapped resources >

[pve-devel] applied: [PATCH 1/2] disk api: avoid using unrelated Datastore.Audit priv for disk management

2023-06-17 Thread Thomas Lamprecht
, which is the correct one here, this is for node specific (HW) details, not some config for accessing datastore in a restricted way. This is a step in splitting the disk manage code out of the pve-storage package, and maybe even repository. Signed-off-by: Thomas Lamprecht --- src/PVE/API

[pve-devel] applied: [PATCH 2/2] disk api: only ask for Datastore.Allocate if adding to storage config

2023-06-17 Thread Thomas Lamprecht
e Sys. space, e.g., Sys.Disk.Use or the like. This is a step in splitting the disk manage code out of the pve-storage package, and maybe even repository Signed-off-by: Thomas Lamprecht --- src/PVE/API2/Disks/Directory.pm | 10 -- src/PVE/API2/Disks/LVM.pm | 10 -- src/PVE

[pve-devel] applied: [PATCH] smartmontools.default: add `-q never` to smartd_opts

2023-06-16 Thread Thomas Lamprecht
Am 16/06/2023 um 14:22 schrieb Stoiko Ivanov: > smartmontools has the option to run as 'notify' type systemd.service > (see `smartd(8)` in bookworm and later), and debian-upstream uses > this. > If a system has no monitorable disks (observed in a HP DL380g8, where > smartd does not seem to work by

Re: [pve-devel] [PATCH v2 container 1/1] pct gentoo plugin fix for systemd

2023-06-16 Thread Thomas Lamprecht
Am 08/05/2023 um 15:49 schrieb Jorge Ventura: > --- > Create variable 'inittype' in the class Gentoo to establish 'openrc' or > 'systemd' procedure and implement in self_init the logic for 'inittype' based > on 'systemd' in the '/sbin/init' symlink. > For self->{inittype} = 'openrc', the previous

[pve-devel] applied: [PATCH widget-toolkit] window: addtotp: Increase the size of the quiet zone

2023-06-16 Thread Thomas Lamprecht
Am 13/06/2023 um 15:32 schrieb Maximiliano Sandoval: > It is recommended that the quiet zone has the width of 4 blocks, since > each block is around 4 pixels each, we need a margin of 16 pixels and a > size of 256 + 2 * 16 pixels. > > Signed-off-by: Maximiliano Sandoval > --- > src/window/AddTot

[pve-devel] applied: [PATCH v2 widget-toolkit] apt repositories: add production ready warnings for Ceph repositories

2023-06-16 Thread Thomas Lamprecht
Am 16/06/2023 um 15:42 schrieb Fiona Ebner: > Could've been done for the test repository already, but now that there > is a split between no-subscription and enterprise it becomes even more > relevant. > > Reported-by: Thomas Lamprecht > Signed-off-by: Fiona Ebner &

[pve-devel] applied: [PATCH cluster 1/1] datacenter config: turn shutdown policy into a standard option

2023-06-16 Thread Thomas Lamprecht
Am 16/06/2023 um 13:33 schrieb Fiona Ebner: > to be re-used by the node/status API endpoint. > > Signed-off-by: Fiona Ebner > --- > src/PVE/DataCenterConfig.pm | 50 +++-- > 1 file changed, 26 insertions(+), 24 deletions(-) > > this doesn't hurt in any case, so:

[pve-devel] applied-series: [PATCH manager 1/2] pve7to8: refactor user.cfg loop

2023-06-16 Thread Thomas Lamprecht
Am 13/06/2023 um 13:50 schrieb Fabian Grünbichler: > next patch adds acl-related checks > > Signed-off-by: Fabian Grünbichler > --- > PVE/CLI/pve7to8.pm | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > seems I forgot to reply on those two, so: applied both pa

Re: [pve-devel] [PATCH v4 qemu-server 2/12] qemuserver: foreach_volid: include pending volumes

2023-06-16 Thread Thomas Lamprecht
Am 16/06/2023 um 14:25 schrieb Fiona Ebner: >> @@ -4902,6 +4904,11 @@ sub foreach_volid { >> }; >> >> PVE::QemuConfig->foreach_volume_full($conf, $include_opts, $test_volid); >> + >> +if ($include_pending && defined($conf->{pending}) && >> $conf->{pending}->%*) { >> +PVE::QemuC

Re: [pve-devel] applied: [PATCH common] schema: explicitly set min/max for vmid option

2023-06-16 Thread Thomas Lamprecht
Am 16/06/2023 um 11:01 schrieb Fiona Ebner: >> let's see if we ever used values < 100 as some special thingy somwhere 😜 >> (if, those things should probably just switch to another format) > > Even if, the problem is limited to cases where the format verification > wouldn't be done, but the min/max

[pve-devel] applied: [PATCH common] schema: explicitly set min/max for vmid option

2023-06-16 Thread Thomas Lamprecht
Am 16/06/2023 um 09:35 schrieb Fiona Ebner: > The associated pve_verify_vmid() method already restricts the value > to this range, but this wouldn't be visible in the API viewer for > example [0]. > > The verify method is also called by qemu-server's qmextract, so it's > not possible to just drop

[pve-devel] applied: [PATCH proxmox-backup 0/3] file-restore: set arc limits correctly

2023-06-15 Thread Thomas Lamprecht
Am 15/06/2023 um 12:42 schrieb Stoiko Ivanov: > The first two patches fix the setting of zfs_arc_min and zfs_arc_max via > the kernel commandline - afaics they should not have been honored until > now - verification was done in the debug-image by inspecting > `grep '^c_' /proc/spl/kstat/zfs/arcstat

[pve-devel] applied: [PATCH manager stable-7] pve7to8: content-dirs check: skip paths that cannot be resolved

2023-06-15 Thread Thomas Lamprecht
Am 15/06/2023 um 15:22 schrieb Friedrich Weber: > The current inequality check for content-dirs does not correctly > handle the case in which `abs_path` returns undef. This can result in > confusing warnings: > > storage [...] uses directory for multiple content types [...] > > Fix this by ski

Re: [pve-devel] [PATCH RFC common] fix #4778: fix boolean type check for json parameters over the api

2023-06-15 Thread Thomas Lamprecht
Am 15/06/2023 um 13:12 schrieb Dominik Csapak: > On 6/15/23 11:51, Wolfgang Bumiller wrote: >> On Thu, Jun 15, 2023 at 11:32:15AM +0200, Dominik Csapak wrote: >>> if a real json boolean is sent via the api, $value is a >>> JSON::PP::Boolean here instead of a string/scalar >>> >>> so we should valid

[pve-devel] applied: [PATCH v2 storage] api: config: add/update storage: check for type mismatch first

2023-06-15 Thread Thomas Lamprecht
Am 12/06/2023 um 16:27 schrieb Fiona Ebner: > This avoids confusing errors about other properties when the storage > type doesn't match. By highlighting that the type doesn't match, users > should know right away what the issue is. > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > *

[pve-devel] applied: [PATCH storage] content-dirs check: silently skip paths that cannot be resolved

2023-06-15 Thread Thomas Lamprecht
Am 15/06/2023 um 13:36 schrieb Friedrich Weber: > Since commit 8e623a2930f7aee4b3309b1f297613a250ee4698, the inequality > check for content-dirs prints a warning if a content directory path > could not be resolved, i.e., if `abs_path` returns undef. Among other > things, `abs_path` returns undef if

[pve-devel] applied-series: [PATCH qemu 1/2] regenerate patches

2023-06-15 Thread Thomas Lamprecht
Am 15/06/2023 um 13:38 schrieb Fiona Ebner: > There's still some context changes not covered by earlier series. No > functional change intended. > > Signed-off-by: Fiona Ebner > --- > ...VE-add-savevm-async-for-background-state-snapshots.patch | 4 ++-- > .../pve/0020-PVE-Add-dummy-id-command-li

[pve-devel] applied: [PATCH common] syslog: interpret priority level 'warn' correctly

2023-06-14 Thread Thomas Lamprecht
mply allow 'warn' as a priority too. > > Suggested-by: Thomas Lamprecht > Signed-off-by: Fiona Ebner > --- > src/PVE/SafeSyslog.pm | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > applied, thanks! ___

[pve-devel] applied-series: [PATCH manager v2 1/4] ui: realm sync edit: improve ux when there is no ldap/ad realm

2023-06-14 Thread Thomas Lamprecht
Am 13/06/2023 um 10:43 schrieb Dominik Csapak: > by adding an empty text to the dropdown, and disabling the other > possibly invalid fields, so that it's clear why the panel is invalid > > as soon as there is an ldap/ad realm, it gets autoselected anyway and > the fields get re-enabled. > > Signe

[pve-devel] applied-series: [PATCH container v2 0/2] add test for LXC_NAME hosts entry and fix a minor glitch

2023-06-14 Thread Thomas Lamprecht
Am 14/06/2023 um 14:33 schrieb Stoiko Ivanov: > v1->v2: > * actually added the /etc/hosts from an alpine template (seems I > fat-fingered a cp iniially) for patch 2 - sorry for the fuzz > > original cover-letter for v1: > the patch from: > https://lists.proxmox.com/pipermail/pve-devel/2023-June/

[pve-devel] applied: [PATCH manager] fix #4739: ui: add group column in user list

2023-06-14 Thread Thomas Lamprecht
Am 14/06/2023 um 14:31 schrieb Dominik Csapak: > to get a fast overview in which groups each user is. > > for that we need to add the 'full=1' parameter. > > this only tokens/groups to the api call, but we have that info in the > backend after parsing the config anyway, so it should not be very >

Re: [pve-devel] [PATCH guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property

2023-06-14 Thread Thomas Lamprecht
Am 14/06/2023 um 14:51 schrieb Fiona Ebner: > Am 13.06.23 um 15:42 schrieb Alexander Zeidler: >> Signed-off-by: Alexander Zeidler >> --- >> src/PVE/VZDump/Common.pm | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm >> index a6fe4

[pve-devel] applied: [PATCH docs] Update and extend permission documentation

2023-06-14 Thread Thomas Lamprecht
Am 14/06/2023 um 13:08 schrieb Fabian Grünbichler: > adapt to recent changes: > - PVESDNUser role, SDN.Use privilege > - Permissions.Modify no longer part of PVESysAdmin and PVEAdmin > - PVE reserved prefix for builtin roles > > and add some notes and warnings about dangerous aspects of permission

Re: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"

2023-06-14 Thread Thomas Lamprecht
Am 14/06/2023 um 13:28 schrieb Aaron Lauterer: > This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15. > > The bug should be fixed by now [0]. The reproducer doesn't cause any > issues in my tests. > > [0] https://github.com/openzfs/zfs/issues/8541 hmm, torn on this one; 1 MB aligned ima

[pve-devel] applied: [PATCH qemu-server] status: fix description of qmpstatus property

2023-06-14 Thread Thomas Lamprecht
Am 03/03/2023 um 08:35 schrieb Fiona Ebner: > Using the word 'agent' is highly confusing here as there is no QMP > agent and thus wrongly suggests that the value is related to the > guest agent[0]. > > [0]: https://forum.proxmox.com/threads/123590/post-537716 > > Signed-off-by: Fiona Ebner > ---

Re: [pve-devel] [PATCH container 2/2] tests: add minimal test for LXC_NAME hosts entry

2023-06-14 Thread Thomas Lamprecht
Am 14/06/2023 um 12:43 schrieb Stoiko Ivanov: > +++ b/src/test/test-alpine-003/etc/hosts > @@ -0,0 +1,5 @@ > +127.0.0.1localhost localhost.localdomain > +::1 localhost localhost.localdomain Misses the "LXC_NAME" line we want to test that it gets removed? > +# --- BEGIN PVE --- > +12

Re: [pve-devel] [PATCH container] setup: template_fixup: remove bogus LXC_NAME line from /etc/hosts

2023-06-13 Thread Thomas Lamprecht
Am 09/06/2023 um 19:36 schrieb Stoiko Ivanov: > diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm > index 5534397..2d14599 100644 > --- a/src/PVE/LXC/Setup/Base.pm > +++ b/src/PVE/LXC/Setup/Base.pm > @@ -841,4 +841,15 @@ sub remove_pve_sections { > return $data =~ s/^\h*\Q$hea

[pve-devel] applied: [PATCH container] setup: template_fixup: remove bogus LXC_NAME line from /etc/hosts

2023-06-13 Thread Thomas Lamprecht
Am 09/06/2023 um 19:36 schrieb Stoiko Ivanov: > Templates not built directly by us, but redistributed from > images.linuxcontainer.org contain the following line in /etc/hosts: > `127.0.1.1 LXC_NAME` > > While it is mostly cosmetic - LXC_NAME, contains an underscore and is > not a valid DNS

[pve-devel] applied-series: [PATCH zfsonlinux 0/2] update to 2.1.12

2023-06-13 Thread Thomas Lamprecht
Am 13/06/2023 um 11:57 schrieb Stoiko Ivanov: > ZFS 2.1.12 got released one week ago [0]. > > Some commits fix data-corruption with mmap on rollback or clone. > The issue with mountpoint=legacy mounts for rpool in Proxmox VE were > addressed by reverting the change that introduced it [1]. > > Pot

[pve-devel] applied: [PATCH v2 ha-manager 1/2] tests: simulate stale maintainance node caused by simultaneous cluster shutdown

2023-06-13 Thread Thomas Lamprecht
Am 12/06/2023 um 17:27 schrieb Fiona Ebner: > In the test log, it can be seen that the service will unexpectedly be > migrated back. This is caused by the service's maintainance node > property being set by the initial shutdown, but never cleared, because > that currently happens only when the serv

[pve-devel] applied: [PATCH v2 ha-manager 2/2] manager: clear stale maintenance node caused by simultaneous cluster shutdown

2023-06-13 Thread Thomas Lamprecht
Am 12/06/2023 um 17:27 schrieb Fiona Ebner: > Currently, the maintenance node for a service is only cleared when the > service is started on another node. In the edge case of a simultaneous > cluster shutdown however, it might be that the service never was > started anywhere else after the maintena

Re: [pve-devel] appllied: [PATCH] read firstline: only map ENOENT to undef, raise error otherwise

2023-06-12 Thread Thomas Lamprecht
Am 13/06/2023 um 07:27 schrieb Dietmar Maurer: >> One could argue that the case for not existent should return undef, >> while an empty file should return an empty string, but for that we >> might want to check all use-sites first. > > AFAIR I use this function many times assuming that it does not

[pve-devel] appllied: [PATCH] read firstline: only map ENOENT to undef, raise error otherwise

2023-06-12 Thread Thomas Lamprecht
might want to check all use-sites first. Signed-off-by: Thomas Lamprecht --- src/PVE/Tools.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 174ded8..2d728f8 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -291,7 +291,10

[pve-devel] applied: [PATCH manager stable-7] pve7to8: add check for nvidia-vgpu-mgr

2023-06-12 Thread Thomas Lamprecht
Am 12/06/2023 um 12:00 schrieb Dominik Csapak: > Currently the nvidia vgpu host driver (15.2) does not support kernels > > 6.0 and thus will not work with bookworm based releases for now. > > Fail when the service is running, and warn if it only exists, but is > disabled/stopped (in case a user in

Re: [pve-devel] [PATCH qemu-server] fix #4549: capture and bubble up qemu errors correctly

2023-06-12 Thread Thomas Lamprecht
Am 12/06/2023 um 13:22 schrieb Fiona Ebner: > Am 09.05.23 um 10:46 schrieb Christoph Heiss: >> @@ -5922,13 +5916,19 @@ sub vm_start_nolock { >> $tpmpid = start_swtpm($storecfg, $vmid, $tpm, $migratedfrom); >> } >> >> +# '\r\n' needs to be used as a line separator her

[pve-devel] applied: [PATCH v2 manager] pve7to8: Improve systemd unified cgroupv2 support check

2023-06-12 Thread Thomas Lamprecht
Am 12/06/2023 um 12:31 schrieb Christian Ebner: > Checking /lib/systemd if it is present and a directory is not enough, as > the shared object file used to check the version might nevertheless be > located at /usr/lib/systemd, or under /usr/lib/x86_64-linux-gnu/systemd. > So check also the latter p

[pve-devel] applied: Re: [PATCH http-server] proxy request: handle missing content-type header

2023-06-09 Thread Thomas Lamprecht
On 09/06/2023 18:11, Stoiko Ivanov wrote: > In case the actual request-body is empty it seems not Content-Type > header is set by browsers. > > Tested on a vm with stopping and starting a container via GUI > (/api2/extjs/nodes//lxc//status/stop) > > fixes f398a3d94bb5c798e1e1ea91113cd76648dd79eb

[pve-devel] applied: Re: [PATCH container] setup: systemd-network: use correct values for dhcp-modes

2023-06-09 Thread Thomas Lamprecht
On 09/06/2023 15:05, Stoiko Ivanov wrote: > the change from v4->ipv4 happened 2015 in systemd commit > cb9fc36a1211967e8c58b0502a26c42552ac8060 - so by now it should be > safe to replace it for all containers relying on systemd-networkd. yeah, especially as cgroup v2 switch brought us some lower b

[pve-devel] applied-series: Re: [PATCH widget-toolkit 1/2] apt repositories: fix typo for getting the default unknown text

2023-06-09 Thread Thomas Lamprecht
On 09/06/2023 16:16, Fiona Ebner wrote: > Could lead to a type error with classifyOrigin when there is a > repository that doesn't have an InRelease file and cannot be detected > as Debian/Proxmox origin from its URL. For me, it triggered with the > element.io repository after changing to bookworm

Re: [pve-devel] [PATCH storage] api: config: add/update storage: check for type mismatch first

2023-06-09 Thread Thomas Lamprecht
On 09/06/2023 15:45, Fiona Ebner wrote: > This avoids confusing errors about other properties when the storage > type doesn't match. By highlighting that the type doesn't match, users > should know right away what the issue is. > > Signed-off-by: Fiona Ebner > --- > src/PVE/API2/Storage/Config.p

[pve-devel] Proxmox VE 8.0 (beta) released!

2023-06-09 Thread Thomas Lamprecht
you for getting involved! -- Best Regards, Thomas Lamprecht ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] ui: qemu: show progress bar for resize task

2023-06-09 Thread Thomas Lamprecht
On 09/06/2023 10:25, Fiona Ebner wrote: > The API call was changed to spawn a task now. > > Signed-off-by: Fiona Ebner > --- > > Dependency bump for qemu-server needed. > > www/manager6/qemu/HDResize.js | 4 > 1 file changed, 4 insertions(+) > > applied, thanks! __

Re: [pve-devel] [PATCH stable-7 access-control 1/2] access control: add /sdn/zones/// path

2023-06-09 Thread Thomas Lamprecht
> (cherry picked from commit 4d5b0937a3497282aae4d3e8fafbe519c9ef4ea2) > > Signed-off-by: Fabian Grünbichler > --- > src/PVE/AccessControl.pm | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) for both: Acked-by: Thomas Lamprecht Reviewed-by: Thomas Lamprecht __

[pve-devel] applied: Re: [PATCH container] network permissions: implement checks

2023-06-09 Thread Thomas Lamprecht
On 09/06/2023 09:51, Fabian Grünbichler wrote: > when creating a new container > when restoring a backup > when cloning a container > and obviously, when changing the nics of an existing container > > Signed-off-by: Fabian Grünbichler > --- > src/PVE/API2/LXC.pm | 12 +++- > src/PVE/LX

[pve-devel] applied: [PATCH qemu-server] qm: remote migration: improve error when storage cannot be found

2023-06-09 Thread Thomas Lamprecht
On 09/06/2023 09:37, Fiona Ebner wrote: > It can also be a permission issue, so the current error can be > a bit confusing. > > Reported in the community forum: > https://forum.proxmox.com/threads/120619/post-562660 > > Signed-off-by: Fiona Ebner > --- > PVE/CLI/qm.pm | 2 +- > 1 file changed,

Re: [pve-devel] applied: Re: [PATCH v4 qemu-server 1/1] api2: add check_bridge_access for create/update/clone/restore vm

2023-06-09 Thread Thomas Lamprecht
On 09/06/2023 09:14, DERUMIER, Alexandre wrote: > Or Maybe, we should simply warn && remove the netX from the restore config ? > (I'm thinking about old backup with older non existing bridge anymore or > coming from another cluster, where user couldn't have any permissions) I think the whole UX

Re: [pve-devel] applied: Re: [PATCH v4 qemu-server 1/1] api2: add check_bridge_access for create/update/clone/restore vm

2023-06-09 Thread Thomas Lamprecht
On 09/06/2023 09:00, DERUMIER, Alexandre wrote: > Le jeudi 08 juin 2023 à 18:02 +0200, Thomas Lamprecht a écrit : >> On 07/06/2023 14:03, Alexandre Derumier wrote: >>> Signed-off-by: Alexandre Derumier >>> --- >>>  PVE/API2/Qemu.pm | 33 +

[pve-devel] applied: Re: [PATCH container 1/1] config: implement method to calculate derived properties from a config

2023-06-08 Thread Thomas Lamprecht
On 28/02/2023 11:54, Fiona Ebner wrote: > See the corresponding commit in guest-common for more information. > > Signed-off-by: Fiona Ebner > --- > src/PVE/LXC/Config.pm | 12 > 1 file changed, 12 insertions(+) > > applied, thanks! ___

[pve-devel] applied: Re: [PATCH v4 qemu-server 1/1] api2: add check_bridge_access for create/update/clone/restore vm

2023-06-08 Thread Thomas Lamprecht
On 07/06/2023 14:03, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > PVE/API2/Qemu.pm | 33 + > 1 file changed, 29 insertions(+), 4 deletions(-) > > applied, with Fabians R-b, thanks. Made a follow-up moving the checker method to QemuServer

[pve-devel] applied: Re: [PATCH qemu-server 1/1] config: implement method to calculate derived properties from a config

2023-06-08 Thread Thomas Lamprecht
On 28/02/2023 11:54, Fiona Ebner wrote: > See the corresponding commit in guest-common for more information. > > Signed-off-by: Fiona Ebner > --- > PVE/QemuConfig.pm | 16 > 1 file changed, 16 insertions(+) > > applied, thanks! ___

[pve-devel] partially-applied-series: [PATCH-SERIES v2 qemu-server/qemu] Some breaking QEMU changes

2023-06-07 Thread Thomas Lamprecht
Am 24/05/2023 um 15:56 schrieb Fiona Ebner: > First one is dropping the custom get_link_status QMP command which I > could not find any users for. > > Second one is dropping left-over, custom, deprecated QMP commands for > drive snapshotting. > > Third one is dropping the dummy id CLI parameter,

[pve-devel] applied: [PATCH guest-common 1/1] abstract config: add method to calculate derived properties from a config

2023-06-07 Thread Thomas Lamprecht
Am 28/02/2023 um 11:54 schrieb Fiona Ebner: > HA manager currently needs to know about internal details about the > configs and how the properties are calculated. With this method, those > details are abstracted away, allowing to change the configuration > structure. In particular, QemuConfig's 'me

[pve-devel] applied: [PATCH qemu-server] cloudinit: pass through hostname via fqdn field

2023-06-07 Thread Thomas Lamprecht
Am 23/05/2023 um 09:14 schrieb Leo Nunner: > If no FQDN is provided, we simply set it to the current hostname. This > ensures that the hostname *really* gets set, since we encountered an > issue on Fedora and CentOS based systems where no hostname got set at > all. > > When there's no FQDN set in

[pve-devel] applied: [PATCH manager] ui: ceph: pool: add pool number as column

2023-06-07 Thread Thomas Lamprecht
Am 22/03/2023 um 10:23 schrieb Aaron Lauterer: > The pool number is shown in a few places, having it easily accessible > can help to understand which pool a warning/error refers to. > > For example, the PG ID consists of '{pool nr}.{pg nr}' and is shown in > every warning concerning that PG. > >

[pve-devel] applied-series: [PATCH-SERIES qemu-server/manager/container] resize endpoint improvements

2023-06-07 Thread Thomas Lamprecht
Am 30/05/2023 um 15:52 schrieb Fiona Ebner: > Note that qemu-server path 2/2 is a breaking API change. > > qemu-server: > > Fiona Ebner (2): > fix #517: api: allow resizing qcow2 disk with snapshots > fix #2315: api: have resize endpoint spawn a worker task > > PVE/API2/Qemu.pm | 15 +++

[pve-devel] applied: [PATCH v2 guest-common] vzdump: config: improve description of ionice setting

2023-06-07 Thread Thomas Lamprecht
Am 07/06/2023 um 16:54 schrieb Fiona Ebner: > The CFQ scheduler was removed with Linux 5.0 and ionice is now used > by the newer BFQ scheduler. Mention what the special value 8 does. > Also mention that for snapshot and suspend mode backups of VMs, the > setting only affects the compressor, because

[pve-devel] applied: [PATCH guest-common v5 1/1] add PCI/USB Mapping configs

2023-06-07 Thread Thomas Lamprecht
Am 06/06/2023 um 15:52 schrieb Dominik Csapak: > adds a config file for each type of resource (usb/pci) by using a 'map' > array propertystring for each node mapping > > in each mapping we save the path(s) and some other information to detect > hardware changes (if possible) like the vendor/device

[pve-devel] applied: [PATCH access-control v5 1/1] add privileges and paths for cluster resource mapping

2023-06-07 Thread Thomas Lamprecht
Am 06/06/2023 um 15:52 schrieb Dominik Csapak: > uses the privileges: > > Mapping.Use > Mapping.Modify > Mapping.Audit > > on /mapping/{TYPE}/{id} > > so that we can assign privileges on resource level > > this will generate new roles (PVEMappingUser, PVEMappingAdmin, > PVEMappingAuditor) > >

[pve-devel] applied: [PATCH manager] api: replication job status: allow querying disabled jobs too

2023-06-07 Thread Thomas Lamprecht
Am 30/05/2023 um 13:32 schrieb Fiona Ebner: > Rather than failing with an error claiming that the job doesn't exist. > The disabled status will be visible in the result of the call. > > Signed-off-by: Fiona Ebner > --- > PVE/API2/Replication.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

[pve-devel] applied: [PATCH docs] cephfs: mention fs-name parameter

2023-06-07 Thread Thomas Lamprecht
Am 26/05/2023 um 12:10 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > pve-storage-cephfs.adoc | 5 + > 1 file changed, 5 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.pro

[pve-devel] applied: [PATCH qemu-server 1/2] fast plug options: order alphabetically

2023-06-07 Thread Thomas Lamprecht
Am 11/05/2023 um 14:30 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > PVE/QemuServer.pm | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://li

[pve-devel] applied: [PATCH qemu-server 2/2] fast plug options: add migrate_downtime and migrate_speed

2023-06-07 Thread Thomas Lamprecht
Am 11/05/2023 um 14:30 schrieb Fiona Ebner: > for convenience. These options do not influence the QEMU instance > directly, but are only used for migration, so no need to keep them in > pending. > > Signed-off-by: Fiona Ebner > --- > PVE/QemuServer.pm | 2 ++ > 1 file changed, 2 insertions(+) >

[pve-devel] applied: [PATCH qemu-server] cloudinit: fix 'pending' api endpoint

2023-06-07 Thread Thomas Lamprecht
Am 11/05/2023 um 10:03 schrieb Leo Nunner: > This patch partially reverts commit 1b5706cd168fedc5e494e24300069ee4ff25761f, > by reintroducing the old format for return values (key, value, pending, > delete), but drops the "force-delete" return value. Right now, this > endpoint does not conform to i

[pve-devel] applied: [PATCH v3 manager 1/2] ui: qga: Add option to turn off QGA fs-freeze/-thaw on backup

2023-06-07 Thread Thomas Lamprecht
Am 23/03/2023 um 12:02 schrieb Christoph Heiss: > Adds a default-on checkbox to the QEMU Guest Agent feature selector > controlling the 'fs-freeze-on-backup' option. If unchecked, an > additional warning is displayed that backups can potentially corrupt > with this setting off. > > Signed-off-by:

[pve-devel] applied: [PATCH v3 docs 2/2] Revert "qm: freeze-fs-on-backup: remove reference to GUI"

2023-06-07 Thread Thomas Lamprecht
Am 23/03/2023 um 12:02 schrieb Christoph Heiss: > This reverts commit 0025e843194130ec5223d5789fa01f916d189783. > The option is now also exposed in the GUI. > > Signed-off-by: Christoph Heiss > --- > Changes v2 -> v3: > * New patch > > qm.adoc | 5 +++-- > 1 file changed, 3 insertions(+), 2 de

[pve-devel] applied: [PATCH manager] fix #3428: cloud-init: add toggle for automatic upgrades

2023-06-07 Thread Thomas Lamprecht
Am 04/05/2023 um 12:55 schrieb Leo Nunner: > to control the newly introduced "ciupgrade" config parameter. > > Signed-off-by: Leo Nunner > --- > www/manager6/qemu/CloudInit.js | 18 ++ > 1 file changed, 18 insertions(+) > > applied, thanks! ___

[pve-devel] applied: [PATCH qemu-server] fix #3428: cloudinit: add parameter for upgrade on boot

2023-06-07 Thread Thomas Lamprecht
Am 04/05/2023 um 12:55 schrieb Leo Nunner: > up until now, we did an automatic upgrade after the first boot in our > standard cloud-init config. This has been requested to be toggleable > several times [1][2]. With this patch, "package_upgrade" is disabled by > default, and needs to be enabled manu

[pve-devel] applied: [PATCH manager/qemu-server 0/3] Cloudinit priv adaptations

2023-06-07 Thread Thomas Lamprecht
Am 03/05/2023 um 09:52 schrieb Fabian Grünbichler: > these patches adapt the Cloudinit privileges in the backend and GUI so > that just giving out "VM.Config.Cloudinit" (and, if forceful > regeneration outside of guest starts is desired, "VM.Config.CDROM") is > enough to allow an unprivileged user

Re: [pve-devel] [RFC ha-manager] manager: clear stale maintenance node in edge case

2023-06-07 Thread Thomas Lamprecht
Am 22/03/2023 um 17:21 schrieb Fiona Ebner: > where the whole cluster was shut down at the same time and the > service was never started on another node since the maintenance node > was set. > > If a user ends up in this edge case, it would be rather surprising > that the service would ignore the

Re: [pve-devel] [PATCH widget-toolkit 3/3] fix #3892: NetworkEdit: add bridge vids field for bridge_vids

2023-06-07 Thread Thomas Lamprecht
Am 02/06/2023 um 15:10 schrieb Aaron Lauterer: > What about safeguarding the vids to only be added/used if we are on PVE? > Something like `if (PVE) {`? We normally use config flags and set them only in those products that support this, that would be a bit cleaner than `typeof PVE === "object"` or

[pve-devel] applied: [PATCH manager 2/2] ui: user view: add 'Unlock TFA' button

2023-06-07 Thread Thomas Lamprecht
Am 06/06/2023 um 12:05 schrieb Wolfgang Bumiller: > Signed-off-by: Wolfgang Bumiller > --- > www/manager6/dc/UserView.js | 31 +++ > 1 file changed, 31 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-dev

[pve-devel] applied: [PATCH manager 1/2] ui: user view: show tfa lock status

2023-06-07 Thread Thomas Lamprecht
Am 06/06/2023 um 12:05 schrieb Wolfgang Bumiller: > Signed-off-by: Wolfgang Bumiller > --- > www/manager6/dc/UserView.js | 24 +++- > 1 file changed, 19 insertions(+), 5 deletions(-) > > applied, thanks! ___ pve-devel mailing lis

[pve-devel] applied: [PATCH widget-toolkit 2/2] tfa: show 'Locked' in 'Enabled' column if tfa is locked

2023-06-07 Thread Thomas Lamprecht
Am 06/06/2023 um 12:03 schrieb Wolfgang Bumiller: > Signed-off-by: Wolfgang Bumiller > --- > This one's new. > > src/panel/TfaView.js | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > applied, thanks! fwiw, as we got the info already we could show the timestamp until the

[pve-devel] applied: [PATCH v3 widget-toolkit 1/2] tfa: improve UX for recovery keys and when none are left

2023-06-07 Thread Thomas Lamprecht
Am 06/06/2023 um 12:03 schrieb Wolfgang Bumiller: > If we get an empty challenge, tell the user to contact an > administrator as it means no 2nd factors and no recovery > keys are available. > > Currently if only 1 key was available and it had a high ID, > we'd show something like: "Recovery keys

[pve-devel] applied: [PATCH v3 docs 1/1] fix #2920: add cifs options parameter

2023-06-07 Thread Thomas Lamprecht
Am 01/03/2023 um 13:13 schrieb Fiona Ebner: > From: Stefan Hrdlicka > > Signed-off-by: Stefan Hrdlicka > [FE: rebase + style fix] > Signed-off-by: Fiona Ebner > --- > > Changes from v2: > * use {pve} instead of PVE > > pve-storage-cifs.adoc | 8 > 1 file changed, 8 insertions(+)

[pve-devel] applied: [PATCH ha-manager] api: fix/add return description for status endpoint

2023-06-07 Thread Thomas Lamprecht
Am 31/05/2023 um 10:12 schrieb Fiona Ebner: > The fact that no 'items' was specified made the api-viewer throw a > JavaScript exception: retinf.items is undefined > > Signed-off-by: Fiona Ebner > --- > src/PVE/API2/HA/Status.pm | 65 ++- > 1 file changed, 64 i

<    5   6   7   8   9   10   11   12   13   14   >