Am 18/04/2024 um 10:48 schrieb Christoph Heiss:
> Do we really need _yet another_ crate dependency for that? Below is a
> check / bail! anyway when running the command proper.
>
> And if we really want a explicit check beforehand, I'd just do something
> like
>
> fn which(name: &str) -> Result<
On 2024-04-18 10:48, Christoph Heiss wrote:
Just quick three notes inline; nits other than the crate thing.
Did not review in depth, LGTM overall tho.
On Wed, Apr 17, 2024 at 02:31:08PM +0200, Aaron Lauterer wrote:
[..]
diff --git a/proxmox-autoinst-helper/Cargo.toml
b/proxmox-autoinst-he
Just quick three notes inline; nits other than the crate thing.
Did not review in depth, LGTM overall tho.
On Wed, Apr 17, 2024 at 02:31:08PM +0200, Aaron Lauterer wrote:
[..]
> diff --git a/proxmox-autoinst-helper/Cargo.toml
> b/proxmox-autoinst-helper/Cargo.toml
> index 2a88c0f..75399e0 100644
This new subcommand makes it possible to prepare an ISO to use it for an
automated installation.
It is possible to control the behavior of the resulting automated ISO
with optional parameters.
If no target file is specified, the new ISO will be named with suffixes
to indicate it as automated and a
