Re: [pve-devel] [PATCH proxmox 01/19] notify: switch to file-based templating system

2024-04-19 Thread Lukas Wagner
On 2024-04-19 10:57, Fiona Ebner wrote: > Am 19.04.24 um 10:45 schrieb Lukas Wagner: >>> Who adds the template files? I don't see a patch for proxmox-ve in this >>> series. Does this series require some versioned breaks to some package? >> >> The pve-manager and pve-ha-manager (for fencing noti

Re: [pve-devel] [PATCH proxmox 01/19] notify: switch to file-based templating system

2024-04-19 Thread Fiona Ebner
Am 19.04.24 um 10:45 schrieb Lukas Wagner: >> Who adds the template files? I don't see a patch for proxmox-ve in this >> series. Does this series require some versioned breaks to some package? > > The pve-manager and pve-ha-manager (for fencing notifications) patches add > the templates. > I can'

Re: [pve-devel] [PATCH proxmox 01/19] notify: switch to file-based templating system

2024-04-19 Thread Lukas Wagner
On 2024-04-19 10:14, Fiona Ebner wrote: > Am 09.04.24 um 15:25 schrieb Lukas Wagner: >> Instead of passing the template strings for subject and body when >> constructing a notification, we pass only the name of a template. >> When rendering the template, the name of the template is used to find

Re: [pve-devel] [PATCH proxmox 01/19] notify: switch to file-based templating system

2024-04-19 Thread Fiona Ebner
Am 09.04.24 um 15:25 schrieb Lukas Wagner: > Instead of passing the template strings for subject and body when > constructing a notification, we pass only the name of a template. > When rendering the template, the name of the template is used to find > corresponding template files. For PVE, they ar

[pve-devel] [PATCH proxmox 01/19] notify: switch to file-based templating system

2024-04-09 Thread Lukas Wagner
Instead of passing the template strings for subject and body when constructing a notification, we pass only the name of a template. When rendering the template, the name of the template is used to find corresponding template files. For PVE, they are located at /usr/share/proxmox-ve/templates/defaul