Re: [pve-devel] [PATCH v2 container] fix #4846: Avoid the outdated noacl mount option on ext4

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 10:48 schrieb Fabian Grünbichler: > On April 18, 2024 10:17 am, Thomas Lamprecht wrote: >> Am 11/04/2024 um 15:44 schrieb Fabian Grünbichler: >>> if $storage && $format eq 'raw' => no noacl ? >> >> shouldn't this branch be taken if the format is _not_ raw, as only in that >> case

Re: [pve-devel] [PATCH v2 container] fix #4846: Avoid the outdated noacl mount option on ext4

2024-04-18 Thread Fabian Grünbichler
On April 18, 2024 10:17 am, Thomas Lamprecht wrote: > Am 11/04/2024 um 15:44 schrieb Fabian Grünbichler: >> if $storage && $format eq 'raw' => no noacl ? > > shouldn't this branch be taken if the format is _not_ raw, as only in that > case it might not use ext4? > if the format is raw (presumed

Re: [pve-devel] [PATCH v2 container] fix #4846: Avoid the outdated noacl mount option on ext4

2024-04-18 Thread Thomas Lamprecht
Am 11/04/2024 um 15:44 schrieb Fabian Grünbichler: > if $storage && $format eq 'raw' => no noacl ? shouldn't this branch be taken if the format is _not_ raw, as only in that case it might not use ext4? ___ pve-devel mailing list

Re: [pve-devel] [PATCH v2 container] fix #4846: Avoid the outdated noacl mount option on ext4

2024-04-17 Thread Filip Schauer
On 11/04/2024 15:44, Fabian Grünbichler wrote: I am not sure this is correct.. or rather, wouldn't it be simpler to say if $storage && $format eq 'raw' => no noacl ? if we get complains that somebody did something non-standard (i.e., manually formatted a raw volume using a different

Re: [pve-devel] [PATCH v2 container] fix #4846: Avoid the outdated noacl mount option on ext4

2024-04-11 Thread Fabian Grünbichler
On February 23, 2024 11:48 am, Filip Schauer wrote: > Do not use the 'noacl' mount option when mounting a container disk with > an ext4 file system. The option was removed from the kernel in commit > 2d544ec923db > > The ext4 detection is based on $do_format in alloc_disk. > > Signed-off-by:

[pve-devel] [PATCH v2 container] fix #4846: Avoid the outdated noacl mount option on ext4

2024-02-23 Thread Filip Schauer
Do not use the 'noacl' mount option when mounting a container disk with an ext4 file system. The option was removed from the kernel in commit 2d544ec923db The ext4 detection is based on $do_format in alloc_disk. Signed-off-by: Filip Schauer --- src/PVE/LXC.pm | 22 -- 1