Re: [pve-devel] [RFC qemu] savevm-async: improve check for blockers

2024-05-17 Thread Thomas Lamprecht
subject might be improved by being less general/ambiguous, something like: savevm-async: improve coverage by also checking for migration blockers or savevm-async: block snapshot also if migration would fail or savevm-async: reuse migration blocker check for snapshots Would have helped me to

Re: [pve-devel] [RFC qemu] savevm-async: improve check for blockers

2024-05-17 Thread Fiona Ebner
Am 17.05.24 um 13:39 schrieb Fiona Ebner: > Same rationale as with upstream QEMU commit 5aaac46793 ("migration: > savevm: consult migration blockers"), migration and (async) snapshot > are essentially the same operation and thus snapshot also needs to > check for migration blockers. For example, th

[pve-devel] [RFC qemu] savevm-async: improve check for blockers

2024-05-17 Thread Fiona Ebner
Same rationale as with upstream QEMU commit 5aaac46793 ("migration: savevm: consult migration blockers"), migration and (async) snapshot are essentially the same operation and thus snapshot also needs to check for migration blockers. For example, this catches passed-through PCI devices, where the d