[pve-devel] [PATCH v2 pve-container 0/4] mountpoints, mkfs, vzdump changes

2015-09-03 Thread Wolfgang Bumiller
Descriptions are in the patches. As for the loop devices: this needs some more cleanup. For now I at least factored out the `losetu -j` call into its own function and changed a few parts of the code to at least use rememberd loop devices where possible and added a detach_loop_devices() function

[pve-devel] [PATCH v2 pve-container 2/4] add support to add mountpoints with pct set

2015-09-03 Thread Wolfgang Bumiller
made create_disk non-private made print_ct_mountpoint include 'mp=' unless 'nomp' is set added an mkdirs flag to mount_all create mount directories for now mountpoints simply by calling mount_all followed by umount_all --- src/PVE/API2/LXC.pm | 4 ++-- src/PVE/LXC.pm | 30

Re: [pve-devel] ceph debian jessie repo news

2015-09-03 Thread Martin Maurer
Hi Alexandre basically very good news, but this also means that we do not have packages from there for the upcoming beta2. lets see how we can workaround this, e.g. by using the packages from http://gitbuilder.ceph.com/ceph-deb-jessie-x86_64-basic/ref/ based on the history

[pve-devel] [RFC pve-container] CT protection mode added

2015-09-03 Thread Alen Grizonic
--- src/PVE/API2/LXC.pm | 3 +++ src/PVE/LXC.pm | 10 ++ 2 files changed, 13 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index d5acace..fbc2eda 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -535,6 +535,9 @@ __PACKAGE__->register_method({

[pve-devel] [RFC pve-manager v2] GUI option for VM protection added

2015-09-03 Thread Alen Grizonic
v2 changes: GUI option for CT protection added --- www/manager/lxc/Options.js | 17 + www/manager/qemu/Options.js | 17 + 2 files changed, 34 insertions(+) diff --git a/www/manager/lxc/Options.js b/www/manager/lxc/Options.js index 998602d..8461514 100644 ---

[pve-devel] ceph debian jessie repo news

2015-09-03 Thread Alexandre DERUMIER
Hi, some news from ceph teams, next packages maitenance point releases (firefly,giant,hammer) will be avaible in ceph.com repo for debien jessie and also all next release from infernalis. (so for hammer, it should be ok for V0.94.4) ___ pve-devel

[pve-devel] [PATCH v2 pve-container 3/4] support resizing of owned container disks

2015-09-03 Thread Wolfgang Bumiller
--- src/PVE/API2/LXC/Config.pm | 145 + src/PVE/LXC.pm | 36 ++- src/PVE/VZDump/LXC.pm | 18 ++ src/pct| 2 + 4 files changed, 184 insertions(+), 17 deletions(-) diff --git

Re: [pve-devel] [PATCH pve-manager] vzdump: replace 'find' exclude command switches

2015-09-03 Thread Dietmar Maurer
> -$self->find_add_exclude ('-type', 's'); # skip sockets So we cannot skip sockets now? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC pve-container 1/2] add support to add mountpoints with pct set

2015-09-03 Thread Dietmar Maurer
I wonder if mount_all() is the correct place to run mkfs? Would it make sense to do that in create_disks instead? > sub mount_all { > -my ($vmid, $storage_cfg, $conf, $format_raw_images) = @_; > +my ($vmid, $storage_cfg, $conf, $format_raw_images, $mkdirs) = @_; > > my $rootdir =

Re: [pve-devel] [PATCH 2/2] remove migration lock from config.

2015-09-03 Thread Cesar Peschiera
I guess maintain the blockade of the VM also will be necessary when the disk image is moved to other storage, also with the VM clone creation, and maybe also for other functions that now i can't deduce. But i don't know if the locking are developed for these functions . (always thinking in the

Re: [pve-devel] [RFC v3 pve-ha-manager 0/4] Adding general resource support and enhancing error behaviour

2015-09-03 Thread Dietmar Maurer
applied, thanks! On 09/02/2015 05:52 PM, Thomas Lamprecht wrote: This series adds support for diffrent service types through an plugin system. The resource class was expanded so it provides services specific methods for actions like stopping, migrating, etc... The PVEVM class was extended

Re: [pve-devel] Implement "resize" for the DRBD backend.

2015-09-03 Thread Philipp Marek
Hi Dietmar, > > > The problem is that it does not resize the underlying LVM volume. > > > > > > Do I need to install any drbdmanage updates/patches to make that work? > > > > I just scanned the drbdmanage sources, and the corresponding implementation > > is empty (always return success)? > > >

[pve-devel] [PATCH 2/2] remove migration lock from config.

2015-09-03 Thread Wolfgang Link
It is not really necessary to use the lock at migragtion. And it makes problem to remove the lock, because the config is moved and the cluster_vm list is not updated at this moment. --- src/PVE/LXC/Migrate.pm | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff

[pve-devel] [PATCH_V2 1/2] check is mounted before try to unmount disk.

2015-09-03 Thread Wolfgang Link
this is neccessay because otherwise when a storage is not mounted, like when it is offline, the migration crash. --- src/PVE/LXC.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 1c9c1a5..7de3975 100644 --- a/src/PVE/LXC.pm +++

[pve-devel] add check is_mounted before unmout storage at migration

2015-09-03 Thread Wolfgang Link
This is necessary to avoid a migration crash. it happent at the offlie migration when we try to unmount a non mounted storage. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH 2/2] remove migration lock from config.

2015-09-03 Thread Cesar Peschiera
Other thinking: 1- I have a VM in HA enabled. 2- A task of backup scheduled is in process (with the lock respective) 3- In the middle of the backup process, this server that has the VM running, breaks down. The question: Will work HA correctly for this VM? - Original Message - From:

Re: [pve-devel] [PATCH] moved from PVE::Storage:NFSPlugin to reuse the code

2015-09-03 Thread Dietmar Maurer
I added the following to ProcFSTools instead: sub read_proc_mounts { return PVE::Tools::file_get_contents("/proc/mounts"): } On 09/03/2015 08:51 AM, Wolfgang Link wrote: +sub read_proc_mounts { + +local $/; # enable slurp mode + +my $data = ""; +if (my $fd =

[pve-devel] move function read_proc_mounts

2015-09-03 Thread Wolfgang Link
we can reuse this function in other parts of the code. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH] move read_proc_mounts from NFSPlugin to Tools.

2015-09-03 Thread Wolfgang Link
this function will be uesd in more path of the code. --- PVE/Storage/NFSPlugin.pm | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/PVE/Storage/NFSPlugin.pm b/PVE/Storage/NFSPlugin.pm index 68764b7..5ba6701 100644 --- a/PVE/Storage/NFSPlugin.pm +++

[pve-devel] [PATCH] moved from PVE::Storage:NFSPlugin to reuse the code

2015-09-03 Thread Wolfgang Link
--- src/PVE/Tools.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 577a8bc..4f7efd1 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -39,6 +39,7 @@ template_replace safe_print trim extract_param +read_proc_mounts ); my

[pve-devel] [PATCH] This function checks if a moutpoint is mounted

2015-09-03 Thread Wolfgang Link
--- src/PVE/Tools.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 4f7efd1..42318ce 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -40,6 +40,7 @@ safe_print trim extract_param read_proc_mounts +is_mounted ); my

Re: [pve-devel] [RFC pve-container 2/2] destroy owned mountpoints on pct destroy

2015-09-03 Thread Dietmar Maurer
applied On 09/01/2015 04:33 PM, Wolfgang Bumiller wrote: --- src/PVE/LXC.pm | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index bf2a964..5f23532 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1263,11 +1263,12 @@ sub

Re: [pve-devel] [PATCH v2 pve-lxc] Enhance pct man page with DESCRIPTION, EXAMPLES, FILES, SEE ALSO sections

2015-09-03 Thread Dietmar Maurer
applied, thanks. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2] Add CT service support and remove type parameter

2015-09-03 Thread Dietmar Maurer
applied. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC v2 pve-container] support resizing of owned container mountpoints

2015-09-03 Thread Dietmar Maurer
On 09/02/2015 02:40 PM, Wolfgang Bumiller wrote: diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 5f23532..0544fd1 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1851,6 +1851,19 @@ sub blockdevices_list { sub find_loopdev { my ($loopdevs, $path) = @_; +if

Re: [pve-devel] Implement "resize" for the DRBD backend.

2015-09-03 Thread Dietmar Maurer
> > No. The master branch doesn't contain it because it just triggers a DRBD > > 9 bug and so wouldn't work anyway. > Just wanted to tell you that the DRBD 9 bug has been fixed in the meantime; > the DRBDmanage code will be done next, so the next (upcoming) releases of > both should have a

[pve-devel] [RFC qemu-server] VM protection mode added

2015-09-03 Thread Alen Grizonic
used to forbid a virtual machine remove operation --- PVE/API2/Qemu.pm | 11 +++ PVE/QemuServer.pm | 6 ++ 2 files changed, 17 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 20d73f7..5fc0397 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -299,6

[pve-devel] [RFC pve-manager] GUI option for VM protection added

2015-09-03 Thread Alen Grizonic
--- www/manager/qemu/Options.js | 17 + 1 file changed, 17 insertions(+) diff --git a/www/manager/qemu/Options.js b/www/manager/qemu/Options.js index 0d3e210..f5d0f80 100644 --- a/www/manager/qemu/Options.js +++ b/www/manager/qemu/Options.js @@ -237,6 +237,23 @@

[pve-devel] protection mode added

2015-09-03 Thread Alen Grizonic
added the option to forbid a VM removal -> with VM protection (mode) enabled -> adding also the LXC part as soon as possible ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-common] Added Tools::command_pipes helper

2015-09-03 Thread Wolfgang Bumiller
Helper to build chain of pipes to avoid passing long strings with quoted text to the shell. Takes an input (filename, string-reference for direct text, filehandle or pipe), an output (same options as for input), an optional stderr handle (this however can currently only be a filehandle). ---

[pve-devel] [PATCH] fix move_disk on RBD

2015-09-03 Thread Wolfgang Link
activating the disk when use RBD is necessary to have the given path. --- PVE/QemuServer.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index be53a1e..42be37b 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6276,6 +6276,8 @@ sub

[pve-devel] How long to PVE 4.0 be released??

2015-09-03 Thread Gilberto Nunes
I meant, stable release... Thanks -- Gilberto Ferreira +55 (47) 9676-7530 Skype: gilberto.nunes36 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [RFC v3 qemu-server] VM protection mode added

2015-09-03 Thread Alen Grizonic
used to prevent an unintended virtual machine remove operation v3 changes: - changed man page message - removed protection parameter (where not needed) --- PVE/API2/Qemu.pm | 3 +++ PVE/QemuServer.pm | 6 ++ 2 files changed, 9 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm

Re: [pve-devel] [RFC v2 qemu-server] VM protection mode added

2015-09-03 Thread Thomas Lamprecht
On 09/03/2015 02:35 PM, Alen Grizonic wrote: used to forbid a virtual machine remove operation v2 changes: error message --- PVE/API2/Qemu.pm | 11 +++ PVE/QemuServer.pm | 6 ++ 2 files changed, 17 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index

Re: [pve-devel] [RFC v2 qemu-server] VM protection mode added

2015-09-03 Thread Alen Grizonic
You are right. I was just checking again if it is used inside any method and I don't find any reference, so I will remove it. Thanks! On 09/03/2015 02:54 PM, Thomas Lamprecht wrote: Why does the protection parameter gets extracted here when it's never used anywhere inside this method?

[pve-devel] [RFC v2 qemu-server] VM protection mode added

2015-09-03 Thread Alen Grizonic
used to forbid a virtual machine remove operation v2 changes: error message --- PVE/API2/Qemu.pm | 11 +++ PVE/QemuServer.pm | 6 ++ 2 files changed, 17 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 20d73f7..a302d06 100644 --- a/PVE/API2/Qemu.pm +++