Re: [pve-devel] [PATCH container 0/5] Further snapshot refactoring

> Dietmar Maurer hat am 22. Februar 2016 um 16:15 > geschrieben: > > > applied, thanks. But seems you have hardoded line > numbers inside the test, so they fail after modifying snapshot-test.pm: > > ... > volume snapshot delete disabled at snapshot-test.pm line 63. > >

Re: [pve-devel] [PATCH] qemu_machine_pxe : return $machine if no pxe

applied - thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH] qemu_machine_pxe : return $machine if no pxe

Currently migration is broken, because qemu_machine_pxe return nothing if no pxe rom exist. That mean that we don't pass -machine flag to migration, and migration is broken between qemu 2.4->2.5 Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 1 + 1 file

Re: [pve-devel] [PATCH manager 2/4] parser: parseLxcMountPoint, printLxcMountPoint

applied, but we need to add the same code in manager6/Parser.js @Weihnachtsmann: It would be great to auto-generate those functions from the new declarative format option ___ pve-devel mailing list pve-devel@pve.proxmox.com

Re: [pve-devel] [PATCH manager 1/4] qemu: factor out storage selector creation for later reuse

not sure if this is worth to do - adds more confusion than it helps... ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server] Make snapshot_prepare and snapshot_commit proper subs

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] config: deal with re-added previously unused volumes

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container 0/5] Further snapshot refactoring

applied, thanks. But seems you have hardoded line numbers inside the test, so they fail after modifying snapshot-test.pm: ... volume snapshot delete disabled at snapshot-test.pm line 63. # Failed test '$@ correct' # at snapshot-test.pm line 130. # got: 'volume snapshot

[pve-devel] [PATCH manager 2/4] parser: parseLxcMountPoint, printLxcMountPoint

--- www/manager/Parser.js | 56 +++ 1 file changed, 56 insertions(+) diff --git a/www/manager/Parser.js b/www/manager/Parser.js index f6f5cf0..550e2aa 100644 --- a/www/manager/Parser.js +++ b/www/manager/Parser.js @@ -267,6 +267,62 @@

[pve-devel] [PATCH manager 1/4] qemu: factor out storage selector creation for later reuse

--- www/manager/qemu/HDEdit.js | 152 +++-- 1 file changed, 79 insertions(+), 73 deletions(-) diff --git a/www/manager/qemu/HDEdit.js b/www/manager/qemu/HDEdit.js index b8ca4e5..9677b83 100644 --- a/www/manager/qemu/HDEdit.js +++

[pve-devel] [PATCH manager 3/4] lxc: create/edit/remove mountpoints

--- www/manager/lxc/ResourceEdit.js | 242 www/manager/lxc/Resources.js| 77 - 2 files changed, 317 insertions(+), 2 deletions(-) diff --git a/www/manager/lxc/ResourceEdit.js b/www/manager/lxc/ResourceEdit.js index 3bff060..a5f935b 100644

[pve-devel] [PATCH manager 0/4] Mount point editing

Here's the first draft of the mountpoint editing GUI. Should be used with my previous pve-container patch which removes 'unused' entries when a volume gets re-added. Wolfgang Bumiller (4): qemu: factor out storage selector creation for later reuse parser: parseLxcMountPoint,

[pve-devel] [PATCH manager 4/4] lxc: use mount point editor in create wizard

--- www/manager/lxc/CreateWizard.js | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/www/manager/lxc/CreateWizard.js b/www/manager/lxc/CreateWizard.js index 53b8c57..2bf32ac 100644 --- a/www/manager/lxc/CreateWizard.js +++

[pve-devel] [PATCH qemu-server] Make snapshot_prepare and snapshot_commit proper subs

--- PVE/QemuServer.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index aad13bd..bf2c480 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5942,7 +5942,7 @@ my $snapshot_save_vmstate = sub { $snap->{machine}

[pve-devel] [PATCH v2 container 5/5] Add snapshot tests

tested so far: -snapshot_prepare -snapshot_commit -snapshot_create -snapshot_delete --- Changes to v1: skip rename of src/test/test-* to src/test/setup-* and associated change in run_setup_tests.pl, to limit noise in the patch. src/test/Makefile | 10 +-

[pve-devel] [PATCH container 4/5] Refactor snapshot_rollback

like in QemuServer.pm, but only for rootfs for now --- src/PVE/LXC.pm | 60 ++ 1 file changed, 39 insertions(+), 21 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index e34c5b4..177ef53 100644 --- a/src/PVE/LXC.pm +++

[pve-devel] [PATCH container 1/5] Adjust snapshot_create and snapshot_prepare signatures

Add new save_vmstate parameter to snapshot_create and snapshot_prepare, like in QemuServer.pm Also make snapshot_prepare and snapshot_commit proper subs. --- src/PVE/API2/LXC/Snapshot.pm | 2 +- src/PVE/LXC.pm | 18 +- src/PVE/VZDump/LXC.pm| 2 +- 3 files

[pve-devel] [PATCH container 0/5] Further snapshot refactoring

This patch series brings the signatures and logic of the following methods in line with what is used in QemuServer, with the exception of multiple volume/mp support: - snapshot_prepare and snapshot_commit - snapshot_create and snapshot_delete - snapshot_rollback It also adds an inital snapshot

[pve-devel] [PATCH container 2/5] Add snapshot_apply_config, cleanup prepare and commit

snapshot_apply_config, snapshot_prepare and snapshot_commit like in QemuServer.pm --- src/PVE/LXC.pm | 53 ++--- 1 file changed, 42 insertions(+), 11 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 2aaa6a7..b393d10 100644 ---

[pve-devel] [PATCH container 3/5] Refactor snapshot_delete

like in QemuServer.pm, but only for rootfs for now --- src/PVE/LXC.pm | 100 ++--- 1 file changed, 53 insertions(+), 47 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index b393d10..e34c5b4 100644 --- a/src/PVE/LXC.pm +++

Re: [pve-devel] Disk Image Upload

Hi Dietmar! That seems like a good solution for our problem. We are a little busy now and will implement your idea when the CeBit is over. Best regards Timo Am 20.02.2016 um 14:35 schrieb Dietmar Maurer: >> Your argument is correct, that would be the best way. >> >> But the problem for us is

Re: [pve-devel] [PATCH ha-manager v3 2/6] fix 'uninitialized value' on online node usage computation

applied. I added an additional patch on top of this to avoid the unnecessary 'started' state... ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] Update-Status / additional Information

Dear, it will been nice, when their are separate informations in the GUI when updates need urgend a reboot of the host, expl. after a CVE when the resolving need a kernel change about bug with informations, when needed, expl. only for KVM when diskdrives used or so! A Host normaly will not been

Re: [pve-devel] lasts updates : qemu live migration , missing -machine to target kvm process

adding "return $machine" at the end fix the problem for me sub qemu_machine_pxe { my ($vmid, $conf, $machine) = @_; $machine = PVE::QemuServer::get_current_qemu_machine($vmid) if !$machine; foreach my $opt (keys %$conf) { next if $opt !~ m/^net(\d+)$/; my $net =

Re: [pve-devel] lasts updates : qemu live migration , missing -machine to target kvm process

maybe in migration: sub prepare { $self->{forcemachine} = PVE::QemuServer::qemu_machine_pxe($vmid, $conf); and sub qemu_machine_pxe { my ($vmid, $conf, $machine) = @_; $machine = PVE::QemuServer::get_current_qemu_machine($vmid) if !$machine; foreach my $opt (keys %$conf) {

[pve-devel] lasts updates : qemu live migration , missing -machine to target kvm process

Hi, user have reported a problem with migration from proxmox 4.1 (qemu 2.4) to proxmox 4.1 with last updates (qemu 2.5). https://forum.proxmox.com/threads/no-online-migration-possible-to-upgraded-cluster-nodes.26158/ I thinked it was a qemu problem, but looking at generate qemu command line on

[pve-devel] FYI: occational kernel crash - patch on its way

Hi all, I don't know if this is news or not, but I encountered this problem once a week for a couple of weeks and finally, there is hope. Hopefully the patch will be available soon in the upstream ubuntu kernel. https://github.com/zfsonlinux/zfs/issues/4355 Best, Andreas

Re: [pve-devel] [PATCH ha-manager v3 1/6] fix some log formatting

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager] rename component 'id' property to 'stateId'

ExtJS6 requires a stateId if we want to save the component state (seems it is not autogenerated anymore from 'id') this fix the selection of timeframes in the Summary View also move properties out of initComponent() also remove code which duplicates framework code: setting stateEvents to

Re: [pve-devel] pve-kernel package : add irqbalance as recommended ? (like debian linux-image package)

>>nearly all current cards and drivers do that. That's the reason why you >>don't need it with current HW and drivers. Not sure why mellanox isn't >>doing that by default - see alexandre's post. >> >>adaptec, lsi and intel have all queues per cpu / interrupt. >> >>Stefan I don't remember the

Re: [pve-devel] pve-kernel package : add irqbalance as recommended ? (like debian linux-image package)

Am 20.02.2016 um 12:40 schrieb Martin Waschbüsch: > >> Am 20.02.2016 um 08:25 schrieb Alexandre DERUMIER : >> Some articles, for instance https://www.kernel.org/doc/ols/2009/ols2009-pages-169-184.pdf, explicitly recommend disabling irqbalance when 10GbE is

Re: [pve-devel] pve-kernel package : add irqbalance as recommended ? (like debian linux-image package)

Am 20.02.2016 um 11:19 schrieb Dietmar Maurer: > >> tuned tool from redhat is just for tunning kernel params, cpu gouvernor, >> ioscheduler, ... from profiles (high-bandwith vs low latency for example) >> >> It's not related to ksm. >> >> you can find details about the profils and tuning values

Re: [pve-devel] pve-kernel package : add irqbalance as recommended ? (like debian linux-image package)

Am 20.02.2016 um 10:08 schrieb Alexandre DERUMIER: > <> Have a look at red hats tuned which is much better and open source at > fedora. >>> >>> https://git.fedorahosted.org/cgit/tuned.git >>> >>> But I have not found reasonable docs - why is is better? What features does > i>>t provide? Can it