[pve-devel] [PATCH 2/3] QemuServer::clone_disk: allow path as src

2017-01-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 4ccf10a..054394b 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6144,7 +6144,8 @@ sub

[pve-devel] [PATCH 3/3] add qmimport command

2017-01-19 Thread Alexandre Derumier
This allow to import an external disk in a vm. qmimport Signed-off-by: Alexandre Derumier --- Makefile| 1 + PVE/CLI/Makefile| 2 +- PVE/CLI/qmimport.pm | 140 qmimport| 8 +++ 4

[pve-devel] add qmimport command

2017-01-19 Thread Alexandre Derumier
Hi, This is second attempt to have a command to import external disk with a single command line. This time, I have a separate qmimport, cli only and only for root. If it's really not possible to include such feature in proxmox, could you review patch 1 & 2 to include them upstream ? They are

[pve-devel] [PATCH 1/3] qemu_img_convert: allow $path as src image

2017-01-19 Thread Alexandre Derumier
This allow to use a path as src image directly, without storeid. We don't try to detect the src format ourself (vmware can export raw file with vmdk extension for example) Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 67

Re: [pve-devel] transparent huge pages support / disk passthrough corruption

2017-01-19 Thread Andreas Steinel
It seems that the current implementation is much better than it was in the RHEL-based kernel. On Thu, Jan 19, 2017 at 9:43 AM, Alexandre DERUMIER wrote: > Hi, > > I have reenable THP ( transparent_hugepage=madvise) since around 1 year > (with pve-kernel 4.2-4.4), and I

Re: [pve-devel] [PATCH qemu-server] only use scsi-block with explicit opt-in

2017-01-19 Thread Dietmar Maurer
I think it is good practice to specify the default value: > +my %scsiblock_fmt = ( > +scsiblock => { > + type => 'boolean', > + description => "whether to use scsi-block for full passthrough of host > block > device\n\nWARNING: can lead to I/O errors in combination with low memory or

Re: [pve-devel] qemu-server : add new qm import_disk feature

2017-01-19 Thread Alexandre DERUMIER
>>well... you can't have your cake and eat it too? or in other words, >>nothing in life is free.. Well, to have a real example, I have a customer which have migrated around 50 vmware vms with exactly your steps, and he said me that's easy really to slow/long will all this steps. Just to

[pve-devel] [PATCH qemu-server] only use scsi-block with explicit opt-in

2017-01-19 Thread Fabian Grünbichler
since it can cause I/O errors and data corruption in low memory or highly fragmented memory situations since Qemu 2.7 use scsi-hd by default instead Signed-off-by: Fabian Grünbichler --- note: at least until this is fixed in Qemu PVE/QemuServer.pm | 12 +++-

[pve-devel] [PATCH docs 2/3] add links to the specific migration chaptes in pvecm

2017-01-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- pvecm.adoc | 8 1 file changed, 8 insertions(+) diff --git a/pvecm.adoc b/pvecm.adoc index baf9300..491b2ac 100644 --- a/pvecm.adoc +++ b/pvecm.adoc @@ -864,6 +864,14 @@ migrations. This can be done via the configuration file

[pve-devel] [PATCH docs 3/3] add details about online migration for qemu

2017-01-19 Thread Dominik Csapak
this adds the distinction between online/offline migration for vms, and explains what happens during an online migration and explains, what the requirements are Signed-off-by: Dominik Csapak --- i added the requirements, so that we can refer to the documentation, when you

[pve-devel] [PATCH docs 1/3] small grammar and word fixes

2017-01-19 Thread Dominik Csapak
s/unless/until/ added a comma to split the sentence Signed-off-by: Dominik Csapak --- ha-manager.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ha-manager.adoc b/ha-manager.adoc index b1ca0c7..47fbe7c 100644 --- a/ha-manager.adoc +++

[pve-devel] [PATCH ha-manager v2 1/6] sim: allocate HA Env only once per service and node

2017-01-19 Thread Thomas Lamprecht
Do not allocate the HA Environment every time we fork a new CRM or LRM, but once at the start of the Simulator for all nodes. This can be done as the Env does not saves any state and thus can be reused, we use this also in the TestHardware class. Making the behavior of both Hardware classes more

[pve-devel] [PATCH ha-manager v2 0/6] refactoring and new simulator features

2017-01-19 Thread Thomas Lamprecht
changes since v1: * dropped patch 2/7 "sim: use HA envs after_fork to close all inherited FDs" as it was to hacky and could cause problems. * implement the semantics from the dropped patch in an easier way in the "factor out and unify sim_hardware_cmd" patch, simply pass the lock filehandle

[pve-devel] [PATCH ha-manager v2 4/6] sim: allow deleting service via GUI

2017-01-19 Thread Thomas Lamprecht
Add a delete button to each service entry row. This allows deleting a service on runtime. Signed-off-by: Thomas Lamprecht --- no changes src/PVE/HA/Sim/RTHardware.pm | 52 1 file changed, 52 insertions(+) diff --git

[pve-devel] [PATCH ha-manager v2 5/6] sim: factor out service gui entry addition

2017-01-19 Thread Thomas Lamprecht
Will be used to allow adding services to the simulator on runtime in a future patch. Signed-off-by: Thomas Lamprecht --- no changes src/PVE/HA/Sim/RTHardware.pm | 92 1 file changed, 51 insertions(+), 41 deletions(-) diff

[pve-devel] [PATCH ha-manager v2 2/6] factor out and unify sim_hardware_cmd

2017-01-19 Thread Thomas Lamprecht
Most things done by sim_hardware_cmd are already abstracted and available in both, the TestHardware and the RTHardware class. Abstract out the CRM and LRM control to allow the unification of both classes sim_hardware_cmd. As in the last year mostly the regression test systems TestHardware class

Re: [pve-devel] [PATCH manager] Reduce the number of translations needed

2017-01-19 Thread Dominik Csapak
On 01/18/2017 05:56 PM, Dietmar Maurer wrote: Can we simple use: gettext('Enable Firewall') => gettext('Enable') gettext('Enable DHCP') => 'DHCP' gettext('Enable XXYYYZZZ') => 'XXYYYZZZ' unless there is a real reason to use 'blah blah XXYYYZZZ blah' ... We could even display the actual

Re: [pve-devel] qemu-server : add new qm import_disk feature

2017-01-19 Thread Fabian Grünbichler
On Thu, Jan 19, 2017 at 10:24:17AM +0100, Alexandre DERUMIER wrote: > The problem with 1), > > it's that users don't have always local file storage space. > (for example, they have only small local disk and disks are on a san, or they > have big lvmthin storage but no space for files) > > My

Re: [pve-devel] qemu-server : add new qm import_disk feature

2017-01-19 Thread Alexandre DERUMIER
The problem with 1), it's that users don't have always local file storage space. (for example, they have only small local disk and disks are on a san, or they have big lvmthin storage but no space for files) My students/customers generaly export image on usb drive or network share, and don't

Re: [pve-devel] qemu-server : add new qm import_disk feature

2017-01-19 Thread Fabian Grünbichler
On Thu, Jan 19, 2017 at 07:17:29AM +0100, Alexandre Derumier wrote: > We had discuted last year about a method to import external image > (vmware,xen,hyperv) to a proxmox vm > http://pve.proxmox.com/pipermail/pve-devel/2016-January/018757.html > > This mostly the feature that all my training

Re: [pve-devel] Question: open virtual appliance

2017-01-19 Thread Emmanuel Kasper
On 01/19/2017 07:46 AM, Alexandre DERUMIER wrote: > Hi, > > as a first step, I have send patch to import external disk image. > > now for ova import, > I think we need a method to extract files from ova (it's a simple tar file), > > then an xml parser to parse OVF descriptor > > Does somebody

Re: [pve-devel] transparent huge pages support / disk passthrough corruption

2017-01-19 Thread Alexandre DERUMIER
Hi, I have reenable THP ( transparent_hugepage=madvise) since around 1 year (with pve-kernel 4.2-4.4), and I don't have problem anymore like in the past. I'm hosting a lot of database (mysql,sqlserver, redis, mongo,...) and I don't have seen performance impact since I have reenable THP. So I

[pve-devel] transparent huge pages support / disk passthrough corruption

2017-01-19 Thread Fabian Grünbichler
So it seems like the recently reported problems[1] with disk pass through using virtio-scsi(-single) are caused by a combination of Qemu since 2.7 not handling memory fragmentation (well) and our compiled-in default of disabling transparent huge pages on the kernel side. While I will investigate