Re: [pve-devel] [PATCH pve-storage 0/5] v5 fix regression and indentation

2017-06-17 Thread Michael Rasmussen
Hi Fabian, On Fri, 16 Jun 2017 14:21:34 +0200 Fabian Grünbichler wrote: > > sub volume_resize { > > my ($class, $scfg, $storeid, $volname, $size, $running) = @_; > > > > my ($vtype, $name, $vmid) = $class->parse_volname($volname); > > > > my $run = PVE::QemuServer::check_running($v

[pve-devel] [PATCH v6 pve-storage 1/1] A lot of bug fixes and clean-ups

2017-06-17 Thread mir
From: Michael Rasmussen fixes TODO Signed-off-by: Michael Rasmussen --- PVE/Storage/FreeNASPlugin.pm | 1011 ++ 1 file changed, 533 insertions(+), 478 deletions(-) diff --git a/PVE/Storage/FreeNASPlugin.pm b/PVE/Storage/FreeNASPlugin.pm index 9fe64d6..

[pve-devel] [PATCH v6 pve-storage 0/1] FreeNAS storage plugin

2017-06-17 Thread mir
From: Michael Rasmussen This is a patch to be added to v5 of the patch series. fixes # if ! to unless # all helper methods now private # remove unused includes # remove unused code # more descriptive variable names # change api timeout to be in sync with the PVE API # add loop over limit until e

[pve-devel] [PATCH v2 pve-container 1/1] Correctly bail when online resize for CT is requested.

2017-06-17 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- src/PVE/API2/LXC.pm | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 9cf22de..d333bea 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.p

[pve-devel] [PATCH v2 pve-container 0/1] FreeNAS storage plugin

2017-06-17 Thread mir
From: Michael Rasmussen The is a fix in response to comments from Fabian. Pass value of $running to volume_resize if storage id is freenas Michael Rasmussen (1): Correctly bail when online resize for CT is requested. src/PVE/API2/LXC.pm | 22 ++-

Re: [pve-devel] [PATCH pve-storage 0/5] v5 fix regression and indentation

2017-06-17 Thread Andreas Steinel
On Sat, Jun 17, 2017 at 5:05 PM, Michael Rasmussen wrote: > On Sat, 17 Jun 2017 13:33:38 +0200 > Andreas Steinel wrote: > >> >> You said that you do not have the required hardware, however, you do >> not need additional hardware for that. >> >> I can provide you with a multipath configuration if

Re: [pve-devel] [PATCH pve-storage 0/5] v5 fix regression and indentation

2017-06-17 Thread Michael Rasmussen
On Sat, 17 Jun 2017 13:33:38 +0200 Andreas Steinel wrote: > > You said that you do not have the required hardware, however, you do > not need additional hardware for that. > > I can provide you with a multipath configuration if you like. iSCSI is > not different to FC-based multipath, so config

Re: [pve-devel] [PATCH pve-storage 0/5] v5 fix regression and indentation

2017-06-17 Thread Andreas Steinel
On Sat, Jun 17, 2017 at 10:33 AM, Michael Rasmussen wrote: > On Sat, 17 Jun 2017 10:15:25 +0200 > Andreas Steinel wrote: > >> Mi Michael, >> >> On Fri, Jun 16, 2017 at 3:10 AM, Michael Rasmussen wrote: >> > MPIO is not tested since I don't have the required hardware to do so. >> >> Is there more

Re: [pve-devel] [PATCH pve-storage 0/5] v5 fix regression and indentation

2017-06-17 Thread Michael Rasmussen
On Sat, 17 Jun 2017 10:15:25 +0200 Andreas Steinel wrote: > Mi Michael, > > On Fri, Jun 16, 2017 at 3:10 AM, Michael Rasmussen wrote: > > MPIO is not tested since I don't have the required hardware to do so. > > Is there more than adding another IP to the FreeNAS machine? I've done > that on

Re: [pve-devel] [PATCH pve-storage 0/5] v5 fix regression and indentation

2017-06-17 Thread Andreas Steinel
Mi Michael, On Fri, Jun 16, 2017 at 3:10 AM, Michael Rasmussen wrote: > MPIO is not tested since I don't have the required hardware to do so. Is there more than adding another IP to the FreeNAS machine? I've done that on a Debian-based target and it automatically logged into each portal, so mult