Re: [pve-devel] pve api offline during log rotation

2017-09-19 Thread Stefan Priebe - Profihost AG
Nobody? Stefan Excuse my typo sent from my mobile phone. > Am 12.09.2017 um 09:27 schrieb Stefan Priebe - Profihost AG > : > > Hello, > > pveproxy has already a reload command - which seems to reopen the logs > correctly. Is there any reason why restart is used in the

[pve-devel] [PATCH pve-manager] Clean up unnecessary code.

2017-09-19 Thread Wolfgang Link
The jobid is already parsed by the file parser. --- PVE/API2/Replication.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm index 15499508..f396615d 100644 --- a/PVE/API2/Replication.pm +++ b/PVE/API2/Replication.pm @@ -60,8 +60,6 @@ sub

Re: [pve-devel] [PATCH access-control] VM.Snapshot.Rollback privilege added

2017-09-19 Thread Thomas Lamprecht
On 09/19/2017 10:49 AM, Dietmar Maurer wrote: As it has already the VM.Backup priv, which means it can already make a (snapshot) backup *and* restore them - i.e. change over the data/state of the VM. I thought restore needs allocate permission on the storage? OK, yes AllocateSpace is

Re: [pve-devel] [PATCH access-control] VM.Snapshot.Rollback privilege added

2017-09-19 Thread Dietmar Maurer
> As it has already the VM.Backup priv, which means it can already make > a (snapshot) backup *and* restore them - i.e. change over the data/state > of the VM. I thought restore needs allocate permission on the storage? ___ pve-devel mailing list

Re: [pve-devel] [PATCH manager] VM.Snapshot.Rollback privilege added

2017-09-19 Thread Thomas Lamprecht
On 09/13/2017 12:30 PM, Matthias Urban wrote: VM.Snapshot.Rollback privilege added Tested and reviewed whole series. Only thing is: I'm not quite sure that its OK where you put the new priv. As this affects only autogenerated Roles and does not gives more privs I can live with it, but would

Re: [pve-devel] [PATCH access-control] VM.Snapshot.Rollback privilege added

2017-09-19 Thread Thomas Lamprecht
On 09/13/2017 12:30 PM, Matthias Urban wrote: VM.Snapshot.Rollback privilege added Signed-off-by: Matthias Urban --- PVE/AccessControl.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm index 7d02cdf..2b610b7

[pve-devel] [PATCH storage] check if zfs tools are installed before using them

2017-09-19 Thread Dominik Csapak
else we get a warning everytime somebody uses the disklist and has no zfs installed (e.g. when creating ceph osds) Signed-off-by: Dominik Csapak --- this patch really only introduces an if around the eval and removes the comment, but it adds an indendation level so best