Re: [pve-devel] [PATCH manager v3 1/8] Do not use 'autoselect' as a boolean when preselecting a bus

2017-09-28 Thread Emmanuel Kasper
On 09/27/2017 10:47 AM, Thomas Lamprecht wrote: > On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: >> The bus selector is displayed when we add a Hard Disk or CD Drive. >> When it is displayed, we *always* preselect the next available >> slot on the controller of our choice. >> So this test is not

Re: [pve-devel] [PATCH manager 5/6] ui: merge CPUOptions into ProcessorEdit

2017-09-28 Thread Thomas Lamprecht
On 09/28/2017 02:43 PM, Dominik Csapak wrote: On 09/26/2017 01:56 PM, Thomas Lamprecht wrote: It seemed a bit weird that those options were in a seprate edit window as they affect the same backend variable and may cause confusion, an user may not be sure in what way they are related to each

Re: [pve-devel] [PATCH manager v3 5/8] Add a field to show which SCSI controller type we are currently using

2017-09-28 Thread Emmanuel Kasper
On 09/27/2017 11:27 AM, Thomas Lamprecht wrote: > On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: >> --- >>   www/manager6/qemu/HDEdit.js | 15 --- >>   1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js >> index

Re: [pve-devel] [PATCH manager 5/6] ui: merge CPUOptions into ProcessorEdit

2017-09-28 Thread Dominik Csapak
On 09/26/2017 01:56 PM, Thomas Lamprecht wrote: It seemed a bit weird that those options were in a seprate edit window as they affect the same backend variable and may cause confusion, an user may not be sure in what way they are related to each other, if at all. This allows us to share the