[pve-devel] [PATCH manager v2 3/3] Move Max Backups field below the Content Type Selector

Since the Max Backups field is now depending of having the Content Type set to 'backup', it makes sense to group these two fields. Signed-off-by: Emmanuel Kasper --- www/manager6/storage/DirEdit.js | 22 +++--- www/manager6/storage/GlusterFsEdit.js |

[pve-devel] [PATCH manager v2 1/3] Add Storage Controller class

This controller will display the 'Max Backups' field only if the storage can hold backups. Signed-off-by: Emmanuel Kasper --- www/manager6/Makefile | 1 + www/manager6/controller/StorageEdit.js | 18 ++ 2 files changed, 19 insertions(+)

[pve-devel] [PATCH manager v2 2/3] Fix #1523: Display the Max Backups field only if relevant

Signed-off-by: Emmanuel Kasper --- www/manager6/storage/DirEdit.js | 3 +++ www/manager6/storage/GlusterFsEdit.js | 3 +++ www/manager6/storage/NFSEdit.js | 3 +++ 3 files changed, 9 insertions(+) diff --git a/www/manager6/storage/DirEdit.js

[pve-devel] [PATCH manager v2 0/3] Fix #1523: Disable 'Max Backup' entry when not applicable

changes since V1: * remove wrong whitespace in DirEdit.js * reset Max Backups value before disabling it in StorageEdit.js Emmanuel Kasper (3): Add Storage Controller class Fix #1523: Display the Max Backups field only if relevant Move Max Backups field below the Content Type Selector

Re: [pve-devel] [PATCH manager 3/3] Move Max Backups field below the Content Type Selector

In general, i am in favor of keeping the order as it is (to avoid confusion), but i get why this could be more logical i am not opposed to this though (maybe someone else has a stronger opinion?) ___ pve-devel mailing list pve-devel@pve.proxmox.com

Re: [pve-devel] [PATCH manager 1/3] Add Storage Controller class

Comment inline: On 10/31/2017 01:34 PM, Emmanuel Kasper wrote: This controller will display the 'Max Backups' field only if the storage can hold backups. Signed-off-by: Emmanuel Kasper --- www/manager6/Makefile | 1 +

[pve-devel] [PATCH manager 1/3] Add Storage Controller class

This controller will display the 'Max Backups' field only if the storage can hold backups. Signed-off-by: Emmanuel Kasper --- www/manager6/Makefile | 1 + www/manager6/controller/StorageEdit.js | 18 ++ 2 files changed, 19 insertions(+)

[pve-devel] [PATCH manager 3/3] Move Max Backups field below the Content Type Selector

Since the Max Backups field is now depending of having the Content Type set to 'backup', it makes sense to group these two fields. Signed-off-by: Emmanuel Kasper --- www/manager6/storage/DirEdit.js | 22 +++--- www/manager6/storage/GlusterFsEdit.js |

[pve-devel] [PATCH manager 0/3] Fix #1523: Disable 'Max Backup' entry when not applicable

This patch serie fixes #1523. Instead of writing for each Storage a new ViewController, I created new ViewController class to be reused. Emmanuel Kasper (3): Add Storage Controller class Fix #1523: Display the Max Backups field only if relevant Move Max Backups field below the Content Type

[pve-devel] [PATCH manager 2/3] Fix #1523: Display the Max Backups field only if relevant

Signed-off-by: Emmanuel Kasper --- www/manager6/storage/DirEdit.js | 3 +++ www/manager6/storage/GlusterFsEdit.js | 3 +++ www/manager6/storage/NFSEdit.js | 3 +++ 3 files changed, 9 insertions(+) diff --git a/www/manager6/storage/DirEdit.js

[pve-devel] applied: [PATCH manager] prevent visual flashing of button when changing element in the tree

applied On Mon, Oct 30, 2017 at 03:03:38PM +0100, Dominik Csapak wrote: > when changing between elements in the tree, either the > start or shutdown buttons were visually flashing (meaning they are > enabled/disabled for a short time and change state shortly after) > > this patch fixes that > >

[pve-devel] [PATCH container 1/3] use systemd-networkd for ubuntu >= 17.10

Ubuntu Artful uses systemd-networkd now, but we have to delete the default netplan config from the upstream lxc container, and enable systemd-networkd Signed-off-by: Dominik Csapak --- src/PVE/LXC/Setup/Ubuntu.pm | 25 - 1 file changed, 24

[pve-devel] [PATCH container 3/3] fix trailing whitespace

Signed-off-by: Dominik Csapak --- src/PVE/LXC/Setup/Ubuntu.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/PVE/LXC/Setup/Ubuntu.pm b/src/PVE/LXC/Setup/Ubuntu.pm index a0d11cc..781348a 100644 --- a/src/PVE/LXC/Setup/Ubuntu.pm +++

[pve-devel] [PATCH container 2/3] simply version check

Signed-off-by: Dominik Csapak --- src/PVE/LXC/Setup/Ubuntu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Setup/Ubuntu.pm b/src/PVE/LXC/Setup/Ubuntu.pm index c4035d9..a0d11cc 100644 --- a/src/PVE/LXC/Setup/Ubuntu.pm +++

Re: [pve-devel] [PATCH manager] prevent visual flashing of button when changing element in the tree

Acked-by: Emmanuel Kasper On 10/30/2017 03:03 PM, Dominik Csapak wrote: > when changing between elements in the tree, either the > start or shutdown buttons were visually flashing (meaning they are > enabled/disabled for a short time and change state shortly after) > >

[pve-devel] applied: [PATCH manager 1/2] Fix: #1542, use percent_used key instead of calculation

applied both patches ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] fix #1539: add missing shellquote for proxied commands of pvesh

applied to master & stable-4 On Fri, Oct 27, 2017 at 02:13:48PM +0200, Dominik Csapak wrote: > if we do not do this, passing arguments with spaces > (e.g., pvesh set YYY --param "one word") > leads to ssh calls like this: > ssh REMOTE pvesh set YYY --param one word > > which cannot be parsed

[pve-devel] applied: [PATCH manager] FirewallOptions: fix DHCP default value

applied On Mon, Oct 30, 2017 at 02:26:00PM +0100, Dominik Csapak wrote: > we always had dhcp enabled by default in the backend, but > showed 'Disabled' on the gui, this patch show 'Enabled' by default > > Signed-off-by: Dominik Csapak > --- >