Re: [pve-devel] [PATCH manager 3/3] Add a proper confirmation message when we detach an used disk

Comment inline On 11/13/2017 12:26 PM, Emmanuel Kasper wrote: Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 3b

Re: [pve-devel] [PATCH manager 2/3] Fix #1526: Use 'detach' instead of 'remove' when the disk is used

Comments inline On 11/13/2017 12:26 PM, Emmanuel Kasper wrote: Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareVie

Re: [pve-devel] [PATCH manager] buildsys: add excludes to dh_fixperms

Tested-By: Emmanuel Kasper Acked-By: Emmanuel Kasper On 11/13/2017 10:37 AM, Wolfgang Bumiller wrote: > Instead of fixing up permissions manually as the make > install target is actually responsible for this (and already > doing it). > > Signed-off-by: Wolfgang Bumiller > --- > debian/rules |

[pve-devel] [PATCH cluster 5/6] buildsys: remove traces from unused rsyslog config

does not get included in package since a long time, if ever, and has no purpose currently. Signed-off-by: Thomas Lamprecht --- debian/pve-rsyslog.conf | 3 --- debian/rules| 3 --- 2 files changed, 6 deletions(-) delete mode 100644 debian/pve-rsyslog.conf diff --git a/debian/pve-rs

[pve-devel] [PATCH cluster 2/6] buildsys: remove outdated postrm

we did nothing special here so just use the debhelper generated one Signed-off-by: Thomas Lamprecht --- debian/postrm | 39 --- 1 file changed, 39 deletions(-) delete mode 100644 debian/postrm diff --git a/debian/postrm b/debian/postrm deleted file mode 1006

[pve-devel] [PATCH cluster 6/6] buildsys: autogen debug package and cleanup unecessary rules

don't do manually what the deb helpers do automatically and better. Autogenerate the debug package, it includes now only the debugsymbols without effectively duplicating all executables and libraries. In the same step add a install file which installs our sysctl settings, this is done together as

[pve-devel] [PATCH cluster 0/6] cleanup buildsys

Remove old sysv init service files. Completely autogen debug symbol package. Cleanup packaging/buildsys in general Thomas Lamprecht (6): remove unused sysv init.d service file buildsys: remove outdated postrm buildsys: use autoreconf buildsys: rules: remove outdated variables buildsys: r

[pve-devel] [PATCH cluster 4/6] buildsys: rules: remove outdated variables

Signed-off-by: Thomas Lamprecht --- debian/rules | 5 - 1 file changed, 5 deletions(-) diff --git a/debian/rules b/debian/rules index bf69290..ed17ae4 100755 --- a/debian/rules +++ b/debian/rules @@ -4,11 +4,6 @@ # Uncomment this to turn on verbose mode. #export DH_VERBOSE=1 -# This has

[pve-devel] [PATCH cluster 1/6] remove unused sysv init.d service file

Signed-off-by: Thomas Lamprecht --- debian/init.d | 145 - debian/pve-cluster.default | 10 debian/rules | 2 - 3 files changed, 157 deletions(-) delete mode 100644 debian/init.d delete mode 100644 debian/pve-cluster

[pve-devel] [PATCH cluster 3/6] buildsys: use autoreconf

do not manually call autogen/configure just use dh_autoreconf Signed-off-by: Thomas Lamprecht --- Makefile | 1 - debian/rules | 8 +--- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/Makefile b/Makefile index 073ddc8..9b75e81 100644 --- a/Makefile +++ b/Makefile @@ -28,7

[pve-devel] [PATCH manager 0/3] Change 'remove' to 'detach' when removing an used disk

A fix for #1526 Emmanuel Kasper (3): Fix JSLint type confusion warnings Fix #1526: Use 'detach' instead of 'remove' when the disk is used Add a proper confirmation message when we detach an used disk www/manager6/qemu/HardwareView.js | 67 +-- 1 file ch

[pve-devel] [PATCH manager 1/3] Fix JSLint type confusion warnings

The type confusion warnings arose from string and integer concatenation, and object properties of the name which were alternatively set with strings or intergers. Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 29 ++--- 1 file changed, 14 insertion

[pve-devel] [PATCH manager 2/3] Fix #1526: Use 'detach' instead of 'remove' when the disk is used

Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 43337c36..3b0f00f6 100644 --- a/www/manager6/qemu/Hardwa

[pve-devel] [PATCH manager 3/3] Add a proper confirmation message when we detach an used disk

Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 3b0f00f6..605958e1 100644 --- a/www/manager6/qemu/HardwareView.js ++

[pve-devel] [PATCH qemu-server] do not add unused disk when already as unused on another storage

when having an unused disk on a storage for which there are multiple definitions, we added it again on another storage when that storage was alphabetically before the already existing one this happens for example when using our automatically generated ceph storages: 'pool_ct' and 'pool_vm' and hav

[pve-devel] [PATCH manager] buildsys: add excludes to dh_fixperms

Instead of fixing up permissions manually as the make install target is actually responsible for this (and already doing it). Signed-off-by: Wolfgang Bumiller --- debian/rules | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/debian/rules b/debian/rules index 8c618219..f2c

Re: [pve-devel] [PATCH cluster 2/4] pvecm: module cleanup: make_path is in core

This patch was sent by mistake and should be ignored, it's wrong. On 11/13/2017 10:16 AM, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > data/PVE/CLI/pvecm.pm | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/data/PVE/CLI/pvecm.pm b/data/PVE/CLI/pv

[pve-devel] [PATCH cluster 4/4] pvecm: module cleanup: remove unused modules

Signed-off-by: Thomas Lamprecht --- data/PVE/CLI/pvecm.pm | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/data/PVE/CLI/pvecm.pm b/data/PVE/CLI/pvecm.pm index 0e1ecb4..a0c676f 100755 --- a/data/PVE/CLI/pvecm.pm +++ b/data/PVE/CLI/pvecm.pm @@ -2,12 +2,8 @@ package PVE::CLI:

[pve-devel] [PATCH cluster 3/4] pvecm: module cleanup: use our get_host_address_family

Signed-off-by: Thomas Lamprecht --- data/PVE/CLI/pvecm.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/data/PVE/CLI/pvecm.pm b/data/PVE/CLI/pvecm.pm index 0137046..0e1ecb4 100755 --- a/data/PVE/CLI/pvecm.pm +++ b/data/PVE/CLI/pvecm.pm @@ -3,7 +3,6 @@ package PVE::CLI::pve

[pve-devel] [PATCH cluster 2/4] pvecm: module cleanup: make_path is in core

Signed-off-by: Thomas Lamprecht --- data/PVE/CLI/pvecm.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/data/PVE/CLI/pvecm.pm b/data/PVE/CLI/pvecm.pm index 015978d..0137046 100755 --- a/data/PVE/CLI/pvecm.pm +++ b/data/PVE/CLI/pvecm.pm @@ -8,7 +8,6 @@ use IO::File; use

[pve-devel] [PATCH cluster 1/4] pvecm: remove unused variable

Signed-off-by: Thomas Lamprecht --- data/PVE/CLI/pvecm.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/data/PVE/CLI/pvecm.pm b/data/PVE/CLI/pvecm.pm index 9707114..015978d 100755 --- a/data/PVE/CLI/pvecm.pm +++ b/data/PVE/CLI/pvecm.pm @@ -86,7 +86,6 @@ __PACKAGE__->register_method ({