Re: [pve-devel] [PATCH storage 2/2] Addition to #1542, get precent_used from RBDPlugin - add librados2-perl for rados commands - get RBD storage status through librados - calculate %USED if not availa

2017-11-15 Thread Thomas Lamprecht
Your commit message heading is way to long, try to stay below 60 chars (to allow space for tags) with 80 as upper hard limit. On 11/15/2017 03:47 PM, Alwin Antreich wrote: > Signed-off-by: Alwin Antreich > --- > PVE/CLI/pvesm.pm | 1 + > PVE/Storage.pm | 6 -- > PVE/Stora

Re: [pve-devel] [PATCH storage 1/2] Fix: 1542 - show storage utilization per pool, not per global

2017-11-15 Thread Thomas Lamprecht
comments inline. On 11/15/2017 03:47 PM, Alwin Antreich wrote: > Signed-off-by: Alwin Antreich > --- > PVE/Storage/RBDPlugin.pm | 40 +++- > 1 file changed, 19 insertions(+), 21 deletions(-) > > diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm

Re: [pve-devel] [PATCH storage 1/2] Fix: 1542 - show storage utilization per pool, not per global

2017-11-15 Thread Alexandre DERUMIER
>>Wouldn't that be totally confusing if you have several pools with different >>replication factor? Personnaly, I don't think it'll be confusing. Currently you need to do the math manually, and you don't known the replication factor without calling manually ceph api or commands. - Mail or

Re: [pve-devel] [PATCH storage 1/2] Fix: 1542 - show storage utilization per pool, not per global

2017-11-15 Thread Dietmar Maurer
Wouldn't that be totally confusing if you have several pools with different replication factor? > Could it be possible to use replication factor from pool config to display > used and free space ? > > (/3 if size=3 for example) > > We didn't do it before, but I think this was because we monitor

Re: [pve-devel] [PATCH storage 1/2] Fix: 1542 - show storage utilization per pool, not per global

2017-11-15 Thread Alexandre DERUMIER
Hi, Could it be possible to use replication factor from pool config to display used and free space ? (/3 if size=3 for example) We didn't do it before, but I think this was because we monitor the full storage, now that it's only for a specific pool, I think it can make sense. - Mail or

[pve-devel] [PATCH storage 2/2] Addition to #1542, get precent_used from RBDPlugin - add librados2-perl for rados commands - get RBD storage status through librados - calculate %USED if not available

2017-11-15 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/CLI/pvesm.pm | 1 + PVE/Storage.pm | 6 -- PVE/Storage/RBDPlugin.pm | 14 +- 3 files changed, 18 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 9455595..006f97f 100755 --- a/PVE/CLI/pv

[pve-devel] [PATCH storage 1/2] Fix: 1542 - show storage utilization per pool, not per global

2017-11-15 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index decfbf5..14386c4 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Stor

[pve-devel] [PATCH docs] add VLAN explanation.

2017-11-15 Thread Wolfgang Link
--- pve-network.adoc | 88 1 file changed, 88 insertions(+) diff --git a/pve-network.adoc b/pve-network.adoc index d221c32..c5d5b40 100644 --- a/pve-network.adoc +++ b/pve-network.adoc @@ -344,6 +344,94 @@ iface vmbr0 inet static

Re: [pve-devel] [PATCH manager] pveproxy: add LISTEN variable to /etc/default/pveproxy

2017-11-15 Thread Wolfgang Bumiller
On Wed, Nov 15, 2017 at 02:10:36PM +0100, Wolfgang Bumiller wrote: > diff --git a/PVE/API2Tools.pm b/PVE/API2Tools.pm > index f1df2384..47cce416 100644 > --- a/PVE/API2Tools.pm > +++ b/PVE/API2Tools.pm > @@ -230,6 +230,7 @@ sub read_proxy_config { > $shcmd .= 'echo \"POLICY:\$POLICY\";'; >

[pve-devel] [PATCH manager] pveproxy: add LISTEN variable to /etc/default/pveproxy

2017-11-15 Thread Wolfgang Bumiller
That way one can explicitly set the listen address. Useful for single nodes to limit the GUI to 127.0.0.1, or in clusters to limit it to a private cluster network. (Note that proxied cluster requests use the hostname so it should usually contain either nothing, the hostname, or the first IP the ho

[pve-devel] applied: [RFC PATCH] fix #1471: change keyboard default to undef

2017-11-15 Thread Wolfgang Bumiller
Applied. Yay, finally the us(altgr-intl) layout seems to fully work over vnc in the browser. On Tue, Nov 07, 2017 at 11:09:30AM +0100, Dominik Csapak wrote: > this means that we do not include the '-k' parameter anymore by default > (which is deprecated by qemu) > > with this, noVNC and spice al

[pve-devel] applied: [PATCH firewall] sort ipsets so that the digest is consistent

2017-11-15 Thread Wolfgang Bumiller
On Wed, Nov 15, 2017 at 11:41:34AM +0100, Dominik Csapak wrote: > otherwise, editing an ipset randomly works (or not) due to > a wrong digest > > Signed-off-by: Dominik Csapak > --- > src/PVE/API2/Firewall/IPSet.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE

Re: [pve-devel] [PATCH qemu-server] Use schema default values as default values

2017-11-15 Thread Emmanuel Kasper
Any feedback on this ? On 10/23/2017 10:45 AM, Emmanuel Kasper wrote: > This fix a bug where VMs where the memory parameter was not > set where reported as having 0MB instead of 512 via `qm list` > > Signed-off-by: Emmanuel Kasper > --- > PVE/QemuServer.pm | 14 +++--- > 1 file changed,

Re: [pve-devel] [PATCH qemu-server] do not add unused disk when already as unused on another storage

2017-11-15 Thread Fabian Grünbichler
On Mon, Nov 13, 2017 at 12:09:11PM +0100, Dominik Csapak wrote: > when having an unused disk on a storage for which there are multiple > definitions, we added it again on another storage when that storage > was alphabetically before the already existing one > > this happens for example when using

[pve-devel] [PATCH manager v2 3/3] Add a proper confirmation message when we detach an used disk

2017-11-15 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 2cd0c940..e6bc0231 100644 --- a/www/manager6/qemu/HardwareView.js ++

[pve-devel] [PATCH manager v2 1/3] Fix JSLint type confusion warnings

2017-11-15 Thread Emmanuel Kasper
The type confusion warnings arose from string and integer concatenation, and object properties of the name which were alternatively set with strings and integers. Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 29 ++--- 1 file changed, 14 insertion

[pve-devel] [PATCH manager v2 0/3] Introduce 'Detach' text for used disks

2017-11-15 Thread Emmanuel Kasper
change since V2: * do not call gettext twice on the same string * use 'render' event instead of 'boxready' when computing an optimal box size Emmanuel Kasper (3): Fix JSLint type confusion warnings Fix #1526: Use 'detach' instead of 'remove' when the disk is used Add a proper confirmation

[pve-devel] [PATCH manager v2 2/3] Fix #1526: Use 'detach' instead of 'remove' when the disk is used

2017-11-15 Thread Emmanuel Kasper
Signed-off-by: Emmanuel Kasper --- www/manager6/qemu/HardwareView.js | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 43337c36..2cd0c940 100644 --- a/www/manager6/qemu/Har

[pve-devel] [PATCH firewall] sort ipsets so that the digest is consistent

2017-11-15 Thread Dominik Csapak
otherwise, editing an ipset randomly works (or not) due to a wrong digest Signed-off-by: Dominik Csapak --- src/PVE/API2/Firewall/IPSet.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/API2/Firewall/IPSet.pm b/src/PVE/API2/Firewall/IPSet.pm index ea6d1a2..068c1a4 10

Re: [pve-devel] [PATCH storage] check if root in zfs regression tests

2017-11-15 Thread Fabian Grünbichler
On Wed, Nov 08, 2017 at 10:27:46AM +0100, Dominik Csapak wrote: > since 'zpool status' runs now with non-root priliveges, > we have to explicitely test for root, else we cannot build > without root but with zfs utils installed I wonder if we should not stop running those tests automatically at bui