[pve-devel] [RFC 1/2 pve-storage] implement map_volume and unmap_volume

2018-09-20 Thread Dietmar Maurer
This allows to request a mapped device/path explicitly, regardles of the storage option, eg. krbd option in the RBDplugin. Signed-off-by: Dietmar Maurer --- PVE/Storage.pm | 24 +++ PVE/Storage/Plugin.pm| 12 ++ PVE/Storage/RBDPlugin.pm | 62

[pve-devel] [RFC 2/2 pve-container] call map_volume before using volumes.

2018-09-20 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- src/PVE/LXC.pm | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 0b57ae9..448ea34 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1302,12 +1302,9 @@ sub mountpoint_mount { my

Re: [pve-devel] [RFC container 3/3] implement permission checks for feature flags

2018-09-20 Thread Thomas Lamprecht
On 9/19/18 3:11 PM, Wolfgang Bumiller wrote: > On Wed, Sep 19, 2018 at 02:09:39PM +0200, Thomas Lamprecht wrote: >> On 7/31/18 2:50 PM, Wolfgang Bumiller wrote: >>> To disable a feature it is enough to be generally allowed >>> to edit the configuration. Enabling a feature requires more >>>

Re: [pve-devel] [PATCH storage 1/2] Add flag $map so container images can be mapped

2018-09-20 Thread Dietmar Maurer
> On August 17, 2018 at 3:44 PM Alwin Antreich wrote: > > > This allows methods to request a mapped device/path explicitly, > regardles of the storage option, eg. krbd option in the RBDplugin. You basically add an additional map parameter to all methods - what for? I would prefer to keep