Re: [pve-devel] [PATCH v2 qemu-server 1/1] Use usb-kbd for q35 in tablet mode

2019-02-13 Thread Kamil Trzciński
I wonder, maybe it is simply better to have `keyboard: ps2,usb` top-level property? On Wed, Feb 13, 2019 at 9:53 AM Wolfgang Bumiller wrote: > On Tue, Feb 12, 2019 at 01:36:31PM +0100, Kamil Trzciński wrote: > > The usb-kbd on q35 in tablet mode removes the need for "hotpatching" > > when

Re: [pve-devel] [PATCH qemu-server] Fix #2062: New timeout switch for guest cmd

2019-02-13 Thread Kamil Trzciński
Oh :) On Wed, Feb 13, 2019 at 9:51 AM Dominik Csapak wrote: > On 2/12/19 1:44 PM, Kamil Trzciński wrote: > > Does it make sense to make this not forever by default? Maybe like 600 > > seconds should be good compromise, and if needed, this could be > overwritten? > > the description is actually

Re: [pve-devel] pve-firewall : vm live migration: rules applied only after vm config file move

2019-02-13 Thread Alexandre DERUMIER
>>(currently, if a CT or VM is booting fast, it's also possible to have some >>seconds with open firewall) sorry,that's wrong. The rules exist if the config file is present (vm started or stopped) - Mail original - De: "aderumier" À: "dietmar" Cc: "pve-devel" Envoyé: Mercredi 13

Re: [pve-devel] pve-firewall : vm live migration: rules applied only after vm config file move

2019-02-13 Thread Alexandre DERUMIER
>>Maybe live migration can tell firewall on target node to activate rules >>before we start migration. But I am not sure >>how to implement that. I think it should be done at vm/ct start, force firewall to activate rules before launching qemu or lxc. Like this we can be sure than rules are

[pve-devel] [PATCH docs] update kernel version in container overview

2019-02-13 Thread Oguz Bektas
4.4.X -> 4.15.X Signed-off-by: Oguz Bektas --- pct.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pct.adoc b/pct.adoc index b5b5af3..65d1e2c 100644 --- a/pct.adoc +++ b/pct.adoc @@ -83,7 +83,7 @@ Technology Overview * CRIU: for live migration (planned) -* Use

[pve-devel] [RFC manager 2/2] add lxc restart warning to bulk migration screen

2019-02-13 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- www/manager6/window/BulkAction.js | 6 ++ 1 file changed, 6 insertions(+) diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/BulkAction.js index 2ec9b9c9..0afc98ed 100644 --- a/www/manager6/window/BulkAction.js +++

[pve-devel] [PATCH manager 1/2] fix #1769: restart mode for bulk lxc migration

2019-02-13 Thread Oguz Bektas
online mode doesn't work, and causes bulk migration of running lxc containers to fail. Signed-off-by: Oguz Bektas --- PVE/API2/Nodes.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 3c450bb8..814dcea4 100644 ---

[pve-devel] [PATCH manager 0/2] bulk migration of running lxc in gui

2019-02-13 Thread Oguz Bektas
This series changes the GUI Bulk Migration window to use "Restart Mode" instead of "Online Mode" (which doesn't work) for running LXC containers. I'm sending the javascript one as RFC. Open to suggestions for the text. Also wanted to make it appear only when there are running containers or when a

[pve-devel] [PATCH firewall] Fix unitialized value $mark in bitwise operation

2019-02-13 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- src/PVE/FirewallSimulator.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/FirewallSimulator.pm b/src/PVE/FirewallSimulator.pm index b01e45b..188c38f 100644 --- a/src/PVE/FirewallSimulator.pm +++ b/src/PVE/FirewallSimulator.pm

[pve-devel] [PATCH docs v2] Fix #2018: CephFS client needs newer binaries

2019-02-13 Thread Alwin Antreich
To run cephfs client the debian stock packages need to be updated to luminous to get it running. This patch adds a section with our Ceph repositories to our package repo chapter to where the cephfs storage plugin chapter links to. Signed-off-by: Alwin Antreich --- V1 -> V2:

[pve-devel] [PATCH docs] change links from master/mimic to luminous

2019-02-13 Thread David Limbeck
Signed-off-by: David Limbeck --- pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index c90a92e..3e35bb0 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -58,7 +58,7 @@ and VMs on the same node is possible. To simplify management,

[pve-devel] applied: [PATCH docs] Fix double occurrence of be in pveceph docs

2019-02-13 Thread Wolfgang Bumiller
applied On Tue, Feb 12, 2019 at 02:22:48PM +0100, Christian Ebner wrote: > This fixes a typo (subsequent occurrence of be) in the CephFS section of the > documentation. > > Signed-off-by: Christian Ebner > --- > pveceph.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[pve-devel] applied: [PATCH docs] Fixed typo in Ceph Metadata Server documentation

2019-02-13 Thread Wolfgang Bumiller
applied On Tue, Feb 12, 2019 at 02:41:59PM +0100, Christian Ebner wrote: > This fixes a typo in the Metadata Server section of the documentation. > > Signed-off-by: Christian Ebner > --- > pveceph.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pveceph.adoc

[pve-devel] applied: [PATCH container] fix #2086: change process checking mechanism in vmstatus

2019-02-13 Thread Wolfgang Bumiller
applied On Mon, Feb 11, 2019 at 03:51:06PM +0100, Oguz Bektas wrote: > vmstatus checked if the container was running by looking at the pid, > which was not an indicator of the process being completely stopped, as > the command socket in /proc/net/unix stays a little while after the > process is

[pve-devel] applied: [PATCH docs 2/3] Fix #2015: add how to get a auth secret for cephfs

2019-02-13 Thread Wolfgang Bumiller
applied On Tue, Feb 12, 2019 at 10:44:50AM +0100, Alwin Antreich wrote: > Signed-off-by: Alwin Antreich > --- > pve-storage-cephfs.adoc | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/pve-storage-cephfs.adoc b/pve-storage-cephfs.adoc > index 2613d64..96f4991

[pve-devel] applied: [PATCH docs 1/3] asciidoc-pve: ignore link targets for non-manpages

2019-02-13 Thread Wolfgang Bumiller
applied On Tue, Feb 12, 2019 at 10:44:49AM +0100, Alwin Antreich wrote: > From: Thomas Lamprecht > > To allow linking from to a chapter/section not included in a manpage > allow the manpage link resolver to just return text in a case the > link target text is in fact no manpage. > > If the

Re: [pve-devel] [PATCH docs 3/3] Fix #2018: CephFS client needs newer binaries

2019-02-13 Thread Wolfgang Bumiller
On Tue, Feb 12, 2019 at 10:44:51AM +0100, Alwin Antreich wrote: > To run cephfs client the debian stock packages need to be updated to > luminous to get it running. > > This patch adds a section with our Ceph repositories to our package repo > chapter to where the cephfs storage plugin chapter

Re: [pve-devel] [PATCH v2 qemu-server 1/1] Use usb-kbd for q35 in tablet mode

2019-02-13 Thread Wolfgang Bumiller
On Tue, Feb 12, 2019 at 01:36:31PM +0100, Kamil Trzciński wrote: > The usb-kbd on q35 in tablet mode removes the need for "hotpatching" > when trying to install MacOS on Proxmox. This kind of change can brake live migration for already running VMs, so we either have to make it depend on the qemu

Re: [pve-devel] [PATCH qemu-server] Fix #2062: New timeout switch for guest cmd

2019-02-13 Thread Dominik Csapak
On 2/12/19 1:44 PM, Kamil Trzciński wrote: Does it make sense to make this not forever by default? Maybe like 600 seconds should be good compromise, and if needed, this could be overwritten? the description is actually wrong, if no timeout is given we have different default timeouts for

Re: [pve-devel] [PATCH qemu-server 1/1] Use nr_hugepages from /proc/cmdline

2019-02-13 Thread Wolfgang Bumiller
Looks good to me. Could you please also include a Signed-off-by line (I think back when you sent your first patches we didn't list that in the developer documentation as requirement, but now we do (though we sometimes forget apparently ;-) */me stares at Thomas*))? On Tue, Feb 12, 2019 at