Re: [pve-devel] [PATCH zfsonlinux 00/15] update to ZFS 0.8.0

2019-05-23 Thread Thomas Lamprecht
On 5/23/19 11:11 PM, Stoiko Ivanov wrote: > ZFS on Linux has just released 0.8.0 [0] bringing many new features and > improvments (see upstreams release notes). That's what I call bleeding edge :D Much thanks for this, I'll try to take a look at this tomorrow. > > From a packaging perspective

[pve-devel] [PATCH zfsonlinux 11/15] spl: remove submodule and debian folder

2019-05-23 Thread Stoiko Ivanov
and adapt global Makefile Starting with ZFS >= 0.8 the zfs and spl codebases are in one repository, and thus one source package Signed-off-by: Stoiko Ivanov --- .gitmodules | 3 - Makefile | 36 +--- spl/debian/changelog | 380

[pve-devel] [PATCH zfsonlinux 03/15] rebase patches on top of zfs-0.8.0

2019-05-23 Thread Stoiko Ivanov
rebase done with export-patchqueue and adapted to new 0.8 release Signed-off-by: Stoiko Ivanov --- ...-for-META-and-DCH-consistency-in-autoconf.patch | 4 +- ...util-to-LIBADD-for-libzfs-and-libzfs_core.patch | 37 - ...h => 0002-always-load-ZFS-module-on-boot.patch} | 0

[pve-devel] [PATCH zfsonlinux 13/15] add 3 patches for lintian errors

2019-05-23 Thread Stoiko Ivanov
* wrong-path-for-interpreter is a lintian error, one single zfs-test used /usr/bin/ksh instead of /bin/ksh. * python-script-but-no-python-dep was reported because test-runner.py had /usr/bin/python as shebang, but the buildsystem and our dependencies expected /usr/bin/python3 *

[pve-devel] [PATCH zfsonlinux 12/15] debian/control: set zfs-dbg priority to extra

2019-05-23 Thread Stoiko Ivanov
in order to appease lintian Signed-off-by: Stoiko Ivanov --- zfs/debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zfs/debian/control b/zfs/debian/control index b473269..69f8a02 100644 --- a/zfs/debian/control +++ b/zfs/debian/control @@ -216,7 +216,7 @@

[pve-devel] [PATCH zfsonlinux 14/15] Move zfs to top-level directory

2019-05-23 Thread Stoiko Ivanov
With the merge of spl and zfs the extra level of directories is not needed anymore. Signed-off-by: Stoiko Ivanov --- .gitmodules | 2 +- Makefile | 4 ++-- {zfs/debian =>

[pve-devel] [PATCH zfsonlinux 10/15] debian/docs: change OPENSOLARIS.LICENSE to LICENSE

2019-05-23 Thread Stoiko Ivanov
taken from debian upstream [0] [0] https://salsa.debian.org/zfsonlinux-team/zfs/ Signed-off-by: Stoiko Ivanov --- zfs/debian/copyright.cme| 2 +- zfs/debian/libnvpair1linux.docs | 2 +- zfs/debian/libuutil1linux.docs | 2 +- zfs/debian/libzfs2linux.docs| 2 +-

[pve-devel] [PATCH zfsonlinux 09/15] add python3-pyzfs binary package

2019-05-23 Thread Stoiko Ivanov
taken from debian upstream [0] [0] https://salsa.debian.org/zfsonlinux-team/zfs/ Signed-off-by: Stoiko Ivanov --- zfs/debian/control | 56 +--- zfs/debian/python3-pyzfs.install | 1 + zfs/debian/rules | 14 +- 3 files

[pve-devel] [PATCH zfsonlinux 15/15] add changelog for 0.8.0

2019-05-23 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/changelog | 11 +++ 1 file changed, 11 insertions(+) diff --git a/debian/changelog b/debian/changelog index 63e8b74..b2c88fd 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,14 @@ +zfs-linux (0.8.0-pve1~bpo1) unstable;

[pve-devel] [PATCH zfsonlinux 00/15] update to ZFS 0.8.0

2019-05-23 Thread Stoiko Ivanov
ZFS on Linux has just released 0.8.0 [0] bringing many new features and improvments (see upstreams release notes). From a packaging perspective the biggest change is the merge of the source repositories of spl and zfs (into the zfs repository), hence this large number of patches mostly consisting

[pve-devel] [PATCH zfsonlinux 07/15] zfsutils-linux: persist hostid in postinst script

2019-05-23 Thread Stoiko Ivanov
/etc/hostid does not exist on a minimal debian system. ZFS reads its contents for MMP (zpool property multihost set to on), and needs the value to be stable. Before the SPL->ZFS merge the spl userspace package wrote the file (by parsing/ mangling the output of hostid (1)) Since ZFS provides the

[pve-devel] [PATCH zfsonlinux 08/15] zfs/control: add spl as transitional dummy package

2019-05-23 Thread Stoiko Ivanov
since splat has been removed from zfs (during the repository merge of zfs and spl, the userspace spl package does not contain any files (apart from metafiles) keep the package as metapackage, s.t. the old splat manpage and binary gets removed upon upgrade. Signed-off-by: Stoiko Ivanov ---

[pve-devel] [PATCH zfsonlinux 01/15] update ZFS to 0.8.0

2019-05-23 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- zfs/upstream | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zfs/upstream b/zfs/upstream index a8c2b7e..e34c3ee 16 --- a/zfs/upstream +++ b/zfs/upstream @@ -1 +1 @@ -Subproject commit a8c2b7ebc64d23ffe15e2b168aa0bea7a4897133 +Subproject

[pve-devel] [PATCH zfsonlinux 02/15] debian: replace zpool.d patch by configure option

2019-05-23 Thread Stoiko Ivanov
the --with-zfsexecdir configure option is available in ZFS 0.8 and replaces the patch for cmd/zpool/Makefile.am (cherry-picked from salsa.d.o e1af594a0970e2b84c922f483e6798e7d155b7b7) Signed-off-by: Stoiko Ivanov --- .../0005-fix-install-path-of-zpool.d-scripts.patch | 38

[pve-devel] [PATCH zfsonlinux 05/15] debian: adapt install paths to ZFS 0.8

2019-05-23 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- zfs/debian/zfs-test.install | 6 -- zfs/debian/zfs-zed.install| 2 +- zfs/debian/zfsutils-linux.install | 3 +++ 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/zfs/debian/zfs-test.install b/zfs/debian/zfs-test.install index

[pve-devel] [PATCH zfsonlinux 06/15] debian/rules: adapt to ZFS 0.8

2019-05-23 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- zfs/debian/rules | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/zfs/debian/rules b/zfs/debian/rules index 8f002c9..e08064d 100755 --- a/zfs/debian/rules +++ b/zfs/debian/rules @@ -32,6 +32,7 @@ override_dh_auto_configure:

[pve-devel] [PATCH zfsonlinux 04/15] zfs/debian: embed downstream revision in META file

2019-05-23 Thread Stoiko Ivanov
taken from spl/debian/rules Additionally refactor the actual change into a separate target. This is needed when building the kernel-modules from an rc-tag (e.g. 0.8.0-rc5) Signed-off-by: Stoiko Ivanov --- Makefile | 1 + zfs/debian/rules | 12 ++-- 2 files changed, 11

Re: [pve-devel] [PATCH 1/4] initial Makefile

2019-05-23 Thread Thomas Lamprecht
FYI: Followed up with two small changes required to make dinstall target work (see inline) and now run lintian on resulting deb target debs, as we do in other packages. On 5/22/19 3:37 PM, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > Makefile | 59

[pve-devel] [RFC qemu-server] vm_resume: correctly honor $nocheck

2019-05-23 Thread Fabian Grünbichler
for both vm_mon_cmd calls. under certain circumstances, the following sequence of events can otherwise fail when live-migrating under load: S...source node T...target node 0: migration is complete, handover from S to T starts 1: S: logically move VM config file from S to T via rename() 2: S:

Re: [pve-devel] LDAP integration with G Suite?

2019-05-23 Thread Victor Hooi
G Suite also has audit records for the Secure LDAP service: https://i.imgur.com/rvV9BXL.png In this case - I can see entries for each time I used ldapsearch. However, I do *not* see any entries for each time I try to login on Proxmox. So it seems like it's not even hitting the server, yet

Re: [pve-devel] LDAP integration with G Suite?

2019-05-23 Thread Victor Hooi
Hi, Sorry, you're correct, that was a typo from re-running an earlier command: I've fixed it to set user-attr back to uid - in this case, no matter whether I set "secure" to 1 or 0 - I still get: ``` May 23 22:16:37 syd1 pvedaemon[84179]: authentication failure; rhost=127.0.0.1

Re: [pve-devel] LDAP integration with G Suite?

2019-05-23 Thread Dominik Csapak
On 5/23/19 1:11 PM, Victor Hooi wrote: Hi, I thought I'd try setting the "secure" value to true: ``` # pvesh create /access/domains --realm anguslab.io --type ldap --base_dn dc=anguslab,dc=io --server1 ldap.google.com --port 636 --cert /root/Google_2022_05_22_3494.crt --certkey /root/Google_20

Re: [pve-devel] LDAP integration with G Suite?

2019-05-23 Thread Victor Hooi
Hi, I thought I'd try setting the "secure" value to true: ``` # pvesh create /access/domains --realm anguslab.io --type ldap --base_dn dc=anguslab,dc=io --server1 ldap.google.com --port 636 --cert /root/Google_2022_05_22_3494.crt --certkey /root/Google_20 22_05_22_3494.key --user_attr victorhooi

[pve-devel] applied: [PATCH] assemble_spice_ticket: ensure variable in interpolated string are correct

2019-05-23 Thread Thomas Lamprecht
In older perl the following two where the same: "$foo::$bar" == "${foo}::${bar}" But in perl 5, version 28 it's not anymore, "$foo::$bar" would be equivalent to "${foo::}${bar}", the double colons are now not used as variable name boundary, so mark that explicitly in the affected case and

Re: [pve-devel] LDAP integration with G Suite?

2019-05-23 Thread Victor Hooi
Hi, Thanks for clarifying about the log line. So in this case, it seems it did query by the right uid. In that case I'm pretty stumped - as you can see from the OP - ldapsearch was able to successfully query against the same LDAP server:: ``` $ LDAPTLS_REQCERT=allow

[pve-devel] applied: [PATCH kronosnet/corosync-pve 00/14] update to Corosync 3.x

2019-05-23 Thread Thomas Lamprecht
On 5/22/19 3:37 PM, Fabian Grünbichler wrote: > and package new dependency kronosnet > applied all, much thanks for this! > kronosnet: > > Fabian Grünbichler (4): > initial Makefile > add upstream sources > cherry-pick crypto changes > bump version to 1.8-pve1 > > corosync > > Fabian

Re: [pve-devel] LDAP integration with G Suite?

2019-05-23 Thread Andreas Steinel
On Thu, May 23, 2019 at 11:03 AM Victor Hooi wrote: > I noticed in the log line above the user is printed as > "victorhooi@gsuiteldap" - is this the actual username that Proxmox > attempted to query the LDAP server on? > No, this is the internal PVE name @ -- With kind regards / Mit

Re: [pve-devel] LDAP integration with G Suite?

2019-05-23 Thread Victor Hooi
Sorry, I was incorrect - there actually is a line logged in /var/log/syslog when I get the "Login failed. Please try again.": ``` May 23 18:41:48 syd1 pvedaemon[84179]: authentication failure; rhost=127.0.0.1 user=victorhooi@gsuiteldap msg=no entries returned ``` Is that what you meant by

[pve-devel] applied: [PATCH container] Fix: check if compression_map format is undefined

2019-05-23 Thread Thomas Lamprecht
On 5/23/19 9:13 AM, Alwin Antreich wrote: > We want to check for an supported compression type, but the check was > not correct as this only works if both sides are scalars, but an > assignment to an array is always "truthy", so actually check explicitly > if the compression type is supported

[pve-devel] [PATCH container] Fix: check if compression_map format is undefined

2019-05-23 Thread Alwin Antreich
We want to check for an supported compression type, but the check was not correct as this only works if both sides are scalars, but an assignment to an array is always "truthy", so actually check explicitly if the compression type is supported before. Signed-off-by: Alwin Antreich

Re: [pve-devel] LDAP integration with G Suite?

2019-05-23 Thread Victor Hooi
I tried changing user_attr to "uid", and I still get "Login failed. Please try again." You mentioned the journal should contain an error log if the authentication fails - where is this journal please? (I didn't see anything in /var/log/messages, or in the "Cluster log" in the Web UI). On Thu,

Re: [pve-devel] LDAP integration with G Suite?

2019-05-23 Thread Dominik Csapak
On 5/23/19 6:34 AM, Victor Hooi wrote: *(Sending again with screenshots removed)* Hi, Hi, Aha, I am glad to know it's meant to work out of the box - I merely had some concerns around support for LDAP certificate authentication (forum post