On 7/1/19 10:16 PM, Stoiko Ivanov wrote:
> run the kernel-postinst hook once (like we do for update-grub) instead
> of once per ESP. This fixes an error (the hook does not write entries for
> mounted partitions), and save quite a bit of (un)mounting and copying in case
> of multiple ESPs
>
> Signe
run the kernel-postinst hook once (like we do for update-grub) instead
of once per ESP. This fixes an error (the hook does not write entries for
mounted partitions), and save quite a bit of (un)mounting and copying in case
of multiple ESPs
Signed-off-by: Stoiko Ivanov
---
tested by successfully i
Signed-off-by: Oguz Bektas
---
v3 -> v4:
* fix description
* create a hash directly instead of mapping keys to it
* style fix in socket variable
* don't use 'unless'
data/PVE/API2/ClusterConfig.pm | 53 ++
1 file changed, 53 insertions(+)
diff --git a/d
"localnet" does not necessarily correspond to the correct network for
corosync (e.g. corosync rings/link can be run independently from other PVE
cluster service networks).
This change uses the previously introduced sub 'for_all_corosync_addresses'
to iterate through all nodes in a corosync cluster
Only applies to corosync 3.
Testing config is changed to allow simulation of multicast rules.
Signed-off-by: Stefan Reiter
---
Only for master, stable-5 (with corosync 2) is not compatible, since
this change assumes that the default transport is knet (or anything else
unicast, really).
src/PVE
Since corosync rules are now only created when a corosync.conf file is
present, a static corosync.conf has been added and will be loaded for
testing.
New test rules have been introduced to check corosync rules relating to
different rings/links.
Includes hostnames in config to trigger resolving co
The sub 'for_all_corosync_addresses' iterates through all nodes in a
passed corosync config and calls a specified function for every ringX_addr
on every node it finds (provided the IP-version matches the specified
one or undef was specified).
All ringX_addr entries that cannot be parsed as an IP a
Related to issue #2245 (pve-firewall poorly detects 'localnet').
Doesn't actually fix the underlying issue (i.e. localnet is still
detected poorly), however, with this patchset corosync rules are
at least unaffected.
corosync.conf is read directly during firewall rule generation, allowing
much mor
Signed-off-by: Oguz Bektas
---
v2 -> v3:
* fix description
data/PVE/API2/ClusterConfig.pm | 54 ++
1 file changed, 54 insertions(+)
diff --git a/data/PVE/API2/ClusterConfig.pm b/data/PVE/API2/ClusterConfig.pm
index e7142b5..0195f2c 100644
--- a/data/PVE
Signed-off-by: Dominik Csapak
---
new in v2
...010-remove-legacy-init.d-ceph-script.patch | 28 +++
patches/series| 1 +
2 files changed, 29 insertions(+)
create mode 100644 patches/0010-remove-legacy-init.d-ceph-script.patch
diff --git a/patches
Signed-off-by: Dominik Csapak
---
changes from v1:
* use the checksum of the service file to be sure that it is our
service we are disabling/deleting
...e-ceph-osd-activation-script-in-post.patch | 41 +++
patches/series| 1 +
2 files changed, 42
list all vms with either max/host cputype or vmx/svm explicitely set
(this can only happen in the args)
give a general message if none is found at the moment (and do not warn)
Signed-off-by: Dominik Csapak
---
changes from v1:
* instead of a new line for each vm, combine the reasons
* only use l
Signed-off-by: Oguz Bektas
---
v1 -> v2:
* return empty hash if socket does not exist or is not a socket file
* remove unnecessary corosync config lines since we don't use the config file
data/PVE/API2/ClusterConfig.pm | 54 ++
1 file changed, 54 inserti
Signed-off-by: Christian Ebner
---
PVE/API2/Qemu.pm | 9 -
1 file changed, 9 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index e2a63be..5bdd052 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -1436,7 +1436,6 @@ __PACKAGE__->register_method({
}
});
-
__P
Signed-off-by: Christian Ebner
---
www/manager6/window/SafeDestroy.js | 12
1 file changed, 12 insertions(+)
diff --git a/www/manager6/window/SafeDestroy.js
b/www/manager6/window/SafeDestroy.js
index eb3e6665..ef867deb 100644
--- a/www/manager6/window/SafeDestroy.js
+++ b/www/manag
When destroying a CT, we intentionally did not remove all related configs such
as
backup or replication jobs.
The intention of this flag is to allow the removal of such configs on destroy.
Signed-off-by: Christian Ebner
---
src/PVE/API2/LXC.pm | 17 ++---
1 file changed, 14 insertio
When destroying a VM, we intentionally did not remove all related configs such
as
backup or replication jobs.
The intention of this flag is to allow the removal of such configs on destroy.
Signed-off-by: Christian Ebner
---
PVE/API2/Qemu.pm | 19 +++
1 file changed, 15 insertion
When destroying a VM/CT, we intentionally did not remove all related configs
such
as backup or replication jobs.
The intention of this flag is to allow the removal of such configs on destroy.
Christian Ebner (2):
fix #1291: implement remove_vmid_from_backup_jobs
fix #1291: implement remove_vm
Signed-off-by: Christian Ebner
---
src/PVE/API2/LXC.pm | 4
1 file changed, 4 deletions(-)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index cf14d75..1561cfe 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -636,16 +636,12 @@ __PACKAGE__->register_method({
my
Allows to remove replication jobs from the config based on the vmid.
Signed-off-by: Christian Ebner
---
PVE/ReplicationConfig.pm | 14 ++
1 file changed, 14 insertions(+)
diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm
index d597799..e58597e 100644
--- a/PVE/Replica
remove_vmid_from_backup_jobs updates the vzdump.cron backup jobs,
excluding the given vmid.
Signed-off-by: Christian Ebner
---
PVE/VZDump/Plugin.pm | 46
1 file changed, 46 insertions(+)
diff --git a/PVE/VZDump/Plugin.pm b/PVE/VZDump/Plugin.pm
index
On 7/1/19 12:39 PM, Dominik Csapak wrote:
> list all vms with either max/host cputype or vmx/svm explicitely set
> (this can only happen in the args)
>
> give a general warning if no is found at the moment
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/CLI/pve5to6.pm | 40 +++
On Mon, Jul 01, 2019 at 02:36:53PM +0200, Stefan Reiter wrote:
> Thank you for the in-depth review, I'll follow up with a v2 shortly.
>
> Pretty much agree with everything mentioned, one question about this patch
> in particular below:
>
> On 7/1/19 2:05 PM, Fabian Grünbichler wrote:
> > >
Thank you for the in-depth review, I'll follow up with a v2 shortly.
Pretty much agree with everything mentioned, one question about this
patch in particular below:
On 7/1/19 2:05 PM, Fabian Grünbichler wrote:
s/independant/independently
On Mon, Jul 01, 2019 at 10:49:22AM +0200, Stefan Reite
On Mon, Jul 01, 2019 at 10:49:21AM +0200, Stefan Reiter wrote:
> The sub 'for_all_corosync_addresses' iterates through all nodes in a
> passed corosync config and calls a lambda function for every ringX_addr
> on every node it finds.
>
> Signed-off-by: Stefan Reiter
> ---
> src/PVE/Firewall.pm |
On Mon, Jul 01, 2019 at 10:49:20AM +0200, Stefan Reiter wrote:
> Needed for corosync related firewall updates.
>
> Signed-off-by: Stefan Reiter
> ---
> src/PVE/Tools.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
> index 4dd073f..77af21c 100644
On Mon, Jul 01, 2019 at 10:49:24AM +0200, Stefan Reiter wrote:
> All ringX_addr entries that cannot be parsed as an IP address will be
> best-effort resolved as hostnames. This has to happen in the exact same
> way as corosync does internally, to ensure consistency with firewall
> rules.
>
> Inclu
s/independant/independently
On Mon, Jul 01, 2019 at 10:49:22AM +0200, Stefan Reiter wrote:
> "localnet" does not necessarily correspond to the correct network for
> corosync (e.g. corosync rings/link can be run independently from other PVE
> cluster service networks).
>
> This change uses the pre
On Mon, Jul 01, 2019 at 10:49:19AM +0200, Stefan Reiter wrote:
> Related to issue #2245 (pve-firewall poorly detects 'localnet').
> Doesn't actually fix the underlying issue (i.e. localnet is still
> detected poorly), however, with this patchset corosync rules are
> at least unaffected.
>
> corosy
list all vms with either max/host cputype or vmx/svm explicitely set
(this can only happen in the args)
give a general warning if no is found at the moment
Signed-off-by: Dominik Csapak
---
PVE/CLI/pve5to6.pm | 40 +++-
1 file changed, 39 insertions(+), 1 del
On 6/28/19 5:42 PM, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas
> ---
> data/PVE/API2/ClusterConfig.pm | 55
> ++
> 1 file changed, 55 insertions(+)
>
while we talked already off-list regarding this, a few comments below,
before I, or you :P, forget
"localnet" does not necessarily correspond to the correct network for
corosync (e.g. corosync rings/link can be run independently from other PVE
cluster service networks).
This change uses the previously introduced sub 'for_all_corosync_addresses'
to iterate through all nodes in a corosync cluster
All ringX_addr entries that cannot be parsed as an IP address will be
best-effort resolved as hostnames. This has to happen in the exact same
way as corosync does internally, to ensure consistency with firewall
rules.
Includes changes to the testing corosync.conf to trigger resolving
codepaths dur
Related to issue #2245 (pve-firewall poorly detects 'localnet').
Doesn't actually fix the underlying issue (i.e. localnet is still
detected poorly), however, with this patchset corosync rules are
at least unaffected.
corosync.conf is read directly during firewall rule creation, allowing
much more
Since corosync rules are now only created when a corosync.conf file is
present, a static corosync.conf has been added and will be loaded for
testing.
New test rules have been introduced to check corosync rules relating to
different rings/links.
Signed-off-by: Stefan Reiter
---
test/corosync.con
The sub 'for_all_corosync_addresses' iterates through all nodes in a
passed corosync config and calls a lambda function for every ringX_addr
on every node it finds.
Signed-off-by: Stefan Reiter
---
src/PVE/Firewall.pm | 20
1 file changed, 20 insertions(+)
diff --git a/src/
Needed for corosync related firewall updates.
Signed-off-by: Stefan Reiter
---
src/PVE/Tools.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 4dd073f..77af21c 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -47,6 +47,8 @@ safe_print
trim
On 7/1/19 9:27 AM, Fabian Grünbichler wrote:
> On Fri, Jun 28, 2019 at 01:05:49PM +0200, Dominik Csapak wrote:
>> one thing to note with this is that we have to adapt our documentation for
>> pcie passthrough to give directions for activating iommu with systemd-boot
>> (if that is installed)
>
> a
On Fri, Jun 28, 2019 at 01:05:49PM +0200, Dominik Csapak wrote:
> one thing to note with this is that we have to adapt our documentation for
> pcie passthrough to give directions for activating iommu with systemd-boot
> (if that is installed)
and also some wiki texts (rootdelay, kvm nesting, ... ?
39 matches
Mail list logo
