[pve-devel] [PATCH manager] Add support for 16 PCI(e) devices

2019-09-05 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 4 ++-- www/manager6/qemu/PCIEdit.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 606c66e5..cad29cc6 100644 --- a/www/m

[pve-devel] [PATCH v2 qemu-server 1/1] Add support for up to 16 PCI(e) devices

2019-09-05 Thread Aaron Lauterer
For non pci express passthrough additional addresses are reserved. For pcie passthrough pcie root ports are needed (unless guest is like windows 7). The first 4 pcie root ports are defined by default in the pve-q35*.cfg files. If more than 4 pcie devices are passed through the needed root ports ar

[pve-devel] [PATCH v2 qemu-server 0/1 pve-manager 0/1] Fix #2347 Support 16 PCI(e) devices

2019-09-05 Thread Aaron Lauterer
This patch series adds support to pass through up to 16 pci(e) devices. v1[0] -> v2: * support 16 and not 10 pci devs * create additional pcie root ports on demand, thanks to Dominik for the suggestion * change pci address reservations as larger spaces are needed [0]: https://pve.proxmox.com/pi

[pve-devel] [PATCH manager] edit/show lxc pending changes in gui

2019-09-05 Thread Oguz Bektas
uses the new /pending and the adapted /config API endpoints to get pending changes and show them in a PendingObjectGrid Signed-off-by: Oguz Bektas --- www/manager6/lxc/DNS.js | 11 +++ www/manager6/lxc/Options.js | 4 ++-- www/manager6/lxc/Resources.js | 4 ++-- 3 files changed

[pve-devel] [PATCH container 9/9] apply pending changes when container is started

2019-09-05 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- src/PVE/LXC.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 475d9be..9dd5bc9 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1939,6 +1939,13 @@ sub vm_start { close($fh); } +# apply pending

[pve-devel] [PATCH container 5/9] add 'pending' API method to LXC

2019-09-05 Thread Oguz Bektas
analog to Qemu, it returns an array of elements, which shows the current value, pending value, and delete requests. Signed-off-by: Oguz Bektas --- src/PVE/API2/LXC.pm | 88 + 1 file changed, 88 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/

[pve-devel] [PATCH container 4/9] remove trailing whitespace

2019-09-05 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- src/PVE/API2/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 6ddff9c..9ddaf58 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -35,7 +35,7 @@ BEGIN { __PACKAGE__->register_met

[pve-devel] [PATCH container 8/9] rework update_pct_config to write and apply pending changes

2019-09-05 Thread Oguz Bektas
use vmconfig_hotplug_pending (when ct up) and vmconfig_apply_pending (when ct down) to apply or write pending changes. Signed-off-by: Oguz Bektas --- src/PVE/API2/LXC/Config.pm | 52 +- src/PVE/LXC/Config.pm | 328 + 2 files changed, 147 insertions(+

[pve-devel] [PATCH container 7/9] add vmconfig_hotplug_pending and vmconfig_apply_pending

2019-09-05 Thread Oguz Bektas
vmconfig_hotplug_pending is responsible for checking if a key in the pending section is hotpluggable, if yes; perform a generic config value replace or perform specific actions if a special case. vmconfig_apply_pending is only supposed to be called when ct isn't live. Signed-off-by: Oguz Bektas

[pve-devel] [PATCH container 0/9] lxc pending changes

2019-09-05 Thread Oguz Bektas
this series makes it possible to add/revert/delete pending changes in the backend. it depends on my previous patch for pve-guest-common, for enabling inheritance of pending changes related methods into PVE::LXC::Config some notes or to-be-fixed-soon-after-review points: [1]. gui patches are c

[pve-devel] [PATCH container 1/9] add pending section to lxc config parser/writer

2019-09-05 Thread Oguz Bektas
allow parsing and writing of the pending changes section in CTID.conf files. Signed-off-by: Oguz Bektas --- src/PVE/LXC/Config.pm | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 9790345..

[pve-devel] [PATCH container 6/9] add 'pct pending' command

2019-09-05 Thread Oguz Bektas
analog to 'qm pending', it shows a list of keys and values defined in configuration. cur: current change new: pending change del: pending delete Signed-off-by: Oguz Bektas --- src/PVE/CLI/pct.pm | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/PVE/CLI/pct.pm

[pve-devel] [PATCH container 3/9] adapt config PUT to use 'revert' and 'force' parameters

2019-09-05 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- src/PVE/API2/LXC/Config.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm index 6e67186..405a079 100644 --- a/src/PVE/API2/LXC/Config.pm +++ b/src/PVE/API2/LXC/Config.pm @@ -20,6 +20,8 @@ us

[pve-devel] [PATCH container 2/9] adapt config GET call for taking pending changes

2019-09-05 Thread Oguz Bektas
the default behaviour is the same as in Qemu, so without the 'current' flag set, current values will be replaced with their respective pending counterparts. Signed-off-by: Oguz Bektas --- src/PVE/API2/LXC/Config.pm | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/

Re: [pve-devel] [PATCH qemu-server v2 1/5] add create and remove reboot trigger subs

2019-09-05 Thread Dominik Csapak
On 9/5/19 12:42 PM, Thomas Lamprecht wrote: On 05.09.19 12:27, Dominik Csapak wrote: On 9/5/19 11:47 AM, Thomas Lamprecht wrote: On 23.08.19 10:55, Dominik Csapak wrote: Signed-off-by: Dominik Csapak +    open(my $fh, '>', "/run/qemu-server/$vmid.reboot") +    or die "failed to create rebo

Re: [pve-devel] [PATCH pve-common] etc_network_interfaces : add uplink-id option

2019-09-05 Thread Alexandre DERUMIER
>>hmm, this ringed some bells, this was sent to the list with a bit >>more extensive commit message[0], it's still the same or? Can I take+ >>the commit message from [0] if I'd apply this - to have some more info? yes, sorry, this is the same than previous patch series. I thinked it was lost.

Re: [pve-devel] [PATCH qemu-server v2 1/5] add create and remove reboot trigger subs

2019-09-05 Thread Thomas Lamprecht
On 05.09.19 12:27, Dominik Csapak wrote: > On 9/5/19 11:47 AM, Thomas Lamprecht wrote: >> On 23.08.19 10:55, Dominik Csapak wrote: >>> Signed-off-by: Dominik Csapak >> >>> +    open(my $fh, '>', "/run/qemu-server/$vmid.reboot") >>> +    or die "failed to create reboot trigger file: $!\n"; >> >> ma

[pve-devel] applied: [PATCH common] add postinst hook to fix /etc/aliases whitespace error

2019-09-05 Thread Fabian Grünbichler
thanks to all three involved people ;) On September 3, 2019 1:06 pm, Thomas Lamprecht wrote: > This was wrongly shipped by our ISO since quite a bit (AFAICT, at > least 4.x), so fix it up in a versioned postinst snippet. > > Do so by usind sed with the following pattern: > # sed -E -i -e 's/^www

Re: [pve-devel] [PATCH qemu-server v2 1/5] add create and remove reboot trigger subs

2019-09-05 Thread Dominik Csapak
On 9/5/19 11:47 AM, Thomas Lamprecht wrote: On 23.08.19 10:55, Dominik Csapak wrote: Signed-off-by: Dominik Csapak --- new in v2 trigger is normally something which is done actively, i.e., gets triggered like "pulling the trigger" says. Maybe call it a flag and the file "$vmid.reboot-request

Re: [pve-devel] [PATCH qemu-server v2 4/5] qm: add reboot command

2019-09-05 Thread Thomas Lamprecht
On 23.08.19 10:55, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/CLI/qm.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm > index f9b0fd7..0e8475e 100755 > --- a/PVE/CLI/qm.pm > +++ b/PVE/CLI/qm.pm > @@ -999,6 +999,8 @@ our $cmddef =

Re: [pve-devel] [PATCH qemu-server v2 3/5] api: add reboot api call

2019-09-05 Thread Thomas Lamprecht
On 23.08.19 10:55, Dominik Csapak wrote: > this creates a reboot trigger file (inspired by pve-container) > and relies on the 'qm cleanup' call by the qmeventd to detect > and restart the vm afterwards > > Signed-off-by: Dominik Csapak > --- > changes from rfc: > * use PVE::QemuServer:vm_stop ins

Re: [pve-devel] [PATCH qemu-server v2 1/5] add create and remove reboot trigger subs

2019-09-05 Thread Thomas Lamprecht
On 23.08.19 10:55, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > new in v2 trigger is normally something which is done actively, i.e., gets triggered like "pulling the trigger" says. Maybe call it a flag and the file "$vmid.reboot-request"? > PVE/QemuServer.pm | 12

Re: [pve-devel] [PATCH qemu-server v2 5/5] api: add missing index child links

2019-09-05 Thread Thomas Lamprecht
On 23.08.19 10:56, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/API2/Qemu.pm | 4 > 1 file changed, 4 insertions(+) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 5094721..6ddfca7 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -1916,6 +1916,

Re: [pve-devel] [PATCH common] add postinst hook to fix /etc/aliases whitespace error

2019-09-05 Thread Thomas Lamprecht
On 03.09.19 13:06, Thomas Lamprecht wrote: > This was wrongly shipped by our ISO since quite a bit (AFAICT, at > least 4.x), so fix it up in a versioned postinst snippet. > > Do so by usind sed with the following pattern: > # sed -E -i -e 's/^www:(\w)/www: \1/' /etc/aliases > proposed by Musee Ul

Re: [pve-devel] [PATCH pve-common] etc_network_interfaces : add uplink-id option

2019-09-05 Thread Thomas Lamprecht
On 04.09.19 09:47, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier hmm, this ringed some bells, this was sent to the list with a bit more extensive commit message[0], it's still the same or? Can I take+ the commit message from [0] if I'd apply this - to have some more info? [0]: ht

Re: [pve-devel] [PATCH ha-manager 0/4] Add inital HW based fencing

2019-09-05 Thread Thomas Lamprecht
On 27.03.19 17:42, Thomas Lamprecht wrote: > Actually this'd be v8, but it's to old and to unreviewed for anybody do > remember anyway, so best seen as new series. > any comments on this one? > Thomas Lamprecht (4): > allow LRM lock stealing for fenced nodes > allow use of external fencing d

Re: [pve-devel] [PATCH 0/2] code refactoring for lxc pending changes feature

2019-09-05 Thread Thomas Lamprecht
On 05.09.19 11:13, Oguz Bektas wrote: > hi, > > On Thu, Sep 05, 2019 at 11:01:57AM +0200, Thomas Lamprecht wrote: >> On 04.09.19 18:00, Oguz Bektas wrote: >>> this patch series moves some pending changes related functions into >>> AbstractConfig. the only thing that changes is that these are now c

Re: [pve-devel] [PATCH 0/2] code refactoring for lxc pending changes feature

2019-09-05 Thread Oguz Bektas
hi, On Thu, Sep 05, 2019 at 11:01:57AM +0200, Thomas Lamprecht wrote: > On 04.09.19 18:00, Oguz Bektas wrote: > > this patch series moves some pending changes related functions into > > AbstractConfig. the only thing that changes is that these are now class > > methods, > > since they need to be

Re: [pve-devel] [PATCH 0/2] code refactoring for lxc pending changes feature

2019-09-05 Thread Thomas Lamprecht
On 04.09.19 18:00, Oguz Bektas wrote: > this patch series moves some pending changes related functions into > AbstractConfig. the only thing that changes is that these are now class > methods, > since they need to be inherited in LXC::Config and QemuConfig. > (the functionality in Qemu side should

[pve-devel] applied: [PATCH pve-docs] bgp-evpn : use ip-forward options on vnet interfaces

2019-09-05 Thread Thomas Lamprecht
On 05.09.19 07:06, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > vxlan-and-evpn.adoc | 92 +++-- > 1 file changed, 72 insertions(+), 20 deletions(-) > applied, thanks! ___ pve-devel mai

Re: [pve-devel] [PATCH v3 guest-common 1/2] fix #1291: implement remove_vmid_from_backup_jobs

2019-09-05 Thread Thomas Lamprecht
On 05.09.19 10:01, Fabian Grünbichler wrote: > On September 4, 2019 4:41 pm, Thomas Lamprecht wrote: >> On 01.07.19 15:43, Christian Ebner wrote: >>> remove_vmid_from_backup_jobs updates the vzdump.cron backup jobs, >>> excluding the given vmid. >>> >>> Signed-off-by: Christian Ebner >>> --- >>>

Re: [pve-devel] [RFC qemu-server] rewrite description for vm_config

2019-09-05 Thread Oguz Bektas
hi, On Thu, Sep 05, 2019 at 09:54:22AM +0200, Fabian Grünbichler wrote: > On September 4, 2019 3:59 pm, Oguz Bektas wrote: > > the description doesn't match the default behaviour, which is to replace > > the current values with pending ones in the returned config, unless the > > 'current' option i

Re: [pve-devel] [PATCH v3 guest-common 1/2] fix #1291: implement remove_vmid_from_backup_jobs

2019-09-05 Thread Christian Ebner
Okay, sounds good to me, I will prepare a v4. Thanks for the feedback! > On September 5, 2019 10:01 AM Fabian Grünbichler > wrote: > > > On September 4, 2019 4:41 pm, Thomas Lamprecht wrote: > > On 01.07.19 15:43, Christian Ebner wrote: > >> remove_vmid_from_backup_jobs updates the vzdump.cro

Re: [pve-devel] [PATCH v3 guest-common 1/2] fix #1291: implement remove_vmid_from_backup_jobs

2019-09-05 Thread Fabian Grünbichler
On September 4, 2019 4:41 pm, Thomas Lamprecht wrote: > On 01.07.19 15:43, Christian Ebner wrote: >> remove_vmid_from_backup_jobs updates the vzdump.cron backup jobs, >> excluding the given vmid. >> >> Signed-off-by: Christian Ebner >> --- >> PVE/VZDump/Plugin.pm | 46 +++

Re: [pve-devel] [RFC qemu-server] rewrite description for vm_config

2019-09-05 Thread Fabian Grünbichler
On September 4, 2019 3:59 pm, Oguz Bektas wrote: > the description doesn't match the default behaviour, which is to replace > the current values with pending ones in the returned config, unless the > 'current' option is passed. > > Signed-off-by: Oguz Bektas > --- > > i tried to come up with a r